Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated April 16, 2014, 9:39 a.m.) Review request for cloudstack and Koushik Das. Changes --- Resolving merge conflicts. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description (updated) --- Updating the patch for 4.4 becuase of merge conflicts. Diffs (updated) - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 678b2a3 server/test/resources/createNetworkOffering.xml 6ae1978 Diff: https://reviews.apache.org/r/18768/diff/ Testing (updated) --- Tested the folowing scenarios: attaching local volume with tags attaching local volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated April 16, 2014, 10:14 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description (updated) --- Updating the patch for 4.4 and master because of merge conflicts. Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 678b2a3 server/test/resources/createNetworkOffering.xml 6ae1978 Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Tested the folowing scenarios: attaching local volume with tags attaching local volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review40538 --- Commit eb195d0575ee8d4b618ec52d2fd453a2c0867666 in cloudstack's branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb195d0 ] CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool Signed-off-by: Koushik Das kous...@apache.org - ASF Subversion and Git Services On April 16, 2014, 10:14 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated April 16, 2014, 10:14 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Updating the patch for 4.4 and master because of merge conflicts. Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 678b2a3 server/test/resources/createNetworkOffering.xml 6ae1978 Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Tested the folowing scenarios: attaching local volume with tags attaching local volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review40541 --- Commit 406c289d15fb25501c6e9d9ce1a73725c34b7aea in cloudstack's branch refs/heads/4.4 from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=406c289 ] CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool Signed-off-by: Koushik Das kous...@apache.org - ASF Subversion and Git Services On April 16, 2014, 10:14 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated April 16, 2014, 10:14 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Updating the patch for 4.4 and master because of merge conflicts. Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 678b2a3 server/test/resources/createNetworkOffering.xml 6ae1978 Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Tested the folowing scenarios: attaching local volume with tags attaching local volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review40542 --- Ship it! Ship It! - Koushik Das On April 16, 2014, 10:14 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated April 16, 2014, 10:14 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Updating the patch for 4.4 and master because of merge conflicts. Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 489b37d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java 678b2a3 server/test/resources/createNetworkOffering.xml 6ae1978 Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Tested the folowing scenarios: attaching local volume with tags attaching local volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review37874 --- Patch doesn't apply in master and 4.4. Can you create a new patch? - Koushik Das On March 5, 2014, 11:17 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated March 5, 2014, 11:17 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Patch for master : https://reviews.apache.org/r/18352/ Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 08efb83 engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 server/test/resources/createNetworkOffering.xml c6228da Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Thanks, Saksham Srivastava
Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review36381 --- Commit 7fb2b8c68e7374d1969ce5ae9af890948dfdd9ce in cloudstack's branch refs/heads/4.3-forward from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7fb2b8c ] CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool Signed-off-by: Koushik Das kous...@apache.org - ASF Subversion and Git Services On March 5, 2014, 11:17 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- (Updated March 5, 2014, 11:17 a.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Patch for master : https://reviews.apache.org/r/18352/ Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 08efb83 engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 server/test/resources/createNetworkOffering.xml c6228da Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Thanks, Saksham Srivastava
Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6151 https://issues.apache.org/jira/browse/CLOUDSTACK-6151 Repository: cloudstack-git Description --- Patch for master : https://reviews.apache.org/r/18352/ Diffs - engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 08efb83 engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java 2c4369d engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java 57afa16 server/test/resources/createNetworkOffering.xml c6228da Diff: https://reviews.apache.org/r/18768/diff/ Testing --- Thanks, Saksham Srivastava
