Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review63214 --- Hi Hari, should we backport this to 4.3? If yes, please send a patch. Thanks. - Rohit Yadav On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 25, 2014, 6:06 a.m.) Review request for cloudstack, Kishan Kavala and Rajani Karuturi. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review62955 --- Ship it! Ship It! - Rajani Karuturi On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 25, 2014, 6:06 a.m.) Review request for cloudstack, Kishan Kavala and Rajani Karuturi. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
On Nov. 25, 2014, 8:16 a.m., Rajani Karuturi wrote: Ship It! pushed to 4.5. commit eae733817b3670b0151410c027325f78013392ad will merge to master as well. - Rajani --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review62955 --- On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 25, 2014, 6:06 a.m.) Review request for cloudstack, Kishan Kavala and Rajani Karuturi. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
On Nov. 25, 2014, 8:16 a.m., Rajani Karuturi wrote: Ship It! Rajani Karuturi wrote: pushed to 4.5. commit eae733817b3670b0151410c027325f78013392ad will merge to master as well. master 9585aa0b51a571d5ea3c33c98bec13f5230ecf4a - Rajani --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review62955 --- On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 25, 2014, 6:06 a.m.) Review request for cloudstack, Kishan Kavala and Rajani Karuturi. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 25, 2014, 6:06 a.m.) Review request for cloudstack, Kishan Kavala and Rajani Karuturi. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 10, 2014, 10:04 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs (updated) - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, line 4995 https://reviews.apache.org/r/20518/diff/1/?file=563053#file563053line4995 Are we using _reserveCpu and _reserveMem in any other place? There are no any references On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote: server/src/com/cloud/configuration/Config.java, line 1194 https://reviews.apache.org/r/20518/diff/1/?file=563054#file563054line1194 This removes vmware.reserve.mem and vmware.reserve.cpu from global settings, won't this break backward compatibility. We have corresponding objects in vmwareguru. So this won't break anything. This is the way we are following to use ConfigKey interface - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review53503 --- On Nov. 10, 2014, 10:04 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated Nov. 10, 2014, 10:04 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 server/src/com/cloud/configuration/Config.java 5ac0e90 Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review53503 --- I still can see vmware.reserve.mem in the global settings, if we want to expose this to cluster level settings let's get opinion from VMWare maintainers such as Koushik. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java https://reviews.apache.org/r/20518/#comment93195 Avoid hardcoding string vmware.reserve.mem, using Config class to get value plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java https://reviews.apache.org/r/20518/#comment93196 avoid hard coding here too plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java https://reviews.apache.org/r/20518/#comment93197 Are we using _reserveCpu and _reserveMem in any other place? server/src/com/cloud/configuration/Config.java https://reviews.apache.org/r/20518/#comment93198 This removes vmware.reserve.mem and vmware.reserve.cpu from global settings, won't this break backward compatibility. - Rohit Yadav On April 21, 2014, 9:42 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- (Updated April 21, 2014, 9:42 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 77c45b2 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 67d3963 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 945773e server/src/com/cloud/configuration/Config.java e45291d Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6465 https://issues.apache.org/jira/browse/CLOUDSTACK-6465 Repository: cloudstack-git Description --- CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 77c45b2 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 67d3963 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 945773e server/src/com/cloud/configuration/Config.java e45291d Diff: https://reviews.apache.org/r/20518/diff/ Testing --- Thanks, Harikrishna Patnala
