Re: Review Request 21009: Added Network API tests to test_escalation.py
On May 7, 2014, 11:15 a.m., Girish Shilamkar wrote: Could you please rebase the patch to 4.4-forward ? Vinay Varma wrote: Same patch can be appliend for 4.4-forward branch also. Please apply the patch Vinay Varma wrote: As discussed with santhosh, will re-check this patch for 4.4-forward and will update the group Vinay is creating new patch for 4.4 and as per Santhosh discarding this review request. - Anish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42401 --- On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Re: Review Request 21009: Added Network API tests to test_escalation.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42401 --- Could you please rebase the patch to 4.4-forward ? - Girish Shilamkar On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Re: Review Request 21009: Added Network API tests to test_escalation.py
On May 7, 2014, 11:15 a.m., Girish Shilamkar wrote: Could you please rebase the patch to 4.4-forward ? Same patch can be appliend for 4.4-forward branch also. Please apply the patch - Vinay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42401 --- On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Re: Review Request 21009: Added Network API tests to test_escalation.py
On May 7, 2014, 11:15 a.m., Girish Shilamkar wrote: Could you please rebase the patch to 4.4-forward ? Vinay Varma wrote: Same patch can be appliend for 4.4-forward branch also. Please apply the patch As discussed with santhosh, will re-check this patch for 4.4-forward and will update the group - Vinay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42401 --- On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Re: Review Request 21009: Added Network API tests to test_escalation.py
Hi Anish, I see that this file has crossed 9500+ LOC and with total 9 Test Classes and according to Log attached, it's taking 12-13 minutes to run just 1 Test Class. It will take even more time in daily runs if we run this serially. So if you think that this test suit can be divided into different Test Suites which are independent of each other, I suggest this should be done. This will help running the test suites in parallel saving much time. Santhosh, what do you think? Regards, Gaurav On Mon, May 5, 2014 at 3:01 PM, Santhosh Edukulla santhosh.eduku...@citrix.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42133 --- Ship it! Ship It! - Santhosh Edukulla On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Re: Review Request 21009: Added Network API tests to test_escalation.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/#review42133 --- Ship it! Ship It! - Santhosh Edukulla On May 2, 2014, 8:35 a.m., Anish Bindal wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- (Updated May 2, 2014, 8:35 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
Review Request 21009: Added Network API tests to test_escalation.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21009/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6282 https://issues.apache.org/jira/browse/CLOUDSTACK-6282 Repository: cloudstack-git Description --- Added Network API tests to test_escalation.py Diffs - test/integration/component/test_escalations.py e994579 tools/marvin/marvin/config/test_data.py b862205 Diff: https://reviews.apache.org/r/21009/diff/ Testing --- Executed all tests and attached are the result log files. File Attachments Result Log File https://reviews.apache.org/media/uploaded/files/2014/05/02/d76abc1c-95c0-4ad5-93f2-38ebb5d85763__results.txt Thanks, Anish Bindal
