Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45581 --- Commit ebff469b46551f8613013e80aa0386203a9c7912 in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ebff469 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45582 --- Commit ebff469b46551f8613013e80aa0386203a9c7912 in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ebff469 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45589 --- Commit 66d1eb92f03c39734dcaf83e20639cd9a338e388 in cloudstack's branch refs/heads/master from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=66d1eb9 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45590 --- Commit 66d1eb92f03c39734dcaf83e20639cd9a338e388 in cloudstack's branch refs/heads/master from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=66d1eb9 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45595 --- Ship it! Ship It! - Devdeep Singh On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45608 --- Commit a951b51523069e72e5cd1e503df11b9370b6d6d8 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a951b51 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set (cherry picked from commit ebff469b46551f8613013e80aa0386203a9c7912) - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Re: Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/#review45607 --- Commit a951b51523069e72e5cd1e503df11b9370b6d6d8 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a951b51 ] CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set (cherry picked from commit ebff469b46551f8613013e80aa0386203a9c7912) - ASF Subversion and Git Services On June 10, 2014, 11:23 a.m., Anshul Gangwar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- (Updated June 10, 2014, 11:23 a.m.) Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
Review Request 22414: CLOUDSTACK-6865, CLOUDSTACK-6868: [hyper-v] attach volume of vhd format volume is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22414/ --- Review request for cloudstack, Devdeep Singh and Rajesh Battala. Bugs: CLOUDSTACK-6865 and CLOUDSTACK-6868 https://issues.apache.org/jira/browse/CLOUDSTACK-6865 https://issues.apache.org/jira/browse/CLOUDSTACK-6868 Repository: cloudstack-git Description --- while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format Now changed the behavior to set Image Format for volume only when it is not set Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 064ffca Diff: https://reviews.apache.org/r/22414/diff/ Testing --- verified by uploading the vhd volume and attaching it to VM Thanks, Anshul Gangwar
