subject:"Review Request 22863\: CLOUDSTACK\-6823 \: First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity."

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-29 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 29, 2014, 8:31 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the reported Coverity findings.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 0a08f28 
  api/src/com/cloud/network/Networks.java 1ad3350 
  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties bb75b08 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
  client/pom.xml 410cb19 
  client/tomcatconf/commands.properties.in aa03949 
  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 
  pl

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-24 Thread Ritu Sabharwal

Hi Hugo,

Where can I submit the Brocade Plugin Usage document?

Thanks & Regards,
Ritu S.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: 
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28  
>> api/src/com/cloud/network/Networks.java 1ad3350  
>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>> d7a0ca9  client/pom.xml 410cb19  
>> client/tomcatconf/commands.properties.in aa03949  
>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>> .xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>> ma.xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>> sd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/module.properties PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/spring-vcs-context.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupB
>> rocadeVcsCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBr
>> ocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/Delet
>> eBrocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListB
>> rocadeVcsDeviceNetworksCmd.java PRE-CREATION  
>> plugins/netw

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Ritu Sabharwal

That's right Hugo.

Thanks & Regards,
Ritu S.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 5:29 AM
To: dev@cloudstack.apache.org
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Sudha,

I think those tests are in test/integration/component/test_brocade_vcs.py that 
Ritu included.

Cheers,

Hugo

On 23 jul. 2014, at 14:07, Sudha Ponnaganti  wrote:

> Ritu,
> 
> Would be good to add automated tests for the procedure you have outlined.  
> Marvin has already similar tests and you should be able to reuse them. 
> 
> Thanks
> /sudha
> 
>>> Testing
>>> ---
>>> 
>>> *   Create an isolated network; verify that the port-profile is created on 
>>> the Brocade switch.
>>> *   Attach a VM to the network; verify that the VMs MAC address is 
>>> associated with the port profile of the network on the Brocade switch.
>>> *   Delete VMs for an isolated network; verify that the VMs MAC address is 
>>> disassociated with the port profile of the network on the Brocade switch.
>>> *   Delete the isolated network; verify that the port-profile is deleted 
>>> from the Brocade switch.
>>> 
>>> Integration test result:
>>> 
>>> Test Brocade Network and VM Creation ... === TestName: 
>>> test_network_vcs | Status : SUCCESS === ok
>>> 
> 
> -Original Message-----
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Wednesday, July 23, 2014 2:15 AM
> To: 
> Cc: Ritu Sabharwal
> Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
> Brocade Network plugin to orchestrate Brocade VDX switches for L2 
> connectivity.
> 
> Hey all,
> 
> Just pushed the brocade VDX code into master.
> 
> * fing bugs is not showing any issues
> * decent unit test coverage
> * includes functional test procedure
> * majority of the functional code is contained in a plugin, minimal 
> changes to core
> 
> Cheers,
> 
> Hugo
> 
> 
> 
> On 23 jul. 2014, at 11:12, Hugo Trippaers  
> wrote:
> 
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/#review48487
>> ---
>> 
>> Ship it!
>> 
>> 
>> commit 628d8e66f77053de9819436739325720710175ed
>> Author: Ritu Sabharwal 
>> Date:   Wed Jul 23 08:51:20 2014 +0200
>> 
>>   CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
>> orchestrate Brocade VDX switches for L2 connectivity
>> 
>>   Signed-off-by: Hugo Trippaers 
>> 
>> 
>> - Hugo Trippaers
>> 
>> 
>> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>>> 
>>> ---
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/22863/
>>> ---
>>> 
>>> (Updated July 22, 2014, 9:44 p.m.)
>>> 
>>> 
>>> Review request for cloudstack and Hugo Trippaers.
>>> 
>>> 
>>> Bugs: CLOUDSTACK-6823
>>>   https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> ---
>>> 
>>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>>> 
>>> 
>>> Diffs
>>> -
>>> 
>>> api/src/com/cloud/network/Network.java 0a08f28 
>>> api/src/com/cloud/network/Networks.java 1ad3350 
>>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.j
>>> a va e73f526  client/WEB-INF/classes/resources/messages.properties
>>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties
>>> d7a0ca9  client/pom.xml 410cb19
>>> client/tomcatconf/commands.properties.in aa03949 
>>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchem
>>> a
>>> .xsd PRE-CREATION
>>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSch
&g

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Ritu Sabharwal

Hi Hugo,

Thanks for reviewing and approving the Brocade VCS plugin.

Thanks & Regards,
Ritu Sabharwal.

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: 
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28  
>> api/src/com/cloud/network/Networks.java 1ad3350  
>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>> d7a0ca9  client/pom.xml 410cb19  
>> client/tomcatconf/commands.properties.in aa03949  
>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>> .xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>> ma.xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>> sd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/module.properties PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/spring-vcs-context.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Disassoc
>> iateMacFromNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupB
>> rocadeVcsCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBr
>> ocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/Delet
>> eBrocadeVcsDeviceCmd.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListB
>> rocadeVcsDeviceNetworksCmd.java PRE-CREATION  
>> plugins/n

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Hugo Trippaers

Sudha,

I think those tests are in test/integration/component/test_brocade_vcs.py that 
Ritu included.

Cheers,

Hugo

On 23 jul. 2014, at 14:07, Sudha Ponnaganti  wrote:

> Ritu,
> 
> Would be good to add automated tests for the procedure you have outlined.  
> Marvin has already similar tests and you should be able to reuse them. 
> 
> Thanks
> /sudha
> 
>>> Testing
>>> ---
>>> 
>>> *   Create an isolated network; verify that the port-profile is created on 
>>> the Brocade switch.
>>> *   Attach a VM to the network; verify that the VMs MAC address is 
>>> associated with the port profile of the network on the Brocade switch.
>>> *   Delete VMs for an isolated network; verify that the VMs MAC address is 
>>> disassociated with the port profile of the network on the Brocade switch.
>>> *   Delete the isolated network; verify that the port-profile is deleted 
>>> from the Brocade switch.
>>> 
>>> Integration test result:
>>> 
>>> Test Brocade Network and VM Creation ... === TestName: 
>>> test_network_vcs | Status : SUCCESS === ok
>>> 
> 
> -Original Message-
> From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
> Sent: Wednesday, July 23, 2014 2:15 AM
> To: 
> Cc: Ritu Sabharwal
> Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
> Brocade Network plugin to orchestrate Brocade VDX switches for L2 
> connectivity.
> 
> Hey all,
> 
> Just pushed the brocade VDX code into master.
> 
> * fing bugs is not showing any issues
> * decent unit test coverage
> * includes functional test procedure
> * majority of the functional code is contained in a plugin, minimal changes 
> to core
> 
> Cheers,
> 
> Hugo
> 
> 
> 
> On 23 jul. 2014, at 11:12, Hugo Trippaers  
> wrote:
> 
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/#review48487
>> ---
>> 
>> Ship it!
>> 
>> 
>> commit 628d8e66f77053de9819436739325720710175ed
>> Author: Ritu Sabharwal 
>> Date:   Wed Jul 23 08:51:20 2014 +0200
>> 
>>   CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
>> orchestrate Brocade VDX switches for L2 connectivity
>> 
>>   Signed-off-by: Hugo Trippaers 
>> 
>> 
>> - Hugo Trippaers
>> 
>> 
>> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>>> 
>>> ---
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/22863/
>>> ---
>>> 
>>> (Updated July 22, 2014, 9:44 p.m.)
>>> 
>>> 
>>> Review request for cloudstack and Hugo Trippaers.
>>> 
>>> 
>>> Bugs: CLOUDSTACK-6823
>>>   https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> ---
>>> 
>>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>>> 
>>> 
>>> Diffs
>>> -
>>> 
>>> api/src/com/cloud/network/Network.java 0a08f28  
>>> api/src/com/cloud/network/Networks.java 1ad3350  
>>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>>> d7a0ca9  client/pom.xml 410cb19  
>>> client/tomcatconf/commands.properties.in aa03949  
>>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>>> .xsd PRE-CREATION  
>>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>>> ma.xsd PRE-CREATION  
>>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>>> sd PRE-CREATION  
>>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>>> s/module.properties PRE-CREATION  
>>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>>> s/spring-vcs-context.xml PR

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Sudha Ponnaganti

Ritu,

Would be good to add automated tests for the procedure you have outlined.  
Marvin has already similar tests and you should be able to reuse them. 

Thanks
/sudha

>> Testing
>> ---
>> 
>> *Create an isolated network; verify that the port-profile is created on 
>> the Brocade switch.
>> *Attach a VM to the network; verify that the VMs MAC address is 
>> associated with the port profile of the network on the Brocade switch.
>> *Delete VMs for an isolated network; verify that the VMs MAC address is 
>> disassociated with the port profile of the network on the Brocade switch.
>> *Delete the isolated network; verify that the port-profile is deleted 
>> from the Brocade switch.
>> 
>> Integration test result:
>> 
>> Test Brocade Network and VM Creation ... === TestName: 
>> test_network_vcs | Status : SUCCESS === ok
>>

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Wednesday, July 23, 2014 2:15 AM
To: 
Cc: Ritu Sabharwal
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28  
>> api/src/com/cloud/network/Networks.java 1ad3350  
>> api/src/com/cloud/network/PhysicalNetwork.java 024b3ce  
>> api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.ja
>> va e73f526  client/WEB-INF/classes/resources/messages.properties 
>> bb75b08  client/WEB-INF/classes/resources/messages_zh_CN.properties 
>> d7a0ca9  client/pom.xml 410cb19  
>> client/tomcatconf/commands.properties.in aa03949  
>> plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema
>> .xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSche
>> ma.xsd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.x
>> sd PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/module.properties PRE-CREATION  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vc
>> s/spring-vcs-context.xml PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/Associat
>> eMacToNetworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNe
>> tworkCommand.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNe
>> tworkAnswer.java PRE-CREATION  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Hugo Trippaers

Hey all,

Just pushed the brocade VDX code into master.

* fing bugs is not showing any issues
* decent unit test coverage
* includes functional test procedure
* majority of the functional code is contained in a plugin, minimal changes to 
core

Cheers,

Hugo



On 23 jul. 2014, at 11:12, Hugo Trippaers  wrote:

> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/#review48487
> ---
> 
> Ship it!
> 
> 
> commit 628d8e66f77053de9819436739325720710175ed
> Author: Ritu Sabharwal 
> Date:   Wed Jul 23 08:51:20 2014 +0200
> 
>CLOUDSTACK-6823 : First code drop for Brocade Network plugin to 
> orchestrate Brocade VDX switches for L2 connectivity
> 
>Signed-off-by: Hugo Trippaers 
> 
> 
> - Hugo Trippaers
> 
> 
> On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22863/
>> ---
>> 
>> (Updated July 22, 2014, 9:44 p.m.)
>> 
>> 
>> Review request for cloudstack and Hugo Trippaers.
>> 
>> 
>> Bugs: CLOUDSTACK-6823
>>https://issues.apache.org/jira/browse/CLOUDSTACK-6823
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
>> switches for L2 connectivity. Please create a new branch for Brocade plugin.
>> 
>> 
>> Diffs
>> -
>> 
>>  api/src/com/cloud/network/Network.java 0a08f28 
>>  api/src/com/cloud/network/Networks.java 1ad3350 
>>  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>>  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
>> e73f526 
>>  client/WEB-INF/classes/resources/messages.properties bb75b08 
>>  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>>  client/pom.xml 410cb19 
>>  client/tomcatconf/commands.properties.in aa03949 
>>  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>>  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
>> PRE-CREATION 
>>  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
>> PRE-CREATION 
>>  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
>> PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
>>  PRE-CREATION 
>>  
>> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/Br

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread Hugo Trippaers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48487
---

Ship it!


commit 628d8e66f77053de9819436739325720710175ed
Author: Ritu Sabharwal 
Date:   Wed Jul 23 08:51:20 2014 +0200

CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate 
Brocade VDX switches for L2 connectivity

Signed-off-by: Hugo Trippaers 


- Hugo Trippaers


On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 22, 2014, 9:44 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 0a08f28 
>   api/src/com/cloud/network/Networks.java 1ad3350 
>   api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties bb75b08 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>   client/pom.xml 410cb19 
>   client/tomcatconf/commands.properties.in aa03949 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/b

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-23 Thread ASF Subversion and Git Services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48486
---


Commit 628d8e66f77053de9819436739325720710175ed in cloudstack's branch 
refs/heads/master from Ritu Sabharwal
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=628d8e6 ]

CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate 
Brocade VDX switches for L2 connectivity

Signed-off-by: Hugo Trippaers 


- ASF Subversion and Git Services


On July 22, 2014, 9:44 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 22, 2014, 9:44 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 0a08f28 
>   api/src/com/cloud/network/Networks.java 1ad3350 
>   api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties bb75b08 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>   client/pom.xml 410cb19 
>   client/tomcatconf/commands.properties.in aa03949 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappi

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-22 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 22, 2014, 9:44 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the findbug findings. 


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 0a08f28 
  api/src/com/cloud/network/Networks.java 1ad3350 
  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties bb75b08 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
  client/pom.xml 410cb19 
  client/tomcatconf/commands.properties.in aa03949 
  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 
  plugins/pom

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-22 Thread Ritu Sabharwal



> On July 22, 2014, 9:57 a.m., Hugo Trippaers wrote:
> > The patch applies cleanly now, thanks for rebasing.
> > 
> > Can you have a look at the following findbug findings:
> > [INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @ 
> > cloud-plugin-network-vcs ---
> > [INFO] BugInstance size is 2
> > [INFO] Error size is 0
> > [INFO] Total bugs: 2
> > [INFO] Found reliance on default encoding in 
> > com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(String): new 
> > java.io.InputStreamReader(InputStream) 
> > ["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 
> > 67-520]
> > [INFO] Found reliance on default encoding in 
> > com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(HttpResponse):
> >  new java.io.InputStreamReader(InputStream) 
> > ["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 
> > 67-520]
> > 
> > The rat check (mvn -pl org.apache.cloudstack:cloudstack 
> > org.apache.rat:apache-rat-plugin:0.10:check) is clear, no no license issues.
> > 
> > If you can fix the two findbug findings i can merge it.
> > 
> > 
> >

Hi Hugo,

I have fixed the 2 findbug findings.

Thanks & Regards,
Ritu Sabharwal.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48356
---


On July 22, 2014, 7:19 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 22, 2014, 7:19 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 0a08f28 
>   api/src/com/cloud/network/Networks.java 1ad3350 
>   api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties bb75b08 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>   client/pom.xml 410cb19 
>   client/tomcatconf/commands.properties.in aa03949 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-22 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 22, 2014, 7:19 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the 2 Findbug findings.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 0a08f28 
  api/src/com/cloud/network/Networks.java 1ad3350 
  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties bb75b08 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
  client/pom.xml 410cb19 
  client/tomcatconf/commands.properties.in aa03949 
  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 
  plugins/po

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-22 Thread Hugo Trippaers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48356
---


The patch applies cleanly now, thanks for rebasing.

Can you have a look at the following findbug findings:
[INFO] --- findbugs-maven-plugin:2.5.3:check (cloudstack-findbugs) @ 
cloud-plugin-network-vcs ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] Found reliance on default encoding in 
com.cloud.network.brocade.BrocadeVcsApi.executeRetreiveStatus(String): new 
java.io.InputStreamReader(InputStream) 
["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 67-520]
[INFO] Found reliance on default encoding in 
com.cloud.network.brocade.BrocadeVcsApi.responseToErrorMessage(HttpResponse): 
new java.io.InputStreamReader(InputStream) 
["com.cloud.network.brocade.BrocadeVcsApi"] At BrocadeVcsApi.java:[lines 67-520]

The rat check (mvn -pl org.apache.cloudstack:cloudstack 
org.apache.rat:apache-rat-plugin:0.10:check) is clear, no no license issues.

If you can fix the two findbug findings i can merge it.




- Hugo Trippaers


On July 21, 2014, 7:25 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 21, 2014, 7:25 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 0a08f28 
>   api/src/com/cloud/network/Networks.java 1ad3350 
>   api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties bb75b08 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
>   client/pom.xml 410cb19 
>   client/tomcatconf/commands.properties.in aa03949 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-21 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 21, 2014, 7:25 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Rebased to latest master. 


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 0a08f28 
  api/src/com/cloud/network/Networks.java 1ad3350 
  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties bb75b08 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
  client/pom.xml 410cb19 
  client/tomcatconf/commands.properties.in aa03949 
  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
 PRE-CREATION 
  
plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
 PRE-CREATION 
  plugins/pom.x

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-21 Thread Ritu Sabharwal



> On July 21, 2014, 2:02 p.m., Hugo Trippaers wrote:
> > Can you rebase on latest master as the patch currently fails to apply.
> > 
> > Cheers,
> > 
> > Hugo
> > 
> > 
> > patching file api/src/com/cloud/network/Network.java
> > Hunk #1 FAILED at 132.
> > Hunk #2 succeeded at 224 (offset 3 lines).
> > 1 out of 2 hunks FAILED -- saving rejects to file 
> > api/src/com/cloud/network/Network.java.rej
> > patching file api/src/com/cloud/network/Networks.java
> > patching file api/src/com/cloud/network/PhysicalNetwork.java
> > Hunk #1 FAILED at 33.
> > 1 out of 1 hunk FAILED -- saving rejects to file 
> > api/src/com/cloud/network/PhysicalNetwork.java.rej
> > patching file 
> > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java
> > patching file client/WEB-INF/classes/resources/messages.properties
> > Hunk #1 FAILED at 327.
> > Hunk #2 FAILED at 500.
> > Hunk #3 succeeded at 880 (offset 6 lines).
> > Hunk #4 succeeded at 1426 (offset 7 lines).
> > Hunk #5 succeeded at 1639 with fuzz 2 (offset 7 lines).
> > 2 out of 5 hunks FAILED -- saving rejects to file 
> > client/WEB-INF/classes/resources/messages.properties.rej
> > patching file client/WEB-INF/classes/resources/messages_zh_CN.properties
> > Hunk #1 FAILED at 297.
> > Hunk #2 FAILED at 509.
> > Hunk #3 succeeded at 1612 with fuzz 2 (offset 4 lines).
> > 2 out of 3 hunks FAILED -- saving rejects to file 
> > client/WEB-INF/classes/resources/messages_zh_CN.properties.rej
> > patching file client/pom.xml
> > patching file client/tomcatconf/commands.properties.in
> > Hunk #1 succeeded at 607 (offset 1 line).
> > patching file plugins/pom.xml
> > Hunk #1 succeeded at 64 (offset 1 line).
> > patching file setup/db/db/schema-440to450.sql
> > Hunk #1 succeeded at 244 with fuzz 2 (offset 20 lines).
> > patching file test/integration/component/test_brocade_vcs.py
> > patching file tools/apidoc/gen_toc.py
> > Hunk #1 succeeded at 132 with fuzz 2.
> > patching file ui/dictionary.jsp
> > Hunk #1 FAILED at 349.
> > Hunk #2 FAILED at 505.
> > Hunk #3 succeeded at 870 (offset 7 lines).
> > Hunk #4 succeeded at 1436 with fuzz 2 (offset 8 lines).
> > Hunk #5 succeeded at 1742 (offset 9 lines).
> > 2 out of 5 hunks FAILED -- saving rejects to file ui/dictionary.jsp.rej
> > patching file ui/scripts/system.js
> > Hunk #2 succeeded at 12240 (offset 243 lines).
> > Hunk #3 succeeded at 19564 (offset 584 lines).
> > Hunk #4 succeeded at 20343 (offset 615 lines).
> > Hunk #5 succeeded at 20379 (offset 618 lines).
> > patching file ui/scripts/ui-custom/zoneWizard.js
> > Hunk #1 FAILED at 726.
> > 1 out of 1 hunk FAILED -- saving rejects to file 
> > ui/scripts/ui-custom/zoneWizard.js.rej
> >

Hi Hugo,

I have rebased to latest master and uploaded the patch. The patch now has both 
the changes: existing cloudstack code changes and plugin specific code.

Please review it and let me know if anything else is needed from my side.

Thanks & Regards,
Ritu Sabharwal.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48220
---


On July 17, 2014, 11:52 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 17, 2014, 11:52 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   test/integration/component/test_brocade_vcs.py PRE-CREATION 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade sw

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-21 Thread Hugo Trippaers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review48220
---

Can you rebase on latest master as the patch currently fails to apply.

Cheers,

Hugo

patching file api/src/com/cloud/network/Network.java
Hunk #1 FAILED at 132.
Hunk #2 succeeded at 224 (offset 3 lines).
1 out of 2 hunks FAILED -- saving rejects to file 
api/src/com/cloud/network/Network.java.rej
patching file api/src/com/cloud/network/Networks.java
patching file api/src/com/cloud/network/PhysicalNetwork.java
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file 
api/src/com/cloud/network/PhysicalNetwork.java.rej
patching file 
api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java
patching file client/WEB-INF/classes/resources/messages.properties
Hunk #1 FAILED at 327.
Hunk #2 FAILED at 500.
Hunk #3 succeeded at 880 (offset 6 lines).
Hunk #4 succeeded at 1426 (offset 7 lines).
Hunk #5 succeeded at 1639 with fuzz 2 (offset 7 lines).
2 out of 5 hunks FAILED -- saving rejects to file 
client/WEB-INF/classes/resources/messages.properties.rej
patching file client/WEB-INF/classes/resources/messages_zh_CN.properties
Hunk #1 FAILED at 297.
Hunk #2 FAILED at 509.
Hunk #3 succeeded at 1612 with fuzz 2 (offset 4 lines).
2 out of 3 hunks FAILED -- saving rejects to file 
client/WEB-INF/classes/resources/messages_zh_CN.properties.rej
patching file client/pom.xml
patching file client/tomcatconf/commands.properties.in
Hunk #1 succeeded at 607 (offset 1 line).
patching file plugins/pom.xml
Hunk #1 succeeded at 64 (offset 1 line).
patching file setup/db/db/schema-440to450.sql
Hunk #1 succeeded at 244 with fuzz 2 (offset 20 lines).
patching file test/integration/component/test_brocade_vcs.py
patching file tools/apidoc/gen_toc.py
Hunk #1 succeeded at 132 with fuzz 2.
patching file ui/dictionary.jsp
Hunk #1 FAILED at 349.
Hunk #2 FAILED at 505.
Hunk #3 succeeded at 870 (offset 7 lines).
Hunk #4 succeeded at 1436 with fuzz 2 (offset 8 lines).
Hunk #5 succeeded at 1742 (offset 9 lines).
2 out of 5 hunks FAILED -- saving rejects to file ui/dictionary.jsp.rej
patching file ui/scripts/system.js
Hunk #2 succeeded at 12240 (offset 243 lines).
Hunk #3 succeeded at 19564 (offset 584 lines).
Hunk #4 succeeded at 20343 (offset 615 lines).
Hunk #5 succeeded at 20379 (offset 618 lines).
patching file ui/scripts/ui-custom/zoneWizard.js
Hunk #1 FAILED at 726.
1 out of 1 hunk FAILED -- saving rejects to file 
ui/scripts/ui-custom/zoneWizard.js.rej

- Hugo Trippaers

On July 17, 2014, 11:52 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 17, 2014, 11:52 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   test/integration/component/test_brocade_vcs.py PRE-CREATION 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> Integration test result:
> 
> Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
> Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 297.497s
> 
> OK
> 
> 
> File Attachments
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-17 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 11:52 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Removed the cfg file from patch. Only for testing.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing (updated)
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | 
Status : SUCCESS ===
ok

--
Ran 1 test in 297.497s

OK


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-17 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 17, 2014, 10:04 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Added marvin integration test.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  setup/dev/advancedvcs.cfg PRE-CREATION 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:57 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Fixed the PhysicalNetwork.java.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal



> On July 15, 2014, 9:30 p.m., Erik Weber wrote:
> > api/src/com/cloud/network/PhysicalNetwork.java, line 36
> > 
> >
> > Looks like you removed the 'N' in L3VPN

Fixed it.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---


On July 15, 2014, 9:57 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:57 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Erik Weber


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47820
---



api/src/com/cloud/network/PhysicalNetwork.java


Looks like you removed the 'N' in L3VPN


- Erik Weber


On July 15, 2014, 9:16 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal



> On July 15, 2014, 11:09 a.m., Hugo Trippaers wrote:
> > Can you resubmit this patch without the reformatting of system.js? At the 
> > moment it shows 4233 changes to that file, which is impossible for me to 
> > review. I need to see only the changes you made for the brocade plugin. If 
> > you think a reformat is needed you can submit the reformat as a separate 
> > patch, but we would prefer to keep the existing format.
> > 
> >

Hi Hugo,

I have resubmitted the patch. Updated diff after removing formatting of 
system.js. Also, removed the configuration reading from properties files. Now 
the plugin configurations are read as network service provider configurations 
from GUI or APIs.

Please review it.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
---


On July 15, 2014, 9:16 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 15, 2014, 9:16 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
> e73f526 
>   client/WEB-INF/classes/resources/messages.properties b504a18 
>   client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
>   client/pom.xml 29fef4f 
>   client/tomcatconf/commands.properties.in d247aa0 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   tools/apidoc/gen_toc.py 827d6bf 
>   ui/dictionary.jsp 9026a36 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 15, 2014, 9:16 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Updated diff after removing formatting of system.js. Also, removed the 
configuration reading from properties files. Now the plugin configurations are 
read as network service provider configurations from GUI or APIs.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs (updated)
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java 
e73f526 
  client/WEB-INF/classes/resources/messages.properties b504a18 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 1ec4e95 
  client/pom.xml 29fef4f 
  client/tomcatconf/commands.properties.in d247aa0 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  tools/apidoc/gen_toc.py 827d6bf 
  ui/dictionary.jsp 9026a36 
  ui/scripts/system.js 9a98a5c 
  ui/scripts/ui-custom/zoneWizard.js 4091c03 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-15 Thread Hugo Trippaers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review47768
---


Can you resubmit this patch without the reformatting of system.js? At the 
moment it shows 4233 changes to that file, which is impossible for me to 
review. I need to see only the changes you made for the brocade plugin. If you 
think a reformat is needed you can submit the reformat as a separate patch, but 
we would prefer to keep the existing format.



- Hugo Trippaers


On July 11, 2014, 10:10 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 11, 2014, 10:10 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
>   ui/scripts/ui-custom/zoneWizard.js 4091c03 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-11 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 11, 2014, 10:10 p.m.)

Review request for cloudstack and Hugo Trippaers.

Changes
---

Updated the diff.

Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

Repository: cloudstack-git

Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches
for L2 connectivity. Please create a new branch for Brocade plugin.

Diffs (updated)
-

api/src/com/cloud/network/Network.java 885bffe
api/src/com/cloud/network/Networks.java 1e4d229
api/src/com/cloud/network/PhysicalNetwork.java 8cc214e
client/pom.xml 29fef4f
plugins/pom.xml b5e6a61
setup/db/db/schema-440to450.sql 77445a9
ui/scripts/system.js 9a98a5c
ui/scripts/ui-custom/zoneWizard.js 4091c03

Diff: https://reviews.apache.org/r/22863/diff/

Testing
---

• Create an isolated network; verify that the port-profile is created on
the Brocade switch.
• Attach a VM to the network; verify that the VMs MAC address is
associated with the port profile of the network on the Brocade switch.
• Delete VMs for an isolated network; verify that the VMs MAC address is
disassociated with the port profile of the network on the Brocade switch.
• Delete the isolated network; verify that the port-profile is deleted
from the Brocade switch.

File Attachments

Diff for the existing cloudstack code

https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code

https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch

Thanks,

Ritu Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-08 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 8, 2014, 9:30 a.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
---

Add the dependency on the plugin code


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-07 Thread Ritu Sabharwal



> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> I commented on the review comments directly. I included a patch file 
> brocade-vcs.patch which has Brocade code. 
> 
> I followed these steps to create the patch:
> 
> -git add plugins/network-elements/brocade-vcs
> -git commit -m "Commit message“
> -git format-patch master --stdout > ~/brocade-vcs.patch
> 
> Is there any other way to include Brocade code in the diffs? Please let 
> me know. I will submit that for review.
> 
> Thanks,
> Ritu.
>
> 
> Hugo Trippaers wrote:
> You can create a separate review request for the vcs code (and post a 
> link in this review) or create a single big patch with everything. I'm fine 
> with either option, but we need the patch in review board as that will help 
> us do the review properly.
> 
> Thanks for fixing the other items.
> 
> Cheers,
> 
> Hugo

Hi Hugo,

I have created another request for vcs specific code. Please find the link for 
the review request: https://reviews.apache.org/r/23314/ 

Hope this helps to review it properly.

Thanks & Regards,
Ritu S.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On July 4, 2014, 9:35 a.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated July 4, 2014, 9:35 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-04 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated July 4, 2014, 9:35 a.m.)


Review request for cloudstack and Hugo Trippaers.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java 885bffe 
  api/src/com/cloud/network/Networks.java 1e4d229 
  api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
  client/pom.xml 29fef4f 
  plugins/pom.xml b5e6a61 
  setup/db/db/schema-440to450.sql 77445a9 
  ui/scripts/system.js 9a98a5c 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  
https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-07-04 Thread Hugo Trippaers



> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo
> 
> Ritu  Sabharwal wrote:
> Hi Hugo,
> 
> I commented on the review comments directly. I included a patch file 
> brocade-vcs.patch which has Brocade code. 
> 
> I followed these steps to create the patch:
> 
> -git add plugins/network-elements/brocade-vcs
> -git commit -m "Commit message“
> -git format-patch master --stdout > ~/brocade-vcs.patch
> 
> Is there any other way to include Brocade code in the diffs? Please let 
> me know. I will submit that for review.
> 
> Thanks,
> Ritu.
>

You can create a separate review request for the vcs code (and post a link in 
this review) or create a single big patch with everything. I'm fine with either 
option, but we need the patch in review board as that will help us do the 
review properly.

Thanks for fixing the other items.

Cheers,

Hugo


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On June 26, 2014, 10:25 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated June 26, 2014, 10:25 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 885bffe 
>   api/src/com/cloud/network/Networks.java 1e4d229 
>   api/src/com/cloud/network/PhysicalNetwork.java 8cc214e 
>   client/pom.xml 29fef4f 
>   plugins/pom.xml b5e6a61 
>   setup/db/db/schema-440to450.sql 77445a9 
>   ui/scripts/system.js 9a98a5c 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch file for Brocade functionality code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-26 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 26, 2014, 10:25 p.m.)

Review request for cloudstack.

Changes
---

Fixed the issues as provided in review comments. Uploaded new diff file with
changes and patch file for Brocade functionality code.

Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

Repository: cloudstack-git

Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches
for L2 connectivity. Please create a new branch for Brocade plugin.

Diffs (updated)
-

Diff: https://reviews.apache.org/r/22863/diff/

Testing
---

File Attachments (updated)

Diff for the existing cloudstack code

https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code

https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch

Thanks,

Ritu Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-24 Thread Ritu Sabharwal



> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > Hey,
> > 
> > There are a number of issues with this patch, i've made the commments on 
> > the lines directly. Also where is the real functionality? The code in this 
> > patch seems to only be the hook into the existing cloudstack code and not 
> > the brocade code itself?
> > 
> > Cheers,
> > 
> > Hugo

Hi Hugo,

I commented on the review comments directly. I included a patch file 
brocade-vcs.patch which has Brocade code. 

I followed these steps to create the patch:

-git add plugins/network-elements/brocade-vcs
-git commit -m "Commit message“
-git format-patch master --stdout > ~/brocade-vcs.patch

Is there any other way to include Brocade code in the diffs? Please let me 
know. I will submit that for review.

Thanks,
Ritu.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > build/replace.properties, line 20
> > 
> >
> > This change will break some developer setups. Can you remove this file 
> > from the patch.

The changes in this file are for my local server. I will remove this file from 
the patch.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > api/src/com/cloud/network/Network.java, line 135
> > 
> >
> > Please remove tabs from the sources.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > plugins/pom.xml, line 71
> > 
> >
> > Why do you need to include test in the main build process?

I created some test project for my testing. I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > setup/db/create-schema.sql, line 148
> > 
> >
> > Don't make changes to this file. Add the new tables to the upgrade 
> > files. In this case you need to make the changes in the 4.4 to 4.5 upgrade 
> > file.

I will fix this.


> On June 24, 2014, 6:40 a.m., Hugo Trippaers wrote:
> > utils/conf/db.properties, line 28
> > 
> >
> > Please don't commit any changes to this file.

This again is for my local server. I will remove this file from the patch.


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


On June 23, 2014, 5:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated June 23, 2014, 5:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java b5e8173 
>   api/src/com/cloud/network/Networks.java 3159f6e 
>   api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
>   build/replace.properties 265f335 
>   client/pom.xml 3995f6e 
>   plugins/pom.xml 4f7805a 
>   setup/db/create-schema.sql 55cb4cc 
>   ui/scripts/system.js 0c56baf 
>   utils/conf/db.properties e1b5fe9 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch for the plugin code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-24 Thread Ritu Sabharwal

Hi Hugo,

There is a separate file

From: Hugo Trippaers [mailto:nore...@reviews.apache.org] On Behalf Of Hugo 
Trippaers
Sent: Monday, June 23, 2014 11:41 PM
To: Ritu Sabharwal; Hugo Trippaers; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/22863/

Hey,

There are a number of issues with this patch, i've made the commments on the 
lines directly. Also where is the real functionality? The code in this patch 
seems to only be the hook into the existing cloudstack code and not the brocade 
code itself?

Cheers,

Hugo

api/src/com/cloud/network/Network.java<https://reviews.apache.org/r/22863/diff/1/?file=614964#file614964line135>
 (Diff revision 1)

public static class Provider {

135

Please remove tabs from the sources.

build/replace.properties<https://reviews.apache.org/r/22863/diff/1/?file=614967#file614967line20>
 (Diff revision 1)

20

DBROOTPW=

20

DBROOTPW=password

This change will break some developer setups. Can you remove this file from the 
patch.

plugins/pom.xml<https://reviews.apache.org/r/22863/diff/1/?file=614969#file614969line71>
 (Diff revision 1)

71

test

Why do you need to include test in the main build process?

setup/db/create-schema.sql<https://reviews.apache.org/r/22863/diff/1/?file=614970#file614970line148>
 (Diff revision 1)

148

DROP TABLE IF EXISTS `cloud`.`brocade_network_host_map`;

Don't make changes to this file. Add the new tables to the upgrade files. In 
this case you need to make the changes in the 4.4 to 4.5 upgrade file.

utils/conf/db.properties<https://reviews.apache.org/r/22863/diff/1/?file=614972#file614972line28>
 (Diff revision 1)

28

db.root.password=

28

db.root.password=password

Please don't commit any changes to this file.

- Hugo Trippaers

On June 23rd, 2014, 5:49 p.m. UTC, Ritu Sabharwal wrote:
Review request for cloudstack.
By Ritu Sabharwal.

Updated June 23, 2014, 5:49 p.m.
Bugs: CLOUDSTACK-6823<https://issues.apache.org/jira/browse/CLOUDSTACK-6823>
Repository: cloudstack-git
Description

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.

Testing

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.

•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.

•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.

•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.

Diffs

 *   api/src/com/cloud/network/Network.java (b5e8173)
 *   api/src/com/cloud/network/Networks.java (3159f6e)
 *   api/src/com/cloud/network/PhysicalNetwork.java (5d38b50)
 *   build/replace.properties (265f335)
 *   client/pom.xml (3995f6e)
 *   plugins/pom.xml (4f7805a)
 *   setup/db/create-schema.sql (55cb4cc)
 *   ui/scripts/system.js (0c56baf)
 *   utils/conf/db.properties (e1b5fe9)

View Diff<https://reviews.apache.org/r/22863/diff/>

File Attachments

 *   Diff for the existing cloudstack 
code<https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff>
 *   Patch for the plugin 
code<https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch>

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-23 Thread Hugo Trippaers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/#review46498
---


Hey,

There are a number of issues with this patch, i've made the commments on the 
lines directly. Also where is the real functionality? The code in this patch 
seems to only be the hook into the existing cloudstack code and not the brocade 
code itself?

Cheers,

Hugo


api/src/com/cloud/network/Network.java


Please remove tabs from the sources.



build/replace.properties


This change will break some developer setups. Can you remove this file from 
the patch.



plugins/pom.xml


Why do you need to include test in the main build process?



setup/db/create-schema.sql


Don't make changes to this file. Add the new tables to the upgrade files. 
In this case you need to make the changes in the 4.4 to 4.5 upgrade file.



utils/conf/db.properties


Please don't commit any changes to this file.


- Hugo Trippaers


On June 23, 2014, 5:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22863/
> ---
> 
> (Updated June 23, 2014, 5:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> First code drop for Brocade Network plugin to orchestrate Brocade VDX 
> switches for L2 connectivity. Please create a new branch for Brocade plugin.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java b5e8173 
>   api/src/com/cloud/network/Networks.java 3159f6e 
>   api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
>   build/replace.properties 265f335 
>   client/pom.xml 3995f6e 
>   plugins/pom.xml 4f7805a 
>   setup/db/create-schema.sql 55cb4cc 
>   ui/scripts/system.js 0c56baf 
>   utils/conf/db.properties e1b5fe9 
> 
> Diff: https://reviews.apache.org/r/22863/diff/
> 
> 
> Testing
> ---
> 
> • Create an isolated network; verify that the port-profile is created on 
> the Brocade switch.
> • Attach a VM to the network; verify that the VMs MAC address is 
> associated with the port profile of the network on the Brocade switch.
> • Delete VMs for an isolated network; verify that the VMs MAC address is 
> disassociated with the port profile of the network on the Brocade switch.
> • Delete the isolated network; verify that the port-profile is deleted 
> from the Brocade switch.
> 
> 
> File Attachments
> 
> 
> Diff for the existing cloudstack code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
> Patch for the plugin code
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-23 Thread Ritu Sabharwal

Hi Sebastian,

I submitted the first code drop for plugin for review. Can you please create a 
new branch for Brocade plugin development.  

Also, I wanted to know how do I select specific reviewers for reviewing the 
request. I did not see any option to choose that while submitting the request.

Thanks & Regards,
Ritu S. 

-Original Message-
From: Ritu Sabharwal [mailto:nore...@reviews.apache.org] On Behalf Of Ritu 
Sabharwal
Sent: Monday, June 23, 2014 10:49 AM
To: Ritu Sabharwal; cloudstack
Subject: Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for 
Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 5:49 p.m.)


Review request for cloudstack.


Changes
---

Added a note requesting a new branch for Brocade plugin.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description (updated)
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity. Please create a new branch for Brocade plugin.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-23 Thread Ritu Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 5:49 p.m.)

Review request for cloudstack.

Changes
---

Added a note requesting a new branch for Brocade plugin.

Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

Repository: cloudstack-git

Description (updated)
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches
for L2 connectivity. Please create a new branch for Brocade plugin.

Diffs
-

api/src/com/cloud/network/Network.java b5e8173
api/src/com/cloud/network/Networks.java 3159f6e
api/src/com/cloud/network/PhysicalNetwork.java 5d38b50
build/replace.properties 265f335
client/pom.xml 3995f6e
plugins/pom.xml 4f7805a
setup/db/create-schema.sql 55cb4cc
ui/scripts/system.js 0c56baf
utils/conf/db.properties e1b5fe9

Diff: https://reviews.apache.org/r/22863/diff/

Testing
---

File Attachments

Diff for the existing cloudstack code

https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code

https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch

Thanks,

Ritu Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

2014-06-23 Thread Ritu Sabharwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
---

(Updated June 23, 2014, 10:18 a.m.)


Review request for cloudstack.


Changes
---

Updated the JIRA Bug id on Summary.


Summary (updated)
-

CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate 
Brocade VDX switches for L2 connectivity.


Bugs: CLOUDSTACK-6823
https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
---

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches 
for L2 connectivity.


Diffs
-

  api/src/com/cloud/network/Network.java b5e8173 
  api/src/com/cloud/network/Networks.java 3159f6e 
  api/src/com/cloud/network/PhysicalNetwork.java 5d38b50 
  build/replace.properties 265f335 
  client/pom.xml 3995f6e 
  plugins/pom.xml 4f7805a 
  setup/db/create-schema.sql 55cb4cc 
  ui/scripts/system.js 0c56baf 
  utils/conf/db.properties e1b5fe9 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
---

•   Create an isolated network; verify that the port-profile is created on 
the Brocade switch.
•   Attach a VM to the network; verify that the VMs MAC address is 
associated with the port profile of the network on the Brocade switch.
•   Delete VMs for an isolated network; verify that the VMs MAC address is 
disassociated with the port profile of the network on the Brocade switch.
•   Delete the isolated network; verify that the port-profile is deleted 
from the Brocade switch.


File Attachments


Diff for the existing cloudstack code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch for the plugin code
  
https://reviews.apache.org/media/uploaded/files/2014/06/23/fbb2b949-a42c-4b22-afa7-60e691c778df__brocade-vcs.patch


Thanks,

Ritu  Sabharwal

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

RE: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.

36 matches

Site Navigation

Mail list logo

Footer information