Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46722 --- Commit 039878b49a821cd1fd52e0ead0f528c3e9371a0c in cloudstack's branch refs/heads/4.4-forward from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=039878b ] CLOUDSTACK-6984: Re-enable the testcase - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46728 --- Commit 7bc997f4fbaa80ed6335ba3658baaee5c9cb8e48 in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7bc997f ] CLOUDSTACK-6984: Re-enable the testcase - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46530 --- Ship it! Ship It! - Girish Shilamkar On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46531 --- Commit 8de18f144c680287c762a4b5db1b6e1d596f5723 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8de18f1 ] CLOUDSTACK-6984: Resolving simulator issues - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found durign simulator run
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/#review46532 --- Commit 0df156c09e152845d6c6332fa1d91fe9c15c7cc6 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0df156c ] CLOUDSTACK-6984: Resolving issues found during simulator run - ASF Subversion and Git Services On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22934/ --- (Updated June 24, 2014, 3:04 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6984 https://issues.apache.org/jira/browse/CLOUDSTACK-6984 Repository: cloudstack-git Description --- Fixing issues found in simulator run. 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead. Diffs - test/integration/smoke/test_network.py 0ae777e test/integration/smoke/test_vm_life_cycle.py 9ab7848 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22934/diff/ Testing --- yes. Thanks, Gaurav Aradhye
