Review Request 23008: Reverted the hardcoding fix for "SR-Label:" and "Path:" strings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23008/ --- Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Reverted the hard-coding fix for strings "Path:" and "SR-Name Label:". Diffs - ui/scripts/system.js 67e01f1 Diff: https://reviews.apache.org/r/23008/diff/ Testing --- No Thanks, Vetrivel Chinnasamy
Re: Review Request 23008: Reverted the hardcoding fix for "SR-Label:" and "Path:" strings
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23008/#review46754
---
This line looks incorrect to me:
-
$form.find('.form-item[rel=path]').find(".name").find("label").text('label.path'+":").prepend($required);
+
$form.find('.form-item[rel=path]').find(".name").find("label").text("SR
Name-Label:").prepend($required);
I think the replaced text should be "Path:".
- Mike Tutkowski
On June 26, 2014, 11:52 a.m., Vetrivel Chinnasamy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23008/
> ---
>
> (Updated June 26, 2014, 11:52 a.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Reverted the hard-coding fix for strings "Path:" and "SR-Name Label:".
>
>
> Diffs
> -
>
> ui/scripts/system.js 67e01f1
>
> Diff: https://reviews.apache.org/r/23008/diff/
>
>
> Testing
> ---
>
> No
>
>
> Thanks,
>
> Vetrivel Chinnasamy
>
>
Re: Review Request 23008: Reverted the hardcoding fix for "SR-Label:" and "Path:" strings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23008/#review46755 --- Ship it! Due to time constraints with regards to RC1 of 4.4 (tentatively planned for tomorrow), I went ahead and modified the patch per my previous comment and committed it to 4.4-forward: 9c2e6f5ed45522ff68131556028f3fb4ff91ee90 - Mike Tutkowski On June 26, 2014, 11:52 a.m., Vetrivel Chinnasamy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23008/ > --- > > (Updated June 26, 2014, 11:52 a.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Repository: cloudstack-git > > > Description > --- > > Reverted the hard-coding fix for strings "Path:" and "SR-Name Label:". > > > Diffs > - > > ui/scripts/system.js 67e01f1 > > Diff: https://reviews.apache.org/r/23008/diff/ > > > Testing > --- > > No > > > Thanks, > > Vetrivel Chinnasamy > >
