Re: Review Request 23084: Making the Adding primary storage form support adding primary storage to CS that is based on storage plug-ins

2014-06-26 Thread Seifeddine JEMLI

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23084/
---

(Updated June 26, 2014, 8:47 p.m.)


Review request for cloudstack and Mike Wang.


Repository: cloudstack-git


Description
---

Making the GUI support adding primary storage to CS that is based on storage 
plug-ins
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins


Diffs
-

  client/WEB-INF/classes/resources/messages.properties b504a18 
  ui/dictionary.jsp 9026a36 
  ui/scripts/docs.js aad358b 
  ui/scripts/system.js 44a08a6 

Diff: https://reviews.apache.org/r/23084/diff/


Testing
---

manual testing by changing GUI controls and observing the behavior. verifying 
that data ended up in the storage_pool table as expected.


Thanks,

Seifeddine JEMLI



Re: Review Request 23084: Making the Adding primary storage form support adding primary storage to CS that is based on storage plug-ins

2014-06-26 Thread Seifeddine JEMLI

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23084/
---

(Updated June 26, 2014, 8:49 p.m.)


Review request for cloudstack and Mike Tutkowski.


Repository: cloudstack-git


Description
---

Making the GUI support adding primary storage to CS that is based on storage 
plug-ins
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins


Diffs
-

  client/WEB-INF/classes/resources/messages.properties b504a18 
  ui/dictionary.jsp 9026a36 
  ui/scripts/docs.js aad358b 
  ui/scripts/system.js 44a08a6 

Diff: https://reviews.apache.org/r/23084/diff/


Testing
---

manual testing by changing GUI controls and observing the behavior. verifying 
that data ended up in the storage_pool table as expected.


Thanks,

Seifeddine JEMLI



Re: Review Request 23084: Making the Adding primary storage form support adding primary storage to CS that is based on storage plug-ins

2014-06-26 Thread Mike Tutkowski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23084/#review46839
---

Ship it!


Committed the changes in 9a27f201b02fe33cdba1dcca7da63497b323a874

- Mike Tutkowski


On June 26, 2014, 2:49 p.m., Seifeddine JEMLI wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/23084/
 ---
 
 (Updated June 26, 2014, 2:49 p.m.)
 
 
 Review request for cloudstack and Mike Tutkowski.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Making the GUI support adding primary storage to CS that is based on storage 
 plug-ins
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Create+GUI+to+add+primary+storage+based+on+plug-ins
 
 
 Diffs
 -
 
   client/WEB-INF/classes/resources/messages.properties b504a18 
   ui/dictionary.jsp 9026a36 
   ui/scripts/docs.js aad358b 
   ui/scripts/system.js 44a08a6 
 
 Diff: https://reviews.apache.org/r/23084/diff/
 
 
 Testing
 ---
 
 manual testing by changing GUI controls and observing the behavior. verifying 
 that data ended up in the storage_pool table as expected.
 
 
 Thanks,
 
 Seifeddine JEMLI