Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/#review78989 --- Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Dec. 5, 2014, 10:37 p.m., Vania Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated Dec. 5, 2014, 10:37 p.m.) Review request for cloudstack, Mike Tutkowski and Pierre-Luc Dion. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/lib/base.py 2ef6f82 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/#review64099 --- the patch cannot be merge into 4.5 or master, could it be possible to resubmit a new patch? Thank you Vania. - Pierre-Luc Dion On July 8, 2014, 8:51 p.m., Vania Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated July 8, 2014, 8:51 p.m.) Review request for cloudstack and Mike Tutkowski. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/lib/base.py 2ef6f82 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated Dec. 5, 2014, 10:37 p.m.) Review request for cloudstack, Mike Tutkowski and Pierre-Luc Dion. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/lib/base.py 2ef6f82 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
Thanks, Vania! On Fri, Dec 5, 2014 at 3:37 PM, Vania Xu vania...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ Review request for cloudstack, Mike Tutkowski and Pierre-Luc Dion. By Vania Xu. *Updated Dec. 5, 2014, 10:37 p.m.* *Repository: * cloudstack-git Description Building automated integration tests that needed additional properties added to Marvin code. Testing Ran new code against my integration tests, and it was successful. Diffs - tools/marvin/marvin/lib/base.py (2ef6f82) View Diff https://reviews.apache.org/r/23098/diff/ -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud http://solidfire.com/solution/overview/?video=play*™*
Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/#review47465 --- It looks like the base.py file has been relocated for the 4.5 release. Can you please regenerate your diff using the 4.5 branch? Thanks! - Mike Tutkowski On June 26, 2014, 5:13 p.m., Vania Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated June 26, 2014, 5:13 p.m.) Review request for cloudstack and Mike Tutkowski. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/integration/lib/base.py 95b7fe9 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
On July 8, 2014, 8:50 p.m., Mike Tutkowski wrote: It looks like the base.py file has been relocated for the 4.5 release. Can you please regenerate your diff using the 4.5 branch? Thanks! I'll go ahead and upload a new diff. - Vania --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/#review47465 --- On June 26, 2014, 11:13 p.m., Vania Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated June 26, 2014, 11:13 p.m.) Review request for cloudstack and Mike Tutkowski. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/integration/lib/base.py 95b7fe9 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated July 8, 2014, 8:51 p.m.) Review request for cloudstack and Mike Tutkowski. Changes --- Here's the updated diff. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs (updated) - tools/marvin/marvin/lib/base.py 2ef6f82 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Re: Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/#review47468 --- Ship it! Ship It! - Mike Tutkowski On July 8, 2014, 2:51 p.m., Vania Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- (Updated July 8, 2014, 2:51 p.m.) Review request for cloudstack and Mike Tutkowski. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/lib/base.py 2ef6f82 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
Review Request 23098: Updated Marvin code to support more properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23098/ --- Review request for cloudstack and Mike Tutkowski. Repository: cloudstack-git Description --- Building automated integration tests that needed additional properties added to Marvin code. Diffs - tools/marvin/marvin/integration/lib/base.py 95b7fe9 Diff: https://reviews.apache.org/r/23098/diff/ Testing --- Ran new code against my integration tests, and it was successful. Thanks, Vania Xu
