Re: Review Request 26025: CLOUDSTACK-7616: Fixed test_escalations_ipaddress.py - test suite should use its own vpc offering

2014-09-26 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26025/#review54664
---

Ship it!


0b9938ce40bd269639e91bf0e7bcfb36427cdaaa master

- SrikanteswaraRao Talluri


On Sept. 25, 2014, 7:28 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26025/
 ---
 
 (Updated Sept. 25, 2014, 7:28 a.m.)
 
 
 Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-7616
 https://issues.apache.org/jira/browse/CLOUDSTACK-7616
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Few test cases in test suite test_escalations_ipaddresses.py were using VPC 
 offering already present in the setup to create the VPC. They should create 
 their own VPC offering and remove it after the run has completed.
 
 Changes:
 1. Created VPC offering in setUpClass and used it in the test cases.
 2. Fixed pep8 issues
 
 
 Diffs
 -
 
   test/integration/component/test_escalations_ipaddresses.py 00aacbf 
 
 Diff: https://reviews.apache.org/r/26025/diff/
 
 
 Testing
 ---
 
 Yes.
 
 Log:
 @summary: Test List IP Addresses pagination ... === TestName: 
 test_01_list_ipaddresses_pagination | Status : SUCCESS ===
 ok
 @summary: Test List IP Addresses details by ID ... === TestName: 
 test_02_list_ipaddresses_byid | Status : SUCCESS ===
 ok
 @summary: Test to Associate IP Address for VPC ... === TestName: 
 test_03_associate_ipaddress_for_vpc | Status : SUCCESS ===
 ok
 @summary: Test to list, create and delete Load Balancer Rule ... === 
 TestName: test_04_create_delete_lbrule_fornonvpc | Status : SUCCESS ===
 ok
 @summary: Test to list, create and delete Load Balancer Rule for IP ... === 
 TestName: test_05_create_delete_lbrule_forvpc | Status : SUCCESS ===
 ok
 @summary: Test to Update Load Balancer Rule Name for ... === TestName: 
 test_06_update_lbrule_name | Status : SUCCESS ===
 ok
 @summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === 
 TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
 ok
 @summary: Test to List, Create, Delete Load Balancer Stickyness Policy ... 
 === TestName: test_08_list_create_delete_lbsticky_policy | Status : SUCCESS 
 ===
 ok
 @summary: Test to list, create and delete Port Forwarding for ... === 
 TestName: test_09_create_delete_portforwarding_fornonvpc | Status : SUCCESS 
 ===
 ok
 @summary: Test to list, create and delete Port Forwarding Rule ... === 
 TestName: test_10_create_delete_portforwarding_forvpc | Status : SUCCESS ===
 ok
 @summary: Test to list, create and delete Firewall Rule for ... === TestName: 
 test_11_create_delete_firewallrule | Status : SUCCESS ===
 ok
 @summary: Test to list, create and delete Remote Access VPNs ... === 
 TestName: test_12_create_delete_remoteaccessvpn | Status : SUCCESS ===
 ok
 @summary: Test to list, add and remove VPN Users ... === TestName: 
 test_13_add_remove_vpnusers | Status : SUCCESS ===
 ok
 @summary: Test to Enable and Disable StaticNat for ... === TestName: 
 test_14_enable_disable_staticnat_fornonvpc | Status : SUCCESS ===
 ok
 @summary: Test to Enable and Disable StaticNat for ... === TestName: 
 test_15_enable_disable_staticnat_forvpc | Status : SUCCESS ===
 ok
 @summary: Test to list, create and ... === TestName: 
 test_16_create_delete_ipforwardingrule | Status : SUCCESS ===
 ok
 @summary: Test to list, create and update Autoscale Policy ... SKIP: ScaleVM 
 is not supported on KVM. Hence, skipping the test
 @summary: Test to list, create and update Autoscale VM Profiles ... SKIP: 
 ScaleVM is not supported on KVM. Hence, skipping the test
 @summary: Test to list, create, update, enable,disable 
 Autoscale VM Profiles ... SKIP: ScaleVM is not supported on KVM. Hence, 
 skipping the test
 
 --
 Ran 19 tests in 2700.975s
 
 OK (SKIP=3)
 
 
 Thanks,
 
 Gaurav Aradhye
 




Review Request 26025: CLOUDSTACK-7616: Fixed test_escalations_ipaddress.py - test suite should use its own vpc offering

2014-09-25 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26025/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7616
https://issues.apache.org/jira/browse/CLOUDSTACK-7616


Repository: cloudstack-git


Description
---

Few test cases in test suite test_escalations_ipaddresses.py were using VPC 
offering already present in the setup to create the VPC. They should create 
their own VPC offering and remove it after the run has completed.

Changes:
1. Created VPC offering in setUpClass and used it in the test cases.
2. Fixed pep8 issues


Diffs
-

  test/integration/component/test_escalations_ipaddresses.py 00aacbf 

Diff: https://reviews.apache.org/r/26025/diff/


Testing
---

Yes.

Log:
@summary: Test List IP Addresses pagination ... === TestName: 
test_01_list_ipaddresses_pagination | Status : SUCCESS ===
ok
@summary: Test List IP Addresses details by ID ... === TestName: 
test_02_list_ipaddresses_byid | Status : SUCCESS ===
ok
@summary: Test to Associate IP Address for VPC ... === TestName: 
test_03_associate_ipaddress_for_vpc | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Load Balancer Rule ... === TestName: 
test_04_create_delete_lbrule_fornonvpc | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Load Balancer Rule for IP ... === 
TestName: test_05_create_delete_lbrule_forvpc | Status : SUCCESS ===
ok
@summary: Test to Update Load Balancer Rule Name for ... === TestName: 
test_06_update_lbrule_name | Status : SUCCESS ===
ok
@summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === 
TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
ok
@summary: Test to List, Create, Delete Load Balancer Stickyness Policy ... === 
TestName: test_08_list_create_delete_lbsticky_policy | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Port Forwarding for ... === TestName: 
test_09_create_delete_portforwarding_fornonvpc | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Port Forwarding Rule ... === 
TestName: test_10_create_delete_portforwarding_forvpc | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Firewall Rule for ... === TestName: 
test_11_create_delete_firewallrule | Status : SUCCESS ===
ok
@summary: Test to list, create and delete Remote Access VPNs ... === TestName: 
test_12_create_delete_remoteaccessvpn | Status : SUCCESS ===
ok
@summary: Test to list, add and remove VPN Users ... === TestName: 
test_13_add_remove_vpnusers | Status : SUCCESS ===
ok
@summary: Test to Enable and Disable StaticNat for ... === TestName: 
test_14_enable_disable_staticnat_fornonvpc | Status : SUCCESS ===
ok
@summary: Test to Enable and Disable StaticNat for ... === TestName: 
test_15_enable_disable_staticnat_forvpc | Status : SUCCESS ===
ok
@summary: Test to list, create and ... === TestName: 
test_16_create_delete_ipforwardingrule | Status : SUCCESS ===
ok
@summary: Test to list, create and update Autoscale Policy ... SKIP: ScaleVM is 
not supported on KVM. Hence, skipping the test
@summary: Test to list, create and update Autoscale VM Profiles ... SKIP: 
ScaleVM is not supported on KVM. Hence, skipping the test
@summary: Test to list, create, update, enable,disable 
Autoscale VM Profiles ... SKIP: ScaleVM is not supported on KVM. Hence, 
skipping the test

--
Ran 19 tests in 2700.975s

OK (SKIP=3)


Thanks,

Gaurav Aradhye