----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26030/ -----------------------------------------------------------
Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Bugs: master https://issues.apache.org/jira/browse/master Repository: cloudstack-git Description ------- The instance.name configuration value is effective only on VMware hypervisor. Hence test cases which reads the value should be skipped on other hypervisors. Changes: 1. Replaced hard coded VM names with random strings to avoid deploying VMs with same names. 2. Skipped the test cases according to hypervisor support 3. Fixed pep8 issues Diffs ----- test/integration/component/test_custom_hostname.py 9d9008a Diff: https://reviews.apache.org/r/26030/diff/ Testing ------- Yes. Tested on KVM and VMware. On Vmware, one test case failed with "Exceptio not raised", this is a different issue and not addressed in this patch. Log: Verify custom hostname for the instance when ... === TestName: test_01_custom_hostname_instancename_false | Status : SUCCESS === ok Verify user provided hostname to an instance ... SKIP: vm.instancename.flag should be true. skipping Verify for globally set instancename ... SKIP: vm.instancename.flag should be true. skipping Test the duplicate name when old VM is in non-expunged state ... SKIP: vm.instancename.flag should be true. skipping Test Edit the Display name Through the UI. ... === TestName: test_04_edit_display_name | Status : SUCCESS === ok Test Unsupported chars in the display name ... === TestName: test_05_unsupported_chars_in_display_name | Status : FAILED === FAIL Test the instance name with hyphens ... SKIP: vm.instancename.flag should be true. skipping @Desc: Test whether cloudstack allows duplicate vm instance ... SKIP: vm.instancename.flag should be true. skipping ====================================================================== FAIL: Test Unsupported chars in the display name ---------------------------------------------------------------------- Traceback (most recent call last): File "/root/test/test_custom_hostname.py", line 773, in test_05_unsupported_chars_in_display_name serviceofferingid=self.service_offering.id, AssertionError: Exception not raised -------------------- >> begin captured stdout << --------------------- === TestName: test_05_unsupported_chars_in_display_name | Status : FAILED === ---------------------------------------------------------------------- Ran 8 tests in 627.421s FAILED (SKIP=5, failures=1) Thanks, Gaurav Aradhye