Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review55966 --- Ship it! 1ede3eeacb2e78a34d43003c12ff060b3aafeb21 - daan Hoogland On Oct. 8, 2014, 10:47 a.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Oct. 8, 2014, 10:47 a.m.) Review request for cloudstack and daan Hoogland. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Oct. 8, 2014, 10:47 a.m.) Review request for cloudstack and daan Hoogland. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54536 --- I think they all should start with a cloudstack-, I'm not sure but does this cause any issue for you? And I think they would be applicable on master, 4.4 branches as well. - Rohit Yadav On Sept. 25, 2014, 1:31 p.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 1:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
On Sept. 25, 2014, 2:12 p.m., Rohit Yadav wrote: I think they all should start with a cloudstack-, I'm not sure but does this cause any issue for you? And I think they would be applicable on master, 4.4 branches as well. No problem with them starting with cloudstack- instead. I'll update the patch. - Vincent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54536 --- On Sept. 25, 2014, 1:31 p.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 1:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 2:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs (updated) - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54539 --- Thanks for your quick fix, it's more consistent with the cloudstack- prefix now. LGTM, merging on master and 4.3 branch. For 4.4 branch, please drop a note to Daan or add him to the reviewers. - Rohit Yadav On Sept. 25, 2014, 2:31 p.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 2:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54540 --- Ship it! Ship It! - Rohit Yadav On Sept. 25, 2014, 2:31 p.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 2:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
Re: Review Request 26035: CLOUDSTACK-7633: fix Provides in most LSB headers
On Sept. 25, 2014, 2:55 p.m., Rohit Yadav wrote: Ship It! Merged on 4.3: 08cb7ef7fa0417ea1d9799a0757f459abc5a9883 Merged on master: 2401eb927bbda69f0376d1f34ef20631e1188540 Once your fix lands on 4.4, please close as submitted. - Rohit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54540 --- On Sept. 25, 2014, 2:31 p.m., Vincent Bernat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/ --- (Updated Sept. 25, 2014, 2:31 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-7633 https://issues.apache.org/jira/browse/CLOUDSTACK-7633 Repository: cloudstack-git Description --- CLOUDSTACK-7633: fix Provides in most LSB headers In init.d scripts, the LSB header may specify what kind of service is provided by an init script. If spaces are used, this means the init script is providing several boot facilities. We fix that by using an hyphen. Diffs - agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b packaging/centos63/cloud-usage.rc 8434e4d568a0 packaging/debian/init/cloud-agent eb2c3d14754b packaging/debian/init/cloud-usage 06b1142172aa python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 Diff: https://reviews.apache.org/r/26035/diff/ Testing --- Thanks, Vincent Bernat
