Re: Review Request 26442: CLOUDSTACK-7685: Fixed copy template method call in test_escalations_template.py. Removed unbound method of the same name as bound method from base l ibrary and changed metho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26442/ --- (Updated Oct. 20, 2014, 11:09 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7685 https://issues.apache.org/jira/browse/CLOUDSTACK-7685 Repository: cloudstack-git Description (updated) --- Error details: unbound method copy() must be called with Template instance as first argument (got CloudStackAPIClient instance instead) Reason: There are bound and unbound methods "copy" in Template class with the same name. Apparently when bound and unbound methods with same name are defined, call to unbound method fails. Solution: Keep only bound method. Please note that I have ensured no test case makes call to unbound method (Template.copy). Diffs - test/integration/component/test_escalations_templates.py 78028bc tools/marvin/marvin/lib/base.py 77faeeb Diff: https://reviews.apache.org/r/26442/diff/ Testing --- Tested with python command/pyflakes. Thanks, Gaurav Aradhye
Re: Review Request 26442: CLOUDSTACK-7685: Fixed copy template method call in test_escalations_template.py. Removed unbound method of the same name as bound method from base l ibrary and changed metho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26442/#review59166 --- Ship it! a1e7feead91b22350f96114add4bf8d75a74b8b1 4.5 - SrikanteswaraRao Talluri On Oct. 20, 2014, 5:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26442/ > --- > > (Updated Oct. 20, 2014, 5:39 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7685 > https://issues.apache.org/jira/browse/CLOUDSTACK-7685 > > > Repository: cloudstack-git > > > Description > --- > > Error details: > unbound method copy() must be called with Template instance as first argument > (got CloudStackAPIClient instance instead) > > Reason: > There are bound and unbound methods "copy" in Template class with the same > name. Apparently when bound and unbound methods with same name are defined, > call to unbound method fails. > > Solution: > Keep only bound method. > > Please note that I have ensured no test case makes call to unbound method > (Template.copy). > > > Diffs > - > > test/integration/component/test_escalations_templates.py 78028bc > tools/marvin/marvin/lib/base.py 77faeeb > > Diff: https://reviews.apache.org/r/26442/diff/ > > > Testing > --- > > Tested with python command/pyflakes. > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 26442: CLOUDSTACK-7685: Fixed copy template method call in test_escalations_template.py. Removed unbound method of the same name as bound method from base l ibrary and changed metho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26442/#review59749 --- a1e7feead91b22350f96114add4bf8d75a74b8b1 master - SrikanteswaraRao Talluri On Oct. 20, 2014, 5:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26442/ > --- > > (Updated Oct. 20, 2014, 5:39 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7685 > https://issues.apache.org/jira/browse/CLOUDSTACK-7685 > > > Repository: cloudstack-git > > > Description > --- > > Error details: > unbound method copy() must be called with Template instance as first argument > (got CloudStackAPIClient instance instead) > > Reason: > There are bound and unbound methods "copy" in Template class with the same > name. Apparently when bound and unbound methods with same name are defined, > call to unbound method fails. > > Solution: > Keep only bound method. > > Please note that I have ensured no test case makes call to unbound method > (Template.copy). > > > Diffs > - > > test/integration/component/test_escalations_templates.py 78028bc > tools/marvin/marvin/lib/base.py 77faeeb > > Diff: https://reviews.apache.org/r/26442/diff/ > > > Testing > --- > > Tested with python command/pyflakes. > > > Thanks, > > Gaurav Aradhye > >
Re: Review Request 26442: CLOUDSTACK-7685: Fixed copy template method call in test_escalations_template.py. Removed unbound method of the same name as bound method from base l ibrary and changed metho
> On Nov. 4, 2014, 6:25 a.m., SrikanteswaraRao Talluri wrote: > > a1e7feead91b22350f96114add4bf8d75a74b8b1 master correction d5316d0572df0843a5decb69c0385fc5fcf192b0 master - SrikanteswaraRao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26442/#review59749 --- On Oct. 20, 2014, 5:39 a.m., Gaurav Aradhye wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26442/ > --- > > (Updated Oct. 20, 2014, 5:39 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7685 > https://issues.apache.org/jira/browse/CLOUDSTACK-7685 > > > Repository: cloudstack-git > > > Description > --- > > Error details: > unbound method copy() must be called with Template instance as first argument > (got CloudStackAPIClient instance instead) > > Reason: > There are bound and unbound methods "copy" in Template class with the same > name. Apparently when bound and unbound methods with same name are defined, > call to unbound method fails. > > Solution: > Keep only bound method. > > Please note that I have ensured no test case makes call to unbound method > (Template.copy). > > > Diffs > - > > test/integration/component/test_escalations_templates.py 78028bc > tools/marvin/marvin/lib/base.py 77faeeb > > Diff: https://reviews.apache.org/r/26442/diff/ > > > Testing > --- > > Tested with python command/pyflakes. > > > Thanks, > > Gaurav Aradhye > >
