Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/ --- Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7765 https://issues.apache.org/jira/browse/CLOUDSTACK-7765 Repository: cloudstack-git Description --- Validation on the super CIDR and DNS domain fields Diffs - ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549 Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy
Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/#review58880 --- Gabor, I am getting a conflict on the latest master: bfederle$ git am ~/Downloads/0001-CLOUDSTACK-7765-Field-Validations-Missing-for-VPC-IP.patch Applying: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields error: patch failed: ui/scripts/sharedFunctions.js:2224 error: ui/scripts/sharedFunctions.js: patch does not apply Patch failed at 0001 CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27297/ > --- > > (Updated Oct. 28, 2014, 7:16 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-7765 > https://issues.apache.org/jira/browse/CLOUDSTACK-7765 > > > Repository: cloudstack-git > > > Description > --- > > Validation on the super CIDR and DNS domain fields > > > Diffs > - > > ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 > ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549 > > Diff: https://reviews.apache.org/r/27297/diff/ > > > Testing > --- > > Checked validation on the super CIDR and DNS domain fields > > > Thanks, > > Gabor Apati-Nagy > >
Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/ --- (Updated Oct. 29, 2014, 3:17 p.m.) Review request for cloudstack, Brian Federle and Jessica Wang. Bugs: CLOUDSTACK-7765 https://issues.apache.org/jira/browse/CLOUDSTACK-7765 Repository: cloudstack-git Description --- Validation on the super CIDR and DNS domain fields Diffs (updated) - ui/scripts/network.js fb293ed0b3a3ace8dd0fdbeaea00dd7896af6d32 ui/scripts/sharedFunctions.js e044d24fc8221aec23e9f140b6c391bf85c88f3a Diff: https://reviews.apache.org/r/27297/diff/ Testing --- Checked validation on the super CIDR and DNS domain fields Thanks, Gabor Apati-Nagy
Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/#review59007 --- Ship it! Ship It! - Brian Federle On Oct. 29, 2014, 3:17 p.m., Gabor Apati-Nagy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27297/ > --- > > (Updated Oct. 29, 2014, 3:17 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-7765 > https://issues.apache.org/jira/browse/CLOUDSTACK-7765 > > > Repository: cloudstack-git > > > Description > --- > > Validation on the super CIDR and DNS domain fields > > > Diffs > - > > ui/scripts/network.js fb293ed0b3a3ace8dd0fdbeaea00dd7896af6d32 > ui/scripts/sharedFunctions.js e044d24fc8221aec23e9f140b6c391bf85c88f3a > > Diff: https://reviews.apache.org/r/27297/diff/ > > > Testing > --- > > Checked validation on the super CIDR and DNS domain fields > > > Thanks, > > Gabor Apati-Nagy > >
