Re: Review Request 28114: RabbitMQ integration, make SSL protocol configurable rather than hard coded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/#review78991 --- Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Nov. 17, 2014, 5:05 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/ --- (Updated Nov. 17, 2014, 5:05 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7923 https://issues.apache.org/jira/browse/CLOUDSTACK-7923 Repository: cloudstack-git Description --- In the current RabbitMQ integration implementation we are using default SSL Context which uses SSLv3 by default. Make it configurable so that let the users decide which protocol to be used. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 2d389f2 Diff: https://reviews.apache.org/r/28114/diff/ Testing --- Tested against RabbitMQ server 3.3.5 Thanks, Damodar Reddy Talakanti
Re: Review Request 28114: RabbitMQ integration, make SSL protocol configurable rather than hard coded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/#review64049 --- Damodar, we're hardcoding TLSv1 here? How can users call the setSslProtocol? Is there an API? - Rohit Yadav On Nov. 17, 2014, 5:05 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/ --- (Updated Nov. 17, 2014, 5:05 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7923 https://issues.apache.org/jira/browse/CLOUDSTACK-7923 Repository: cloudstack-git Description --- In the current RabbitMQ integration implementation we are using default SSL Context which uses SSLv3 by default. Make it configurable so that let the users decide which protocol to be used. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 2d389f2 Diff: https://reviews.apache.org/r/28114/diff/ Testing --- Tested against RabbitMQ server 3.3.5 Thanks, Damodar Reddy Talakanti
Review Request 28114: RabbitMQ integration, make SSL protocol configurable rather than hard coded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28114/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-7923 https://issues.apache.org/jira/browse/CLOUDSTACK-7923 Repository: cloudstack-git Description --- In the current RabbitMQ integration implementation we are using default SSL Context which uses SSLv3 by default. Make it configurable so that let the users decide which protocol to be used. Diffs - plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java 2d389f2 Diff: https://reviews.apache.org/r/28114/diff/ Testing --- Tested against RabbitMQ server 3.3.5 Thanks, Damodar Reddy Talakanti
