Re: Review Request 28168: public_ip type resource count for an account is not decremented upon IP range deletion

2015-04-06 Thread Sebastien Goasguen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28168/#review79019
---


Thank you for submitting your CloudStack contribution through review board. 
After discussion on the dev@cloudstack.apache.org the community decided to 
close down review board and start accepting contributiong through GitHub pull 
requests. We have been using GH PR for several months now and the process is 
better than review board.

We will keep Review Board open for another week to give you time to migrate 
your patch to a github PR if you wish. After that time, your patch will no 
longer be viewable (even though it will not be deleted).

Please consider submitting a pull request.

Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md

Thank you very much for your time and your contribution to Apache CloudStack, 
we hope that using this new process will encourage you to do more.

- Sebastien Goasguen


On Nov. 18, 2014, 1:07 p.m., Damodar Reddy Talakanti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28168/
 ---
 
 (Updated Nov. 18, 2014, 1:07 p.m.)
 
 
 Review request for cloudstack, bharat kumar and Kishan Kavala.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 When deleting the IP range which is associated to an account the resource 
 count for public_ip is not decremented accordingly which is causing not to 
 add any new ranges to that account further once we reach max limit.
 
 Repro Steps.
 -
 1. Add an IP range and associate it to a particular account. This will 
 increment your resource count for public_ip to that range count.
 2. Now try to delete this range and check the resource count for public_ip of 
 that account. it will not be decreased.
 
 
 Diffs
 -
 
   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2cb4203 
 
 Diff: https://reviews.apache.org/r/28168/diff/
 
 
 Testing
 ---
 
 Tested on latest master with Xen Hypervisor.
 
 Tested with acquiring atleast an IP from that account and with out acquiring 
 any IPs from that account.
 
 
 Thanks,
 
 Damodar Reddy Talakanti
 




Review Request 28168: public_ip type resource count for an account is not decremented upon IP range deletion

2014-11-18 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28168/
---

Review request for cloudstack, bharat kumar and Kishan Kavala.


Repository: cloudstack-git


Description
---

When deleting the IP range which is associated to an account the resource count 
for public_ip is not decremented accordingly which is causing not to add any 
new ranges to that account further once we reach max limit.

Repro Steps.
-
1. Add an IP range and associate it to a particular account. This will 
increment your resource count for public_ip to that range count.
2. Now try to delete this range and check the resource count for public_ip of 
that account. it will not be decreased.


Diffs
-

  server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2cb4203 

Diff: https://reviews.apache.org/r/28168/diff/


Testing
---

Tested on latest master with Xen Hypervisor.

Tested with acquiring atleast an IP from that account and with out acquiring 
any IPs from that account.


Thanks,

Damodar Reddy Talakanti