Re: Review Request 28278: CLOUDSTACK-7949: Fixing issue in test_base_image_updation.py

2014-11-25 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28278/#review62980
---

Ship it!


c25b6fab122118bd9a0e4e14d103ac015e52ab5a 4.5

6eb4a40afe743e4a200730073e084a4d11026219 master

- SrikanteswaraRao Talluri


On Nov. 20, 2014, 10:59 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28278/
 ---
 
 (Updated Nov. 20, 2014, 10:59 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-7949
 https://issues.apache.org/jira/browse/CLOUDSTACK-7949
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case test_04 failed while rebooting because the template it was 
 using was being deleted in test_03.
 Instead the template should be deleted after all the test cases have executed.
 
 Made according changes and also fixeed the assertion.
 
 
 Diffs
 -
 
   test/integration/component/test_base_image_updation.py 8288f2c 
 
 Diff: https://reviews.apache.org/r/28278/diff/
 
 
 Testing
 ---
 
 Test deploy an instance with service offerings with IsVolatile set. ... === 
 TestName: test_01_deploy_instance_with_is_volatile_offering | Status : 
 SUCCESS ===
 ok
 Test rebooting instances created with isVolatile service offerings ... === 
 TestName: test_02_reboot_instance_with_is_volatile_offering | Status : 
 SUCCESS ===
 ok
 Test restoring a vm with different template than the one it was created with 
 ... === TestName: test_03_restore_vm_with_new_template | Status : SUCCESS ===
 ok
 1) Create a VM using the Service offering IsVolatile enabled ... === 
 TestName: test_04_reoccuring_snapshot_rules | Status : SUCCESS ===
 ok
 
 --
 Ran 4 tests in 5416.231s
 
 OK
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Review Request 28278: CLOUDSTACK-7949: Fixing issue in test_base_image_updation.py

2014-11-20 Thread Ashutosh Kelkar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28278/
---

Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7949
https://issues.apache.org/jira/browse/CLOUDSTACK-7949


Repository: cloudstack-git


Description
---

The test case test_04 failed while rebooting because the template it was using 
was being deleted in test_03.
Instead the template should be deleted after all the test cases have executed.

Made according changes and also fixeed the assertion.


Diffs
-

  test/integration/component/test_base_image_updation.py 8288f2c 

Diff: https://reviews.apache.org/r/28278/diff/


Testing
---

Test deploy an instance with service offerings with IsVolatile set. ... === 
TestName: test_01_deploy_instance_with_is_volatile_offering | Status : SUCCESS 
===
ok
Test rebooting instances created with isVolatile service offerings ... === 
TestName: test_02_reboot_instance_with_is_volatile_offering | Status : SUCCESS 
===
ok
Test restoring a vm with different template than the one it was created with 
... === TestName: test_03_restore_vm_with_new_template | Status : SUCCESS ===
ok
1) Create a VM using the Service offering IsVolatile enabled ... === TestName: 
test_04_reoccuring_snapshot_rules | Status : SUCCESS ===
ok

--
Ran 4 tests in 5416.231s

OK


Thanks,

Ashutosh Kelkar