Review Request 28965: CLOUDSTACK-7881: Allow VPN IP range to be specified when creating a VPN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28965/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Added optional "Start IP" and "End IP" fields to the Create Remote Access VPN confirmation in the UI. Diffs - ui/scripts/network.js f934f21 Diff: https://reviews.apache.org/r/28965/diff/ Testing --- Tested creating VPN with several inputs, including leaving the fields blank. Results: - No input: VPN deployed with globally specified VPN IP range. - IP in only one field: VPN deployed with globally specified VPN IP range. - IP in both fields: VPN deployed with client specified VPN IP range. - Random data in one or both fields: VPN deployed with globally specified VPN IP range. Thanks, Logan B
Re: Review Request 28965: CLOUDSTACK-7881: Allow VPN IP range to be specified when creating a VPN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28965/ --- (Updated Dec. 13, 2014, 3:02 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Mihaela Stoica. Changes --- added some people that can judge thi change more then I. LTGM Repository: cloudstack-git Description --- Added optional "Start IP" and "End IP" fields to the Create Remote Access VPN confirmation in the UI. Diffs - ui/scripts/network.js f934f21 Diff: https://reviews.apache.org/r/28965/diff/ Testing --- Tested creating VPN with several inputs, including leaving the fields blank. Results: - No input: VPN deployed with globally specified VPN IP range. - IP in only one field: VPN deployed with globally specified VPN IP range. - IP in both fields: VPN deployed with client specified VPN IP range. - Random data in one or both fields: VPN deployed with globally specified VPN IP range. Thanks, Logan B
Re: Review Request 28965: CLOUDSTACK-7881: Allow VPN IP range to be specified when creating a VPN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28965/ --- (Updated Dec. 13, 2014, 3:20 p.m.) Review request for cloudstack, Brian Federle, Gabor Apati-Nagy, Jessica Wang, and Mihaela Stoica. Changes --- Had to look up Gabor Repository: cloudstack-git Description --- Added optional "Start IP" and "End IP" fields to the Create Remote Access VPN confirmation in the UI. Diffs - ui/scripts/network.js f934f21 Diff: https://reviews.apache.org/r/28965/diff/ Testing --- Tested creating VPN with several inputs, including leaving the fields blank. Results: - No input: VPN deployed with globally specified VPN IP range. - IP in only one field: VPN deployed with globally specified VPN IP range. - IP in both fields: VPN deployed with client specified VPN IP range. - Random data in one or both fields: VPN deployed with globally specified VPN IP range. Thanks, Logan B
Re: Review Request 28965: CLOUDSTACK-7881: Allow VPN IP range to be specified when creating a VPN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28965/#review78988 --- Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Dec. 13, 2014, 3:20 p.m., Logan B wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28965/ > --- > > (Updated Dec. 13, 2014, 3:20 p.m.) > > > Review request for cloudstack, Brian Federle, Gabor Apati-Nagy, Jessica Wang, > and Mihaela Stoica. > > > Repository: cloudstack-git > > > Description > --- > > Added optional "Start IP" and "End IP" fields to the Create Remote Access VPN > confirmation in the UI. > > > Diffs > - > > ui/scripts/network.js f934f21 > > Diff: https://reviews.apache.org/r/28965/diff/ > > > Testing > --- > > Tested creating VPN with several inputs, including leaving the fields blank. > > Results: > > - No input: VPN deployed with globally specified VPN IP range. > - IP in only one field: VPN deployed with globally specified VPN IP range. > - IP in both fields: VPN deployed with client specified VPN IP range. > - Random data in one or both fields: VPN deployed with globally specified VPN > IP range. > > > Thanks, > > Logan B > >
