Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-22 Thread sanjeev n


 On Jan. 22, 2015, 11:22 a.m., sanjeev n wrote:
  Ship It!

commit 2db5ee3c0a5d40cdc4d5de60b2f8f3afca32e57f
Author: Gaurav Aradhye gaurav.arad...@clogeny.com
Date:   Tue Jan 13 13:56:41 2015 +0530

CLOUDSTACK-8152: Adding delay before creating snapshot/template from root 
disk after writing data to disk - test_vm_passwordenabled.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-22 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-21 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/
---

(Updated Jan. 22, 2015, 10:59 a.m.)


Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8152
https://issues.apache.org/jira/browse/CLOUDSTACK-8152


Repository: cloudstack-git


Description
---

Due to timing issue, sometimes data gets lost if snapshot/template is created 
from root volume immediately after writing data to disk. Add delay to bypass 
this issue.


Diffs
-

  test/integration/component/test_vm_passwdenabled.py d998ed5 

Diff: https://reviews.apache.org/r/29845/diff/


Testing
---

Test get VM password for password enabled template ... === TestName: 
test_11_get_vm_password | Status : SUCCESS ===
ok

--
Ran 1 test in 751.495s

OK


Thanks,

Gaurav Aradhye



Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-13 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8152
https://issues.apache.org/jira/browse/CLOUDSTACK-8152


Repository: cloudstack-git


Description
---

Due to timing issue, sometimes data gets lost if snapshot/template is created 
from root volume immediately after writing data to disk. Add delay to bypass 
this issue.


Diffs
-

  test/integration/component/test_vm_passwdenabled.py d998ed5 

Diff: https://reviews.apache.org/r/29845/diff/


Testing
---

Test get VM password for password enabled template ... === TestName: 
test_11_get_vm_password | Status : SUCCESS ===
ok

--
Ran 1 test in 751.495s

OK


Thanks,

Gaurav Aradhye



Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-13 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review67830
---

Ship it!


d79837b67a481e618c8291152a9ecec299ff02dd master

doesn't apply on 4.5 
Applying: CLOUDSTACK-8152: Adding delay before creating snapshot/template from 
root disk after writing data to disk - test_vm_passwordenabled.py
Using index info to reconstruct a base tree...
M   test/integration/component/test_vm_passwdenabled.py
Falling back to patching base and 3-way merge...
Auto-merging test/integration/component/test_vm_passwdenabled.py
CONFLICT (content): Merge conflict in 
test/integration/component/test_vm_passwdenabled.py
Failed to merge in the changes.
Patch failed at 0001 CLOUDSTACK-8152: Adding delay before creating 
snapshot/template from root disk after writing data to disk - 
test_vm_passwordenabled.py
The copy of the patch that failed is found in:
   /Users/talluri/asf/cloudstack/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

- SrikanteswaraRao Talluri


On Jan. 13, 2015, 8:31 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 13, 2015, 8:31 a.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-13 Thread Gaurav Aradhye


 On Jan. 13, 2015, 3:37 p.m., SrikanteswaraRao Talluri wrote:
  d79837b67a481e618c8291152a9ecec299ff02dd master
  
  doesn't apply on 4.5 
  Applying: CLOUDSTACK-8152: Adding delay before creating snapshot/template 
  from root disk after writing data to disk - test_vm_passwordenabled.py
  Using index info to reconstruct a base tree...
  M   test/integration/component/test_vm_passwdenabled.py
  Falling back to patching base and 3-way merge...
  Auto-merging test/integration/component/test_vm_passwdenabled.py
  CONFLICT (content): Merge conflict in 
  test/integration/component/test_vm_passwdenabled.py
  Failed to merge in the changes.
  Patch failed at 0001 CLOUDSTACK-8152: Adding delay before creating 
  snapshot/template from root disk after writing data to disk - 
  test_vm_passwordenabled.py
  The copy of the patch that failed is found in:
 /Users/talluri/asf/cloudstack/.git/rebase-apply/patch
  When you have resolved this problem, run git am --continue.
  If you prefer to skip this patch, run git am --skip instead.
  To restore the original branch and stop patching, run git am --abort.

Please cherry-pick 41b871b6bdfd48f673e1fdc011069dd3c7ca032b from master to 4.5 
and then apply this patch to 4.5.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review67830
---


On Jan. 13, 2015, 2:01 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 13, 2015, 2:01 p.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye