[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1665
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

[ProjectMoon]

Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1624
  
We can have someone test it. Are you looking for results of a manual test, 
reproduction tests, or something automated? A manual test is probably the best 
from our side because we don't really have the time to write any 
unit/integration tests at the moment beyond what already exists in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1624#discussion_r77325991
  
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -677,6 +679,17 @@ public boolean deleteAccount(AccountVO account, long 
callerUserId, Account calle
 return cleanupAccount(account, callerUserId, caller);
 }
 
+protected List getExpungedInstanceRootVolume(long 
instanceId) {
+SearchBuilder sb = _volumeDao.createSearchBuilder();
+sb.and("instanceId", sb.entity().getInstanceId(), 
SearchCriteria.Op.EQ);
+sb.and("vType", sb.entity().getVolumeType(), SearchCriteria.Op.EQ);
+sb.done();
+SearchCriteria c = sb.create();
+c.setParameters("instanceId", instanceId);
+c.setParameters("vType", Volume.Type.ROOT);
+return _volumeDao.customSearchIncludingRemoved(c, null);
--- End diff --

This method does not return expunged volume, but root volume of a VM. Could 
there be a case where a VM can have more than one root volume? If not, let's 
rename the method to say `getInstanceRootVolume` and return just the VolumeVO 
instead a list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1624#discussion_r77326112
  
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -761,6 +774,17 @@ protected boolean cleanupAccount(AccountVO account, 
long callerUserId, Account c
 s_logger.error("Unable to expunge vm: " + vm.getId());
 accountCleanupNeeded = true;
 }
+else if 
(!vm.getState().equals(VirtualMachine.State.Destroyed)) {
+// We have to emit the event here because the state 
listener is ignoring root volume deletions,
+// assuming that the UserVMManager is responsible for 
emitting the usage event for them when
--- End diff --

Why not fix the state listener, or the manager that is responsible for 
emitting the event in the first place?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1665
  
Tests performed:

- Upgraded from 4.9.0, upgrade path ran (whose sql file names were 
changed)
- Clean db deployment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1665
  
Tests performed after fwd-merge, all pass:

- Upgraded from 4.9.1.0
- Clean db deployment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1665
  

LGTM.

Tested on CS 4.9.0 to 4.9.1.0-snapshot installation.
(perhaps just change the comment below inside the SQL file to indicate 
4.9.1.0 (missing .0?)
"-- Schema upgrade from 4.9.0 to 4.9.1;"

Logs:
2016-09-02 15:13:45,721 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.9.0 Code Version = 4.9.1.0
2016-09-02 15:13:45,722 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.9.0 to 4.9.1.0
2016-09-02 15:13:45,723 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade490to4910 to upgrade from 4.9.0-4.9.1.0 to 
4.9.1.0
[...]
2016-09-02 15:13:45,984 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Cleanup script 
/usr/share/cloudstack-management/setup/db/schema-490to4910-cleanup.sql is 
executed successfully
2016-09-02 15:13:46,019 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Upgrade completed for version 4.9.1.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
@jburwell sorry I've been silent, I've been on vacation for a bit and I 
will be juggling plans this weekend as well.  I plan to update this PR soon, 
and as far as a Marvin test I am not aware of any current tests that would 
cover this.  I haven't forgotten about this but it might be a few days yet 
before I can dig in fully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...

[nvazquez]

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1660#discussion_r77363519
  
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -196,6 +201,16 @@ public static void scpTo(String host, int port, String 
user, File pemKeyFile, St
 
 String result = sbResult.toString();
 
+if (StringUtils.isBlank(result)) {
+try {
+result = IOUtils.toString(stdout, UTF8);
--- End diff --

Done, thanks @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: upgrade divergence vs/ new install

[Pierre-Luc Dion]

Look like anything in Config.java is not applied when upgrading CloudStack,
so if that file change, we need to update the configuration name="init".
This is the case for anyone upgrading prior 4.6.

https://issues.apache.org/jira/browse/CLOUDSTACK-9489

I'm not sure how we should proceed with this but basically any upgraded
CloudStack have 15 missing Global Settings.
It's easy to replicate event with jetty.




On Thu, Sep 1, 2016 at 1:34 PM, Pierre-Luc Dion  wrote:

> Hi,
>
> I've observed on few system we've upgrade over the last months that they
> don't have the same amount of global settings has opose to a fresh install
> of cloudstack.
>
> I have 3 scenarios
>
> 4.4.x to 4.7.x (484)
> 4.4.x to 4.7.x to 4.9.0  (494)
> 4.2.1 to 4.6.0 to 4.7.0 to 4.9.0  (499)
> 4.7.x  (398)
>
> in all case they have missing settings and don't have the same number of
> settings in the configuration table, counts inside ().
>
>
> for the case of 4.7.x vs 4.4.x to 4.7.x  I found that missing settings are
> located in the file:
> server/src/com/cloud/configuration/Config.java
>
> So, does anyone have the same issue, if you search for "publish" in Global
> settings you would have nothing ?
>
> And, How those this Config.java is call, look like it called at the first
> boot lf cloudstack or something like that.
>
>
> Thanks,
>

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1560
  
@jburwell @rhtyd I post test results:

```
[root@ussarlabcsmgt41 cloudstack]# cat 
/tmp//MarvinLogs/test_volumes_SAGNPP/results.txt
test DeployVM in anti-affinity groups for project ... === TestName: 
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
ok
test DeployVM in anti-affinity groups ... === TestName: 
test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
ok
Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
ok
Test proper failure to deploy virtual machine with rootdisksize of 0 ... 
=== TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
ok
Test proper failure to deploy virtual machine with rootdisksize less than 
template size ... === TestName: test_02_deploy_vm_root_resize | Status : 
SUCCESS ===
ok
Test to deploy vm with a first fit offering ... === TestName: 
test_deployvm_firstfit | Status : SUCCESS ===
ok
Test deploy VMs using user concentrated planner ... === TestName: 
test_deployvm_userconcentrated | Status : SUCCESS ===
ok
Test deploy VMs using user dispersion planner ... === TestName: 
test_deployvm_userdispersing | Status : SUCCESS ===
ok
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | 
Status : SUCCESS ===
ok
Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
ok
Test to create disk offering ... === TestName: test_01_create_disk_offering 
| Status : SUCCESS ===
ok
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
ok
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
ok
Test to update existing disk offering ... === TestName: 
test_02_edit_disk_offering | Status : SUCCESS ===
ok
Test to delete disk offering ... === TestName: test_03_delete_disk_offering 
| Status : SUCCESS ===
ok
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: 
test_UpdateConfigParamWithScope | Status : SUCCESS ===
ok
Test guest vlan range dedication ... === TestName: 
test_dedicateGuestVlanRange | Status : SUCCESS ===
ok
Test create public & private ISO ... === TestName: test_01_create_iso | 
Status : SUCCESS ===
ok
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
ok
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
ok
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : 
SUCCESS ===
ok
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions 
| Status : SUCCESS ===
ok
Test for copy ISO from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status : 
SUCCESS ===
ok
Test listing Volumes using 'id

[GitHub] cloudstack issue #1665: Changes database upgrade script names to be consiste...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1665
  
Thanks @milamberspace 
Based on the tests and LGTMs, I'll proceed with merging this on 4.9. On 
fwd-merging, I've fixed conflicts and renamed a subsequent class to match the 
change. Fwd-merged master branch has also passed my tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
LGTM thanks @nvazquez for the change. Can you help with testing, 
unfortunately I don't have the resources (some infra issues) to run tests 
across vmware and xenserver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: 4.8.2.0/4.9.1.0 RC Status

[Pierre-Luc Dion]

Hi John,

I would like to rise the following issue recently found  that I think
affect any update past 4.6.
https://issues.apache.org/jira/browse/CLOUDSTACK-9489
I think it should be relatively easy to fix but I'm scared about the impact
of overriding costumized value. I'm testing this these days...

Worst case we can update the release-notes.

Thanks



On Thu, Sep 1, 2016 at 9:35 PM, John Burwell 
wrote:

> All,
>
> We are still working to merge the PR necessary to create the 4.8.2.0 and
> 4.9.1.0 RCs.  The following is the status of the PRs targeted for 4.8.2.0:
>
> * 1635 [1]: CLOUDSTACK-9451 — one open code review item and needs a
> test LGTM
> * 1636 [2]: Fix a quote issue with Spanish L10N (from transifex
> translation) — MERGED
> * 1654 [3]: Updating pom.xml version numbers for release
> 4.8.2.0-SNAPSHOT — MERGED
> * 1624 [4]: Fixes regarding VOLUME_DELETE events resulting from
> account deletion — needs a test LGTM
>
> The following is the status of the PRs targeted for 4.9.1.0:
>
> * 1621 [5]: [CLOUDSTACK-9444] Fix a little issue from PR1610 if the
> db.properties file hasn't EOL character at the end of file — MERGED
> * 1648 [6]: test/integration: fix tearDown order in list_acl_ tests —
> MERGED
> * 1663 [7]/1653 [8]: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS
> reflection attacks — MERGED/CLOSED
> * 1660 [9]: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affecting
> interaction with vRouter in VmwareResource and HypervDirectConnectResource
> — open code review issue
> * 1665 [10]: Changes database upgrade script names to be consistent
> for the 4.9.1.0 release — Needs a test LGTM
>
> Any help pulling completing the remaining PRs would be greatly appreciated.
>
> Thanks,
> -John
>
> [1]: https://github.com/apache/cloudstack/pull/1635
> [2]: https://github.com/apache/cloudstack/pull/1636
> [3]: https://github.com/apache/cloudstack/pull/1654
> [4]: https://github.com/apache/cloudstack/pull/1624
> [5]: https://github.com/apache/cloudstack/pull/1621
> [6]: https://github.com/apache/cloudstack/pull/1648
> [7]: https://github.com/apache/cloudstack/pull/1663
> [8]: https://github.com/apache/cloudstack/pull/1653
> [9]: https://github.com/apache/cloudstack/pull/1660
> [10]: https://github.com/apache/cloudstack/pull/1665
>
> >
> john.burw...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
>
>
>
> On Aug 28, 2016, at 11:14 PM, John Burwell 
> wrote:
> >
> > All,
> >
> > I apologize for being behind getting the 4.8.2.0 and 4.9.1.0 RCs out.  A
> small part of it was due to the RC release dates falling the weekend after
> being on vacation, and a large part of it is due to rookie mistakes as a
> first time RM.  Hopefully, the lessons learned will keep things on-time for
> the 4.9.2.0 and 4.10.0.0 releases.
> >
> > The big lesson learned is that we need to watching the candidate PRs for
> a release about 7-10 days in advance of a release.  To that end, we have
> the following are the PRs targeted for 4.8.2.0 and 4.9.1.0 which need to be
> closed before we can cut an RC:
> >
> >* 1635 [1]: CLOUDSTACK-9451
> >* 1636 [2]: Fix a quote issue with Spanish L10N (from transifex
> translation)
> >* 1654 [3]: Updating pom.xml version numbers for release
> 4.8.2.0-SNAPSHOT
> >* 1624 [4]: Fixes regarding VOLUME_DELETE events resulting from
> account deletion
> >
> > The following are the PRs targeted for 4.9.1.0 which need to be closed
> be we can cut an RC:
> >
> >* 1621 [5]: [CLOUDSTACK-9444] Fix a little issue from PR1610 if the
> db.properties file hasn't EOL character at the end of file
> >* 1648 [6]: test/integration: fix tearDown order in list_acl_ tests
> >* 1663 [7]/1653 [8]: [LTS/blocker] CLOUDSTACK-6432: Prevent DNS
> reflection attacks (
> >* 1660 [9]: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affecting
> interaction with vRouter in VmwareResource and HypervDirectConnectResource
> >* 1665 [10]: Changes database upgrade script names to be consistent
> for the 4.9.1.0 release
> >
> > Please let me know if there is a PR or defect you feel must be addressed
> in order to ship either 4.8.2.0 or 4.9.1.0.  Otherwise, we will be working
> to get these PRs merged ASAP and cut RCs for voting.
> >
> > Thank you for patience as I stumble through this process for the first
> time,
> > -John
> >
> > [1]: https://github.com/apache/cloudstack/pull/1635
> > [2]: https://github.com/apache/cloudstack/pull/1636
> > [3]: https://github.com/apache/cloudstack/pull/1654
> > [4]: https://github.com/apache/cloudstack/pull/1624
> > [5]: https://github.com/apache/cloudstack/pull/1621
> > [6]: https://github.com/apache/cloudstack/pull/1648
> > [7]: https://github.com/apache/cloudstack/pull/1663
> > [8]: https://github.com/apache/cloudstack/pull/1653
> > [9]: https://github.com/apache/cloudstack/pull/1660
> > [10]: https://github.com/apache/cloudstack/pull/1665
> >
> >
> > john.burw...@shapeblue.com
> > www.shapebl

[GitHub] cloudstack pull request #1665: Changes database upgrade script names to be c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1665


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: upgrade divergence vs/ new install

[Rohit Yadav]

Hi PL,


That's correct, all new global settings should use the ConfigKey class to setup 
new global settings. Any changes that may be done recently (4.6+) that added 
new global settings directly in Config.java won't get added to the 
configuration table unless it's a fresh installation. Can you gather the list 
of such global settings, we can migrate them to use ConfigKey so they get 
created during upgrade/db-migration.


Regards.


From: Pierre-Luc Dion 
Sent: 02 September 2016 21:28:02
To: dev@cloudstack.apache.org
Subject: Re: upgrade divergence vs/ new install

Look like anything in Config.java is not applied when upgrading CloudStack,
so if that file change, we need to update the configuration name="init".
This is the case for anyone upgrading prior 4.6.

https://issues.apache.org/jira/browse/CLOUDSTACK-9489

I'm not sure how we should proceed with this but basically any upgraded
CloudStack have 15 missing Global Settings.
It's easy to replicate event with jetty.





rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

On Thu, Sep 1, 2016 at 1:34 PM, Pierre-Luc Dion  wrote:

> Hi,
>
> I've observed on few system we've upgrade over the last months that they
> don't have the same amount of global settings has opose to a fresh install
> of cloudstack.
>
> I have 3 scenarios
>
> 4.4.x to 4.7.x (484)
> 4.4.x to 4.7.x to 4.9.0  (494)
> 4.2.1 to 4.6.0 to 4.7.0 to 4.9.0  (499)
> 4.7.x  (398)
>
> in all case they have missing settings and don't have the same number of
> settings in the configuration table, counts inside ().
>
>
> for the case of 4.7.x vs 4.4.x to 4.7.x  I found that missing settings are
> located in the file:
> server/src/com/cloud/configuration/Config.java
>
> So, does anyone have the same issue, if you search for "publish" in Global
> settings you would have nothing ?
>
> And, How those this Config.java is call, look like it called at the first
> boot lf cloudstack or something like that.
>
>
> Thanks,
>

Re: upgrade divergence vs/ new install

[Pierre-Luc Dion]

I'll investigate further but setting init to false dynamite my db at the
first try :-S.

I'll continue next week but might be a dangerous path so far :-S




On Fri, Sep 2, 2016 at 2:03 PM, Rohit Yadav 
wrote:

> Hi PL,
>
>
> That's correct, all new global settings should use the ConfigKey class to
> setup new global settings. Any changes that may be done recently (4.6+)
> that added new global settings directly in Config.java won't get added to
> the configuration table unless it's a fresh installation. Can you gather
> the list of such global settings, we can migrate them to use ConfigKey so
> they get created during upgrade/db-migration.
>
>
> Regards.
>
> 
> From: Pierre-Luc Dion 
> Sent: 02 September 2016 21:28:02
> To: dev@cloudstack.apache.org
> Subject: Re: upgrade divergence vs/ new install
>
> Look like anything in Config.java is not applied when upgrading CloudStack,
> so if that file change, we need to update the configuration name="init".
> This is the case for anyone upgrading prior 4.6.
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-9489
>
> I'm not sure how we should proceed with this but basically any upgraded
> CloudStack have 15 missing Global Settings.
> It's easy to replicate event with jetty.
>
>
>
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> On Thu, Sep 1, 2016 at 1:34 PM, Pierre-Luc Dion 
> wrote:
>
> > Hi,
> >
> > I've observed on few system we've upgrade over the last months that they
> > don't have the same amount of global settings has opose to a fresh
> install
> > of cloudstack.
> >
> > I have 3 scenarios
> >
> > 4.4.x to 4.7.x (484)
> > 4.4.x to 4.7.x to 4.9.0  (494)
> > 4.2.1 to 4.6.0 to 4.7.0 to 4.9.0  (499)
> > 4.7.x  (398)
> >
> > in all case they have missing settings and don't have the same number of
> > settings in the configuration table, counts inside ().
> >
> >
> > for the case of 4.7.x vs 4.4.x to 4.7.x  I found that missing settings
> are
> > located in the file:
> > server/src/com/cloud/configuration/Config.java
> >
> > So, does anyone have the same issue, if you search for "publish" in
> Global
> > settings you would have nothing ?
> >
> > And, How those this Config.java is call, look like it called at the first
> > boot lf cloudstack or something like that.
> >
> >
> > Thanks,
> >
>

[GitHub] cloudstack pull request #1671: Adding support for cross-cluster storage migr...

[mike-tutkowski]

GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/1671

Adding support for cross-cluster storage migration for managed storage when 
using XenServer

This PR adds support for cross-cluster storage migration of VMs that make 
use of managed storage with XenServer.

Managed storage is when you have a 1:1 mapping between a virtual disk and a 
volume on a SAN (in the case of XenServer, an SR is placed on this SAN volume 
and a single virtual disk placed in the SR).

Managed storage allows features such as storage QoS and SAN-side snapshots 
to work (sort of analogous to VMware VVols).

This PR focuses on enabling VMs that are using managed storage to be 
migrated across XenServer clusters.

I have successfully run the following tests on this branch:

TestVolumes.py
TestSnapshots.py
TestVMSnapshots.py
TestAddRemoveHosts.py
TestVMMigrationWithStorage.py (which is a new test that is being added with 
this PR)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack copy-vol-migration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1671






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---