[GitHub] [cloudstack-primate] rhtyd commented on pull request #298: [WIP] Quota UI
rhtyd commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644573762 @utchoang the PR title says WIP, is it ready for review and testing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed pull request #401: [FIX] New Instance dialog
rhtyd closed pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #298: [WIP] Quota UI
utchoang commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644574933 @rhtyd Yes. Please review it. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #401: [FIX] New Instance dialog
rhtyd commented on pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401#issuecomment-644575059 @utchoang I tested latest master, and couldn't reproduce the issue; please re-open if I missed any case or the issue still exists. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled
rhtyd commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644575737 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #170: Modified forms when SAML is enabled
blueorangutan commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644575975 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #298: [WIP] Quota UI
rhtyd commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644575984 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #298: Quota UI
rhtyd commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644576089 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #217: Identify and access - Add user - duplicated password field
blueorangutan commented on pull request #217: URL: https://github.com/apache/cloudstack-primate/pull/217#issuecomment-644577017 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option
blueorangutan commented on pull request #423: URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644576876 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #298: Quota UI
blueorangutan commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644576537 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option
rhtyd commented on pull request #423: URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644576358 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain
blueorangutan commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644576664 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #252: Add support to manage network service providers
blueorangutan commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-644576399 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #252: Add support to manage network service providers
rhtyd commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-644576183 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #217: Identify and access - Add user - duplicated password field
rhtyd commented on pull request #217: URL: https://github.com/apache/cloudstack-primate/pull/217#issuecomment-644576236 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #401: [FIX] New Instance dialog
utchoang commented on pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401#issuecomment-644579034 @rhtyd With the exception of scrolling information, I've corrected some missing points in the auto-selection section when turning pages in each section (When turning pages, the auto-select is not correct). I will remove the roll, can you check and merge it for me, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain
rhtyd commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644575911 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #401: [FIX] New Instance dialog
rhtyd commented on pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401#issuecomment-644580103 @utchoang alright please merge latest master and let me know when it's ready for review/testing. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain
blueorangutan commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644580672 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/324 (JID-2010) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #170: Modified forms when SAML is enabled
blueorangutan commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644581707 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/170 (JID-2007) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #298: Quota UI
blueorangutan commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-644582815 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/298 (JID-2009) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #252: Add support to manage network service providers
blueorangutan commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-644582736 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/252 (JID-2008) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #217: Identify and access - Add user - duplicated password field
blueorangutan commented on pull request #217: URL: https://github.com/apache/cloudstack-primate/pull/217#issuecomment-644583506 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/217 (JID-2012) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option
blueorangutan commented on pull request #423: URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644583324 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/423 (JID-2011) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain
rhtyd commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644584170 @utchoang can you address following: - Navigation from a different view does not show the domain tab with info card and comments (to reproduce goto account and click on domain "ROOT" for example)  - When navigating from a different view, it does not show/select the domain (use primate-qa server, go to accounts tab and say select "ROOT/saml" domain, on the left side of the tree-view still the "ROOT"domain is selected) - Perhaps for the resource view we can still use autogen-view but use the new component only for listView; for example when selecting a domain, we can show the view like:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #217: Identify and access - Add user - duplicated password field
rhtyd merged pull request #217: URL: https://github.com/apache/cloudstack-primate/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #175: [BUG] Identify and access > Users > Add user - duplicated password field
rhtyd commented on issue #175: URL: https://github.com/apache/cloudstack-primate/issues/175#issuecomment-644586397 Tested, merged the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #175: [BUG] Identify and access > Users > Add user - duplicated password field
rhtyd closed issue #175: URL: https://github.com/apache/cloudstack-primate/issues/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #170: Modified forms when SAML is enabled
rhtyd commented on a change in pull request #170:
URL: https://github.com/apache/cloudstack-primate/pull/170#discussion_r440642212
##
File path: src/config/section/user.js
##
@@ -69,6 +70,15 @@ export default {
dataView: true,
show: (record) => { return record.state === 'enabled' }
},
+{
+ api: 'authorizeSamlSso',
+ icon: 'check-circle',
+ label: 'Configure SAML SSO Authorization',
+ dataView: true,
+ show: () => { return 'authorizeSamlSso' in store.getters.apis },
Review comment:
The `api` already adds this check
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled
rhtyd commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644587407 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #170: Modified forms when SAML is enabled
blueorangutan commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644587633 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #170: Modified forms when SAML is enabled
blueorangutan commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644591052 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/170 (JID-2013) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled
rhtyd commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-644619115 @shwstppr please see https://github.com/apache/cloudstack-primate/issues/184 And check against the old UI, I think if account is specified then the form should create the user in that account; in my test I created an account with username 'domadmin' and account 'domadmincontainer' but it ended up creating a user/account with the name 'domadmin'. Additional changes requested - add a popover (i) information button like other forms for which you can use the apiParams description; (see old UI create account form). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #423: [FIX] Acquire public IP address does not give IP selection option
rhtyd commented on a change in pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#discussion_r440684934
##
File path: src/views/network/IpAddressesTab.vue
##
@@ -181,6 +214,21 @@ export default {
this.fetchLoading = false
})
},
+fetchListPublicIpAddress () {
+ return new Promise((resolve, reject) => {
+const params = {
+ zoneid: this.resource.zoneid,
+ domainid: this.resource.domainid,
+ account: this.resource.account,
+ forvirtualnetwork: true,
+ allocatedonly: false
+}
+api('listPublicIpAddresses', params).then(json => {
+ const listPublicIps =
json.listpublicipaddressesresponse.publicipaddress || []
+ resolve(listPublicIps)
Review comment:
Can you sort the IPs @utchoang (and make the list searching, like other
a-selects)?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #423: [FIX] Acquire public IP address does not give IP selection option
utchoang commented on a change in pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#discussion_r440694628
##
File path: src/views/network/IpAddressesTab.vue
##
@@ -181,6 +214,21 @@ export default {
this.fetchLoading = false
})
},
+fetchListPublicIpAddress () {
+ return new Promise((resolve, reject) => {
+const params = {
+ zoneid: this.resource.zoneid,
+ domainid: this.resource.domainid,
+ account: this.resource.account,
+ forvirtualnetwork: true,
+ allocatedonly: false
+}
+api('listPublicIpAddresses', params).then(json => {
+ const listPublicIps =
json.listpublicipaddressesresponse.publicipaddress || []
+ resolve(listPublicIps)
Review comment:
@rhtyd I've fixed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #421: Fixing enable/disable HA, OOBM across zone, cluster, host
davidjumani commented on pull request #421: URL: https://github.com/apache/cloudstack-primate/pull/421#issuecomment-644634326 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #424: Adding rolling maintenance
davidjumani commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-644634522 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #424: Adding rolling maintenance
blueorangutan commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-644634822 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
davidjumani commented on pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644634634 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #421: Fixing enable/disable HA, OOBM across zone, cluster, host
blueorangutan commented on pull request #421: URL: https://github.com/apache/cloudstack-primate/pull/421#issuecomment-644634952 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
blueorangutan commented on pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644635261 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #421: Fixing enable/disable HA, OOBM across zone, cluster, host
blueorangutan commented on pull request #421: URL: https://github.com/apache/cloudstack-primate/pull/421#issuecomment-644639175 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/421 (JID-2015) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #424: Adding rolling maintenance
blueorangutan commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-644639046 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/424 (JID-2014) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #425: Fix unmanage / manager cluster
blueorangutan commented on pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-644639604 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/425 (JID-2016) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr opened a new pull request #426: compute: import vm
shwstppr opened a new pull request #426: URL: https://github.com/apache/cloudstack-primate/pull/426 Adds UI for importing VM Importing VM is currently supported only on VMware. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #313: Bootintobios
rhtyd commented on a change in pull request #313:
URL: https://github.com/apache/cloudstack-primate/pull/313#discussion_r440728203
##
File path: src/config/section/compute.js
##
@@ -89,7 +89,18 @@ export default {
dataView: true,
groupAction: true,
show: (record) => { return ['Stopped'].includes(record.state) },
- args: (record, store) => { return
['Admin'].includes(store.userInfo.roletype) ? ['podid', 'clusterid', 'hostid']
: [] },
+ args: (record, store) => {
+var fields = []
+if (store.userInfo.roletype === 'Admin') {
+ fields = ['podid', 'clusterid', 'hostid']
+}
+if (record.hypervisor === 'VMware') {
+ if (store.apis.startVirtualMachine.params.filter(x => x.name ===
'bootintosetup').length > 0) {
Review comment:
@DaanHoogland I've tested and fixed a case here - we want to make
Primate work with all recent/pass/future version of CloudStack; so if there's a
feature adding new params for autogenerated forms, we can check if the param is
available by checking the API discovery /cc @shwstppr @davidjumani
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #313: Bootintobios
rhtyd merged pull request #313: URL: https://github.com/apache/cloudstack-primate/pull/313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #419: Adding custom change affinity view
davidjumani commented on pull request #419: URL: https://github.com/apache/cloudstack-primate/pull/419#issuecomment-644670254 @rhtyd Is there a need to add this vpc tier selection? It does not affect listing / updating the affinity group in any way. It only shows up while listing the vm through the configure network vpc   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez opened a new pull request #139: Unmanage VMs documentation
nvazquez opened a new pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139 Functionality PR: https://github.com/apache/cloudstack/pull/4103 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644787219 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez commented on pull request #139: Unmanage VMs documentation
nvazquez commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644787185 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644788423 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440958947 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: Review comment: ```suggestion To unmanage a guest virtual machine, an administrator must invoke the unmanageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440961143 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM + +- Clean up the virtual machine from the following: + + - Remove the virtual machine from security groups (if any) + + - Remove the virtual machine from instance groups (if any) + + - Remove firewall rules for the virtual machine (if any) + + - Remove forwarding rules for the virtual machine (if any) + + - Remove load balancing rules for the virtual machine (if any) + + - Disable static NAT (if the virtual machine is assigned to it) + + - Remove the virtual machine from affinity groups (if any) + +- Set VM details as removed in the CloudStack database + +- Decrement the account resources count for volumes and virtual machines + +- Generate usage events: + + - For volumes destroyed, with type: ‘VOLUME.DELETE’ + + - For virtual machine snapshots destroyed (if any), with type: ‘VMSNAPSHOT.DELETE’ Review comment: ```suggestion - For virtual machine snapshots destroyed (if any), with type: ‘VMSNAPSHOT.DELETE’ and 'VMSNAPSHOT.OFF_PRIMARY' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440962106 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM + +- Clean up the virtual machine from the following: + + - Remove the virtual machine from security groups (if any) + + - Remove the virtual machine from instance groups (if any) + + - Remove firewall rules for the virtual machine (if any) + + - Remove forwarding rules for the virtual machine (if any) + + - Remove load balancing rules for the virtual machine (if any) + + - Disable static NAT (if the virtual machine is assigned to it) + + - Remove the virtual machine from affinity groups (if any) + +- Set VM details as removed in the CloudStack database + +- Decrement the account resources count for volumes and virtual machines + +- Generate usage events: + + - For volumes destroyed, with type: ‘VOLUME.DELETE’ + + - For virtual machine snapshots destroyed (if any), with type: ‘VMSNAPSHOT.DELETE’ + + - For virtual machine NICs destroyed: with type: ‘NETWORK.OFFERING.REMOVE’ + + - For the virtual machine being unmanaged: stopped and destroyed usage events (similar as the generated usage events when expunging a virtual machine), with types: ‘VM.STOP’ and ‘VM.DESTROY Review comment: ```suggestion - For the virtual machine being unmanaged: stopped and destroyed usage events (similar to the generated usage events when expunging a virtual machine), with types: ‘VM.STOP’ and ‘VM.DESTROY', unless the VM has been already stopped before being unmanaged and in this case only ‘VM.DESTROY' is generated. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@in
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440962374 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM + +- Clean up the virtual machine from the following: + + - Remove the virtual machine from security groups (if any) + + - Remove the virtual machine from instance groups (if any) + + - Remove firewall rules for the virtual machine (if any) + + - Remove forwarding rules for the virtual machine (if any) Review comment: ```suggestion - Remove port forwarding rules for the virtual machine (if any) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440963062 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM + +- Clean up the virtual machine from the following: + + - Remove the virtual machine from security groups (if any) + + - Remove the virtual machine from instance groups (if any) + + - Remove firewall rules for the virtual machine (if any) + + - Remove forwarding rules for the virtual machine (if any) + + - Remove load balancing rules for the virtual machine (if any) + + - Disable static NAT (if the virtual machine is assigned to it) + + - Remove the virtual machine from affinity groups (if any) + +- Set VM details as removed in the CloudStack database Review comment: ```suggestion - Remove VM details from the CloudStack database ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440962718 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM + +- Clean up the virtual machine from the following: + + - Remove the virtual machine from security groups (if any) + + - Remove the virtual machine from instance groups (if any) + + - Remove firewall rules for the virtual machine (if any) Review comment: This is actually not applicable, as firewall rules are linked to the network, but it can stay... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440966161 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS Review comment: ```suggestion Preserving unmanaged virtual machine NICs ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on a change in pull request #139: Unmanage VMs documentation
andrijapanicsb commented on a change in pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#discussion_r440967760 ## File path: source/adminguide/virtual_machines/unmanage_vms.rst ## @@ -0,0 +1,81 @@ +About Unmanaged Virtual Machines + + +As of ACS 4.14, CloudStack has the concept of **unmanaged** virtual machines. These are virtual machines that are on CloudStack +managed hosts, but that are not in CloudStack's database and therefore CloudStack cannot control (manage) then in any way. Previously, +such VMs could exist, but CloudStack did not 'see' them (their existence *would* be reported in logs as unrecognised VMs). + +From ACS 4.14 onwards, CloudStack is able to list these VMs via the listUnmanagedInstances API command and then import (also known as ingest) +those unmanaged VMs via the importUnmanagedInstance API so that they become CloudStack managed guest instances + +From ACS 4.15 onwards, administrators are able to unmanage guest virtual machines. + +.. note:: This is currently only available for **vSphere** clusters. + +Unmanaging Virtual Machines via API +--- + +Administrators are able to unmanage guest virtual machines from CloudStack. Once unmanaged, CloudStack can no longer monitor, control or administer the provisioning and orchestration related operations on a virtual machine. + +To unmanage a guest virtual machine, an administrator must invoke the unmnageVirtualMachine API passing the ID of the virtual machine to unmanage. The API has the following preconditions: + +- The virtual machine must not be destroyed +- The virtual machine state must be 'Running’ or ‘Stopped’ +- The virtual machine must be a VMware virtual machine + +The API execution will perform the following pre-checks, failing if they are not met: + +- There are no volume snapshots associated with any of the virtual machine volumes +- There is no ISO attached to the virtual machine + +.. note:: This is currently only available for **vSphere** clusters. + + +Preserving unmanaged virtual machine NICS +- + +The zone setting: unmanage.vm.preserve.nics can be used to preserve virtual machine NICs and its MAC addresses after unmanaging them. If set to true, the virtual machine NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise, NICs are removed and MAC addresses can be reassigned. + + +Unmanaging virtual machine actions +-- + +- Clean up virtual machine NICs and deallocate network resources used such as IP addresses and DHCP entries on virtual routers. + + - If ‘unmanage.vm.preserve.nics’ = ‘false’ then the NICs are deallocated and removed from CloudStack + + - If ‘unmanage.vm.preserve.nics’ = ‘true’ then the NICs remain allocated and are not removed from the database. The NIC’s MAC addresses remain preserved and therefore cannot be assigned to any new NIC. + +- Clean up virtual machine volumes in the CloudStack database + +- Clean up virtual machine snapshots in the CloudStack database (if any) · Revoke host access to any managed volumes attached to the VM Review comment: ```suggestion - Clean up virtual machine snapshots in the CloudStack database (if any) - Revoke host access to any managed volumes attached to the VM (applicable to managed storage only) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #139: Unmanage VMs documentation
andrijapanicsb commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644859620 @nvazquez Please consider also documenting the "forced" parameter in the importUnmanagedInstance API call - that is new (afaik) in this release/4.15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb edited a comment on pull request #139: Unmanage VMs documentation
andrijapanicsb edited a comment on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644859620 @nvazquez Please consider also documenting: - the "forced" parameter in the importUnmanagedInstance API call - that is new (afaik) in this release/4.15 - "diskofferingid" import parameter was removed afaik This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #94: Add update ISO permissions
ACSGitBot commented on pull request #94: URL: https://github.com/apache/cloudstack-documentation/pull/94#issuecomment-644897530 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez commented on pull request #94: Add update ISO permissions
nvazquez commented on pull request #94: URL: https://github.com/apache/cloudstack-documentation/pull/94#issuecomment-644897491 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #94: Add update ISO permissions
ACSGitBot commented on pull request #94: URL: https://github.com/apache/cloudstack-documentation/pull/94#issuecomment-644898592 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr94 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez commented on pull request #139: Unmanage VMs documentation
nvazquez commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644916929 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez commented on pull request #139: Unmanage VMs documentation
nvazquez commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644916863 Thanks @andrijapanicsb - added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644916976 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez commented on pull request #139: Unmanage VMs documentation
nvazquez commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644918476 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644918044 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #139: Unmanage VMs documentation
ACSGitBot removed a comment on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644918044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644918506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] nvazquez removed a comment on pull request #139: Unmanage VMs documentation
nvazquez removed a comment on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644916929 requesting docbuild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644919544 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #139: Unmanage VMs documentation
ACSGitBot commented on pull request #139: URL: https://github.com/apache/cloudstack-documentation/pull/139#issuecomment-644920449 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139 Build Log Output: No log errors found to report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] gaaray2k opened a new issue #427: [FEATURE]
gaaray2k opened a new issue #427: URL: https://github.com/apache/cloudstack-primate/issues/427 1) Allow to create a site to site vpn to a regular isolated network instead of just a vpc. right now site-to-site vpn is only allowed to a vpc. 2) action buttons on virtual machines from the instance tab. right now users are only allow to take actions(shutdown, delete, etc) on virtual machines after clicking on the virtual machine. 3) create multiple virtual machines from the VM creation form. ask me how many virtual machines I want to create from a single virtual machine creation form. apologies if this isnt clear enough. not very good at putting my thoughts in writing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on pull request #324: Create new view component for Tree Domain
utchoang commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645114585 @rhtyd Thank you for the feedback. I have edited the following: When navigating from a different view, I will use a view like AutogenView (bellow image).  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[DISCUSS] 4.14.1.0 release
All, We've managed to review, test, and merge two critical issues that were found wrt the 4.14.0.0 release whose scope is limited to only KVM/CentOS7 security group users and the new B&R feature (disabled by default, won't affect users by default): https://github.com/apache/cloudstack/commit/db55910f6bc032b708afa84d56c463c648ceb9b3 https://github.com/apache/cloudstack/commit/b54d19b3b9a66adbb8f5681005160ca549f35e33 Please discuss: * Are there any other outstanding blocker, critical issues that we've missed or have been discovered in 4.14.0.0 release? * Does anybody want to lead the 4.14.1.0 release work effort? Thanks and regards. rohit.ya...@shapeblue.com www.shapeblue.com 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK @shapeblue
[GitHub] [cloudstack-primate] rhtyd commented on issue #427: [FEATURE]
rhtyd commented on issue #427: URL: https://github.com/apache/cloudstack-primate/issues/427#issuecomment-645116452 @gaaray2k thanks for reporting; 1. you're asking for a new backend feature, Primate is UI only. You can raise a ticket here https://github.com/apache/cloudstack/issues and discuss your proposal on the dev mailing list. 2. The group action feature is already created towards the 1.0/GA milestone - https://github.com/apache/cloudstack-primate/issues/162 Or, are you suggesting a quick/action overview feature like the legacy UI? 3. I think I get the last one, you're asking something to ask number of VMs in the form to deploy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd merged pull request #59: Statically building the binary to not depend on gcc compiler
rhtyd merged pull request #59: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [DISCUSS] Next CloudMonkey release v6.1.0
All, Ping - any feedback towards the next release[1]? Thanks. [1] https://github.com/apache/cloudstack-cloudmonkey/milestone/2 Regards. rohit.ya...@shapeblue.com www.shapeblue.com 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK @shapeblue From: Rohit Yadav Sent: Saturday, May 9, 2020 11:17 To: dev@cloudstack.apache.org ; us...@cloudstack.apache.org Subject: [DISCUSS] Next CloudMonkey release v6.1.0 All, It's been over a year since the last CloudMonkey (cmk) release. While cmk appears to stable (given no major complains) we've had a few fixes since the last release and we must work on a release in near future (likely after 4.14 and Primate tech preview). I've triaged a few issues for the next v6.1.0 milestone, kindly provide any feedback, comments on this thread and report issues/feature requests here https://github.com/apache/cloudstack-cloudmonkey/issues Thanks. Regards, Rohit Yadav Software Architect, ShapeBlue https://www.shapeblue.com
[GitHub] [cloudstack-primate] davidjumani commented on pull request #425: Fix unmanage / manager cluster
davidjumani commented on pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645147556 @rhtyd ready to go! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #424: Adding rolling maintenance
davidjumani commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-645148907 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #424: Adding rolling maintenance
blueorangutan commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-645149305 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #425: Fix unmanage / manager cluster
rhtyd commented on pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645152399 The check can be based on record.managedstate and record.allocationstate to show/hide the buttons This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #425: Fix unmanage / manager cluster
rhtyd commented on pull request #425:
URL:
https://github.com/apache/cloudstack-primate/pull/425#issuecomment-645152148
@davidjumani it gets a bit complicated as the state itself is determined as
follows, legacy code reference:
```
if (jsonObj.managedstate == "Managed") {
jsonObj.state = jsonObj.allocationstate; //jsonObj.state ==
Enabled, Disabled
} else {
jsonObj.state = jsonObj.managedstate; //jsonObj.state ==
Unmanaged, PrepareUnmanaged, PrepareUnmanagedError
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #162: [BUG] Group action buttons don't work properly (Events, Alerts, VM)
rhtyd commented on issue #162: URL: https://github.com/apache/cloudstack-primate/issues/162#issuecomment-645156992 Another note: https://github.com/apache/cloudstack-primate/pull/424/files to be checked against old UI and added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #424: Adding rolling maintenance
rhtyd commented on pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424#issuecomment-645157034 Ref added https://github.com/apache/cloudstack-primate/issues/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #363: [FEATURE] Rolling maintenance feature for zone, pod, cluster...
rhtyd closed issue #363: URL: https://github.com/apache/cloudstack-primate/issues/363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #424: Adding rolling maintenance
rhtyd merged pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain
rhtyd commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645161973 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-645162094 @utchoang please resolve conflict and ping me if/when ready for review; thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #401: [FIX] New Instance dialog
rhtyd commented on pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401#issuecomment-645162205 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain
blueorangutan commented on pull request #324: URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645162141 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #379: Add support for tiers in PF, LB rules for a VPC
rhtyd commented on pull request #379: URL: https://github.com/apache/cloudstack-primate/pull/379#issuecomment-645162134 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #379: Add support for tiers in PF, LB rules for a VPC
blueorangutan commented on pull request #379: URL: https://github.com/apache/cloudstack-primate/pull/379#issuecomment-645162513 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #401: [FIX] New Instance dialog
blueorangutan commented on pull request #401: URL: https://github.com/apache/cloudstack-primate/pull/401#issuecomment-645162444 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #298: Quota UI
rhtyd commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-645163415 @utchoang LGTM but can you address the following: - Fix translation/key label usage across views (see locales/en.json to pick the keys, all lowercase) - Add ability to edit the email template (some action/button to edit the email template), refer legacy UI for implementation (but avoid changing code ListView and AutogenView) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #418: Invalid ticket
rhtyd closed issue #418: URL: https://github.com/apache/cloudstack-primate/issues/418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
