[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1957
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1942
  
LGTM on the code changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1869: CLOUDSTACK-9701: When host is disabled/removed, capa...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1869
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1725: CLOUDSTACK-9559 Why allow deleting zone without dele...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1725
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1810: CLOUDSTACK-9647: NIC adapter type becomes e1000 , ev...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1810
  
LGTM for code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1972#discussion_r103159426
  
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java ---
@@ -29,4 +30,6 @@
 
 List listInTransitionStateByNetworkIdAndScheme(long 
networkId, Scheme scheme);
 
+boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, String 
instanceIp, long networkId, FirewallRule.Purpose purpose);
--- End diff --

@niteshsarda You don't need the purpose parameter here, as the 
implementation is specific for firewall rules. While setting the parameter with 
SearchBuilder the value can be set as  Purpose.LoadBalancing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
@niteshsarda I don't see any change in file createNetworkOffering.xml, but 
still there are many lines being removed and added. As there is not change in 
this file, please revert.

Also the marvin test case seems as the complete file was edited, even the 
license header. Please add only the changes that are relevant.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1734
  
@jburwell As suggested, I have added a marvin test case to verify the fix. 
Should I add it to smoke test suite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1978: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1978
  
LGTM for the code changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/892
  
Rebased against master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1734
  
Rebased against master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/883
  
Previous CI failures were not relevant to my changes. 
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1246
  
@nlivens As suggested I have moved the getValidNetworkCidr to common class 
NetworkModel.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1911: CLOUDSTACK-9742:Simultaneous snapshots for detached ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1911
  
@mrunalinikankariya Can you provide some marvin test? Also is it possible 
to add some snapshots/test results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1797
  
LGTM on the code changes. Make sense to keep listVirtualMachines and 
listNics in sync for nic response. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1877: CLOUDSTACK-9716: Change of network to rvr for bareme...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1877
  
@rashmidixit Could you add a marvin test case? It looks with your changes, 
master VR Redundant state will be stuck in unknown state. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/892
  
@alexandrelimassantana As suggested I have moved the code snippet to a 
method and also added unit tests. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1875: CLOUDSTACK-8608: [VMware] System VMs failed t...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1875#discussion_r104600403
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -707,6 +709,23 @@ private String setupMountPoint(String parent) {
 return mountPoint;
 }
 
+@Override
+public synchronized void setSystemVmTmpltPermission(String mountPoint) 
{
+if (!s_isSystemVmTmpltPermissionSet) {
+s_logger.debug("Set permissions for " + mountPoint);
+String result = null;
+final String systemVmTmpltPermissions = "0777";
+Script script = new Script(true, "chmod", _timeout, s_logger);
+script.add("-R", systemVmTmpltPermissions, mountPoint);
--- End diff --

@sureshanaparti It would be better if you  can move it to TemplateConstants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1875
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails some...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/2013

Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes

This is a specific case when vm state gets updated by the vmsync before it 
can be updated by the api-job-executor thread. 
I could see following logs. 

```
2015-10-28 02:03:21,590 DEBUG [jobs.impl.AsyncJobManagerImpl] 
(API-Job-Executor-5:ctx-5fe7b795 job-3056226 ctx-49b11835) Sync job-3056236 
execution on object VmWorkJobQueue.845336
2015-10-28 02:03:23,563 DEBUG [vm.dao.VMInstanceDaoImpl] 
(API-Job-Executor-5:ctx-5fe7b795 job-3056226 ctx-49b11835) Unable to update 
VM[User|i-3702-845336-VM]: DB Data={Host=null; State=Stopped; updated=6; 
time=Wed Oct 28 02:03:23 PDT 2015} New Data: {Host=null; State=Destroyed; 
updated=6; time=Wed Oct 28 02:03:23 PDT 2015} Stale Data: {Host=null; 
State=Stopped; updated=5; time=Wed Oct 28 02:03:18 PDT 2015}
```
I don't see any other traces of sync job queued for the mentioned vm. 
This is an extremely rare scenario and is not reproducible.  

To fix the scenario, I have added 2 retries to trigger DestroyRequested 
event for the VM.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack cs-9734

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2013.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2013


commit 4686f1e45bfc5ae079b54e3b4ebcb39f50124d9b
Author: Sudharma Jain 
Date:   2017-01-09T09:45:22Z

Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2017: CLOUDSTACK-9847 vm_network_map is not getting...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/2017

CLOUDSTACK-9847 vm_network_map is not getting cleaned 

While releasing nic for Create reservation strategy, vm_network_map is not 
getting cleaned. I have added corresponding code to perform the cleanup. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack cs-9847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2017


commit 159ee0e1fae99be44b77119aeb5235b0b1571b0d
Author: Sudharma Jain 
Date:   2017-03-23T10:36:31Z

CLOUDSTACK-9847 vm_network_map is not getting cleaned while releasing nic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2017: CLOUDSTACK-9847 vm_network_map is not getting cleane...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2017
  
@serg38 This is different from #1613. In #1613 vm_network_map was getting 
cleaned only when nic reservation strategy is Start, but not for Create.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2019: CLOUDSTACK-9851 travis CI build failure after...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/2019

CLOUDSTACK-9851 travis CI build failure after merge of PR#1953 & 
CLOUDSTACK-9850

Fixed travis CI failures happening after merge of PR#1953.
Also fixed root volume detach that was broken after merge of PR#1953.
I found following logs with root volume attach. 

`
2017-03-24 23:19:48,380 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-27:ctx-7c53d1bc job-44) (logid:f3b54257) Executing AsyncJobVO 
{id:44, userId: 2, accountId: 2, instanceType: Volume, instanceId: 3, cmd: 
org.apache.cloudstack.api.command.admin.volume.AttachVolumeCmdByAdmin, cmdInfo: 
{"apiKey":"PYHMg5HhOkmTQvlmZSe1dIDfTxl8uwreeFoqfj0a4zPCC-1XTuwH7H5I8Ac9fyvPbtNO1eN9THi72q8ATfs8hg","signature":"DD+ljbVWpWQw6FCl1tCDSYe5Ui0\u003d","httpmethod":"GET","deviceid":"0","ctxAccountId":"2","uuid":"2db57cd8-c96c-48f9-83c5-b9a79c852cc5","cmdEventType":"VOLUME.ATTACH","virtualmachineid":"9cb6a944-8775-4e11-961b-0e8dbdebf5a7","response":"json","ctxUserId":"2","ctxStartEventId":"117","id":"2db57cd8-c96c-48f9-83c5-b9a79c852cc5","ctxDetails":"{\"interface
 
com.cloud.vm.VirtualMachine\":\"9cb6a944-8775-4e11-961b-0e8dbdebf5a7\",\"interface
 com.cloud.storage.Volume\":\"2db57cd8-c96c-48f9-83c5-b9a79c852cc5\"}"}, 
cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
  null, initMsid: 4278190080, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: null }
2017-03-24 23:19:50,160 ERROR [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-15:ctx-489eb1dd job-44/job-45 ctx-cce17070) (logid:f3b54257) 
Invocation exception, caused by: java.lang.RuntimeException: deviceId should be 
1,2,4-5
`


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack cs-9850

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2019


commit 61178ea770a02ecda8b305e728167dc3bf453601
Author: Sudharma Jain 
Date:   2017-03-26T07:01:42Z

CLOUDSTACK-9851 travis CI build failure after merge of PR#1953
CLOUDSTACK-9850 Root volume detach broken after merge of PR#1953




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2019
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2019
  
Thanks @koushik-das for reviewing this. So Let me close this and root 
volume detach should also be fixed as a part of PR #1953.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2019
  
@koushik-das As suggested by you, I have  added changes to correct the 
maxDataVolume limits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1722: CLOUDSTACK-9558 Cleanup the snapshots on the primary...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1722
  
LGTM for the code changes. @yvsubhash please change the base branch to 4.9.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/899
  
@yvsubhash your template related changes are not relevant to the issue 
fixed. Please remove the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2012
  
LGTM for the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2002
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/883
  
@jayakarteek Thanks for testing. I have made the respective code changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2021: CLOUDSTACK-9854: Fix test_primary_storage test failu...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/2021
  
LGTM for the code changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/899
  
@yvsubhash Jenkins failed. Please force push the changes again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_poo...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/876
  
@rhtyd As suggested I have added a marvin test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #899: BUG-ID:CLOUDSTACK-8921 snapshot_store_ref table shoul...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/899
  
LGTM for the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #892: CLOUDSTACK-8910: The reserved_capacity field increase...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/892
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1734
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1246
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotat...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/883
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/876#discussion_r109859606
  
--- Diff: 
plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
 ---
@@ -359,7 +359,7 @@ public boolean attachCluster(DataStore store, 
ClusterScope scope) {
 
 PrimaryDataStoreInfo primarystore = (PrimaryDataStoreInfo) store;
 // Check if there is host up in this cluster
-List allHosts = 
_resourceMgr.listAllUpAndEnabledHosts(Host.Type.Routing, 
primarystore.getClusterId(), primarystore.getPodId(), 
primarystore.getDataCenterId());
+List allHosts = 
_resourceMgr.listAllUpHosts(Host.Type.Routing, primarystore.getClusterId(), 
primarystore.getPodId(), primarystore.getDataCenterId());
--- End diff --

@syed We cannot send commands to the host in maintenance mode. So it is not 
possible to add an SR to those host. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1196#issuecomment-164350819
  
Fixed the build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9166:Build failed in Jenkins: ...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1243

CLOUDSTACK-9166:Build failed in Jenkins: cloudstack-rat-master #7038

With my last PR#1196, I missed to place the license disclaimer into 
CitrixHelperTest.java. Updated the file with the disclaimer. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9166

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1243


commit 601f2dba24f7665d295627e3b2a2eb6f4aae9f77
Author: SudharmaJain 
Date:   2015-12-14T11:39:12Z

CLOUDSTACK-9166:Build failed in Jenkins: cloudstack-rat-master #7038




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1246

CLOUDSTACK-9165 unable to use reserved IP range in a network for exte…

…rnal VMs

Repro Steps
--
1.  Create an isolated network with CIDR 192.168.200.0/24. 
2.  Edit the CIDR to 192.168.200.0/25. 
3. Perform Network restart with cleanup.
4.  Network Restart with Cleanup, it was successful. 
4.  Add external VM to the network with IP 192.168.200.150/24 to the 
network. 
5.  After restart Netmask1 displayed CIDR 192.168.200.150/25 and Network 
CIDR as 192.168.200.150/24.
6.  Create an instance from cloudstack.  
7.  Ping the VM from external VM.

Before Applying the fix
---
External Vm was unable to communicate with the cloudstack managed VM. 

![image](https://cloud.githubusercontent.com/assets/12229259/11832815/b642ff08-a3e2-11e5-8716-71ed5bfca742.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11832892/6547de6a-a3e3-11e5-97f0-c1e86753123a.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11833167/fe714df4-a3e5-11e5-8e18-a820e8c97b78.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11833031/c71e23dc-a3e4-11e5-892a-69f877701885.png)


After applying the fix
--


![image](https://cloud.githubusercontent.com/assets/12229259/11833583/0e151502-a3ea-11e5-86c8-4eceece59cc1.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11833648/f56d7278-a3ea-11e5-94e1-89577f27686a.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11833601/6689a4dc-a3ea-11e5-805f-cb0c51d35111.png)


![image](https://cloud.githubusercontent.com/assets/12229259/11833618/8fc85906-a3ea-11e5-8452-16cb393b847c.png)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9165

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1246


commit 1bd12fce44d79a2825c4c78fbfe1183e04ce496d
Author: SudharmaJain 
Date:   2015-12-16T04:42:00Z

CLOUDSTACK-9165 unable to use reserved IP range in a network for external 
VMs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/880#discussion_r40543530
  
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -1999,7 +1999,9 @@
 // StatsCollector
 StatsOutPutGraphiteHost("Advanced", ManagementServer.class, 
String.class, "stats.output.uri", "", "URI to additionally send StatsCollector 
statistics to", null),
 
-SSVMPSK("Hidden", ManagementServer.class, String.class, 
"upload.post.secret.key", "", "PSK with SSVM", null);
+SSVMPSK("Hidden", ManagementServer.class, String.class, 
"upload.post.secret.key", "", "PSK with SSVM", null),
+
+TemplatePreloaderPoolSize("Advanced", TemplateManager.class, 
Integer.class, "template.preloader.pool.size", "8", "Size of the 
TemplateManager threadpool", null);
--- End diff --

@koushik-das, changed the mechanism to use configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/895

CLOUDSTACK-8911: VM start job got stuck in loop looking for suitable …

…host

VM instance creation job get stuck in the loop, when VMs require local 
storage there are host that reached max guest limit and remain hosts does have 
storage available.  This happens because the hosts that reach the max guest 
limit were not getting added to the avoid list and hence the cluster. 

Verified the fix on my local setup.

Repro Steps:
1. Take an environment with single cluster and 2 hosts.
2. change the max guest limit for the hypervisor such that on one host max 
guest limit should reach.
3. change thresholds so that other host should not have enough storage. If 
required create a VM for sufficient bigger disk.
4. Now deploy a VM with local storage.
5. cluster will never be put in the avoid set and job will keep looking for 
suitable host.
6. once we increase the max guest limit, VM will deploy or will fail if 
there is a lack of storage.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8911

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #895


commit 17050a07dbcf1ac1430c6b0dae8e415d9fcd5181
Author: SudharmaJain 
Date:   2015-09-25T12:35:54Z

CLOUDSTACK-8911: VM start job got stuck in loop looking for suitable host




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/895#discussion_r40755936
  
--- Diff: 
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java ---
@@ -297,6 +297,7 @@
 s_logger.debug("Host name: " + host.getName() + ", 
hostId: " + host.getId() +
 " already has max Running VMs(count includes 
system VMs), skipping this and trying other available hosts");
 }
+avoid.addHost(host.getId());
--- End diff --

@koushik-das I have added the change for GPU device as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/880#discussion_r40756846
  
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
   UNIQUE KEY `uk_ldap_trust_map__domain_id` (`domain_id`),
   CONSTRAINT `fk_ldap_trust_map__domain_id` FOREIGN KEY (`domain_id`) 
REFERENCES `domain` (`id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT', 
'TemplateManager', 'template.preloader.pool.size', '8', 'Size of the threadpool 
for preparetemplate api', '8', NULL, 'Global', 0);
--- End diff --

@koushik-das Implemented Configurable interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-146081053
  
@koushik-das This bug exist in xenserver 6.0.2 and later. For XenServer 
6.0, logrotation works. Thats is the reason i have implemented 
XenServer602Resource and didn't used Xenserver600Resource. Contents of patch 
file for 6.0 and 6.0.2 had a difference of one line. I have added a new file 
logrotate to be deployed in /etc/cron.hourly for versions 6.0.2 and later. So i 
have updated the patch file for 6.2 and 6.5 as well.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-146083023
  
@remibergsma  @koushik-das For incorporating the change in 
XenServer600Resource, I need to test the change for Xenserver 6.0. After 
checking it for 6.0, I will update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-147233273
  
@remibergsma @koushik-das I have made the changes and have removed 
reimplementation of XenServer 6.0.2 resource. I have added changes to patch 
file for XenServer 6.0 resource, so that log rotation will work for 6.0 and 
6.0.2.  PR #861 will not fix this issue. Now both PR #883 and PR #861 need to 
be merged to fix the issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/880#discussion_r41722125
  
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,4 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
   UNIQUE KEY `uk_ldap_trust_map__domain_id` (`domain_id`),
   CONSTRAINT `fk_ldap_trust_map__domain_id` FOREIGN KEY (`domain_id`) 
REFERENCES `domain` (`id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
--- End diff --

Removed the empty line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/955

CLOUDSTACK-8969 VPN customer gateway can't be registered with hostname

When we have VPN customer gateway which is resolved by a hostname , we 
should be able to register the VPN customer gateway with its hostname instead 
of the IP address, this would be useful in case where the remote device IP is 
dynamically assigned , where customers use DDNS to resolve it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8969

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #955


commit 97882eb4b6d0ee1e34228d80a442b8fc2795bc6d
Author: SudharmaJain 
Date:   2015-10-20T04:46:12Z

CLOUDSTACK-8969 VPN customer gateway can't be registered with hostname




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/956

CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} guest OS mapping for vmware is n…

…ot available 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8970

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #956


commit 926d446b142e43324cd5f366c7984b96156b0ca3
Author: SudharmaJain 
Date:   2015-10-20T05:31:34Z

CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} guest OS mapping for vmware is not 
available




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/883#discussion_r43846616
  
--- Diff: scripts/vm/hypervisor/xenserver/logrotate ---
@@ -0,0 +1,29 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Version @VERSION@
+#
+# script to perform logrotation on xenserver 6.0.2 and later
+
+/usr/sbin/logrotate  /etc/logrotate.d/cloudlog
--- End diff --

@sspans  I think the files mentioned in the patch file are the only ones 
getting deployed to the xenserver. Of these I cloud find cloudlog is the only 
logrotate configuration file. 
Please let me know if I missed anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1157

CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREATE event missing for usage_e…

…vent by template sync thread

If there is a Management server restart while template is in downloading or 
installing state. Template Sync does not push event into usage_event table. 

I have verified the fix manually. Here is a snapshot.

![image](https://cloud.githubusercontent.com/assets/12229259/11559714/0989748c-99e1-11e5-88e0-48b4dbec0224.png)

 I have registered 4 templates. template id 207 and 208(ISO.CREATE event is 
missing) before applying the fix. and template id 209 and 210 after applying 
the fix.

Repro Steps (3 cases)
==
Case - 1 (private template)
-
1. register a private template/iso.
2. restart management server when template is in downloading state.
3. After management server restart, template_store_ref entry is removed if  
download was not yet completed.
4. on next management server restart, if download would have completed, 
template_store_ref entry will get populated, but TEMPLATE.CREATE event is 
missing in usage_event.

Case - 2 (Public template)

1.  register public template.
2. restart management server when in downloading state.
3. after restart template download reinitiates.
4. template goes to ready state, but there is no usage event.

case -3 (public/private template)
- 
1. register a template 
2. restart management server when template is in installing state.
3. after restart template goes to ready, but there is no usage event.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9100

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1157


commit 912735a03086056e8e1e0d049492ead1bc0dfd3d
Author: SudharmaJain 
Date:   2015-12-03T08:41:14Z

CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREATE event missing for usage_event 
by template sync thread




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1196

CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise…

… Server 10 SP2 and SP3"

ISSUE

STOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during 
the start command.
DESCRIPTION
--
Repro steps
1. Upload Suse ISO 
2. Create a VM with this ISO, and install it.
3. Detach ISO from the VM. 
4. Reboot the VM, :>>>> This will work fine, as the pv-bootloader-args are 
not missing during reboot.
5.Stop the VM from CCP(VM will get destroyed in Xencenter)
6. Start the same VM from CCP , it will try to start but will fail.

Before Applying the fix

Before applying the starting the VM failed with following exception 
com.cloud.utils.exception.CloudRuntimeException: Unable to start 
VM(i-2-6-VM) on host(7cfd6388-b763-4c09-b3a3-9679db2904a3) due to Task failed! 
Task record: uuid: 21a6799f-9523-7c0e-bb86-1de750a38d74
   nameLabel: Async.VM.start_on
 nameDescription:
   allowedOperations: []
   currentOperations: {}
 created: Wed Dec 09 07:00:29 UTC 2015
finished: Wed Dec 09 07:00:31 UTC 2015
  status: failure
  residentOn: com.xensource.xenapi.Host@513d238c
progress: 1.0
type: 
  result:
   errorInfo: [BOOTLOADER_FAILED, 
OpaqueRef:0b10b6ac-837d-29af-da9d-6ef1e11a064a, Unable to find partition 
containing kernel
]
 otherConfig: {}
   subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []


![image](https://cloud.githubusercontent.com/assets/12229259/11678758/bd0fc9aa-9e70-11e5-9687-c77bfecaa4dd.png)


After Applying the fix
--
After applying the fix I am able to start the vm.

![image](https://cloud.githubusercontent.com/assets/12229259/11678938/6d44f5b0-9e72-11e5-83b0-60a736408b4d.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9127

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1196


commit fa81844812a26832e42b31e415de66277c59e3c5
Author: SudharmaJain 
Date:   2015-12-09T06:23:51Z

CLOUDSTACK-9127 Missing PV-bootloader-args for "SUSE Linux Enterprise 
Server 10 SP2 and SP3"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[SudharmaJain]

Github user SudharmaJain commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1196#discussion_r47336103
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
 ---
@@ -236,4 +236,15 @@ public static String getProductVersion(final 
Host.Record record) {
 }
 return prodVersion;
 }
+
+public static String getPVbootloaderArgs(String guestOS) {
+if (guestOS.startsWith("SUSE Linux Enterprise Server")) {
+if (guestOS.contains("64-bit")) {
+return "--kernel /boot/vmlinuz-xen --ramdisk 
/boot/initrd-xen";
+} else if (guestOS.contains("32-bit")) {
+return "--kernel /boot/vmlinuz-xenpae --ramdisk 
/boot/initrd-xenpae";
+}
+}
+return "";
+}
--- End diff --

Added a unit test to cover the newly added method.

Thanks,
Sudharma


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/836

CLOUDSTACK-8863: VM doesn't reconnect to internet post VR RESTART/STO…

…P-START/RECREATE

The ongoing ICMP request reply session is broken when the VR is down, the 
expectation is that it would resume once the VR is up. Investigations revealed 
that the ongoing ICMP packets are sent out of eth2 without being NATed post VR 
stop/start or restart or recreate.

TCPDUMP output from VR post restart/stop-start/recreate on eth2:

root@r-4-VM:~# tcpdump -i eth2 icmp -n -vvv
tcpdump: listening on eth2, link-type EN10MB (Ethernet), capture size 65535 
bytes
06:22:52.749770 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 81, 
length 64
06:22:53.749782 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 82, 
length 64
06:22:54.749771 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 83, 
length 64
06:22:55.749775 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 84, 
length 64
06:22:56.749765 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 85, 
length 64
06:22:57.749776 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto ICMP 
(1), length 84)
192.168.200.67 > 173.194.33.163: ICMP echo request, id 30996, seq 86, 
length 64
^C
6 packets captured
6 packets received by filter
0 packets dropped by kernel
root@r-4-VM:~#
root@r-4-VM:~# grep icmp /proc/net/ip_conntrack
icmp 1 29 src=192.168.200.67 dst=173.194.33.163 type=8 code=0 id=30996 
[UNREPLIED] src=173.194.33.163 dst=192.168.200.67 type=0 code=0 id=30996 mark=0 
use=2

This get fixed after flushing the conntrack table. 

Screenshots:

Before fix (ping session doesn't resume, stop and starting the ping works, 
120 packets lost):

![image](https://cloud.githubusercontent.com/assets/12229259/9897800/4de7488e-5c6a-11e5-98eb-3bd79cc3a8b1.png)

After fix(ping session resumes, 27 packets lost):

![image](https://cloud.githubusercontent.com/assets/12229259/9897822/9112e866-5c6a-11e5-95b3-1b20600d2e44.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #836


commit 321bba79579eab9cd59a1697a2d4b0ff6ae54bec
Author: sudharma jain 
Date:   2015-09-16T05:25:57Z

CLOUDSTACK-8863: VM doesn't reconnect to internet post VR 
RESTART/STOP-START/RECREATE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/836#issuecomment-140687549
  
@bhaisaab, using service conntrackd status don't provide the status and 
always gives the usage information for conntrackd. So i have added the changes 
by starting conntrackd in deamon mode with (-d) switch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8864: Not able to add TCP port...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/851

CLOUDSTACK-8864: Not able to add TCP port forwarding rule in VPN for …

…specific ports

Setting port forwarding rules for port 500,1701 and 4500 after enabling 
VPN, gives the error message "The range specified, , conflicts with rule 
 which has ." This happens because the rules added for vpn doesn't have 
a matching condition to allow port forwarding rules.

Added a unit test to verify the detectRulesConflict function of 
FirewallManagerImpl.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #851


commit 96c38bf491d81e41975dddbfc3c87716293c7bdf
Author: SudharmaJain 
Date:   2015-09-19T18:10:21Z

CLOUDSTACK-8864: Not able to add TCP port forwarding rule in VPN for 
specific ports




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/876

CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry…

… for disabled host

This causes VM deployment failure on the host that was disabled while 
adding the storage repository.
In the attachCluster function of the PrimaryDataStoreLifeCycle, we were 
only selecting hosts that are up and are in enabled state. Here if we select 
all up hosts, it will populate the DB properly and will fix this issue.

Also added a unit test for attachCluster function. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8865

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #876


commit 00d921e3c81d2e34dce64a9c70c720c76bb8073f
Author: SudharmaJain 
Date:   2015-09-23T05:49:24Z

CLOUDSTACK-8865: Adding SR doesn't create Storage_pool_host_ref entry for 
disabled host




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/880

CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads

 The thread pool was hardcoded to use 8 threads,
com.cloud.template.TemplateManagerImpl.configure(String, Map):
_preloadExecutor = Executors.newFixedThreadPool(8, new 
NamedThreadFactory("Template-Preloader"));

Added the change to pick threadpool size from configuration.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8901

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #880


commit 49ed8ee960acce13f32def10e15924c84257c4e4
Author: SudharmaJain 
Date:   2015-09-24T06:11:54Z

CLOUDSTACK-8901: PrepareTemplate job thread hard-coded to max 8 threads




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/883

CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver

After integrating XS with CCP the following folder gets created: 
/var/log/cloud/ however the logs in that are not rotated resulting in root file 
system fill up. It was a known issue and link 
http://support.citrix.com/article/CTX138064 describes the issue and solution. 
Used the article and added corresponding changes to Cloudstack. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8906

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/883.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #883


commit ffc786f40317c05e0a9b2b3ccd47fee21e1f76bb
Author: SudharmaJain 
Date:   2015-09-24T12:34:38Z

CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-143478261
  
@remibergsma I didn't checked the PR #861. I was looking to fix the issue 
with xenserver 6.0.2 and higher. For this I have added a logrotate script and a 
Patch file for 6.0.2 which is the same as for xenserver 6.0 with an extra entry 
for logrotate script. same entry is added in patch file for 6.2 and 6.5. In 
earlier version, you can find logrotate in /etc/cron.hourly. In later versions 
it was not available which broke the log rotate functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/892

CLOUDSTACK-8910: The reserved_capacity field increases suddenly after…

… a vmware host failure

In case of vmware host failure, all the VMs including stopped VMs migrate 
to the new host. For the Stopped Vms powerhost gets updated. This was 
triggering HandlePowerStateReport which finally calls updatePowerState updating 
update_time for the VM. This cause the capacity being reserved for stopped VMs 
capacity skip counting hours. 

Added the change to avoid update if the VM is in stopped state and host Id 
is null. 

Verified the fix manually. 

Here are the repro steps:
1. take a HA enabled cluster with two hosts.
2. should have few started and stopped VMs to each of the host.
3. Now shutdown one host.
4. All VMs(including stopped) on the host will migrate to another host.
5. Now update time of even stopped VMs get updated and will reserve the 
capacity for skip counting hours on the host identified by last_host_id.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-8910

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/892.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #892


commit 3feda2024c8f7a8d9965dddb16bfbf452b3dd84b
Author: SudharmaJain 
Date:   2015-09-25T19:20:11Z

CLOUDSTACK-8910: The reserved_capacity field increases suddenly after a 
vmware host failure

In case of vmware host failure, all the VMs including stopped VMs migrate
to the new host. For the Stopped Vms powerhost gets updated. This was
triggering HandlePowerStateReport which finally calls updatePowerState
updating update_time for the VM. This cause the capacity being reserved
for stopped VMs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-143645025
  
@remibergsma Rebased against the current master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218362347
  
Rebased and pushed it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218830874
  
@swill Rebased against master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218960573
  
Getting following error with Jenkins

Running org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest
Testing don't block on newly created clones - pass
Testing block on modified files - pass
Testing timeout of blocking on modified files - pass
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.272 sec - 
in org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest
Running org.apache.cloudstack.utils.imagestore.ImageStoreUtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.057 sec - 
in org.apache.cloudstack.utils.imagestore.ImageStoreUtilTest
Running org.apache.cloudstack.utils.process.ProcessTest
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 301.061 sec 
<<< FAILURE! - in org.apache.cloudstack.utils.process.ProcessTest
testProcessRunner(org.apache.cloudstack.utils.process.ProcessTest)  Time 
elapsed: 300.038 sec  <<< FAILURE!
java.lang.AssertionError: expected:<-1> but was:<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.cloudstack.utils.process.ProcessTest.testProcessRunner(ProcessTest.java:43)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-219617936
  
Rebased and pushed the branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1246#issuecomment-212258625
  
@alexandrelimassantana I have made changes with respect to ur last comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1157#issuecomment-212360074
  
@pedro-martins On line 503, It is not a function but It is a way to define 
callback method. It has been used all over the cloudstack code.  On line 504, 
context was set and will be available in callback method 
'createTemplateAsyncCallBack'. So there are no chances of null pointer 
exception on line 598. If there was any chance of null pointer exception, it 
would have happened in my test setup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-212404120
  
@bhaisaab Rebased the branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9100: ISO.CREATE/TEMPLATE.CREA...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1157#issuecomment-212408609
  
Rebased against master. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-212416597
  
@bhaisaab Rebased against master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/880#issuecomment-212418415
  
Rebased against master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-212718578
  
@bhaisaab Thanks for the comment. I  have updated with the latest now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/880#issuecomment-212724576
  
@bhaisaab I pushed it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/876#issuecomment-212725838
  
Rebased with master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-212742630
  
The existing implementation for logrotation that works with xenserver 6.0 
and earlier does not works with 6.0.2 and later. That is the reason I have 
added this implentation. With #861 we are changing the database to point to 
XenServer600Resource, but this change has no impact on log rotation 
implementation.  Here is an article that described the problem and the solution 
that I implemented.


[http://support.en.ctx.org.cn/ctx138064.citrix](http://support.en.ctx.org.cn/ctx138064.citrix)

@harikrishna-patnala can you comment if #861 is going to help in log 
rotation problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/892#issuecomment-212745452
  
Rebased the branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8865: Adding SR doesn't create...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/876#issuecomment-212794906
  
@alexandrelimassantana This method is about a query execution on database. 
Could you suggest how can i add a unit test for it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/1516#issuecomment-214143155
  
LGTM. Code Reviewed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/892#issuecomment-216196848
  
@rhtyd Rebased again master. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218056032
  
@swill I force pushed again and still it is failing. In logs I see 
following error.

fatal: write error: No space left on device


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1733: CLOUDSTACK-9563 ExtractTemplate returns malfo...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1733

CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating…

… NFS to s3

While downloading the template for the first time install path was not 
available. During first download after migration template is synced to s3 
storage and template install path is updated to DB. But while generating the 
extract URL we are still taking install path from TemplateDataStoreVO object 
cached in the process.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9563

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1733


commit 9074f37cb8f33171246056aca1ad50f35e65b494
Author: Sudharma Jain 
Date:   2016-10-26T12:03:31Z

CLOUDSTACK-9563 ExtractTemplate returns malformed URL after migrating NFS 
to s3




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1734: CLOUDSTACK-9567 Difference in the api call ou...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1734

CLOUDSTACK-9567 Difference in the api call outputs for CAPACITY_TYPE_…

…CPU = 1

The total capacity reported listPods and listCapacity is different, ideally 
they have to be same


http://10.223.59.69:8096/client/api?command=listPods&id=78c23ee6-c585-4065-a03c-08c15492c077&zoneid=48889c46-dd04-4a50-af06-8aad7ea46f61&showcapacities=true

```

1
1042980
1621776
64.31

```


http://10.223.59.69:8096/client/api?command=listCapacity&podid=78c23ee6-c585-4065-a03c-08c15492c077&zoneid=48889c46-dd04-4a50-af06-8aad7ea46f61&type=1

```

1

1
48889c46-dd04-4a50-af06-8aad7ea46f61
jp2-east01
78c23ee6-c585-4065-a03c-08c15492c077
RG1-ck2ejo2-Pod11
1042980
2453456
42.51


```

The problem here was the query being used to fetch data. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9567

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1734


commit 4220d20f2d6633649b9b65c92f02b47ea09280c7
Author: Sudharma Jain 
Date:   2016-10-26T12:38:58Z

CLOUDSTACK-9567 Difference in the api call outputs for CAPACITY_TYPE_CPU = 1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1736: CLOUDSTACK-9562 Linux Guest VM get wrong defa...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1736

CLOUDSTACK-9562 Linux Guest VM get wrong default route when there are…

… multiple Nic

REPRO STEPS
==
1. Log as admin, create a VM CentOSx64 integrate with default network 
"Admin-Network" (gateway is 10.1.1.1)
2. Create a VPC "TestVpc" and inside network named "TechNet" (gateway is 
10.0.0.1)
3. Add VPC network to VM as NIC 2
4. Reboot VM and examine VM default VR changed to VPC default gateway

dhcp options entries getting updated on the VR properly, but still they are 
not taking effect. Once we restart the dnsmasq service the issue is resolved. 
This is because dhcp-opsfile entry to dnsmasq.conf was made after service start 
and sending SIGHUP does not reload dnsmasq configuration. Thus adding 
dhcp-opsfile entry to vpcdnsmasq.conf helped to fix the issue. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9562

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1736


commit d9b701fbee7e11198ce23c8166a985db0da3ec00
Author: Sudharma Jain 
Date:   2016-10-27T05:05:38Z

CLOUDSTACK-9562 Linux Guest VM get wrong default route when there are 
multiple Nic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1737: CLOUDSTACK-9561 Unable to delete domain/Accou...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1737

CLOUDSTACK-9561 Unable to delete domain/Account

While deleting the UserAccount Cleanup for the removed VMs/volumes are not 
happening. For the removed VMs, snapshots doesn't get cleaned. Only for running 
VMs the cleanup happens. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9561

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1737


commit 2c443cd189664ec35aaeedd7bd447d4fcfce0387
Author: Sudharma Jain 
Date:   2016-10-27T05:28:37Z

CLOUDSTACK-9561 Unable to delete domain/Account




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1738: CLOUDSTACK-9566 instance-id metadata for bare...

[SudharmaJain]

GitHub user SudharmaJain opened a pull request:

https://github.com/apache/cloudstack/pull/1738

CLOUDSTACK-9566 instance-id metadata for baremetal VM returns ID

There is difference in instance-id metadata across baremetal and other 
hypervisors.  

On Baremetal
[root@ip-172-17-0-144 ~]# curl 
http://8.37.203.221/latest/meta-data/instance-id
6021

on Xen
[root@ip-172-17-2-103 ~]# curl 
http://172.17.0.252/latest/meta-data/instance-id
cbeb517a-e833-4a0c-b1e8-9ed70200fbbf

In both cases it should be vm's uuid. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SudharmaJain/cloudstack cs-9566

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1738


commit 759a92d2516a99b90b59dc096f23e2e903d0673b
Author: Sudharma Jain 
Date:   2016-10-27T08:20:39Z

CLOUDSTACK-9566 instance-id metadata for baremetal VM returns ID




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1736: CLOUDSTACK-9562 Linux Guest VM get wrong defa...

[SudharmaJain]

Github user SudharmaJain closed the pull request at:

https://github.com/apache/cloudstack/pull/1736


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1736: CLOUDSTACK-9562 Linux Guest VM get wrong default rou...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1736
  
@ustcweizhou You are right. This is not fixing the issue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1734
  
Manual Test on local environment 

### Before Applying the fix


http://localhost:8080/client/api?command=listPods&id=9b409cf0-a227-488d-87ea-0033aea2dcc5&response=&_=1481106672505&showcapacities=true
```

1

9b409cf0-a227-488d-87ea-0033aea2dcc5
POD0
88a777cf-17c3-4bdd-b1fd-44eef39bff68
Sandbox-simulator
172.16.15.1
255.255.255.0
172.16.15.2
172.16.15.200
Enabled

5
4
199
2.01


1
1500
96000
1.56


2
0
3298534883328
0


3
400
6597069766656
0


0
2684354560
25769803776
10.42



```


http://localhost:8080/client/api?command=listCapacity&podid=9b409cf0-a227-488d-87ea-0033aea2dcc5&response=&_=1481106672505&type=1
```

1

1
88a777cf-17c3-4bdd-b1fd-44eef39bff68
Sandbox-simulator
9b409cf0-a227-488d-87ea-0033aea2dcc5
POD0
1500
128000
1.17


```

### After applying the fix 


http://localhost:8080/client/api?command=listPods&id=9b409cf0-a227-488d-87ea-0033aea2dcc5&response=&_=1481106672505&showcapacities=true

```

1

9b409cf0-a227-488d-87ea-0033aea2dcc5
POD0
88a777cf-17c3-4bdd-b1fd-44eef39bff68
Sandbox-simulator
172.16.15.1
255.255.255.0
172.16.15.2
172.16.15.200
Enabled

1
1500
128000
1.17


0
2684354560
34359738368
7.81


2
0
3298534883328
0


3
400
6597069766656
0


5
4
199
2.01



```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1734
  
@jburwell I have added a Marvin test case to verify the fix.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1246
  
Moved the getValidNetworkCidr to common class NetworkModel and Rebased with 
master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1913
  
@nvazquez I think in case if connection to vcenter fails there are changes 
as the disk may get created on vcenter. In such case we may need to remove the 
vmdk. we can improve the logic to search vmdk in specific location of data 
store and reduce the delay. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1910
  
Code changes looks good. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1942
  
@niteshsarda Can you add some screenshots of the impact before the fix and 
after the fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1924: CLOUDSTACK-9766 : Executing deleteSnapshot api with ...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1924
  
LGTM on the code changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1909: CLOUDSTACK-9740 : Search for secondary IP of NIC tha...

[SudharmaJain]

Github user SudharmaJain commented on the issue:

https://github.com/apache/cloudstack/pull/1909
  
@niteshsarda I see a problem here. The listNics command can be used to list 
both primary and secondary ips. In case if we pass nicid parameter with it, i 
feel we should use keywork to filter secondary nics. If only virtualmachineid 
is given, we should use it to filter primary IPs.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---