[jira] [Assigned] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò reassigned COCOON3-95: - Assignee: Francesco Chicchiriccò > Sitemap file not validated against schema > - > > Key: COCOON3-95 > URL: https://issues.apache.org/jira/browse/COCOON3-95 > Project: Cocoon 3 > Issue Type: Bug > Components: cocoon-general >Affects Versions: 3.0.0-beta-1 >Reporter: Javier Puerto >Assignee: Francesco Chicchiriccò > Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, > sitemap-validation.tar.gz > > > http://cocoon.markmail.org/thread/cq6nrzy5xladcuys > Summary: Lars Huttar found that his sitemap declaration was not working as > expected. Some matchers worked an others not. Finally the problem was a > matcher tag not inside a pipeline tag. > Attached is a block to reproduce the problem, I just review the > SitemapBuilder class and there's not validation at all against a schema. So > if the sitemap.xmap file is a XML well formed, C3 will not throw any error > about. The ugly issue is that C3 is returning a HTTP status code of 200 > instead of a code 500 and also the exception in the log is not very helpful, > NullPointerException. > I think that we should validate the sitemap file or at least response with > the right HTTP status code and better error information in this case. We can > do something like we have already for the SchemaProcessorTransformer, using > the caching to avoid unnecessary processing. The schema file path is > trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244857#comment-13244857 ] Javier Puerto commented on COCOON3-95: -- Sitemap builder now validates sitemap files against the schema. A simple caching was added to avoid unnecessary validations. > Sitemap file not validated against schema > - > > Key: COCOON3-95 > URL: https://issues.apache.org/jira/browse/COCOON3-95 > Project: Cocoon 3 > Issue Type: Bug > Components: cocoon-general >Affects Versions: 3.0.0-beta-1 >Reporter: Javier Puerto > Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, > sitemap-validation.tar.gz > > > http://cocoon.markmail.org/thread/cq6nrzy5xladcuys > Summary: Lars Huttar found that his sitemap declaration was not working as > expected. Some matchers worked an others not. Finally the problem was a > matcher tag not inside a pipeline tag. > Attached is a block to reproduce the problem, I just review the > SitemapBuilder class and there's not validation at all against a schema. So > if the sitemap.xmap file is a XML well formed, C3 will not throw any error > about. The ugly issue is that C3 is returning a HTTP status code of 200 > instead of a code 500 and also the exception in the log is not very helpful, > NullPointerException. > I think that we should validate the sitemap file or at least response with > the right HTTP status code and better error information in this case. We can > do something like we have already for the SchemaProcessorTransformer, using > the caching to avoid unnecessary processing. The schema file path is > trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Puerto updated COCOON3-95: - Attachment: sitemap-schema.diff Update sitemap schema with caching pipeline attributes. > Sitemap file not validated against schema > - > > Key: COCOON3-95 > URL: https://issues.apache.org/jira/browse/COCOON3-95 > Project: Cocoon 3 > Issue Type: Bug > Components: cocoon-general >Affects Versions: 3.0.0-beta-1 >Reporter: Javier Puerto > Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, > sitemap-validation.tar.gz > > > http://cocoon.markmail.org/thread/cq6nrzy5xladcuys > Summary: Lars Huttar found that his sitemap declaration was not working as > expected. Some matchers worked an others not. Finally the problem was a > matcher tag not inside a pipeline tag. > Attached is a block to reproduce the problem, I just review the > SitemapBuilder class and there's not validation at all against a schema. So > if the sitemap.xmap file is a XML well formed, C3 will not throw any error > about. The ugly issue is that C3 is returning a HTTP status code of 200 > instead of a code 500 and also the exception in the log is not very helpful, > NullPointerException. > I think that we should validate the sitemap file or at least response with > the right HTTP status code and better error information in this case. We can > do something like we have already for the SchemaProcessorTransformer, using > the caching to avoid unnecessary processing. The schema file path is > trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244826#comment-13244826 ] Javier Puerto commented on COCOON3-95: -- Samples block sitemap file doesn't validate against the schema. > Sitemap file not validated against schema > - > > Key: COCOON3-95 > URL: https://issues.apache.org/jira/browse/COCOON3-95 > Project: Cocoon 3 > Issue Type: Bug > Components: cocoon-general >Affects Versions: 3.0.0-beta-1 >Reporter: Javier Puerto > Attachments: SitemapBuilder-COCOON-95.diff, sitemap-validation.tar.gz > > > http://cocoon.markmail.org/thread/cq6nrzy5xladcuys > Summary: Lars Huttar found that his sitemap declaration was not working as > expected. Some matchers worked an others not. Finally the problem was a > matcher tag not inside a pipeline tag. > Attached is a block to reproduce the problem, I just review the > SitemapBuilder class and there's not validation at all against a schema. So > if the sitemap.xmap file is a XML well formed, C3 will not throw any error > about. The ugly issue is that C3 is returning a HTTP status code of 200 > instead of a code 500 and also the exception in the log is not very helpful, > NullPointerException. > I think that we should validate the sitemap file or at least response with > the right HTTP status code and better error information in this case. We can > do something like we have already for the SchemaProcessorTransformer, using > the caching to avoid unnecessary processing. The schema file path is > trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Javier Puerto updated COCOON3-95: - Attachment: SitemapBuilder-COCOON-95.diff Add schema validation to SitemapBuilder > Sitemap file not validated against schema > - > > Key: COCOON3-95 > URL: https://issues.apache.org/jira/browse/COCOON3-95 > Project: Cocoon 3 > Issue Type: Bug > Components: cocoon-general >Affects Versions: 3.0.0-beta-1 >Reporter: Javier Puerto > Attachments: SitemapBuilder-COCOON-95.diff, sitemap-validation.tar.gz > > > http://cocoon.markmail.org/thread/cq6nrzy5xladcuys > Summary: Lars Huttar found that his sitemap declaration was not working as > expected. Some matchers worked an others not. Finally the problem was a > matcher tag not inside a pipeline tag. > Attached is a block to reproduce the problem, I just review the > SitemapBuilder class and there's not validation at all against a schema. So > if the sitemap.xmap file is a XML well formed, C3 will not throw any error > about. The ugly issue is that C3 is returning a HTTP status code of 200 > instead of a code 500 and also the exception in the log is not very helpful, > NullPointerException. > I think that we should validate the sitemap file or at least response with > the right HTTP status code and better error information in this case. We can > do something like we have already for the SchemaProcessorTransformer, using > the caching to avoid unnecessary processing. The schema file path is > trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
