[jira] [Commented] (COCOON3-98) RegexpLinkRewriterTransformer doesn't guarantees rules order
[ https://issues.apache.org/jira/browse/COCOON3-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253224#comment-13253224 ] Javier Puerto commented on COCOON3-98: -- The problem I see is that Cocoon use a Map again to configure the transformer, public void setup(final MapString, Object parameters) so the order is not guaranteed neither. RegexpLinkRewriterTransformer doesn't guarantees rules order Key: COCOON3-98 URL: https://issues.apache.org/jira/browse/COCOON3-98 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sax Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: LinkRewriterTransformer-COCOON-98.diff RegexpLinkRewriterTransformer apply all the defined rules iterating over a Set. I think that makes sense to implement some kind of priority because you may have rules that depends on other rules. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-76) Remove jakarta-regexp dependency
[ https://issues.apache.org/jira/browse/COCOON3-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252917#comment-13252917 ] Javier Puerto commented on COCOON3-76: -- The patch is valid for Cocoon 2.2 but there are differences in behaviour. See http://stackoverflow.com/questions/6582569/differences-between-jakarta-regexp-and-java-6-java-util-regex Remove jakarta-regexp dependency Key: COCOON3-76 URL: https://issues.apache.org/jira/browse/COCOON3-76 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Reporter: Francesco Chicchiriccò Attachments: DirectoryGenerator-COCOON3-76.diff Remove jakarta-regexp dependency from all POMs: the only class using this is, at the moment, DirectoryGenerator, in cocoon-optional. This class should be refactored to make use of java.util.regexp.* instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-98) RegexpLinkRewriterTransformer doesn't guarantees rules order
[ https://issues.apache.org/jira/browse/COCOON3-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252993#comment-13252993 ] Thorsten Scherler commented on COCOON3-98: -- I understand the underlying issue, so I wonder if a linkedList would get rid of the position. Otherwise looks nice. RegexpLinkRewriterTransformer doesn't guarantees rules order Key: COCOON3-98 URL: https://issues.apache.org/jira/browse/COCOON3-98 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sax Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: LinkRewriterTransformer-COCOON-98.diff RegexpLinkRewriterTransformer apply all the defined rules iterating over a Set. I think that makes sense to implement some kind of priority because you may have rules that depends on other rules. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246069#comment-13246069 ] Francesco Chicchiriccò commented on COCOON3-95: --- Couldn't an example of new act:src usage be added in cocoon-sample's sitemap.xmap? Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, cocoon3-95.txt, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-96) Add support for internal-only pipelines
[ https://issues.apache.org/jira/browse/COCOON3-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246085#comment-13246085 ] Francesco Chicchiriccò commented on COCOON3-96: --- Sorry Simone, I did not realize that there was a way to keep all modifications inside cocoon-sitemap only. Now things should be fixed. Add support for internal-only pipelines - Key: COCOON3-96 URL: https://issues.apache.org/jira/browse/COCOON3-96 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Cocoon 2.1 [1] and 2.2 [2] used to have support for internal-only pipelines, i.e. pipelines evaulated for internal (i.e. cocoon:/) requests only. Such feature would be very useful in C3 as well, of course replacing cocoon:/ with servlet:/ [1] http://cocoon.apache.org/2.1/faq/faq-sitemap.html [2] http://cocoon.apache.org/2.2/core-modules/core/2.2/835_1_1.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-97) Wrong status response code for sitemap errors
[ https://issues.apache.org/jira/browse/COCOON3-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246108#comment-13246108 ] Hudson commented on COCOON3-97: --- Integrated in Cocoon-trunk #168 (See [https://builds.apache.org/job/Cocoon-trunk/168/]) [COCOON3-97] Applying provided patch (Revision 1309273) Result = SUCCESS ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1309273 Files : * /cocoon/cocoon3/trunk/cocoon-servlet/src/main/java/org/apache/cocoon/servlet/XMLSitemapServlet.java Wrong status response code for sitemap errors - Key: COCOON3-97 URL: https://issues.apache.org/jira/browse/COCOON3-97 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: XMLSitemapServlet-COCOON3-97.diff As described in COCOON3-95 issue, Cocoon 3 is not handling the status response code properly when a RuntimeException is thrown. It's returning a 200 and should be a 500. The block to reproduce the error is in previous issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-96) Add support for internal-only pipelines
[ https://issues.apache.org/jira/browse/COCOON3-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246107#comment-13246107 ] Hudson commented on COCOON3-96: --- Integrated in Cocoon-trunk #168 (See [https://builds.apache.org/job/Cocoon-trunk/168/]) [COCOON3-96] Restoring pristine cocoon-pipeline modifications and delegating internal-only attribute management to PipelineNode (Revision 1309265) Result = SUCCESS ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1309265 Files : * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/AbstractPipeline.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/Pipeline.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/Invocation.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/InvocationImpl.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/PipelineNode.java Add support for internal-only pipelines - Key: COCOON3-96 URL: https://issues.apache.org/jira/browse/COCOON3-96 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Cocoon 2.1 [1] and 2.2 [2] used to have support for internal-only pipelines, i.e. pipelines evaulated for internal (i.e. cocoon:/) requests only. Such feature would be very useful in C3 as well, of course replacing cocoon:/ with servlet:/ [1] http://cocoon.apache.org/2.1/faq/faq-sitemap.html [2] http://cocoon.apache.org/2.2/core-modules/core/2.2/835_1_1.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-97) Wrong status response code for sitemap errors
[ https://issues.apache.org/jira/browse/COCOON3-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246375#comment-13246375 ] Lars Huttar commented on COCOON3-97: Thank you for catching that. It makes a difference in development, testing and debugging! Lars Wrong status response code for sitemap errors - Key: COCOON3-97 URL: https://issues.apache.org/jira/browse/COCOON3-97 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: XMLSitemapServlet-COCOON3-97.diff As described in COCOON3-95 issue, Cocoon 3 is not handling the status response code properly when a RuntimeException is thrown. It's returning a 200 and should be a 500. The block to reproduce the error is in previous issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245111#comment-13245111 ] Hudson commented on COCOON3-95: --- Integrated in Cocoon-trunk #164 (See [https://builds.apache.org/job/Cocoon-trunk/164/]) [COCOON3-95] Applying and reworking a bit provided patch in order to handle sitemap XML validation when controller: and servlet: namespaces are also present; cocoon-sitemap-1.0.xsd further extended in order to deal with existing sitemap files (Revision 1308780) Result = SUCCESS ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1308780 Files : * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/SitemapBuilder.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-96) Add support for internal-only pipelines
[ https://issues.apache.org/jira/browse/COCOON3-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245456#comment-13245456 ] Hudson commented on COCOON3-96: --- Integrated in Cocoon-trunk #166 (See [https://builds.apache.org/job/Cocoon-trunk/166/]) [COCOON3-96] Sitemap extended for handling internal-only pipelines; samples updated (Revision 1308984) Result = SUCCESS ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1308984 Files : * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/AbstractPipeline.java * /cocoon/cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/Pipeline.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/overview.html * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-sitemap/pom.xml * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/InvocationImpl.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd Add support for internal-only pipelines - Key: COCOON3-96 URL: https://issues.apache.org/jira/browse/COCOON3-96 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Cocoon 2.1 [1] and 2.2 [2] used to have support for internal-only pipelines, i.e. pipelines evaulated for internal (i.e. cocoon:/) requests only. Such feature would be very useful in C3 as well, of course replacing cocoon:/ with servlet:/ [1] http://cocoon.apache.org/2.1/faq/faq-sitemap.html [2] http://cocoon.apache.org/2.2/core-modules/core/2.2/835_1_1.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245471#comment-13245471 ] Thorsten Scherler commented on COCOON3-95: -- Committed revision 1309027. cocoon3-95.txt Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, cocoon3-95.txt, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245507#comment-13245507 ] Hudson commented on COCOON3-95: --- Integrated in Cocoon-trunk #167 (See [https://builds.apache.org/job/Cocoon-trunk/167/]) FIxing sitemap xsd since act can have now a src attribute cocoon3-95. Patch submitted by Leonardo Miceli. (Revision 1309027) Result = SUCCESS Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: SitemapBuilder-COCOON-95.diff, cocoon3-95.txt, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-96) Add support for internal-only pipelines
[ https://issues.apache.org/jira/browse/COCOON3-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245561#comment-13245561 ] Simone Tripodi commented on COCOON3-96: --- Hi Grosso! well done and thanks for taking care! just a request: can we move the {{isInternalOnly}} detail outside the Pipeline APIs? I mean, that is a method needed in the sitemap, while Pipeline APis have to be work as a library also outside Cocoon, it doesn't make a lot of sense to users - like me (blush) - that are focused on the lower level library only. How those kind of users should interpret it, outside the Cocoon product? TIA -Simo Add support for internal-only pipelines - Key: COCOON3-96 URL: https://issues.apache.org/jira/browse/COCOON3-96 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Cocoon 2.1 [1] and 2.2 [2] used to have support for internal-only pipelines, i.e. pipelines evaulated for internal (i.e. cocoon:/) requests only. Such feature would be very useful in C3 as well, of course replacing cocoon:/ with servlet:/ [1] http://cocoon.apache.org/2.1/faq/faq-sitemap.html [2] http://cocoon.apache.org/2.2/core-modules/core/2.2/835_1_1.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244826#comment-13244826 ] Javier Puerto commented on COCOON3-95: -- Samples block sitemap file doesn't validate against the schema. Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: SitemapBuilder-COCOON-95.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-95) Sitemap file not validated against schema
[ https://issues.apache.org/jira/browse/COCOON3-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244857#comment-13244857 ] Javier Puerto commented on COCOON3-95: -- Sitemap builder now validates sitemap files against the schema. A simple caching was added to avoid unnecessary validations. Sitemap file not validated against schema - Key: COCOON3-95 URL: https://issues.apache.org/jira/browse/COCOON3-95 Project: Cocoon 3 Issue Type: Bug Components: cocoon-general Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Attachments: SitemapBuilder-COCOON-95.diff, sitemap-schema.diff, sitemap-validation.tar.gz http://cocoon.markmail.org/thread/cq6nrzy5xladcuys Summary: Lars Huttar found that his sitemap declaration was not working as expected. Some matchers worked an others not. Finally the problem was a matcher tag not inside a pipeline tag. Attached is a block to reproduce the problem, I just review the SitemapBuilder class and there's not validation at all against a schema. So if the sitemap.xmap file is a XML well formed, C3 will not throw any error about. The ugly issue is that C3 is returning a HTTP status code of 200 instead of a code 500 and also the exception in the log is not very helpful, NullPointerException. I think that we should validate the sitemap file or at least response with the right HTTP status code and better error information in this case. We can do something like we have already for the SchemaProcessorTransformer, using the caching to avoid unnecessary processing. The schema file path is trunk/cocoon-sitemap/src/main/resources/cocoon-sitemap-1.0.xsd. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-94) Extend Action to allow to use @src and parameter from within the sitemap
[ https://issues.apache.org/jira/browse/COCOON3-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236791#comment-13236791 ] Hudson commented on COCOON3-94: --- Integrated in Cocoon-trunk #160 (See [https://builds.apache.org/job/Cocoon-trunk/160/]) COCOON3-94 Bring back old school way of actions back to c3. Although it is not 100% like we had in c2.x since the body of an action ATM is ignore. (Revision 1304459) Result = FAILURE thorsten : http://svn.apache.org/viewvc/?view=revrev=1304459 Files : * /cocoon/cocoon3/trunk/cocoon-sample/src/main/java/org/apache/cocoon/sample/action/ErrorThrowingAction.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/Invocation.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/InvocationImpl.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/action/Action.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/ActNode.java Extend Action to allow to use @src and parameter from within the sitemap Key: COCOON3-94 URL: https://issues.apache.org/jira/browse/COCOON3-94 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Thorsten Scherler Priority: Critical Fix For: 3.0.0-beta-1 In cocoon 2.x you can use the src attribute and further use map:parameter to configure an action. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-93) Concurrency issues with ComponentProvider
[ https://issues.apache.org/jira/browse/COCOON3-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230079#comment-13230079 ] Thorsten Scherler commented on COCOON3-93: -- I applied the patch in revision 1300923 even if we still discuss it since it fixes the concurrency problem in our customer app. Concurrency issues with ComponentProvider - Key: COCOON3-93 URL: https://issues.apache.org/jira/browse/COCOON3-93 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Labels: patch Attachments: SpringComponentProvider.diff, concurrency.tar.gz http://cocoon.markmail.org/thread/3kgfye55zxavikwo we are working in a project based on C3 and we found a strange behaviour when loading the static resources. We are developing a Web 2.0 application and therefore we have a lot of resources (js, images and css). The weird thing is that sometimes the system is returning the wrong resources, returning a js instead of a css or switching images... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-93) Concurrency issues with ComponentProvider
[ https://issues.apache.org/jira/browse/COCOON3-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230101#comment-13230101 ] Hudson commented on COCOON3-93: --- Integrated in Cocoon-trunk #152 (See [https://builds.apache.org/job/Cocoon-trunk/152/]) COCOON3-93 Applying patch to fix concurrency problems. The patch is still under discussion so this commit may be reverted in the future. Reporter/Patch: Javier Puerto Gracias Javier. (Revision 1300923) Result = SUCCESS thorsten : http://svn.apache.org/viewvc/?view=revrev=1300923 Files : * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/SpringComponentProvider.java Concurrency issues with ComponentProvider - Key: COCOON3-93 URL: https://issues.apache.org/jira/browse/COCOON3-93 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Javier Puerto Labels: patch Attachments: SpringComponentProvider.diff, concurrency.tar.gz http://cocoon.markmail.org/thread/3kgfye55zxavikwo we are working in a project based on C3 and we found a strange behaviour when loading the static resources. We are developing a Web 2.0 application and therefore we have a lot of resources (js, images and css). The weird thing is that sometimes the system is returning the wrong resources, returning a js instead of a css or switching images... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-91) Migrate CalendarGenerator
[ https://issues.apache.org/jira/browse/COCOON3-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224902#comment-13224902 ] Hudson commented on COCOON3-91: --- Integrated in Cocoon-trunk #147 (See [https://builds.apache.org/job/Cocoon-trunk/147/]) COCOON3-91 Migrate CalendarGenerator It is basically the same as in c2.2 but cache key is implemented c3 style. Add a small bugfix/feature that weekdays are as well locale and not static as before. Adding as well basic functional test. (Revision 1298246) Result = SUCCESS thorsten : http://svn.apache.org/viewvc/?view=revrev=1298246 Files : * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/calendar * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/calendar/CalendarGenerator.java * /cocoon/cocoon3/trunk/cocoon-optional/src/main/resources/META-INF/cocoon/spring-optional/cocoon-optional-generators.xml * /cocoon/cocoon3/trunk/cocoon-optional/src/test/java/org/apache/cocoon/optional/pipeline/components/sax/calendar * /cocoon/cocoon3/trunk/cocoon-optional/src/test/java/org/apache/cocoon/optional/pipeline/components/sax/calendar/CalendarGeneratorTest.java Migrate CalendarGenerator - Key: COCOON3-91 URL: https://issues.apache.org/jira/browse/COCOON3-91 Project: Cocoon 3 Issue Type: New Feature Components: cocoon-optional Affects Versions: 3.0.0-beta-1 Reporter: Thorsten Scherler Assignee: Thorsten Scherler Priority: Trivial Fix For: 3.0.0-beta-1 https://svn.apache.org/repos/asf/cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/CalendarGenerator.java migrate it for c3 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-89) Add feature to limit invalid login attempts
[ https://issues.apache.org/jira/browse/COCOON3-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207709#comment-13207709 ] Ajay Deshwal commented on COCOON3-89: - Thanks you Add feature to limit invalid login attempts --- Key: COCOON3-89 URL: https://issues.apache.org/jira/browse/COCOON3-89 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-shiro Affects Versions: 3.0.0-beta-1 Reporter: Ajay Deshwal Assignee: Thorsten Scherler Attachments: COCOON3-89.patch, COCOON3-89.patch cocoon-shiro module should provide: 1) Feature to record invalid login attempts count. On exceeding the predefined maximum allowed attempts, its should flag the state that maximum login attempts exceeded. 2) A method in AbstractShiroLogin class to validate some data, which extending classes can implement and will be invoked prior to initiating actual login, like captcha etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-89) Add feature to limit invalid login attempts
[ https://issues.apache.org/jira/browse/COCOON3-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207727#comment-13207727 ] Hudson commented on COCOON3-89: --- Integrated in Cocoon-trunk #140 (See [https://builds.apache.org/job/Cocoon-trunk/140/]) COCOON3-89 Reporter: Ajay Deshwal Add feature to limit invalid login attempts Thanks Ajay for your patch (Revision 1243917) Result = SUCCESS thorsten : http://svn.apache.org/viewvc/?view=revrev=1243917 Files : * /cocoon/cocoon3/trunk/cocoon-shiro-sample/src/main/java/org/apache/cocoon/shiro/sample/rest/LoginUser.java * /cocoon/cocoon3/trunk/cocoon-shiro/src/main/java/org/apache/cocoon/shiro/rest/AbstractShiroLogin.java Add feature to limit invalid login attempts --- Key: COCOON3-89 URL: https://issues.apache.org/jira/browse/COCOON3-89 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-shiro Affects Versions: 3.0.0-beta-1 Reporter: Ajay Deshwal Assignee: Thorsten Scherler Attachments: COCOON3-89.patch, COCOON3-89.patch cocoon-shiro module should provide: 1) Feature to record invalid login attempts count. On exceeding the predefined maximum allowed attempts, its should flag the state that maximum login attempts exceeded. 2) A method in AbstractShiroLogin class to validate some data, which extending classes can implement and will be invoked prior to initiating actual login, like captcha etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-90) Migrate CSVGenerator
[ https://issues.apache.org/jira/browse/COCOON3-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207728#comment-13207728 ] Hudson commented on COCOON3-90: --- Integrated in Cocoon-trunk #140 (See [https://builds.apache.org/job/Cocoon-trunk/140/]) COCOON3-90 Migrating CSVGenerator fom 2.2 to c3. Extending the generator to work as well with string input and not only with url. Adding basic test case. (Revision 1243911) Result = SUCCESS thorsten : http://svn.apache.org/viewvc/?view=revrev=1243911 Files : * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/csv * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/optional/pipeline/components/sax/csv/CSVGenerator.java * /cocoon/cocoon3/trunk/cocoon-optional/src/main/java/org/apache/cocoon/pipeline/components/parameters/Parameters.java * /cocoon/cocoon3/trunk/cocoon-optional/src/main/resources/META-INF/cocoon/spring-optional/cocoon-optional-generators.xml * /cocoon/cocoon3/trunk/cocoon-optional/src/test/java/org/apache/cocoon/optional/pipeline/components/sax/csv * /cocoon/cocoon3/trunk/cocoon-optional/src/test/java/org/apache/cocoon/optional/pipeline/components/sax/csv/CSVGeneratorTest.java Migrate CSVGenerator Key: COCOON3-90 URL: https://issues.apache.org/jira/browse/COCOON3-90 Project: Cocoon 3 Issue Type: New Feature Components: cocoon-optional Affects Versions: 3.0.0-beta-1 Reporter: Thorsten Scherler Assignee: Thorsten Scherler Fix For: 3.0.0-beta-1 Please migrate the http://cocoon.apache.org/2.1/apidocs/org/apache/cocoon/generation/CSVGenerator.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-87) Update Cocoon to be OSGi compliant
[ https://issues.apache.org/jira/browse/COCOON3-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181371#comment-13181371 ] Jean-Baptiste Onofré commented on COCOON3-87: - This first patch turns Cocoon modules as OSGi bundles. I will submit a set of new patches including: - new bundles definition for Cocoon modules - Karaf features descriptor - some fix around the cocoon-maven-plugin - some checkstyle fix in the POM - better usage of OSGi using services Update Cocoon to be OSGi compliant -- Key: COCOON3-87 URL: https://issues.apache.org/jira/browse/COCOON3-87 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-controller, cocoon-databases, cocoon-monitoring, cocoon-pipeline, cocoon-profiling, cocoon-rest, cocoon-sax, cocoon-servlet, cocoon-shiro, cocoon-sitemap, cocoon-stax, cocoon-stringtemplate, cocoon-util, cocoon-webapp, cocoon-wicket Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Attachments: COCOON3-87.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-86) Migrate to latest Wicket 1.5
[ https://issues.apache.org/jira/browse/COCOON3-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178706#comment-13178706 ] Hudson commented on COCOON3-86: --- Integrated in Cocoon-trunk #127 (See [https://builds.apache.org/job/Cocoon-trunk/127/]) COCOON3-86 ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1226743 Files : * /cocoon/cocoon3/trunk/cocoon-archetype-block/src/main/resources/archetype-resources/pom.xml * /cocoon/cocoon3/trunk/cocoon-sample-webapp/src/test/java/org/apache/cocoon/it/CocoonHtmlUnitTestCase.java * /cocoon/cocoon3/trunk/cocoon-sample-webapp/src/test/java/org/apache/cocoon/it/WicketTest.java * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/java/org/apache/cocoon/sample/wicket/CocoonSAXPipeline.java * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/java/org/apache/cocoon/sample/wicket/CocoonWicketSampleReloadingWicketFilter.java * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/java/org/apache/cocoon/sample/wicket/CocoonWicketSampleWebApplication.java * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/java/org/apache/cocoon/sample/wicket/Homepage.html * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/java/org/apache/cocoon/sample/wicket/Homepage.java * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/webapp/WEB-INF/applicationContext.xml * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/webapp/WEB-INF/web.xml * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/webapp/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-sample-wicket-webapp/src/main/webapp/sitemap.xmap.xml * /cocoon/cocoon3/trunk/cocoon-sample/pom.xml * /cocoon/cocoon3/trunk/cocoon-sample/src/main/java/org/apache/cocoon/sample/wicket/CocoonSampleWicketWebapp.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/java/org/apache/cocoon/sample/wicket/HelloWicketPage.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/java/org/apache/cocoon/sample/wicket/OtherPage.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/read/favicon.ico * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-wicket/pom.xml * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/markup * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/markup/html * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/markup/html/CocoonSAXPipelineComponent.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/request * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/request/CocoonSitemapRequestHandler.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/request/CocoonSitemapRequestMapper.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/request/CocoonWicketRequestWrapper.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/request/CocoonWicketRuntimeException.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/sitemap/CocoonWicketHttpServletResponse.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/sitemap/CocoonWicketServletContext.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/sitemap/WicketReader.java * /cocoon/cocoon3/trunk/cocoon-wicket/src/main/java/org/apache/cocoon/wicket/target * /cocoon/cocoon3/trunk/parent/pom.xml Migrate to latest Wicket 1.5 Key: COCOON3-86 URL: https://issues.apache.org/jira/browse/COCOON3-86 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sample, cocoon-sample-webapp, cocoon-wicket Affects Versions: 3.0.0-alpha-3 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Follow directions in https://cwiki.apache.org/WICKET/migration-to-wicket-15.html. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177200#comment-13177200 ] Francesco Chicchiriccò commented on COCOON3-85: --- @Thorsten I've just tried to reproduce the issue with StringTemplate generator with no luck: no my laptop (Linux 3.1 64bit / OpenJDK 6.0.23) it runs smoothly. cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-alpha-1, 3.0.0-alpha-2, 3.0.0-alpha-3, 3.0.0-beta-1 Reporter: Igor Malinin Fix For: 3.0.0-beta-1 Attachments: java.patch As reported at first in mailing list [1], AspectJ's static optimizer was reviewed starting from 1.6.7 onward. A temporary workaround for this is to force usage of version 1.6.6 of AspectJ (quite ancient right now). At the moment Cocoon 3 is using latest Spring (3.1) and AspectJ (1.6.12) versions. With Spring 3.1, this workaround is not enough any more. One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) [1] http://old.nabble.com/Jetty-7---%22can%27t-determine-modifiers-of-missing-type-org.eclipse.jetty.webapp.WebAppContext$Context%22-error-td32314839.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177216#comment-13177216 ] Thorsten Scherler commented on COCOON3-85: -- I am At revision 1225548. uname -rios Linux 3.0.0-14-generic x86_64 GNU/Linux java -version java version 1.6.0_25 Java(TM) SE Runtime Environment (build 1.6.0_25-b06) Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode) c3/cocoon-sample$ mvn clean install jetty:run now works, weird seems the clean did the trick, sorry for the noise and thanks for testing. cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-alpha-1, 3.0.0-alpha-2, 3.0.0-alpha-3, 3.0.0-beta-1 Reporter: Igor Malinin Fix For: 3.0.0-beta-1 Attachments: java.patch As reported at first in mailing list [1], AspectJ's static optimizer was reviewed starting from 1.6.7 onward. A temporary workaround for this is to force usage of version 1.6.6 of AspectJ (quite ancient right now). At the moment Cocoon 3 is using latest Spring (3.1) and AspectJ (1.6.12) versions. With Spring 3.1, this workaround is not enough any more. One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) [1] http://old.nabble.com/Jetty-7---%22can%27t-determine-modifiers-of-missing-type-org.eclipse.jetty.webapp.WebAppContext$Context%22-error-td32314839.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177189#comment-13177189 ] Thorsten Scherler commented on COCOON3-85: -- Actually @Francesco r1224754 broke the Stringtemplate example, meaning it seems that everything is fine but in runtime that is not like that any more. It seems as Igor described a problem of the class loader. Not sure though whether it is fault of the RCL or the configurator, but I will try now to apply the patch on my system and look whether that solves the problem. To reproduce, * just mvn clean install current Head * cd cocoon-sample * mvn jetty:run * http://localhost:/string-template/generator - BANG! {{{ 2011-12-29 15:08:16.138:INFO:/:Initializing Spring root WebApplicationContext 2011-12-29 15:08:19.347:INFO:/:Apache Cocoon Spring Configurator v2.1.0 is running in mode 'dev'. 2011-12-29 15:08:23.468:INFO:/:DispatcherServlet: Block dispatcher was initialized successfully. 2011-12-29 15:08:23.581:INFO::Started SelectChannelConnector@0.0.0.0: [INFO] Started Jetty Server 2011-12-29 15:08:35.365:INFO:/:Apache Cocoon Spring Configurator v2.1.0 is running in mode 'dev'. java.lang.Error: Unresolved compilation problem: STRenderer cannot be resolved at org.apache.cocoon.stringtemplate.StringTemplateGenerator.renderTemplate(StringTemplateGenerator.java:152) at org.apache.cocoon.stringtemplate.StringTemplateGenerator.execute(StringTemplateGenerator.java:172) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:91) at org.apache.cocoon.profiling.aspects.InvocationDispatcher.dispatch(InvocationDispatcher.java:68) at org.apache.cocoon.profiling.aspects.PipelineComponentProfilingAspect.handleInvocation(PipelineComponentProfilingAspect.java:41) at sun.reflect.GeneratedMethodAccessor73.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621) at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:610) at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:65) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:90) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202) at $Proxy46.execute(Unknown Source) at org.apache.cocoon.pipeline.AbstractPipeline.invokeStarter(AbstractPipeline.java:150) at org.apache.cocoon.pipeline.AbstractPipeline.execute(AbstractPipeline.java:80) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:318) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:80) at org.apache.cocoon.servlet.collector.ResponseHeaderCollector.interceptInvoke(ResponseHeaderCollector.java:94) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
[jira] [Commented] (COCOON3-69) Replace the logging framework with SLF4J + Logback
[ https://issues.apache.org/jira/browse/COCOON3-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176124#comment-13176124 ] Francesco Chicchiriccò commented on COCOON3-69: --- I am waiting to complete this after Subversion reorganization [1]. [1] http://old.nabble.com/Re%3A--C3--Import-subprojects-proposal--WAS%3A-Re%3A--c3--Log4j-injection-in-target-of-blocks--td32880500.html Replace the logging framework with SLF4J + Logback -- Key: COCOON3-69 URL: https://issues.apache.org/jira/browse/COCOON3-69 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-controller, cocoon-monitoring, cocoon-optional, cocoon-pipeline, cocoon-profiling, cocoon-rest, cocoon-sample, cocoon-sample-webapp, cocoon-sax, cocoon-servlet, cocoon-sitemap, cocoon-stax, cocoon-stringtemplate Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò See the mail thread on dev ML at http://comments.gmane.org/gmane.text.xml.cocoon.devel/81149. Be also sure to check http://pmd.sourceforge.net/rules/logging-java.html, otherwise Sonar will blame Cocoon code's quality even more ;-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176121#comment-13176121 ] Francesco Chicchiriccò commented on COCOON3-85: --- After re-reading the thread in mailing list, I now (finally :-P) understand your point. For this reason I have modified a bit this issue's title and description. Since we need to apply your patch (and possibly one of the alternatives considered in mailing list in the original thread [1]) to Cocoon subprojects (cocoon-spring-configurator) outside of Cocoon 3 own sources, I think we will also have to wait for proposed Subversion reorganization [2] so that SNAPSHOT artifacts will be regularly published for these subprojects as well. [2] http://old.nabble.com/Re%3A--C3--Import-subprojects-proposal--WAS%3A-Re%3A--c3--Log4j-injection-in-target-of-blocks--td32880500.html cocoon-spring-configurator doesn't work with latest ( 1.6.6) AspectJ's static optimizer Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-alpha-1, 3.0.0-alpha-2, 3.0.0-alpha-3, 3.0.0-beta-1 Reporter: Igor Malinin Fix For: 3.0.0-beta-1 Attachments: java.patch As reported at first in mailing list [1], AspectJ's static optimizer was reviewed starting from 1.6.7 onward. A temporary workaround for this is to force usage of version 1.6.6 of AspectJ (quite ancient right now). At the moment Cocoon 3 is using latest Spring (3.1) and AspectJ (1.6.12) versions. With Spring 3.1, this workaround is not enough any more. One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) [1] http://old.nabble.com/Jetty-7---%22can%27t-determine-modifiers-of-missing-type-org.eclipse.jetty.webapp.WebAppContext$Context%22-error-td32314839.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-84) Add remeber-me feature in cocoon-shiro module
[ https://issues.apache.org/jira/browse/COCOON3-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176114#comment-13176114 ] Ajay Deshwal commented on COCOON3-84: - Thank you Thorsten for prompt response. Add remeber-me feature in cocoon-shiro module - Key: COCOON3-84 URL: https://issues.apache.org/jira/browse/COCOON3-84 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-shiro Affects Versions: 3.0.0-beta-1 Reporter: Ajay Deshwal Assignee: Thorsten Scherler Fix For: 3.0.0-beta-1 Attachments: COCOON3-84.patch cocoon-shiro module should provide feature to remember authenticating user. A remembered identity gives the system an idea who that person probably is, but in reality, has no way of guaranteeing the remembered identity really is that user. According to shiro docs: Shiro follows same paradigm as all over the web. for eg: When you visit Amazon.com and perform a login and ask it to 'remember me', it will set a cookie with your identity. If you don't log out and your session expires, and you come back, say the next day, Amazon still knows who you probably are: you still see all of your book and movie recommendations and similar user-specific features since these are based on your (remembered) user id. Some facts worth remembering about Shiro's remember me feature: if in filter chain definitons we set: /myurl=authc User has to authenticate no matter user had enabled remember-me in previous session. /myurl=roles[USER] User will be granted access if user had enabled remember-me in previous session(Assuming USER role has been assigned to requesting user). Now, when writing your own webapp, whether you use the authc filter or simply depend on if the user is remembered is entirely up to you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-64) i18n support
[ https://issues.apache.org/jira/browse/COCOON3-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176450#comment-13176450 ] Hudson commented on COCOON3-64: --- Integrated in Cocoon-trunk #121 (See [https://builds.apache.org/job/Cocoon-trunk/121/]) COCOON3-64 Fixing parameter replacement for keys defined in resource bundle. thorsten : http://svn.apache.org/viewvc/?view=revrev=1225089 Files : * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/I18nTransformer.java i18n support Key: COCOON3-64 URL: https://issues.apache.org/jira/browse/COCOON3-64 Project: Cocoon 3 Issue Type: New Feature Components: cocoon-pipeline, cocoon-sax, cocoon-servlet, cocoon-sitemap Affects Versions: 3.0.0-alpha-3 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Cocoon 3 would take benefit from having a complete i18n support, possibly porting the 2.1 I18NTransformer. We would also need some sitemap, pipeline and servlet integration and, of course, an overlook should also be considered towards the cocoon-wicket integration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-79) Sitemap parameters are always cast to String
[ https://issues.apache.org/jira/browse/COCOON3-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176451#comment-13176451 ] Hudson commented on COCOON3-79: --- Integrated in Cocoon-trunk #121 (See [https://builds.apache.org/job/Cocoon-trunk/121/]) Due to COCOON3-79 the sitemap parameters are not anymore only String but object, so droping test of type and removing test about illegeal invocation. thorsten : http://svn.apache.org/viewvc/?view=revrev=1225090 Files : * /cocoon/cocoon3/trunk/cocoon-rest/src/main/java/org/apache/cocoon/rest/controller/SpringRESTController.java * /cocoon/cocoon3/trunk/cocoon-rest/src/test/java/org/apache/cocoon/rest/controller/SpringRESTControllerTest.java Sitemap parameters are always cast to String Key: COCOON3-79 URL: https://issues.apache.org/jira/browse/COCOON3-79 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: COCOON3-79.patch Sitemap parameters are cast to String when passed to actual sitemap components: this can cause troubles when the actual original object needs to be accessed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with Spring 3.1
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175984#comment-13175984 ] Francesco Chicchiriccò commented on COCOON3-85: --- I have committed today some version updates in C3 sources (including Spring 3.1). I have forked your GitHub project at git://github.com/ilgrosso/cocoon-springification.git You can test my fork by: # git clone git://github.com/ilgrosso/cocoon-springification.git # cd cocoon-springification # mvn clean install # cd webapp At this point you can choose which JEE container to run with: # mvn -P cargo.jetty6x or # mvn -P cargo.tomcat7x or # mvn -P cargo.jetty7x or # mvn -P cargo.jetty8x Without applying your patch, Jetty 6 and Tomcat 7 run fine, Jetty 7 and Jetty 8 fail with stacktrace you reported above, so I think this is more a Jetty (7 and 8) issue than C3's. cocoon-spring-configurator doesn't work with Spring 3.1 --- Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Igor Malinin Priority: Critical Attachments: java.patch There are several issues that prevent Cocoon 3 to work with Spring 3.1 One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with Spring 3.1
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176054#comment-13176054 ] Igor Malinin commented on COCOON3-85: - I explained some time ago the roots of the problem on cocoon-dev mailing list (http://old.nabble.com/Jetty-7---%22can't-determine-modifiers-of-missing-type-org.eclipse.jetty.webapp.WebAppContext$Context%22-error-td32314839.html), and those are in no way Jetty problem, but the Cocoon! Jetty is OSGi container and it isolates class loaders. This is perfectly legal and is not in any violation of Servlet specs. C3 defines a BeanFactory for ServletContext and then tries to apply AspectJ pointcuts over it, but AspectJ optimizer fails because it cannot see the Jetty's implementation of ServletContext. Before Spring 3.1 it was possible to workaround it by using old AspectJ versions (they are without optimizer), but with Spring 3.1 - it doesn't help. As more and more containers are switching to OSGi (or other similar component isolation models) you can expect Cocoon to fail on more and more containers... Jetty 6 is so ancient already that pointing to it for new developments is just irrelevant... It works there only by accident. You can claim that AspectJ is the problem, but they declared it clearly that they will not fix it, at leas soon, as this requires serious redesign of its optimizer. cocoon-spring-configurator doesn't work with Spring 3.1 --- Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Igor Malinin Priority: Critical Attachments: java.patch There are several issues that prevent Cocoon 3 to work with Spring 3.1 One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with Spring 3.1
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175746#comment-13175746 ] Francesco Chicchiriccò commented on COCOON3-85: --- What is your use case? I've just tried to replace spring.version3.0.7.RELEASE/spring.version with spring.version3.1.0.RELEASE/spring.version in parent/pom.xml, then launched it.sh and all went fine. cocoon-spring-configurator doesn't work with Spring 3.1 --- Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Igor Malinin Priority: Critical Attachments: java.patch There are several issues that prevent Cocoon 3 to work with Spring 3.1 One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with Spring 3.1
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175747#comment-13175747 ] Igor Malinin commented on COCOON3-85: - Hmm... Probably this is because I am using AspectJ 1.6.6 (newer versions break Cocoon on Jetty7+ because of ServletContextFactoryBean is not synthetic). I'll try to get a stack trace for this and update my sample app so that you can reproduce it. cocoon-spring-configurator doesn't work with Spring 3.1 --- Key: COCOON3-85 URL: https://issues.apache.org/jira/browse/COCOON3-85 Project: Cocoon 3 Issue Type: Bug Components: cocoon-servlet Affects Versions: 3.0.0-beta-1 Reporter: Igor Malinin Priority: Critical Attachments: java.patch There are several issues that prevent Cocoon 3 to work with Spring 3.1 One issue I reported already in mailing list when Jetty7 + recent AspectJ was failing, not the same issue is deeper and ServletContextFactoryBean doesn't work at all with Spring 3.1. Note that ServletContext is already in the Spring web-app context, although with another name ('servletContext'). This is available starting from Spring 3.0. Making an alias 'javax.servlet.ServletContext' - 'servletContext' solves problem partially, but still fails on XMLSitemapServlet initialization (as it uses static field in ServletContextFactoryBean). I will attach a patch (a little bit dirty, but not more than the current implementation). But it assumes at least Spring 3.0. As Cocoon 3 project is moved to Java 1.6, it is probably also worth to have as a dependency at leas 3.0 version of Spring Framework (for Java5 generics etc.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-85) cocoon-spring-configurator doesn't work with Spring 3.1
[ https://issues.apache.org/jira/browse/COCOON3-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175749#comment-13175749 ] Igor Malinin commented on COCOON3-85: - To reproduce: # git clone git://github.com/igorzep/cocoon-springification.git # cd cocoon-springification # mvn clean install # cd webapp # mvn jetty:run-web Long exception trace... Switch Spring version back to 3.0.7 in top-level pom - everything works as expected. The trace is: 2011-12-24 19:36:37.337:WARN::Failed startup of context JettyWebAppContext@56c492c8@56c492c8/,file:/W:/workspaces/agentler/clone/cocoon-springification/webapp/target/tmp/webapp/,W:\workspaces\agentler\clone\cocoon-springification\webapp\target\cocoon-springification-webapp-0.1-SNAPSHOT.war org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.apache.cocoon.blockdeployment.BlockResourcesHolder' defined in URL [jar:file:/W:/workspaces/agentler/clone/cocoon-springification/webapp/target/tmp/webapp/WEB-INF/lib/cocoon-block-deployment-1.1.0.jar!/META-INF/cocoon/spring/cocoon-blockdeployment-resourcesholder.xml]: Cannot resolve reference to bean 'javax.servlet.ServletContext' while setting bean property 'servletContext'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'javax.servlet.ServletContext': Post-processing of the FactoryBean's object failed; nested exception is java.lang.IllegalArgumentException: warning no match for this type name: org.apache.cocoon.sitemap.node.SerializeNode [Xlint:invalidAbsoluteTypeName] at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:328) at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:106) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1360) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1118) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:517) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:456) at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:294) at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:225) at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:291) at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:193) at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:585) at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:913) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:464) at org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:384) at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:283) at org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:111) at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:643) at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:189) at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:913) at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:584) at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:341) at org.mortbay.jetty.plugin.JettyWebAppContext.doStart(JettyWebAppContext.java:102) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:55) at org.eclipse.jetty.server.handler.HandlerCollection.doStart(HandlerCollection.java:164) at org.eclipse.jetty.server.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:161) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:55) at org.eclipse.jetty.server.handler.HandlerCollection.doStart(HandlerCollection.java:164) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:55
[jira] [Commented] (COCOON3-84) Add remeber-me feature in cocoon-shiro module
[ https://issues.apache.org/jira/browse/COCOON3-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175504#comment-13175504 ] Hudson commented on COCOON3-84: --- Integrated in Cocoon-trunk #116 (See [https://builds.apache.org/job/Cocoon-trunk/116/]) COCOON3-84 Add remeber-me feature in cocoon-shiro module Reporter/Patch: Ajay Deshwal As a remark plese the issue for explanation how to use it. Thanks adeshwal at becompany dot ch thorsten : http://svn.apache.org/viewvc/?view=revrev=1222722 Files : * /cocoon/cocoon3/trunk/cocoon-shiro/src/main/java/org/apache/cocoon/shiro/rest/AbstractShiroLogin.java Add remeber-me feature in cocoon-shiro module - Key: COCOON3-84 URL: https://issues.apache.org/jira/browse/COCOON3-84 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-shiro Affects Versions: 3.0.0-beta-1 Reporter: Ajay Deshwal Assignee: Thorsten Scherler Fix For: 3.0.0-beta-1 Attachments: COCOON3-84.patch cocoon-shiro module should provide feature to remember authenticating user. A remembered identity gives the system an idea who that person probably is, but in reality, has no way of guaranteeing the remembered identity really is that user. According to shiro docs: Shiro follows same paradigm as all over the web. for eg: When you visit Amazon.com and perform a login and ask it to 'remember me', it will set a cookie with your identity. If you don't log out and your session expires, and you come back, say the next day, Amazon still knows who you probably are: you still see all of your book and movie recommendations and similar user-specific features since these are based on your (remembered) user id. Some facts worth remembering about Shiro's remember me feature: if in filter chain definitons we set: /myurl=authc User has to authenticate no matter user had enabled remember-me in previous session. /myurl=roles[USER] User will be granted access if user had enabled remember-me in previous session(Assuming USER role has been assigned to requesting user). Now, when writing your own webapp, whether you use the authc filter or simply depend on if the user is remembered is entirely up to you. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-69) Replace the logging framework with SLF4J + Logback
[ https://issues.apache.org/jira/browse/COCOON3-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175612#comment-13175612 ] Igor Malinin commented on COCOON3-69: - Any plans of completing cocoon-spring-configurator part? The cocoon-spring-configurator - commons-logging - servlet-api:2.3 is killing me, it is transitive and spoiling classpath :( Replace the logging framework with SLF4J + Logback -- Key: COCOON3-69 URL: https://issues.apache.org/jira/browse/COCOON3-69 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-controller, cocoon-monitoring, cocoon-optional, cocoon-pipeline, cocoon-profiling, cocoon-rest, cocoon-sample, cocoon-sample-webapp, cocoon-sax, cocoon-servlet, cocoon-sitemap, cocoon-stax, cocoon-stringtemplate Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò See the mail thread on dev ML at http://comments.gmane.org/gmane.text.xml.cocoon.devel/81149. Be also sure to check http://pmd.sourceforge.net/rules/logging-java.html, otherwise Sonar will blame Cocoon code's quality even more ;-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-82) Allow Saxon to be used as a XSLT transformer
[ https://issues.apache.org/jira/browse/COCOON3-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168804#comment-13168804 ] Simone Tripodi commented on COCOON3-82: --- Having Saxon working in C3 would indeed awesome - I am not sure, due to Saxon license, any Saxon-based code can be included in Cocoon. Can you provide a patch to show the integration works? I made tests with XSLT-C just using the SPI pattern, by adding in the classpath {{META-INF/services/javax.xml.transform.TransformerFactory}} file containing the XSLT-C {{org.apache.xalan.xsltc.trax.TransformerFactoryImpl}} factory - it should work with Saxon as well, but it would be wonderful having the proof :) Allow Saxon to be used as a XSLT transformer Key: COCOON3-82 URL: https://issues.apache.org/jira/browse/COCOON3-82 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sax Affects Versions: 3.0.0-beta-1 Reporter: Huib Verweij In order to use XSLT 2.0 features (and beyond) in a XSLT transform I need to be able to use Saxon as a transformer. In C2.2 this could be done. There is a way of defining the transformer to be used in the system settings: -Djavax.xml.transform.TransformerFactory=net.sf.saxon.TransformerFactoryImpl. This might work, I am not sure, but then the choice of XSLT processor is gone - but that is perhaps not important? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-82) Allow Saxon to be used as a XSLT transformer
[ https://issues.apache.org/jira/browse/COCOON3-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169095#comment-13169095 ] David Crossley commented on COCOON3-82: --- Yes Saxon-HE would be okay. Subject: Re: [C3] Pipeline DSL Date: 2010-12-14 http://s.apache.org/gx Allow Saxon to be used as a XSLT transformer Key: COCOON3-82 URL: https://issues.apache.org/jira/browse/COCOON3-82 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-sax Affects Versions: 3.0.0-beta-1 Reporter: Huib Verweij In order to use XSLT 2.0 features (and beyond) in a XSLT transform I need to be able to use Saxon as a transformer. In C2.2 this could be done. There is a way of defining the transformer to be used in the system settings: -Djavax.xml.transform.TransformerFactory=net.sf.saxon.TransformerFactoryImpl. This might work, I am not sure, but then the choice of XSLT processor is gone - but that is perhaps not important? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-83) Encoding bug in XMLGenerator (SAX version) when passing a String to the constructor
[ https://issues.apache.org/jira/browse/COCOON3-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167455#comment-13167455 ] JBert commented on COCOON3-83: -- The problem would appear to be in the StringGenerator inner class, in version 3.0.0-alpha 3 the problem is on line 322: {code} XMLUtils.toSax(new ByteArrayInputStream(this.xmlString.getBytes()), XMLGenerator.this.getSAXConsumer()); {code} This encodes the String to bytes using the JRE platform encoding. A SAX parser will later have trouble parsing this bytestream when the XML declares an encoding different from the platform encoding. If I look at line 149, there's this: {code} XMLUtils.toSax(new String(this.bytes, this.encoding), XMLGenerator.this.getSAXConsumer()); {code} This issue could thus be fixed by simply passing the XML String into the toSax function, like so: {code} XMLUtils.toSax(this.xmlString, XMLGenerator.this.getSAXConsumer()); {code} Encoding bug in XMLGenerator (SAX version) when passing a String to the constructor --- Key: COCOON3-83 URL: https://issues.apache.org/jira/browse/COCOON3-83 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sax Affects Versions: 3.0.0-alpha-3 Reporter: JBert When creating a new org.apache.cocoon.sax.component.XMLGenerator instance with a String argument, the execute method will fail when the XML uses non-ASCII characters. See http://stackoverflow.com/a/8471886/983949 for more info with regards to the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-83) Encoding bug in XMLGenerator (SAX version) when passing a String to the constructor
[ https://issues.apache.org/jira/browse/COCOON3-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167483#comment-13167483 ] Hudson commented on COCOON3-83: --- Integrated in Cocoon-trunk #110 (See [https://builds.apache.org/job/Cocoon-trunk/110/]) COCOON3-83 #resolve ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1213207 Files : * /cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/XMLGenerator.java Encoding bug in XMLGenerator (SAX version) when passing a String to the constructor --- Key: COCOON3-83 URL: https://issues.apache.org/jira/browse/COCOON3-83 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sax Affects Versions: 3.0.0-alpha-3 Reporter: JBert Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 When creating a new org.apache.cocoon.sax.component.XMLGenerator instance with a String argument, the execute method will fail when the XML uses non-ASCII characters. See http://stackoverflow.com/a/8471886/983949 for more info with regards to the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144967#comment-13144967 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Locally New +++ Locally New @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cocoon.components.serializers.encoding; + +/** + * Encodes nothing. All characters are returned as they are. + * @author Andr#233; Juffer, Triacle Biocomputing + */ +public class TextEncoder extends XMLEncoder { + +private final static String ENCODING_NAME = X-W3C-TEXT; + +public TextEncoder() +{ +super(ENCODING_NAME); +} + +protected TextEncoder(String encodingName) +{ +super(encodingName); +} + +/** + * @return true (always) + */ +@Override +public boolean compile(char ch) +{ +return true; +} + +/** + * @return Original character in a character array. + */ +@Override +public char[] encode(char ch) +{ +char chs[] = { ch }; +return chs; +} + +} Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144968#comment-13144968 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Locally New +++ Locally New @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cocoon.components.serializers.util; + +import org.json.JSONObject; +import org.json.JSONException; + +import org.xml.sax.SAXException; +import org.xml.sax.Attributes; + +/** + * A text serializer for JSON. This serializer expects all JSON text to be enclosed by a + * single element. It also checks whether or not the received JSON text is valid. + * @author Andr#233; Juffer, Triacle Biocomputing + * + * @see a href=http://www.json.org/;JSON.org/a + */ +public class JsonSerializer extends TextSerializer { + +StringBuilder jsonString; +boolean element; + +public JsonSerializer() +throws Exception +{ +super(); +this.jsonString = new StringBuilder(); +this.element = false; +} + +@Override +public String getMimeType() +{ +return application/json; charset= + this.charset.getName(); +} + +@Override +public void characters(char[] chars, + int start, + int len) +throws SAXException +{ +if ( this.element ) +{ +String s = new String(chars, start, len); +this.jsonString.append(s); +} +super.characters(chars, start, len); +} + +@Override +public void startElement(String uri, + String localName, + String qName, + Attributes atts) +throws SAXException +{ +this.element = true; +super.startElement(uri, uri, uri, atts); + +} + +/** + * Validates JSON. + * @throws SAXException if JSON is invalid. + */ +@Override +public void endElement(String uri, + String localName, + String qName) +throws SAXException +{ +String s = this.jsonString.toString(); +try +{ +JSONObject jsonObject = new JSONObject(s); +} +catch (JSONException exception) +{ +throw new SAXException(s + : Invalid JSON., exception); +} +super.endElement(uri, localName, qName); +} + +@Override +public void recycle() +{ +this.jsonString = new StringBuilder(); +this.element = false; +super.recycle(); +} + + +@Override +public String toString() +{ +String newline = System.getProperty(line.separator); + +StringBuilder s = new StringBuilder(this.getClass().getName() + : [ + newline); +if ( this.charset != null ) +s.append(charset - ).append(this.charset.toString()); +if ( this.doctype != null ) +s.append().append(this.doctype.toString()).append(newline); +s.append(mime-type - ).append(this.getMimeType()).append(newline); +s.append(]).append(newline); + +return s.toString(); +} +} Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144969#comment-13144969 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Locally New +++ Locally New @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cocoon.components.serializers.util; + +import org.apache.cocoon.components.serializers.encoding.TextEncoder; +import org.apache.cocoon.components.serializers.encoding.XMLEncoder; + +import org.xml.sax.SAXException; +import org.xml.sax.Attributes; + +/** + * Converts XML into plain text. + * It omits all XML tags and writes only character events to the output. + * Input document must have at least one element - root element - which + * should wrap all the text inside it. + * + * @author Andr#233; Juffer, Triacle Biocomputing + */ +public class TextSerializer extends XMLSerializer { + +private static final XMLEncoder XML_ENCODER = new TextEncoder(); + +/* + * Set to true after first XML element + */ +private boolean hasRootElement; + +private final static String CHARSET = UTF-8; + +public TextSerializer() +throws Exception +{ +super(XML_ENCODER); +super.setEncoding(CHARSET); +this.hasRootElement = false; +} + +@Override +public void head() +{ +// Do nothing. +} + +@Override +public void startElement(String uri, + String loc, + String raw, + Attributes a) +throws SAXException +{ +this.hasRootElement = true; +} + +/** + * @throws SAXException if text is encountered before root element. + */ +@Override +public void characters(char c[], int start, int len) +throws SAXException +{ + if ( !this.hasRootElement ) +throw new SAXException(Encountered text before root element); + super.characters(c, start, len); +} + +@Override +public void recycle() +{ +this.hasRootElement = false; +super.recycle(); +} + +/** + * @return text/plain; charset= followed by character set, by default UTF-8 + */ +@Override +public String getMimeType() +{ +return(text/plain; charset= + this.charset.getName()); +} + +@Override +public void startElementImpl(String uri, + String local, + String qual, + String namespaces[][], + String attributes[][]) +throws SAXException +{ +// Do nothing. +} + +@Override +public void endElementImpl(String uri, + String local, + String qual) +throws SAXException +{ +// Do nothing. +} + + +@Override +public void charactersImpl(char[] chars, + int start, + int len) +throws SAXException +{ +super.encode(chars, start, len); +} + + +@Override +public void body(String uri, + String local, + String qual) +{ +// Do nothing. +} + +@Override +public void skippedEntity(String name) +throws SAXException +{ +// Do nothing. +} + +@Override +public void processingInstruction(String target, String data) +throws SAXException +{ +// Do nothing. +} + +@Override +public void ignorableWhitespace(char[] ch, +int start, +int length) +throws SAXException +{ +// Do nothing. +} + +@Override +public void comment(char[] ch, +int start, +int length
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144971#comment-13144971 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Locally New +++ Locally New @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cocoon.optional.servlet.components.sax.serializers; + +import org.apache.cocoon.components.serializers.util.TextSerializer; + +import org.apache.cocoon.optional.servlet.components.sax.serializers.util.ConfigurationUtils; +import org.apache.cocoon.sax.SAXPipelineComponent; +import org.apache.cocoon.pipeline.component.Finisher; +import org.apache.cocoon.sax.SAXConsumer; +import org.apache.cocoon.pipeline.component.CachingPipelineComponent; +import org.apache.cocoon.pipeline.caching.CacheKey; +import org.apache.cocoon.pipeline.caching.ParameterCacheKey; +import org.apache.cocoon.pipeline.SetupException; +import org.apache.cocoon.servlet.util.HttpContextHelper; + +import java.util.Map; +import java.io.OutputStream; +import java.io.IOException; +import java.io.UnsupportedEncodingException; + +/** + * pUsage in sitemap: + * pre + * lt;map:serialize type='text' /gt; + * /pre + * + * @author Andr#233; Juffer, Triacle Biocomputing + */ +public class EncodingTextSerializer extends TextSerializer +implements SAXPipelineComponent, Finisher, SAXConsumer, CachingPipelineComponent { + +private String encoding; +private int indent = 0; +private String omitXmlDeclaration; +private String docType; + +public EncodingTextSerializer() +throws Exception +{ +super(); +} + +@Override +public void setup(java.util.Mapjava.lang.String, java.lang.Object parameters) +{ +this.setup(HttpContextHelper.getRequest(parameters)); +} + +@Override +public void setConfiguration(MapString,? extends Object configuration) +{ +try { +this.encoding = ConfigurationUtils.getEncoding(configuration); +this.setEncoding(this.encoding); +} +catch (UnsupportedEncodingException exception) +{ + throw new SetupException(exception); + } + +try { +this.indent = ConfigurationUtils.getIndent(configuration); +this.setIndentPerLevel(this.indent); +} +catch (NumberFormatException exception) +{ +throw new SetupException(exception); +} + +this.omitXmlDeclaration = (String) configuration.get(omit-xml-declaration); +this.docType = (String) configuration.get(doctype-default); +} + +@Override +public void finish() +{ +// Do nothing. +} + +@Override +public String getContentType() +{ +return this.getMimeType(); +} + +public CacheKey constructCacheKey() +{ +ParameterCacheKey parameterCacheKey = new ParameterCacheKey(); +parameterCacheKey.addParameter(encoding, this.encoding); +parameterCacheKey.addParameter(indent, this.indent); +parameterCacheKey.addParameter(docType, this.docType); +parameterCacheKey.addParameter(omitXmlDeclaration, this.omitXmlDeclaration); +return parameterCacheKey; +} + +@Override +public void setOutputStream(OutputStream outputStream) +{ +try +{ +super.setOutputStream(outputStream); + } +catch (IOException exception) +{ +throw new SetupException(exception); + } +} + +@Override +public String toString() +{ +String newline = System.getProperty(line.separator); + +StringBuilder s = new StringBuilder(this.getClass().getName() + newline); +s.append(charset - ).append(this.charset).append(newline); +s.append(docType - ).append(this.docType).append(newline); +if ( this.doctype != null ) +s.append(doctype - ).append
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144970#comment-13144970 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Locally New +++ Locally New @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cocoon.optional.servlet.components.sax.serializers; + +import org.apache.cocoon.components.serializers.util.JsonSerializer; + +import org.apache.cocoon.optional.servlet.components.sax.serializers.util.ConfigurationUtils; +import org.apache.cocoon.sax.SAXPipelineComponent; +import org.apache.cocoon.pipeline.component.Finisher; +import org.apache.cocoon.sax.SAXConsumer; +import org.apache.cocoon.pipeline.component.CachingPipelineComponent; +import org.apache.cocoon.pipeline.caching.CacheKey; +import org.apache.cocoon.pipeline.caching.ParameterCacheKey; +import org.apache.cocoon.pipeline.SetupException; +import org.apache.cocoon.servlet.util.HttpContextHelper; + +import java.util.Map; +import java.io.OutputStream; +import java.io.IOException; +import java.io.UnsupportedEncodingException; +/** + * pUsage in sitemap: + * pre + * lt;map:serialize type='json' /gt; + * /pre + * + + * @author Andr#233; Juffer, Triacle Biocomputing + */ +public class EncodingJsonSerializer extends JsonSerializer +implements SAXPipelineComponent, Finisher, SAXConsumer, CachingPipelineComponent { + +private String encoding; +private int indent = 0; +private String omitXmlDeclaration; +private String docType; + +public EncodingJsonSerializer() +throws Exception +{ +super(); +} + +@Override +public void setup(java.util.Mapjava.lang.String, java.lang.Object parameters) +{ +this.setup(HttpContextHelper.getRequest(parameters)); +} + +@Override +public void setConfiguration(MapString,? extends Object configuration) +{ +try { +this.encoding = ConfigurationUtils.getEncoding(configuration); +this.setEncoding(this.encoding); +} +catch (UnsupportedEncodingException exception) +{ + throw new SetupException(exception); + } + +try { +this.indent = ConfigurationUtils.getIndent(configuration); +this.setIndentPerLevel(this.indent); +} +catch (NumberFormatException exception) +{ +throw new SetupException(exception); +} + +this.omitXmlDeclaration = (String) configuration.get(omit-xml-declaration); +this.docType = (String) configuration.get(doctype-default); +} + +@Override +public void finish() +{ +// Do nothing. +} + +@Override +public String getContentType() +{ +return this.getMimeType(); +} + +public CacheKey constructCacheKey() +{ +ParameterCacheKey parameterCacheKey = new ParameterCacheKey(); +parameterCacheKey.addParameter(encoding, this.encoding); +parameterCacheKey.addParameter(indent, this.indent); +parameterCacheKey.addParameter(docType, this.docType); +parameterCacheKey.addParameter(omitXmlDeclaration, this.omitXmlDeclaration); +return parameterCacheKey; +} + +@Override +public void setOutputStream(OutputStream outputStream) +{ +try +{ +super.setOutputStream(outputStream); + } +catch (IOException exception) +{ +throw new SetupException(exception); + } +} + +@Override +public String toString() +{ +String newline = System.getProperty(line.separator); + +StringBuilder s = new StringBuilder(this.getClass().getName() + newline); +s.append(charset - ).append(this.charset).append(newline); +s.append(docType - ).append(this.docType).append(newline); +if ( this.doctype != null ) +s.append(doctype - ).append
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144972#comment-13144972 ] Andre Juffer commented on COCOON3-77: - # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Base (BASE) +++ Locally Modified (Based On LOCAL) @@ -126,7 +126,16 @@ artifactIdjaxb-impl/artifactId optionaltrue/optional /dependency - +dependency +groupIdorg.apache.cocoon/groupId +artifactIdcocoon-serializers-charsets/artifactId +version1.0.0/version +/dependency +dependency +groupIdorg.json/groupId +artifactIdjson/artifactId +version20090211/version +/dependency !-- Test libraries -- dependency groupIdjunit/groupId Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144974#comment-13144974 ] Andre Juffer commented on COCOON3-77: - bean name=serializer:ehtml class=org.apache.cocoon.optional.servlet.components.sax.serializers.EncodingHTMLSerializer scope=prototype / + +bean name=serializer:text + class=org.apache.cocoon.optional.servlet.components.sax.serializers.EncodingTextSerializer + scope=prototype +/bean + +bean name=serializer:json + class=org.apache.cocoon.optional.servlet.components.sax.serializers.EncodingJsonSerializer + scope=prototype +/bean /beans Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-79) Sitemap parameters are always cast to String
[ https://issues.apache.org/jira/browse/COCOON3-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144666#comment-13144666 ] Hudson commented on COCOON3-79: --- Integrated in Cocoon-trunk #98 (See [https://builds.apache.org/job/Cocoon-trunk/98/]) Fixes issue COCOON3-79 ilgrosso : http://svn.apache.org/viewvc/?view=revrev=1197931 Files : * /cocoon/cocoon3/trunk/cocoon-controller/src/main/java/org/apache/cocoon/controller/node/CallNode.java * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/sitemap.xmap * /cocoon/cocoon3/trunk/cocoon-sample/src/main/resources/COB-INF/string-template/template.xml * /cocoon/cocoon3/trunk/cocoon-servlet/src/main/java/org/apache/cocoon/servlet/collector/ResponseHeaderCollector.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/Invocation.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/InvocationImpl.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/SitemapParametersStack.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/expression/JexlLanguageInterpreter.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/expression/LanguageInterpreter.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/expression/SettingsInterpreter.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/expression/SitemapLanguageInterpreter.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/AbstractSitemapNode.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/GenerateNode.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/MatchNode.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/ReadNode.java * /cocoon/cocoon3/trunk/cocoon-sitemap/src/main/java/org/apache/cocoon/sitemap/node/TransformNode.java Sitemap parameters are always cast to String Key: COCOON3-79 URL: https://issues.apache.org/jira/browse/COCOON3-79 Project: Cocoon 3 Issue Type: Bug Components: cocoon-sitemap Affects Versions: 3.0.0-beta-1 Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0-beta-1 Attachments: COCOON3-79.patch Sitemap parameters are cast to String when passed to actual sitemap components: this can cause troubles when the actual original object needs to be accessed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139583#comment-13139583 ] Andre Juffer commented on COCOON3-77: - Yeah, sure. I am bit tight in time right now, but in the course of next week I'll care of it. -- Andre H. Juffer | Phone: +358-8-553 1161 Biocenter Oulu and | Fax: +358-8-553-1141 Department of Biochemistry | Email: andre.juf...@oulu.fi University of Oulu, Finland | WWW: www.biochem.oulu.fi/Biocomputing/ StruBioCat | WWW: www.strubiocat.oulu.fi Triacle Biocomputing | WWW: www.triacle-bc.com Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (COCOON3-77) Text and JSON serializers
[ https://issues.apache.org/jira/browse/COCOON3-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139376#comment-13139376 ] Thorsten Scherler commented on COCOON3-77: -- Andre can you prepare a svn diff since I am really keen to apply this patch. Text and JSON serializers - Key: COCOON3-77 URL: https://issues.apache.org/jira/browse/COCOON3-77 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-optional Affects Versions: 3.0.0-alpha-3 Reporter: Andre Juffer Priority: Minor Attachments: EncodingJsonSerializer.java, EncodingTextSerializer.java, JsonSerializer.java, TextEncoder.java, TextSerializer.java, pom.xml, tribc-cocoon-3.xml Serveral classes have been created for serializing text and JSON in the sitemap. The JsonSerializer also checks whether the JSON text actually is valid. The organization of the classes follows the encoding serializers (such as the EncodingHTMLSerializer). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira