[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554665 ] Reinhard Poetz commented on COCOON-1831: yes, I understand and agree. But Grek's and my question is why do you iterate the whole callstack? Wouldn't it be enough to pass parameters from the parent only? Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz Assignee: Reinhard Poetz Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554654 ] Rice Yeh commented on COCOON-1831: -- Iteration over the whole call stack is my way to implement 'overriding' effect in values like parameters. For values' overriding, please see http://www.mail-archive.com/dev@cocoon.apache.org/msg52250.html. Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz Assignee: Reinhard Poetz Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554464 ] Grzegorz Kossakowski commented on COCOON-1831: -- I have taken a look on fragments where iteration of CallStack occurs and I'm almost sure it is not needed. Personally speaking I have no idea why it was done this way. I hope that Rice can give us an explanation. For now I would suggest to apply this patch _without_ iterating whole CallStack and only limit ourselves to calling request object. Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz Assignee: Reinhard Poetz Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546938 ] Reinhard Poetz commented on COCOON-1831: I've applied the patch except the part that deals with accessing the session because I remember some controversial discussions about it. I've brought up this topic on [EMAIL PROTECTED] and wait for the outcome of the discussion. Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz Assignee: Grzegorz Kossakowski Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528941 ] Grzegorz Kossakowski commented on COCOON-1831: -- Thanks Rice for attaching this patch. I will review and commit it after upcoming next release of servlet-service-fw is made. Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz Assignee: Grzegorz Kossakowski Attachments: cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1831) Finish blocks-fw implementation
[ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524362 ] Grzegorz Kossakowski commented on COCOON-1831: -- I think current version of servlet-service-fw is quite satisfying when it comes to handling Cocoon blocks. Could this issues be closed? Finish blocks-fw implementation --- Key: COCOON-1831 URL: https://issues.apache.org/jira/browse/COCOON-1831 Project: Cocoon Issue Type: New Feature Components: - Servlet service framework Reporter: Reinhard Poetz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
