[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12442563 ] Georg Hüttenegger commented on COCOON-1931: --- I have now checked with newer cocoon versions and the issue has already been solved (presumabley in connection with the newer rhino and excalibur versions). My check within the cocoon sources was obviously inadequate. Sorry about that. Consequently, I am closing the issue (the patch might still be intereesting for people using older cocoon versions). Georg > Provide more information when compiling a Flowscript fails > -- > > Key: COCOON-1931 > URL: http://issues.apache.org/jira/browse/COCOON-1931 > Project: Cocoon > Issue Type: Improvement > Components: - Flowscript >Affects Versions: 2.1.8, 2.1.9, 2.2-dev (Current SVN), 2.1.10-dev (current > SVN) >Reporter: Georg Hüttenegger >Priority: Minor > Attachments: FOM_JavaScriptInterpreter.java.MoreErrorInfoPatch > > > When a flowscript defined in the sitemap cannot be loaded a > NullPointerException is thrown without telling the developer the real cause > of the issue. > The same is true for certain Javascript coding errors (at least missing > closing bracket of a for loop). > The provided patch throws a CascadingRuntimeException with the name of the > flowscript instead of just a simple NullPointerException. In that way the > developer is lead directly to the cause of the problem instead of wondering > what the real issue might be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12442465 ] Antonio Gallardo commented on COCOON-1931: -- Would you test the 2.1.10 branch on subversion. I think it was fixed just few days ago. I tried to reproduce the issue using the calculator flow sample: http://cocoon.zones.apache.org/demos/21branch/samples/flow/ Here is what I did: 1. When I removed the file, I got: java.io.FileNotFoundException: /home/agallardo/svn/cocoon-2.1/build/webapp/samples/flow/jxcalc/calc.js (No such file or directory) 2. When I remove a closing ")" for a funtion call I got: Missing ")" etc. Would you try the newest version and try to provide an NPE? If you are not able, please let us know to close this issue. Many thanks in advance. > Provide more information when compiling a Flowscript fails > -- > > Key: COCOON-1931 > URL: http://issues.apache.org/jira/browse/COCOON-1931 > Project: Cocoon > Issue Type: Improvement > Components: - Flowscript >Affects Versions: 2.1.8, 2.1.9, 2.2-dev (Current SVN), 2.1.10-dev (current > SVN) >Reporter: Georg Hüttenegger >Priority: Minor > Attachments: FOM_JavaScriptInterpreter.java.MoreErrorInfoPatch > > > When a flowscript defined in the sitemap cannot be loaded a > NullPointerException is thrown without telling the developer the real cause > of the issue. > The same is true for certain Javascript coding errors (at least missing > closing bracket of a for loop). > The provided patch throws a CascadingRuntimeException with the name of the > flowscript instead of just a simple NullPointerException. In that way the > developer is lead directly to the cause of the problem instead of wondering > what the real issue might be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12441936 ] Georg Hüttenegger commented on COCOON-1931: --- One more thing: The stack traces are from cocoon 2.1.7 (with a slightly modified FOM_JavaScriptInterpreter). Georg > Provide more information when compiling a Flowscript fails > -- > > Key: COCOON-1931 > URL: http://issues.apache.org/jira/browse/COCOON-1931 > Project: Cocoon > Issue Type: Improvement > Components: - Flowscript >Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9, 2.1.10-dev (current > SVN) >Reporter: Georg Hüttenegger >Priority: Minor > Attachments: FOM_JavaScriptInterpreter.java.MoreErrorInfoPatch > > > When a flowscript defined in the sitemap cannot be loaded a > NullPointerException is thrown without telling the developer the real cause > of the issue. > The same is true for certain Javascript coding errors (at least missing > closing bracket of a for loop). > The provided patch throws a CascadingRuntimeException with the name of the > flowscript instead of just a simple NullPointerException. In that way the > developer is lead directly to the cause of the problem instead of wondering > what the real issue might be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12441935 ] Georg Hüttenegger commented on COCOON-1931: --- Not sure if fixing the NullPointerException is going to be easy. It would definitely be great to get the line number of an erronous flowscript in the second case (missing '}'). The NullPointerException when a flowscript is missing: [13.10.06 08:17:49:613 CEST] 0028 SystemOut O 08:17:49,613 ERROR [tainer : 2][ap.handled-errors] []: Could not read resource cocoon://webapp/flowcall-loginWithPassword org.apache.cocoon.ProcessingException: Could not read resource cocoon://webapp/flowcall-loginWithPassword: java.lang.NullPointerException at org.apache.cocoon.components.source.SourceUtil.handleSAXException(SourceUtil.java:446) at org.apache.cocoon.generation.FileGenerator.generate(FileGenerator.java:117) at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.processXMLPipeline(AbstractProcessingPipeline.java:575) at org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.process(AbstractProcessingPipeline.java:483) at org.apache.cocoon.components.treeprocessor.sitemap.SerializeNode.invoke(SerializeNode.java:120) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.sitemap.SelectNode.invoke(SelectNode.java:102) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.ContainerNode.invoke(ContainerNode.java:31) at org.apache.cocoon.components.treeprocessor.sitemap.CallNode.invoke(CallNode.java:93) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:46) at org.apache.cocoon.components.treeprocessor.sitemap.ActTypeNode.invoke(ActTypeNode.java:138) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:138) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:92) at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:234) at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:176) at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:243) at org.apache.cocoon.components.treeprocessor.sitemap.MountNode.invoke(MountNode.java:117) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:46) at org.apache.cocoon.components.treeprocessor.sitemap.PreparableMatchNode.invoke(PreparableMatchNode.java:130) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke(PipelineNode.java:138) at org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes(AbstractParentProcessingNode.java:68) at org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke(PipelinesNode.java:92) at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:234) at org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process(ConcreteTreeProcessor.java:176) at org.apache.cocoon.components.treeprocessor.TreeProcessor.process(TreeProcessor.java:243) at org.apache.cocoon.Cocoon.process(Cocoon.java:608) at org.apache.cocoon.servlet.CocoonServlet.service(CocoonServlet.java:1123) at at.rsf4j.cocoon.servlet.RSFCocoonServlet.service(RSFCocoonServlet.java:186) at javax.servlet.http.HttpServlet.service(HttpServlet.java:856) at com.ibm.ws.webcontainer.servlet.ServletWrapper.service(ServletWrapper.java:1282) at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:673) at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:2965) at com.ibm.ws.webcontainer.webapp.WebGroup.handleRequest(WebGroup.java:221) at com.ibm.ws.webcontainer.VirtualHost.handleRequest(VirtualHost.java:210) at com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:1931) at com.ibm.ws.webcontainer.channel.WCChannelLink.ready(WCChannelLink.ja
[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12441513 ] Jörg Heinicke commented on COCOON-1931: --- flow => flaw > Provide more information when compiling a Flowscript fails > -- > > Key: COCOON-1931 > URL: http://issues.apache.org/jira/browse/COCOON-1931 > Project: Cocoon > Issue Type: Improvement > Components: - Flowscript >Affects Versions: 2.1.8, 2.1.9, 2.2-dev (Current SVN), 2.1.10-dev (current > SVN) >Reporter: Georg Hüttenegger >Priority: Minor > Attachments: FOM_JavaScriptInterpreter.java.MoreErrorInfoPatch > > > When a flowscript defined in the sitemap cannot be loaded a > NullPointerException is thrown without telling the developer the real cause > of the issue. > The same is true for certain Javascript coding errors (at least missing > closing bracket of a for loop). > The provided patch throws a CascadingRuntimeException with the name of the > flowscript instead of just a simple NullPointerException. In that way the > developer is lead directly to the cause of the problem instead of wondering > what the real issue might be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (COCOON-1931) Provide more information when compiling a Flowscript fails
[ http://issues.apache.org/jira/browse/COCOON-1931?page=comments#action_12441507 ] Jörg Heinicke commented on COCOON-1931: --- IMO we should fix the flow, not the symptoms - if it is possible. Where is the NPE thrown? Can you provide a stacktrace? Jörg > Provide more information when compiling a Flowscript fails > -- > > Key: COCOON-1931 > URL: http://issues.apache.org/jira/browse/COCOON-1931 > Project: Cocoon > Issue Type: Improvement > Components: - Flowscript >Affects Versions: 2.1.8, 2.1.9, 2.2-dev (Current SVN), 2.1.10-dev (current > SVN) >Reporter: Georg Hüttenegger >Priority: Minor > Attachments: FOM_JavaScriptInterpreter.java.MoreErrorInfoPatch > > > When a flowscript defined in the sitemap cannot be loaded a > NullPointerException is thrown without telling the developer the real cause > of the issue. > The same is true for certain Javascript coding errors (at least missing > closing bracket of a for loop). > The provided patch throws a CascadingRuntimeException with the name of the > flowscript instead of just a simple NullPointerException. In that way the > developer is lead directly to the cause of the problem instead of wondering > what the real issue might be. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
