Re: [jira] Created: (COCOON-1789) [PATCH] Char datatype

2006-03-12 Thread Jorg Heymans 

Andrew Savory wrote:

 Patch applied. I noticed that your editor is not set to use the
 preferred coding style for tabs - can you update it to use 4 spaces,
 instead of tabs?
 
 I also noticed @author in the javadoc comments - I believe use of
 @author is now deprecated, so I've stripped them.
 

Shouldn't this change be mentioned in status.xml ?


Jorg

Re: [jira] Created: (COCOON-1789) [PATCH] Char datatype

2006-03-12 Thread Andrew Savory 

Jorg Heymans wrote:


Shouldn't this change be mentioned in status.xml ?


Ooops, yes, done.

Thanks,

Andrew.
--
Andrew Savory, Managing Director, Luminas Limited
Tel: +44 (0)870 741 6658  Fax: +44 (0)700 598 1135
Web: http://www.luminas.co.uk/
Orixo alliance: http://www.orixo.com/

Re: [jira] Created: (COCOON-1789) [PATCH] Char datatype

2006-03-11 Thread Andrew Savory 

Hi Simone,

Simone Gianni (JIRA) wrote:

[PATCH] Char datatype
-


Patch applied. I noticed that your editor is not set to use the 
preferred coding style for tabs - can you update it to use 4 spaces, 
instead of tabs?


I also noticed @author in the javadoc comments - I believe use of 
@author is now deprecated, so I've stripped them.



Thanks,

Andrew.
--
Andrew Savory, Managing Director, Luminas Limited
Tel: +44 (0)870 741 6658  Fax: +44 (0)700 598 1135
Web: http://www.luminas.co.uk/
Orixo alliance: http://www.orixo.com/

[jira] Created: (COCOON-1789) [PATCH] Char datatype

2006-03-01 Thread Simone Gianni (JIRA) 
[PATCH] Char datatype
-

 Key: COCOON-1789
 URL: http://issues.apache.org/jira/browse/COCOON-1789
 Project: Cocoon
Type: New Feature
  Components: Blocks: Forms  
Versions: 2.1.9-dev (current SVN)
Reporter: Simone Gianni
Priority: Minor
 Attachments: chardataype-conf.diff, chardataype-samples.diff, chardataype.diff

Cocoon forms lacks a Char datatype. This is often needed in bean bindings for 
database oriented applications, where the char often appears in a field.

The first patch provides a char datatype with it's builder, it's char 
convertor, the second patch the changes to the configuration to add the 
datatype, the third a modification of the samples form2 definition, bean and 
binding to give an example of the char datatype adding a middleInitial char 
field.

Patches applied to 2.1.X branch, but tested on 2.1.6, 2.1.7 and trunk.

Thanks to Maurizio Pillitu for first implementation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira