[jira] Updated: (COCOON-1818) SendMailTransformer misses closing tag when recipient address is malformed
[ http://issues.apache.org/jira/browse/COCOON-1818?page=all ] Jasha Joachimsthal updated COCOON-1818: --- Attachment: SendMailTransformer.diff Simone, thank you for making the changes. I moved soms other lines of code too so the SendMailTransformer won't stop if one address is invalid. The diff is not a delta from yours but a new one. SendMailTransformer misses closing tag when recipient address is malformed -- Key: COCOON-1818 URL: http://issues.apache.org/jira/browse/COCOON-1818 Project: Cocoon Type: Bug Components: Blocks: Mail Reporter: Jasha Joachimsthal Attachments: SendMailTransformer.diff, sendmail-exceptions.diff, sendmail-exceptions2.diff When a recipient address contains an illegal character (, ; space [EMAIL PROTECTED]@com etc), an exception is being thrown by method sendMail(List newAddresses, Transport trans). The execution of the try in method sendMail() is stopped which may have created a email:result tag. No /email:result end tag is created when this occurs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1818) SendMailTransformer misses closing tag when recipient address is malformed
[ http://issues.apache.org/jira/browse/COCOON-1818?page=all ] Simone Gianni updated COCOON-1818: -- Attachment: sendmail-exceptions2.diff This patch applies the solution number 3 : for every call to the sendMail() method a result element is always generated. It will contain an error, an exception, or the common email sent results. This changes the produced XML in many ways : - The error element was not conained in a result before this patch. - The exception element was or was not contained in a result before this patch (and this caused the main problems) So consider that after applying you'll probably have to change the XSL that transforms the result. If a mail is not sent, it should not stop sending all the others, unless a SAXException is received (in that case the pipeline is probably broken, so there's nothing cocoon can do about it). Maybe you've seen it stopping because of the inconsistent XML, which caused a SAXException, which stops everything. P.S. this patch is not a delta from the previous one, so you should revert the file on which you applied the previous patch and the apply this one on the clean reverted file. SendMailTransformer misses closing tag when recipient address is malformed -- Key: COCOON-1818 URL: http://issues.apache.org/jira/browse/COCOON-1818 Project: Cocoon Type: Bug Components: Blocks: Mail Reporter: Jasha Joachimsthal Attachments: sendmail-exceptions.diff, sendmail-exceptions2.diff When a recipient address contains an illegal character (, ; space [EMAIL PROTECTED]@com etc), an exception is being thrown by method sendMail(List newAddresses, Transport trans). The execution of the try in method sendMail() is stopped which may have created a email:result tag. No /email:result end tag is created when this occurs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (COCOON-1818) SendMailTransformer misses closing tag when recipient address is malformed
[ http://issues.apache.org/jira/browse/COCOON-1818?page=all ] Simone Gianni updated COCOON-1818: -- Attachment: sendmail-exceptions.diff I'm not an expert about this block, but i made the following modifications : - The sendEndElementEventNS is now called inside a finally, this way the output is resultexception.../exception/result - A SAXException is now propagated up to when it happens in sendMail, since IMMO it makes no sense to intercept a SAXException and try to generate an exception report producing more SAX events. The only thing i'm not sure is the this.ignoreHookCount-- . But since it's SAX related i moved it to the finally as well as the sendEndElementEventNS. SendMailTransformer misses closing tag when recipient address is malformed -- Key: COCOON-1818 URL: http://issues.apache.org/jira/browse/COCOON-1818 Project: Cocoon Type: Bug Components: Blocks: Mail Reporter: Jasha Joachimsthal Attachments: sendmail-exceptions.diff When a recipient address contains an illegal character (, ; space [EMAIL PROTECTED]@com etc), an exception is being thrown by method sendMail(List newAddresses, Transport trans). The execution of the try in method sendMail() is stopped which may have created a email:result tag. No /email:result end tag is created when this occurs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
