Re: 2.1.11 release

2007-12-28 Thread Carsten Ziegeler
Ralph Goers wrote:
> I committed the changes to 2.1.x. I'll try to get trunk done on 1/1/08
> 
Many thanks Ralph!

Carsten


-- 
Carsten Ziegeler
[EMAIL PROTECTED]


Thanks Ralph [Was: 2.1.11 release]

2007-12-27 Thread David Crossley
Ralph Goers wrote:
> I committed the changes to 2.1.x. I'll try to get trunk done on 1/1/08

Thanks for that extra effort Ralph, in the midst of your preparations.

Your ASF friends wish you well.

-David


Re: 2.1.11 release

2007-12-27 Thread Ralph Goers

I committed the changes to 2.1.x. I'll try to get trunk done on 1/1/08

Ralph Goers wrote:
If I can't get it done in the next 24 hrs go ahead and do that. 
However, I'd really like my changes in 2.1.11 also. It has been an 
outstanding defect for several years.


Grzegorz Kossakowski wrote:

Ralph Goers pisze:
 

I'm currently trying to get the XPathXMLFileModule into trunk. I was
holding off committing until I had that working. However, I will be
heading off to Seattle very early tomorrow until New Year's Eve so if I
don't get it committed today it won't be included in your build - which
is a very bad thing since several JXPath based input modules don't work
right now (i.e - I'd have to vote -1 on the release until I get this
fixed).  I may just commit what I have for 2.1 and get trunk done 
when I

get back.

Unfortunately, I am very busy getting things ready for my grandkids
birthday party so I have no idea if I'll get this completed today.



What about reverting my change in 2.1.x branch that broke 
JXPath-based modules and introducing a new

method in JXPathHelper just to make xmodule:flow-attr working properly?
It's really not my favorite choice but it was me who broke XMLModule 
and I don't want to block a

release.

In trunk I opt for cleaner API at price of breaking back-compatibility.

WDYT?

  


Re: 2.1.11 release

2007-12-27 Thread Ralph Goers
If I can't get it done in the next 24 hrs go ahead and do that. However, 
I'd really like my changes in 2.1.11 also. It has been an outstanding 
defect for several years.


Grzegorz Kossakowski wrote:

Ralph Goers pisze:
  

I'm currently trying to get the XPathXMLFileModule into trunk. I was
holding off committing until I had that working. However, I will be
heading off to Seattle very early tomorrow until New Year's Eve so if I
don't get it committed today it won't be included in your build - which
is a very bad thing since several JXPath based input modules don't work
right now (i.e - I'd have to vote -1 on the release until I get this
fixed).  I may just commit what I have for 2.1 and get trunk done when I
get back.

Unfortunately, I am very busy getting things ready for my grandkids
birthday party so I have no idea if I'll get this completed today.



What about reverting my change in 2.1.x branch that broke JXPath-based modules 
and introducing a new
method in JXPathHelper just to make xmodule:flow-attr working properly?
It's really not my favorite choice but it was me who broke XMLModule and I 
don't want to block a
release.

In trunk I opt for cleaner API at price of breaking back-compatibility.

WDYT?

  


Re: 2.1.11 release

2007-12-27 Thread Grzegorz Kossakowski
Ralph Goers pisze:
> I'm currently trying to get the XPathXMLFileModule into trunk. I was
> holding off committing until I had that working. However, I will be
> heading off to Seattle very early tomorrow until New Year's Eve so if I
> don't get it committed today it won't be included in your build - which
> is a very bad thing since several JXPath based input modules don't work
> right now (i.e - I'd have to vote -1 on the release until I get this
> fixed).  I may just commit what I have for 2.1 and get trunk done when I
> get back.
> 
> Unfortunately, I am very busy getting things ready for my grandkids
> birthday party so I have no idea if I'll get this completed today.

What about reverting my change in 2.1.x branch that broke JXPath-based modules 
and introducing a new
method in JXPathHelper just to make xmodule:flow-attr working properly?
It's really not my favorite choice but it was me who broke XMLModule and I 
don't want to block a
release.

In trunk I opt for cleaner API at price of breaking back-compatibility.

WDYT?

-- 
Grzegorz Kossakowski


2.1.11 release

2007-12-27 Thread Ralph Goers
I'm currently trying to get the XPathXMLFileModule into trunk. I was 
holding off committing until I had that working. However, I will be 
heading off to Seattle very early tomorrow until New Year's Eve so if I 
don't get it committed today it won't be included in your build - which 
is a very bad thing since several JXPath based input modules don't work 
right now (i.e - I'd have to vote -1 on the release until I get this 
fixed).  I may just commit what I have for 2.1 and get trunk done when I 
get back.


Unfortunately, I am very busy getting things ready for my grandkids 
birthday party so I have no idea if I'll get this completed today.


Ralph

Carsten Ziegeler wrote:

If I get no response from Paul (or anyone else on this), I'll revert the
change for the release. I'm currently planning to prepare the
distribution next monday.

Carsten