RE: CommandManager again (was RE: [VOTE] Migrate from the aging ECM)

2003-09-03 Thread Carsten Ziegeler

Berin Loritsch wrote:
> 
> Carsten Ziegeler wrote:
> 
> >
> >>m_threadPool.waitWhenBlocked();
> >>
> >>to
> >>
> >>m_threadPool.discardWhenBlocked();
> >>
> >>functionally, this shouldn't change anything (I think), and it will
> >>avoid the problem in PooledExecutor completely. If you have some time
> >>available to try this out, that would be great.
> >>
> > 
> > Yes, I just tried it - and it works. Great!
> > 
> > So, how do we proceed? We can distribute our own patched 
> version of event
> > or we can ask that this will be changed in excalibur.
> 
> You (all cocoon developers) have access to excalibur components.  Why not
> go ahead and fix it?
> 
Yes, I now this - I just wanted first to hear your opinion on this.
So, I will apply the change asap.

> Just ask for a new release, and all will be happy.
> 
Can we have a new release, please? :)

Carsten


Re: CommandManager again (was RE: [VOTE] Migrate from the aging ECM)

2003-09-03 Thread Berin Loritsch
Carsten Ziegeler wrote:


m_threadPool.waitWhenBlocked();

to

m_threadPool.discardWhenBlocked();

functionally, this shouldn't change anything (I think), and it will
avoid the problem in PooledExecutor completely. If you have some time
available to try this out, that would be great.
Yes, I just tried it - and it works. Great!

So, how do we proceed? We can distribute our own patched version of event
or we can ask that this will be changed in excalibur.
You (all cocoon developers) have access to excalibur components.  Why not
go ahead and fix it?
Just ask for a new release, and all will be happy.

--

"They that give up essential liberty to obtain a little temporary safety
 deserve neither liberty nor safety."
- Benjamin Franklin


RE: CommandManager again (was RE: [VOTE] Migrate from the aging ECM)

2003-09-03 Thread Carsten Ziegeler
Bruno Dumon wrote:
> 
> On Wed, 2003-09-03 at 10:23, Carsten Ziegeler wrote:
> 
> > I think we should do this switch asap. *If* we can solve the 
> commandmanager
> > issue discussed in the other thread, I will make a 2.1.1 
> release this week.
> 
> The issue can in fact be fixed immediately by changing the way we use
> the PooledExecutor class. In the TPCThreadManager class (in
> excalibur-event), change the line:
> 
> m_threadPool.waitWhenBlocked();
> 
> to
> 
> m_threadPool.discardWhenBlocked();
> 
> functionally, this shouldn't change anything (I think), and it will
> avoid the problem in PooledExecutor completely. If you have some time
> available to try this out, that would be great.
> 
Yes, I just tried it - and it works. Great!

So, how do we proceed? We can distribute our own patched version of event
or we can ask that this will be changed in excalibur.

Carsten


CommandManager again (was RE: [VOTE] Migrate from the aging ECM)

2003-09-03 Thread Bruno Dumon
On Wed, 2003-09-03 at 10:23, Carsten Ziegeler wrote:

> I think we should do this switch asap. *If* we can solve the commandmanager
> issue discussed in the other thread, I will make a 2.1.1 release this week.

The issue can in fact be fixed immediately by changing the way we use
the PooledExecutor class. In the TPCThreadManager class (in
excalibur-event), change the line:

m_threadPool.waitWhenBlocked();

to

m_threadPool.discardWhenBlocked();

functionally, this shouldn't change anything (I think), and it will
avoid the problem in PooledExecutor completely. If you have some time
available to try this out, that would be great.

Of course, this doesn't fix the original problem we had in
PooledExecutor, but I'm starting to doubt if this can be fixed at all.
Anyhow, I'm communicating with Doug Lea about that.

-- 
Bruno Dumon http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
[EMAIL PROTECTED]  [EMAIL PROTECTED]