Re: cvs commit: cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components PipelineAuthenticator.java

2004-01-27 Thread Joerg Heinicke
On 27.01.2004 12:49, Carsten Ziegeler wrote:

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
joerg   2004/01/27 03:42:51

 Modified:
src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authen
tication/components
   PipelineAuthenticator.java
 Log:
 SourceUtil.toDOM() is not really needed in logout, is it?
 some formatting
 
It *is* needed; otherwise the pipeline is never called. Please revert.
Ok, I have it reverted 2 hourse ago, only the message didn't arrive 
until now (somewhat slow the apache mail system in the last couple 
days). I only have the feeling that it is somewhat hacky. Or at least it 
is responsible for more than I expect when reading the method name.

Joerg


RE: cvs commit: cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components PipelineAuthenticator.java

2004-01-27 Thread Carsten Ziegeler


> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, January 27, 2004 12:43 PM
> To: [EMAIL PROTECTED]
> Subject: cvs commit:
> cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/a
> uthentication/components PipelineAuthenticator.java
> 
> 
> joerg   2004/01/27 03:42:51
> 
>   Modified:
> src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authen
> tication/components
> PipelineAuthenticator.java
>   Log:
>   SourceUtil.toDOM() is not really needed in logout, is it?
>   some formatting
>   
It *is* needed; otherwise the pipeline is never called. Please revert.

Carsten


cvs commit: cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components PipelineAuthenticator.java

2003-08-26 Thread cziegeler
cziegeler2003/08/25 23:43:32

  Modified:
src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components
PipelineAuthenticator.java
  Log:
  Fixing NPE in authentication reported bySonny Sukumar ([EMAIL PROTECTED])
  
  Revision  ChangesPath
  1.3   +3 -1  
cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components/PipelineAuthenticator.java
  
  Index: PipelineAuthenticator.java
  ===
  RCS file: 
/home/cvs/cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components/PipelineAuthenticator.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- PipelineAuthenticator.java4 Aug 2003 03:06:30 -   1.2
  +++ PipelineAuthenticator.java26 Aug 2003 06:43:32 -  1.3
  @@ -280,6 +280,8 @@
   
   if (doc != null) {
   data = DOMUtil.getFirstNodeFromPath(doc, new String[] 
{"authentication","data"}, false);
  +} else {
  +doc = DOMUtil.createDocument();
   }
   
   // now create the following xml:
  
  
  


cvs commit: cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components PipelineAuthenticator.java DefaultAuthenticationManager.java Authenticator.java

2003-07-12 Thread cziegeler
cziegeler2003/07/12 11:39:49

  Modified:.status.xml
   
src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/configuration
HandlerConfiguration.java
   
src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components
DefaultAuthenticationManager.java
Authenticator.java
  Added:   
src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components
PipelineAuthenticator.java
  Log:
 The authentication framework now uses a configurable component to try to 
authenticate a user.
 This allows to drop in own authentication services or e.g. the servlet 
authentication mechanism.
  
  Revision  ChangesPath
  1.90  +5 -1  cocoon-2.1/status.xml
  
  Index: status.xml
  ===
  RCS file: /home/cvs/cocoon-2.1/status.xml,v
  retrieving revision 1.89
  retrieving revision 1.90
  diff -u -r1.89 -r1.90
  --- status.xml12 Jul 2003 13:30:02 -  1.89
  +++ status.xml12 Jul 2003 18:39:48 -  1.90
  @@ -184,6 +184,10 @@
 
   

  +  
  +   The authentication framework now uses a configurable component to try to 
authenticate a user.
  +   This allows to drop in own authentication services or e.g. the servlet 
authentication mechanism.
  +  
 
  Made JSPs working in Resin that don't end on *.jsp.
 
  
  
  
  1.2   +21 -3 
cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/configuration/HandlerConfiguration.java
  
  Index: HandlerConfiguration.java
  ===
  RCS file: 
/home/cvs/cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/configuration/HandlerConfiguration.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- HandlerConfiguration.java 27 Apr 2003 12:52:53 -  1.1
  +++ HandlerConfiguration.java 12 Jul 2003 18:39:49 -  1.2
  @@ -59,6 +59,7 @@
   import org.apache.avalon.framework.configuration.ConfigurationException;
   import org.apache.cocoon.ProcessingException;
   import org.apache.cocoon.environment.Request;
  +import org.apache.cocoon.webapps.authentication.components.PipelineAuthenticator;
   import org.apache.excalibur.source.SourceParameters;
   import org.apache.excalibur.source.SourceResolver;
   import org.xml.sax.SAXException;
  @@ -83,6 +84,9 @@
   
   /** The authentication resource */
   private String authenticationResource;
  +
  +/** The class name of the authenticator to use */
  +private String authenticatorClass;
   
   /** The authentication resource parameters */
   private SourceParameters authenticationResourceParameters;
  @@ -141,9 +145,16 @@
   
   // get load resource (required)
   child = conf.getChild("authentication", false);
  -if (child == null)
  +if (child == null) {
   throw new ConfigurationException("Handler '"+this.name+"' needs 
authentication configuration");
  -this.authenticationResource = child.getAttribute("uri");
  +}
  +this.authenticatorClass = child.getAttribute("authenticator", 
PipelineAuthenticator.class.getName());
  +if ( PipelineAuthenticator.class.getName().equals(authenticatorClass)) {
  +this.authenticationResource = child.getAttribute("uri");
  +} else {
  +// the uri attribute is optional for other authenticators
  +this.authenticationResource = child.getAttribute("uri", null);
  +}
   this.authenticationResourceParameters = SourceParameters.create(child);
   
   // get load resource (optional)
  @@ -268,5 +279,12 @@
*/
   public String toString() {
   return "authentication-Handler " + this.name;
  +}
  +
  +/**
  + * Return the authenticator class
  + */
  +public String getAuthenticatorClassName() {
  +return this.authenticatorClass;
   }
   }
  
  
  
  1.15  +53 -20
cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components/DefaultAuthenticationManager.java
  
  Index: DefaultAuthenticationManager.java
  ===
  RCS file: 
/home/cvs/cocoon-2.1/src/blocks/authentication-fw/java/org/apache/cocoon/webapps/authentication/components/DefaultAuthenticationManager.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- DefaultAuthenticationManager.java 1 Jul 2003 19:26:40 -   1.14
  +++ DefaultAuthenticationManager.java 12 Jul 2003 18:39:49 -  1.15
  @@ -51,6 +51,7 @@
   package org.apache.cocoon.webapps.authentication.components;
   
   import java.io.IOException;
  +imp