[lang] ArrayUtils issues

2009-11-14 Thread Henri Yandell
Wrapping 5 ArrayUtils issues up in one email to see if we can make
decisions on them.

LANG-470Add containsAll(Object[], Object[]) methods to ArrayUtils
LANG-531Add defaultIfEmpty or nullIfEmpty to ArrayUtils
LANG-536Add isSorted() to ArrayUtils
LANG-537Add ArrayUtils.toArray to create generic arrays
LANG-534ArrayUtils should have method to convert null arrays to
empty ones to help with Defensive coding

Going through each:

LANG-470.
  Vaguely interesting, but I don't know what containsAll( array, null
) and containsAll( null, null ) would do. This is effectively a set
method on arrays, so I'm thinking more in the direction of adding an
Set ArrayUtils.toSet(T[]) method. It would mean a, potentially
non-public, ArraySet class.

LANG-531.
  I don't get the usefulness of the nullIfEmpty notion. Seems like an
odd paradigm to prefer null over empty (i.e. null safe) values. I'm
inclined to WONTFIX.

LANG-536.
  Needs tests, but I'm +1 to add this. Feels valuable despite the
annoyance of more primitive[] overloads bloating code.

LANG-537.
  I don't get this one. Presumably I'm missing something.

LANG-534.
  More irritating code bloat, but feels like a fair enough feature.
Opposite of LANG-531 and the more common pattern imo.


Thoughts?

Hen

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[logging] JIRA issues building up

2009-11-14 Thread Henri Yandell
Various JIRA issues building up on Logging.

Do we have any plans for more Logging releases? Ignoring the obvious
that something could mean doing a 1.1.2 release.

Hen

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Help cutting JEXL-2.0 RC1 needed

2009-11-14 Thread Christian Grobmeier
>
>
> > I'm sure glad there is help; there are a few project that are just going
> /
> > went through that process (commons-exec for instance) . Is there anyone
> > involved willing to share their successful publishing process ?
>
> We definitely need to do that and it is on my todo list to document
> the "manual" process that I follow.  Basically, we have two ways to
> do releases now - using the maven release plugin (more or less
> documented on the Wiki) and "manually" doing the tagging and file
> movement via the command line. Personally, I prefer the command line
> approach.


I have used the M2 approach for compress. It worked, but I sometime felt
that the process had control bout me and not otherwise. I also run into
several problems, from which most were based on my own enviroment. However,
it was no fun at all. Currently I try to build up the release plugin for
Log4php project, but this is pretty hard too. At the moment, I am tending to
a proper command line plan. There are too much problems I don't understand
with M2.

@Henri: I don't know what why the error here happened, but I know that you
need a clean checkout to make release plugin work proberly. Its not working
if you have some kind of files from your IDE in your project.

Cheers
Christian


Re: [lang] ArrayUtils issues

2009-11-14 Thread Hasan Diwan
2009/11/14 Henri Yandell :
> LANG-470        Add containsAll(Object[], Object[]) methods to ArrayUtils

public static containsAll(Object[] first, Object[] second) {
  for (Object o : first) {
if (ArrayUtils.contains(second, o) == false) return false;
  }
  return ArrayUtils.getLength(first) == ArrayUtils.getLength(second)
}

> LANG-537        Add ArrayUtils.toArray to create generic arrays

public static toArray(Object [] o){
  return o;
}
These are needed to be compliant to java.util.Collections. I agree,
both seem a little silly.
-- 
Sent from my mobile device
Envoyait de mon telephone mobil

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Help cutting JEXL-2.0 RC1 needed

2009-11-14 Thread sebb
On 14/11/2009, Christian Grobmeier  wrote:
> >
>  >
>  > > I'm sure glad there is help; there are a few project that are just going
>  > /
>  > > went through that process (commons-exec for instance) . Is there anyone
>  > > involved willing to share their successful publishing process ?
>  >
>  > We definitely need to do that and it is on my todo list to document
>  > the "manual" process that I follow.  Basically, we have two ways to
>  > do releases now - using the maven release plugin (more or less
>  > documented on the Wiki) and "manually" doing the tagging and file
>  > movement via the command line. Personally, I prefer the command line
>  > approach.
>
>
>
> I have used the M2 approach for compress. It worked, but I sometime felt
>  that the process had control bout me and not otherwise. I also run into
>  several problems, from which most were based on my own enviroment. However,
>  it was no fun at all. Currently I try to build up the release plugin for
>  Log4php project, but this is pretty hard too. At the moment, I am tending to
>  a proper command line plan. There are too much problems I don't understand
>  with M2.
>
>  @Henri: I don't know what why the error here happened, but I know that you
>  need a clean checkout to make release plugin work proberly. Its not working
>  if you have some kind of files from your IDE in your project.

Seems to me one should _always_ work from a clean check-out,
regardless of the build process. Otherwise the process may not be
repeatable by others, and it's far too easy to accidentally include
spurious files.

>  Cheers
>
> Christian
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [lang] ArrayUtils issues

2009-11-14 Thread sebb
On 14/11/2009, Hasan Diwan  wrote:
> 2009/11/14 Henri Yandell :
>
> > LANG-470Add containsAll(Object[], Object[]) methods to ArrayUtils
>
>
> public static containsAll(Object[] first, Object[] second) {
>
>   for (Object o : first) {
> if (ArrayUtils.contains(second, o) == false) return false;
>   }
>   return ArrayUtils.getLength(first) == ArrayUtils.getLength(second)
>
> }

AFAICT this does not work for arrays with duplicate entries.

>
>  > LANG-537Add ArrayUtils.toArray to create generic arrays
>
>
> public static toArray(Object [] o){
>   return o;
>  }
>  These are needed to be compliant to java.util.Collections. I agree,
>  both seem a little silly.
>
> --
>  Sent from my mobile device
>  Envoyait de mon telephone mobil
>
>
>  -
>  To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>  For additional commands, e-mail: dev-h...@commons.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[g...@vmgump]: Project commons-configuration-test (in module apache-commons) failed

2009-11-14 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-configuration-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 5 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-configuration-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-configuration-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven2 settings: 
[/srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml]
 -DEBUG- (Gump generated) Maven2 Settings in: 
/srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/apache-commons/configuration/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/configuration/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-configuration-test/gump_work/build_apache-commons_commons-configuration-test.html
Work Name: build_apache-commons_commons-configuration-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 6 mins 11 secs
Command Line: mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/configuration/gump_mvn_settings.xml 
test 
[Working Directory: /srv/gump/public/workspace/apache-commons/configuration]
CLASSPATH: 
/usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/apache-commons/configuration/target/commons-configuration-1.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/jexl/target/commons-jexl-2.0-SNAPSHOT.jar
-
  testInitCopy(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveWithDelimiterParsingDisabled(org.apache.commons.configuration.TestXMLConfiguration)
  testSetRootAttribute(org.apache.commons.configuration.TestXMLConfiguration)
  testLoadAndSaveFromFile(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveToURL(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveToStream(org.apache.commons.configuration.TestXMLConfiguration)
  testAutoSave(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveAttributes(org.apache.commons.configuration.TestXMLConfiguration)
  testCloneWithSave(org.apache.commons.configuration.TestXMLConfiguration)
  testEmptyElements(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveWithEncoding(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveWithNullEncoding(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveWithDoctype(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveWithDoctypeIDs(org.apache.commons.configuration.TestXMLConfiguration)
  testSubsetWithReload(org.apache.commons.configuration.TestXMLConfiguration)
  
testConfigurationAtWithReload(org.apache.commons.configuration.TestXMLConfiguration)
  
testConfigurationsAtWithReload(org.apache.commons.configuration.TestXMLConfiguration)
  testGetKeysWithReload(org.apache.commons.configuration.TestXMLConfiguration)
  testSetTextRootElement(org.apache.commons.configuration.TestXMLConfiguration)
  
testClearTextRootElement(org.apache.commons.configuration.TestXMLConfiguration)
  
testAutoSaveWithSubnodeConfig(org.apache.commons.configuration.TestXMLConfiguration)
  
testAutoSaveWithSubSubnodeConfig(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveDelimiterParsingDisabled(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveDelimiterParsingDisabledAttrs(org.apache.commons.configuration.TestXMLConfiguration)
  
testMultipleAttrValuesEscaped(org.apache.commons.configuration.TestXMLConfiguration)
  
testAutoSaveWithReloadingStrategy(org.apache.commons.configuration.TestXMLConfiguration)
  testAutoSaveAddNodes(org.apache.commons.configuration.TestXMLConfiguration)
  testAddNodesAndSave(org.apache.commons.configuration.TestXMLConfiguration)
  testRegisterEntityId(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveAfterCreateWithCopyConstructor(org.apache.commons.configuration.TestXMLConfiguration)
  testCopyRootName(org.apache.commons.configuration.TestXMLConfiguration)
  
testCopyRootNameNoDocument(org.apache.commons.configuration.TestXMLConfiguration)
  testSaveWithValidation(org.apache.commons.configuration.TestXMLConfiguration)
  
testSaveWithValidationFailure(org.apache.commons.configuration.TestXMLConfiguration)

Tests run: 1456, Failures: 0, Errors: 58, Skipped: 0

[INFO] ---

Re: [logging] JIRA issues building up

2009-11-14 Thread Dennis Lundberg
I'm available to be RM if we want to make a release.

Henri Yandell wrote:
> Various JIRA issues building up on Logging.
> 
> Do we have any plans for more Logging releases? Ignoring the obvious
> that something could mean doing a 1.1.2 release.
> 
> Hen
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 
> 


-- 
Dennis Lundberg

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[g...@vmgump]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed

2009-11-14 Thread commons-jelly-tags-fmt development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-jelly-tags-fmt-test has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-fmt-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml
 -DEBUG- Maven project properties in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties
 -INFO- Project Reports in: 
/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html
Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 5 secs
Command Line: maven --offline jar 
[Working Directory: /srv/gump/public/workspace/commons-jelly/jelly-tags/fmt]
CLASSPATH: 
/usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-14112009.jar:/srv/gump/pu
 
blic/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/public/workspace/commons-jelly/target/commons-jelly-14112009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-14112009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-14112009.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-14112009.jar:/srv/gump/public/workspace/apache-commons/jexl/target/commons-jexl-2.0-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-14112009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-14112009.jar:/srv/gump/public/workspace/dom4j/build/dom4j.jar:/srv/gump/public/workspace/jaxen/target/jaxen-14112009.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jel
 ly-tags-fmt-14112009.jar
-
[junit] at 
org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:111)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:267)
[junit] ... 11 more
[junit] Root cause
[junit] java.lang.NoClassDefFoundError: org/apache/tools/ant/Main
[junit] at 
org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128)
[junit] at 
org.apache.commons.jelly.tags.ant.AntTagLibrary.getProject(AntTagLibrary.java:96)
[junit] at 
org.apache.commons.jelly.tags.ant.AntTag.getAntProject(AntTag.java:310)
[junit] at 
org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:111)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:267)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:60)
[junit] 
[junit] 
[junit] Testcase: 
testSetLocale(org.apache.commons.jelly.tags.junit.CaseTag$1): Cau

Re: [VOTE] Release pool 1.5.4 based on RC1

2009-11-14 Thread Oliver Heger

+1

Oliver

Phil Steitz schrieb:

We have found and fixed another pool 1.5 regression (POOL-152) and
we would like to cut a patch release including the fix.

Release distributions:
http://people.apache.org/~psteitz/pool-1.5.4-RC1/

Maven artifacts:
http://people.apache.org/~psteitz/pool-1.5.4-RC1/maven/

Site (not included with distributions, not yet updated to reflect
release):
http://people.apache.org/~psteitz/pool-1.5.4-RC1/site/

Tag:
http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_4_RC1/

Votes, please.  This vote will close in 72 hours (02:15:00 16-Nov-09)

[ ] +1 release 1.5.4
[ ] -1 no, because...

Thanks!

Phil

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Help cutting JEXL-2.0 RC1 needed

2009-11-14 Thread Phil Steitz
sebb wrote:
> On 14/11/2009, Christian Grobmeier  wrote:
>>  >
>>  > > I'm sure glad there is help; there are a few project that are just going
>>  > /
>>  > > went through that process (commons-exec for instance) . Is there anyone
>>  > > involved willing to share their successful publishing process ?
>>  >
>>  > We definitely need to do that and it is on my todo list to document
>>  > the "manual" process that I follow.  Basically, we have two ways to
>>  > do releases now - using the maven release plugin (more or less
>>  > documented on the Wiki) and "manually" doing the tagging and file
>>  > movement via the command line. Personally, I prefer the command line
>>  > approach.
>>
>>
>>
>> I have used the M2 approach for compress. It worked, but I sometime felt
>>  that the process had control bout me and not otherwise. I also run into
>>  several problems, from which most were based on my own enviroment. However,
>>  it was no fun at all. Currently I try to build up the release plugin for
>>  Log4php project, but this is pretty hard too. At the moment, I am tending to
>>  a proper command line plan. There are too much problems I don't understand
>>  with M2.
>>
>>  @Henri: I don't know what why the error here happened, but I know that you
>>  need a clean checkout to make release plugin work proberly. Its not working
>>  if you have some kind of files from your IDE in your project.
> 
> Seems to me one should _always_ work from a clean check-out,
> regardless of the build process. Otherwise the process may not be
> repeatable by others, and it's far too easy to accidentally include
> spurious files.

+1.  This is another reason I like the "manual" approach outlined by
Niall above.  You know what you are tagging, the tags are immutable
and you build the artifacts from a fresh checkout of the tag.

Phil
> 
>>  Cheers
>>
>> Christian
>>
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Help cutting JEXL-2.0 RC1 needed

2009-11-14 Thread Henrib


Made some progress; by adding an 'rc' profile in my maven / settings.xml
containing the gpg.passphrase, using commons-parent-12, I'm able to sign the
artifacts.

My input is:
What is the release version for "Commons JEXL"?
(org.apache.commons:commons-jexl) 2.0: : 2.0-RC1
What is SCM release tag or label for "Commons JEXL"?
(org.apache.commons:commons-jexl) commons-jexl-2.0: : JEXL_2_0_RC1
What is the new development version for "Commons JEXL"?
(org.apache.commons:commons-jexl) 2.1-SNAPSHOT: : 2.0-SNAPSHOT


The new pb is related to svn, the svn copy fails:
[INFO] Trace
org.apache.maven.BuildFailureException: Unable to tag SCM
Provider message:
The svn tag command failed.
Command output:
svn: No such revision 836226

With the following trace:

[INFO] Tagging release with the label JEXL_2_0_RC1...
[INFO] Executing: /bin/sh -c cd
/Users/henri/Java/apache-commons/rc1/commons/jexl-2.0 && svn
--non-interactive copy --file
/var/folders/Ya/YaSJZzgsHu4O4NXovx-nNE+++TI/-Tmp-/maven-scm-1545582656.commit
--revision 836226
https://svn.apache.org/repos/asf/commons/proper/jexl/tags/JEXL_2_0_RC1
https://svn.apache.org/repos/asf/commons/proper/jexl/tags/JEXL_2_0_RC1

The source & destination of the svn copy are the same...
I suspect the pom.xml should carry somewhere the 'trunk' information; may be
the  should mention the trunk rather than RC1 ?

Hints welcome.
Henrib



-- 
View this message in context: 
http://old.nabble.com/Help-cutting-JEXL-2.0-RC1-needed-tp26339499p26351941.html
Sent from the Commons - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org