[continuum] BUILD FAILURE: Apache Commons - Apache Commons Chain :: Parent - Project build using Java 1.6 (-Prelease does not work for multimodule poms)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=27136&projectId=69 Build statistics: State: Failed Previous State: Failed Started at: Fri 14 Jun 2013 21:20:01 + Finished at: Fri 14 Jun 2013 21:20:41 + Total time: 40s Build Trigger: Schedule Build Number: 69 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version "1.6.0_30" Java(TM) SE Runtime Environment (build 1.6.0_30-b12) Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_30 Java home: /usr/lib/jvm/jdk1.6.0_30/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux" version: "2.6.32-41-server" arch: "amd64" Family: "unix" SCM Changes: Changed: britter @ Fri 14 Jun 2013 21:04:41 + Comment: CHAIN-90 - Create test for o.a.c.chain.generic.CopyCommand Files changed: /commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/generic/CopyCommandTest.java ( 1493246 ) /commons/proper/chain/trunk/src/changes/changes.xml ( 1493246 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean deploy Arguments: --batch-mode -Pjava-1.6 Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Project build using Java 1.6 (-Prelease does not work for multimodule poms) Test Summary: Tests: 99 Failures: 0 Errors: 0 Success Rate: 100 Total time: 1.0180001 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[CHAIN] CopyCommand implements two commands at once
Hi, the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands: * a CopyCommand that copies a value from one key to another * an OverrideCommand, that overrides a value with a provided value. What do you think about splitting this up into two separate classes? Regards, Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[continuum] BUILD FAILURE: Apache Commons - Apache Commons Chain :: Parent - Project build using Java 1.6 (-Prelease does not work for multimodule poms)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=27134&projectId=69 Build statistics: State: Failed Previous State: Failed Started at: Fri 14 Jun 2013 19:20:02 + Finished at: Fri 14 Jun 2013 19:20:44 + Total time: 42s Build Trigger: Schedule Build Number: 69 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version "1.6.0_30" Java(TM) SE Runtime Environment (build 1.6.0_30-b12) Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_30 Java home: /usr/lib/jvm/jdk1.6.0_30/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux" version: "2.6.32-41-server" arch: "amd64" Family: "unix" SCM Changes: Changed: britter @ Fri 14 Jun 2013 18:41:09 + Comment: CHAIN-89 - Combine XmlConfigParserTestCase and XmlConfigParser2TestCase into a parameterized test case - initial refactoring to parameterized test case Files changed: /commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java ( 1493195 ) /commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParser2TestCase.java ( 1493195 ) /commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParserTestCase.java ( 1493195 ) Changed: britter @ Fri 14 Jun 2013 18:45:38 + Comment: CHAIN-89 - Combine XmlConfigParserTestCase and XmlConfigParser2TestCase into a parameterized test case - move loading of config to setUp() Files changed: /commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParserTestCase.java ( 1493199 ) Changed: britter @ Fri 14 Jun 2013 18:48:32 + Comment: CHAIN-89 - Combine XmlConfigParserTestCase and XmlConfigParser2TestCase into a parameterized test case - add issue to changes.xml Files changed: /commons/proper/chain/trunk/src/changes/changes.xml ( 1493200 ) Changed: britter @ Fri 14 Jun 2013 18:49:45 + Comment: Invert assertions Files changed: /commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParserTestCase.java ( 1493201 ) Changed: britter @ Fri 14 Jun 2013 18:51:37 + Comment: Use Id svn keyword Files changed: /commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ExceptionCommand.java ( 1493202 ) Changed: britter @ Fri 14 Jun 2013 19:10:45 + Comment: Apply compose method instead of using comments Files changed: /commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/ConfigRuleSet.java ( 1493213 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean deploy Arguments: --batch-mode -Pjava-1.6 Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Project build using Java 1.6 (-Prelease does not work for multimodule poms) Test Summary: Tests: 93 Failures: 0 Errors: 0 Success Rate: 100 Total time: 0.963 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[continuum] BUILD FAILURE: Apache Commons - Apache Commons Chain :: Parent - Project build using Java 1.6 (-Prelease does not work for multimodule poms)
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=27133&projectId=69 Build statistics: State: Failed Previous State: Failed Started at: Fri 14 Jun 2013 17:20:01 + Finished at: Fri 14 Jun 2013 17:20:47 + Total time: 45s Build Trigger: Schedule Build Number: 69 Exit code: 1 Building machine hostname: vmbuild Operating system : Linux(unknown) Java Home version : java version "1.6.0_30" Java(TM) SE Runtime Environment (build 1.6.0_30-b12) Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode) Builder version : Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+) Java version: 1.6.0_30 Java home: /usr/lib/jvm/jdk1.6.0_30/jre Default locale: en_US, platform encoding: ANSI_X3.4-1968 OS name: "linux" version: "2.6.32-41-server" arch: "amd64" Family: "unix" SCM Changes: Changed: britter @ Fri 14 Jun 2013 16:51:37 + Comment: Remove unneeded hyphens in JavaDoc Files changed: /commons/proper/chain/trunk/configuration/api/src/main/java/org/apache/commons/chain2/config/ConfigParser.java ( 1493152 ) /commons/proper/chain/trunk/configuration/xml/src/main/java/org/apache/commons/chain2/config/xml/XmlConfigParser.java ( 1493152 ) Dependencies Changes: No dependencies changed Build Definition: POM filename: pom.xml Goals: clean deploy Arguments: --batch-mode -Pjava-1.6 Build Fresh: false Always Build: false Default Build Definition: true Schedule: COMMONS_SCHEDULE Profile Name: Maven 2.2.1 Description: Project build using Java 1.6 (-Prelease does not work for multimodule poms) Test Summary: Tests: 93 Failures: 0 Errors: 0 Success Rate: 100 Total time: 2.879 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1492833 - in /commons/proper/chain/trunk/configuration/xml/src/test: java/org/apache/commons/chain2/config/xml/ resources/org/apache/commons/chain2/config/xml/
go for it!
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Thu, Jun 13, 2013 at 9:54 PM, Benedikt Ritter wrote:
> I'm still not really satisfied, since the only thing thats different between
> XmlConfigParserTestCase and XmlConfigParser2TestCase is the config location…
> I'm thinking about using a parameterized test. This will work as long the two
> config define exactly the same catalogs.
>
> WDYT?
>
> Benedikt
>
> Am 13.06.2013 um 21:50 schrieb brit...@apache.org:
>
>> Author: britter
>> Date: Thu Jun 13 19:50:01 2013
>> New Revision: 1492833
>>
>> URL: http://svn.apache.org/r1492833
>> Log:
>> Pull up common methods in abstract base class
>>
>> Added:
>>
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java
>> Modified:
>>
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParser2TestCase.java
>>
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/XmlConfigParserTestCase.java
>>
>> commons/proper/chain/trunk/configuration/xml/src/test/resources/org/apache/commons/chain2/config/xml/test-config.xml
>>
>> Added:
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java?rev=1492833&view=auto
>> ==
>> ---
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java
>> (added)
>> +++
>> commons/proper/chain/trunk/configuration/xml/src/test/java/org/apache/commons/chain2/config/xml/AbstractXmlParserTest.java
>> Thu Jun 13 19:50:01 2013
>> @@ -0,0 +1,119 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +
>> +package org.apache.commons.chain2.config.xml;
>> +
>> +import static org.junit.Assert.assertEquals;
>> +import static org.junit.Assert.assertNotNull;
>> +
>> +import java.net.URL;
>> +import java.util.Iterator;
>> +
>> +import org.apache.commons.chain2.Catalog;
>> +import org.apache.commons.chain2.CatalogFactory;
>> +import org.apache.commons.chain2.Context;
>> +import org.apache.commons.chain2.impl.CatalogBase;
>> +import org.apache.commons.chain2.impl.CatalogFactoryBase;
>> +import org.apache.commons.chain2.impl.ContextBase;
>> +import org.junit.After;
>> +import org.junit.Before;
>> +
>> +public abstract class AbstractXmlParserTest {
>> +
>> +// -- Instance
>> Variables
>> +
>> +/**
>> + * The Catalog to contain our configured commands.
>> + */
>> +protected Catalog> catalog =
>> null;
>> +
>> +/**
>> + * The Context to use for execution tests.
>> + */
>> +protected Context context = null;
>> +
>> +/**
>> + * The ConfigParser instance under test.
>> + */
>> +protected XmlConfigParser parser = null;
>> +
>> +
>> +// Overall Test
>> Methods
>> +
>> +
>> +/**
>> + * Set up instance variables required by this test case.
>> + */
>> +@Before
>> +public void setUp() {
>> +CatalogFactory.clear();
>> +catalog = new CatalogBase> Object>>();
>> +context = new ContextBase();
>> +parser = new XmlConfigParser();
>> +}
>> +
>> +
>> +/**
>> + * Tear down instance variables required by this test case.
>> + */
>> +@After
>> +public void tearDown() {
>> +parser = null;
>> +context = null;
>> +catalog = null;
>> +}
>> +
>> +
>> +// - Private
>> Methods
>> +
>> +
>> +// Verify the number of configured commands
>> +protected void checkCommandCount(int expected) {
>> +int n = 0;
>> +Iterator names = catalog.getNames();
>> +while (names.hasNext()) {
>> +String
