Re: commons-monitoring?

[Romain Manni-Bucau]

Hi

i was able to commit this morning :)

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/7/28 Romain Manni-Bucau 

> Hi,
>
> thanks Mark but i still get issues:
>
> ┌( rmannibucau @ ubuntu )─( 1.7.0 -:- 3.1.0 )
> └( /opt/dev/tomee/commons-monitoring )·> svn ci -m "removing gauge which
> weren't really gauge, replacing it by a counter in counters, adding basic
> config, splitting in several modules, adding some js sorting/filtering in
> html format"
> SendingPROPOSAL.html
> Adding aop
> svn: E195023: Commit failed (details follow):
> svn: E195023: Changing directory '/opt/dev/tomee/commons-monitoring/aop'
> is forbidden by the server
> svn: E175013: Access to
> '/repos/asf/!svn/rvr/1506987/commons/sandbox/monitoring/trunk/instrumentation'
> forbidden
>
>
>
> btw here is a patch with a little html with js sorting/filtering
> https://gist.github.com/rmannibucau/738df316addfe0f14974
>
> i used tablesorter plugin for jquery, both are under MIT license so it
> should be fine (please correct me if not).
>
> About it i wonder if we should paginate or not the rendering (i started
> with but it can be done using
> http://mottie.github.io/tablesorter/docs/example-pager-ajax.html - ATM
> i'm not sure it would be useful) + which techno to use to build the website
> associated to the reporting module (ATM the whole HTML is generated by HTML
> format/MonitoringServlet but there is a single page ;)
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau *
> *Blog: **http://rmannibucau.wordpress.com/*
> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> *Github: https://github.com/rmannibucau*
>
>
>
> 2013/7/28 Mark Struberg 
>
>> Hi folks!
>>
>> Romain is a great guy, I've now added him to commons-sandbox.
>>
>> LieGrue,
>> strub
>>
>>
>>
>>
>> - Original Message -
>> From: James Carman 
>> To: Commons Developers List 
>> Cc:
>> Sent: Saturday, 27 July 2013, 3:46
>> Subject: Re: commons-monitoring?
>>
>> On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau
>>  wrote:
>> > Well we can discuss it in another thread but basically commons spirit
>> for
>> > me is more basic and shouldn't be a facade (excepted logging). So i'd
>> > rather see proxy as an implementation of proxying using asm efficiently.
>> > The issue with proxying is not its lifecycle or API in general but its
>> > specificities (cache, proxy names, handlers...). The best solution IMO
>> is
>> > to propose a unified solution which could be a facade but facade means
>> all
>> > impl specificities in its API which makes it harder or specific (in v1
>> > instantiating the factory was a pain IMO since it is specific). ATM the
>> > question for me is always which one do i import depending my container,
>> do
>> > i test against all proxies impl? Etc... it makes libs hard to write and
>> > maintain
>>
>> Great feedback!  Please start another thread so we can discuss.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
>

Re: commons-monitoring?

[Romain Manni-Bucau]

Hi,

thanks Mark but i still get issues:

┌( rmannibucau @ ubuntu )─( 1.7.0 -:- 3.1.0 )
└( /opt/dev/tomee/commons-monitoring )·> svn ci -m "removing gauge which
weren't really gauge, replacing it by a counter in counters, adding basic
config, splitting in several modules, adding some js sorting/filtering in
html format"
SendingPROPOSAL.html
Adding aop
svn: E195023: Commit failed (details follow):
svn: E195023: Changing directory '/opt/dev/tomee/commons-monitoring/aop' is
forbidden by the server
svn: E175013: Access to
'/repos/asf/!svn/rvr/1506987/commons/sandbox/monitoring/trunk/instrumentation'
forbidden



btw here is a patch with a little html with js sorting/filtering
https://gist.github.com/rmannibucau/738df316addfe0f14974

i used tablesorter plugin for jquery, both are under MIT license so it
should be fine (please correct me if not).

About it i wonder if we should paginate or not the rendering (i started
with but it can be done using
http://mottie.github.io/tablesorter/docs/example-pager-ajax.html - ATM i'm
not sure it would be useful) + which techno to use to build the website
associated to the reporting module (ATM the whole HTML is generated by HTML
format/MonitoringServlet but there is a single page ;)

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/7/28 Mark Struberg 

> Hi folks!
>
> Romain is a great guy, I've now added him to commons-sandbox.
>
> LieGrue,
> strub
>
>
>
>
> - Original Message -
> From: James Carman 
> To: Commons Developers List 
> Cc:
> Sent: Saturday, 27 July 2013, 3:46
> Subject: Re: commons-monitoring?
>
> On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau
>  wrote:
> > Well we can discuss it in another thread but basically commons spirit for
> > me is more basic and shouldn't be a facade (excepted logging). So i'd
> > rather see proxy as an implementation of proxying using asm efficiently.
> > The issue with proxying is not its lifecycle or API in general but its
> > specificities (cache, proxy names, handlers...). The best solution IMO is
> > to propose a unified solution which could be a facade but facade means
> all
> > impl specificities in its API which makes it harder or specific (in v1
> > instantiating the factory was a pain IMO since it is specific). ATM the
> > question for me is always which one do i import depending my container,
> do
> > i test against all proxies impl? Etc... it makes libs hard to write and
> > maintain
>
> Great feedback!  Please start another thread so we can discuss.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [proxy] and impl

[Romain Manni-Bucau]

answers inline

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/7/28 Matt Benson 

> Interesting patch. I have some questions and comments:
>
> - You'd additionally need to make sure the impl class is non-final, no?
>

hmm, good question i didn't check but with asm we can subclass final
classes, hehe


> - note to others that asm4-shaded is used because asm didn't change
> packages from v3. Good to see this in use; I hadn't kept track after
> submitting that patch.  ;-)
>

i used asm4 since that's the more up to date and it supports java 7 very
well. The shade was used since provided in tomee and owb but real asm
should be fine (see next point)


> - Would you explain the purpose of the AsmFacade class? Much of the "nuts
> and bolts" work of the patch seems quite different from what I perceive as
> "typical asm client code."
>

i first wrote it with asm imports but a common issue is: do i use asm?
spring-asm-shade? xbean-asm-shade? so AsmFacade is an utility class to
allow to use whatever impl is here (almost).


> Back to the subject of cglib, do you expect this implementation should
> significantly outperform it for any reason ( if so, which? ), or is the
> main motivation that cglib is almost dead as you say?
>

since cglib is dead we need something else and i expect the impl to be
faster than javassist. Another nice side effect is no dep in a container
providing asm.


>  Thanks and regards,
> Matt
> On Jul 28, 2013 10:58 AM, "Romain Manni-Bucau" 
> wrote:
>
>> Hi
>>
>> here is a patch implementing proxying using ASM:
>> https://gist.github.com/rmannibucau/6099063
>>
>> having the handlers used by default in ProxyFactory protected would avoid
>> to copy them in ASMProxyFactory.
>>
>> *Romain Manni-Bucau*
>> *Twitter: @rmannibucau *
>> *Blog: 
>> **http://rmannibucau.wordpress.com/*
>> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
>> *Github: https://github.com/rmannibucau*
>>
>>
>>
>> 2013/7/28 Romain Manni-Bucau 
>>
>>> Cglib is "almost" dead if i'm right, javassist is alive but not that
>>> stable and owb is faster ATM and at least would bring an Apache impl
>>> adapted to [proxy].
>>>
>>> Note: the fact to be able to reuse InvocationHandler and not a new API
>>> is great too
>>> Le 27 juil. 2013 20:13, "Matt Benson"  a écrit :
>>>
>>> AFAIK Mark Struberg's work on the OWB proxies could be instructive, and
 since I've just spent several weeks in ASM hell I might just be a bit of
 use there myself. The only thing is, isn't cglib built on ASM as well?
 The
 dynamic nature of the various proxy helpers means that we probably
 couldn't
 really improve on cglib, i.e. only if we could test invocation matching
 up
 front while creating the proxy class would we be faster.

 Matt
 On Jul 27, 2013 12:22 PM, "Romain Manni-Bucau" 
 wrote:

 > Hehe, we benched in owb but lets wait the porting ;)
 > Le 27 juil. 2013 16:49, "James Carman"  a
 > écrit :
 >
 > > On Sat, Jul 27, 2013 at 10:34 AM, Romain Manni-Bucau
 > >  wrote:
 > > > Once ill have done the monitoring stuff ill try to work on it.
 > >
 > > What would be really cool is to have a "smackdown" once we get ASM
 > > into the mix to see which one performs the best and exactly how fast
 > > they are compared to one another.
 > >
 > >
 -
 > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 > > For additional commands, e-mail: dev-h...@commons.apache.org
 > >
 > >
 >

>>>
>>

Re: [proxy] and impl

[Matt Benson]

Interesting patch. I have some questions and comments:

- You'd additionally need to make sure the impl class is non-final, no?
- note to others that asm4-shaded is used because asm didn't change
packages from v3. Good to see this in use; I hadn't kept track after
submitting that patch.  ;-)
- Would you explain the purpose of the AsmFacade class? Much of the "nuts
and bolts" work of the patch seems quite different from what I perceive as
"typical asm client code."

Back to the subject of cglib, do you expect this implementation should
significantly outperform it for any reason ( if so, which? ), or is the
main motivation that cglib is almost dead as you say?

Thanks and regards,
Matt
On Jul 28, 2013 10:58 AM, "Romain Manni-Bucau" 
wrote:

> Hi
>
> here is a patch implementing proxying using ASM:
> https://gist.github.com/rmannibucau/6099063
>
> having the handlers used by default in ProxyFactory protected would avoid
> to copy them in ASMProxyFactory.
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau *
> *Blog: **http://rmannibucau.wordpress.com/*
> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> *Github: https://github.com/rmannibucau*
>
>
>
> 2013/7/28 Romain Manni-Bucau 
>
>> Cglib is "almost" dead if i'm right, javassist is alive but not that
>> stable and owb is faster ATM and at least would bring an Apache impl
>> adapted to [proxy].
>>
>> Note: the fact to be able to reuse InvocationHandler and not a new API is
>> great too
>> Le 27 juil. 2013 20:13, "Matt Benson"  a écrit :
>>
>> AFAIK Mark Struberg's work on the OWB proxies could be instructive, and
>>> since I've just spent several weeks in ASM hell I might just be a bit of
>>> use there myself. The only thing is, isn't cglib built on ASM as well?
>>> The
>>> dynamic nature of the various proxy helpers means that we probably
>>> couldn't
>>> really improve on cglib, i.e. only if we could test invocation matching
>>> up
>>> front while creating the proxy class would we be faster.
>>>
>>> Matt
>>> On Jul 27, 2013 12:22 PM, "Romain Manni-Bucau" 
>>> wrote:
>>>
>>> > Hehe, we benched in owb but lets wait the porting ;)
>>> > Le 27 juil. 2013 16:49, "James Carman"  a
>>> > écrit :
>>> >
>>> > > On Sat, Jul 27, 2013 at 10:34 AM, Romain Manni-Bucau
>>> > >  wrote:
>>> > > > Once ill have done the monitoring stuff ill try to work on it.
>>> > >
>>> > > What would be really cool is to have a "smackdown" once we get ASM
>>> > > into the mix to see which one performs the best and exactly how fast
>>> > > they are compared to one another.
>>> > >
>>> > > -
>>> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> > > For additional commands, e-mail: dev-h...@commons.apache.org
>>> > >
>>> > >
>>> >
>>>
>>
>

Re: commons-monitoring?

[Mark Struberg]

Hi folks!

Romain is a great guy, I've now added him to commons-sandbox.

LieGrue,
strub




- Original Message -
From: James Carman 
To: Commons Developers List 
Cc: 
Sent: Saturday, 27 July 2013, 3:46
Subject: Re: commons-monitoring?

On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau
 wrote:
> Well we can discuss it in another thread but basically commons spirit for
> me is more basic and shouldn't be a facade (excepted logging). So i'd
> rather see proxy as an implementation of proxying using asm efficiently.
> The issue with proxying is not its lifecycle or API in general but its
> specificities (cache, proxy names, handlers...). The best solution IMO is
> to propose a unified solution which could be a facade but facade means all
> impl specificities in its API which makes it harder or specific (in v1
> instantiating the factory was a pain IMO since it is specific). ATM the
> question for me is always which one do i import depending my container, do
> i test against all proxies impl? Etc... it makes libs hard to write and
> maintain

Great feedback!  Please start another thread so we can discuss.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [proxy] and impl

[Romain Manni-Bucau]

Hi

here is a patch implementing proxying using ASM:
https://gist.github.com/rmannibucau/6099063

having the handlers used by default in ProxyFactory protected would avoid
to copy them in ASMProxyFactory.

*Romain Manni-Bucau*
*Twitter: @rmannibucau *
*Blog: **http://rmannibucau.wordpress.com/*
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/7/28 Romain Manni-Bucau 

> Cglib is "almost" dead if i'm right, javassist is alive but not that
> stable and owb is faster ATM and at least would bring an Apache impl
> adapted to [proxy].
>
> Note: the fact to be able to reuse InvocationHandler and not a new API is
> great too
> Le 27 juil. 2013 20:13, "Matt Benson"  a écrit :
>
> AFAIK Mark Struberg's work on the OWB proxies could be instructive, and
>> since I've just spent several weeks in ASM hell I might just be a bit of
>> use there myself. The only thing is, isn't cglib built on ASM as well? The
>> dynamic nature of the various proxy helpers means that we probably
>> couldn't
>> really improve on cglib, i.e. only if we could test invocation matching up
>> front while creating the proxy class would we be faster.
>>
>> Matt
>> On Jul 27, 2013 12:22 PM, "Romain Manni-Bucau" 
>> wrote:
>>
>> > Hehe, we benched in owb but lets wait the porting ;)
>> > Le 27 juil. 2013 16:49, "James Carman"  a
>> > écrit :
>> >
>> > > On Sat, Jul 27, 2013 at 10:34 AM, Romain Manni-Bucau
>> > >  wrote:
>> > > > Once ill have done the monitoring stuff ill try to work on it.
>> > >
>> > > What would be really cool is to have a "smackdown" once we get ASM
>> > > into the mix to see which one performs the best and exactly how fast
>> > > they are compared to one another.
>> > >
>> > > -
>> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> > > For additional commands, e-mail: dev-h...@commons.apache.org
>> > >
>> > >
>> >
>>
>

[CSV][RTC] Revert builder implementation in CSVFormat

[Benedikt Ritter]

Hi guys,

we've taked about this a lot and finally came to the agreement that we want
to revert the builder implementation we've added a while ago. I've created
a patch for this and attached it to CSV-99 [1]. Since this is a massive
change in how the API works from a user POV I'd like to have some feedback
before applying these changes.

TIA!
Benedikt

[1] https://issues.apache.org/jira/browse/CSV-99


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter