Re: svn commit: r1647869 - in /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java

2014-12-25 Thread Bernd
Currently cant commit or I would fix it myself, the 50ms from comment
should be removed (twice)

> // Second borrow does not have to wait on create, average should be about
50

Btw: even without the change the tests worked for me on Windows - it does
increase the test time rather dramatic, maybe 200ms is better here?

Greetings
Bernd


Re: svn commit: r1647869 - in /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java

2014-12-25 Thread Phil Steitz
On 12/25/14 3:15 PM, Emmanuel Bourg wrote:
> Le 25/12/2014 04:38, pste...@apache.org a écrit :
>> Author: psteitz
>> Date: Thu Dec 25 03:38:57 2014
>> New Revision: 1647869
>>
>> URL: http://svn.apache.org/r1647869
>> Log:
>> Made POOL-259 tests less dependent on system clock resolution.
> The tests are ok on Windows now, thank you for the fix Phil.

Thanks for testing!

Phil
>
> Emmanuel
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE] Release pool 2.3 based on RC1

2014-12-25 Thread Phil Steitz
On 12/23/14 5:48 PM, sebb wrote:
> On 23 December 2014 at 21:57, Phil Steitz  wrote:
>> On 12/23/14 1:11 PM, sebb wrote:
>>> On 23 December 2014 at 17:32, Phil Steitz  wrote:
 Tag:
 https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_3_RC1/
>>
>> r1647682
>>
 Tags are not immutable;
>> My tags are.
> But someone else could change it.
>
>>>  the vote thread needs the revision.
>>>
 Release:
 https://dist.apache.org/repos/dist/dev/commons/pool/
>> r7545
>>> Likewise, the URL does not uniquely identify what artifacts are being voted 
>>> on.
>>> A revision or hashes of the artifacts are needed.
>>>
>>> Also need link to KEYS file so can check the sigs
>> My key has been on the commons KEYs file for 10+ years now.  I would
>> expect Commons PMC members to know where to grab that file.
> But the vote thread should allow anyone to review the code, not just
> those in the know.
>
 Maven:
 https://repository.apache.org/content/repositories/orgapachecommons-1070

 Site:
 http://people.apache.org/~psteitz/pool/pool-2.3-rc1/

 Release notes:
 https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt

 Votes, please.  This vote will close in 72 hours (26-Dec 17:30 GMT)

 [ ] +1 Release this
 [ ] +0 Ok, but...
 [ ] -0  Really should fix...
 [X] -1 We should not release this RC
>>> The code contains LinkedBlockingDeque which is based on 3rd party code.
>>> There is no corresponding mention in the LICENSE file, this needs to be 
>>> added.
>> This is Apache Harmony code.  The ASF license header is there in the
>> source.
> Yes, but the NOTICE file contains a reference to
>
> http://creativecommons.org/licenses/publicdomain
>
> This is a license, and if it applies to the code, it needs to be in
> the LICENSE file.
> If it does not apply, why is it in NOTICE?
>
> I've found what I assume is the original file:
>
> https://svn.apache.org/repos/asf/harmony/enhanced/java/branches/java6/classlib/modules/concurrent/src/main/java/java/util/concurrent/LinkedBlockingDeque.java
>
> This has the header:
>
> /*
>  * Written by Doug Lea with assistance from members of JCP JSR-166
>  * Expert Group and released to the public domain, as explained at
>  * http://creativecommons.org/licenses/publicdomain
>  */
>
> This does not look to me like a copyright statement that needs to be
> removed to NOTICE.
> See:
> http://www.apache.org/legal/src-headers.html#headers
>
> Seems to me that a simple mention in LICENSE should be enough.

I was on the fence between just putting the header back into the
source or moving the text from NOTICE to LICENSE.  I did that
latter.  Any objections to that?

Phil
>
>> Phil
>>> I'm not sure that there should be a mention in the NOTICE file.
>>> There does not appear to be an attribution requirement.
>>> Or was the attribution removed from existing code?
>>>
 Thanks!

 Phil




 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org

>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1647869 - in /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java

2014-12-25 Thread Emmanuel Bourg
Le 25/12/2014 04:38, pste...@apache.org a écrit :
> Author: psteitz
> Date: Thu Dec 25 03:38:57 2014
> New Revision: 1647869
> 
> URL: http://svn.apache.org/r1647869
> Log:
> Made POOL-259 tests less dependent on system clock resolution.

The tests are ok on Windows now, thank you for the fix Phil.

Emmanuel

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections pull request: [COLLECTIONS-540] Duplication of...

2014-12-25 Thread ielatif
GitHub user ielatif opened a pull request:

https://github.com/apache/commons-collections/pull/6

[COLLECTIONS-540] Duplication of code in CollectionUtils



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ielatif/commons-collections trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit cb78878bce77099720e1f726f06dad0100f7b2e3
Author: ielatif 
Date:   2014-12-25T21:06:04Z

[COLLECTIONS-540] Duplication of code in CollectionUtils




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: request for an article.

2014-12-25 Thread Hasan Diwan
https://commons.apache.org/proper/commons-collections/userguide.html

The users' guide seems to have the data you're looking for. I'm sure, were
you to design a visualisation, the powers-that-be would not be opposed to
including it. -- H

On 25 December 2014 at 00:06, Thomas Neidhart 
wrote:

> On 12/25/2014 01:03 AM, Devang Gaur wrote:
> > Hi folks ,
> > Is there any article with a chart or table  explaining the whole Apache
> > Commons Collections hierarchy? If yes , link please ?.
>
> I am not aware of an article explaining collections, but it is rather
> straight-forward.
>
> The base package org.apache.commons.collections4 contains mainly the
> interfaces, e.g. Bag, OrderedMap, MultiMap, whereas the concrete
> implementations reside in sub-packages, organized by collection type.
>
> Thomas
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
OpenPGP: https://hasan.d8u.us/gpg.key
Sent from my mobile device
Envoyé de mon portable


Re: Fwd: Returned post for committ...@apache.org

2014-12-25 Thread Benedikt Ritter
2014-12-25 16:14 GMT+01:00 Phil Steitz :
>
> On 12/25/14 7:00 AM, Benedikt Ritter wrote:
> > 2014-12-22 16:52 GMT+01:00 Phil Steitz :
> >> On 12/22/14 8:40 AM, Phil Steitz wrote:
> >>> On 12/22/14 7:42 AM, Benedikt Ritter wrote:
>  Well, that didn't work out they way it was supposed to be... Can
> anybody
>  help?
> >>> I think that list is "deprecated" for general announcements.  Better
> >>> to send to |d...@community.apache.org.
> >> or just  commun...@apache.org .  See [1]
> >>
> >> [1] https://svn.apache.org/repos/private/committers/docs/resources.txt
> >
> > I'm not a member of the ASF so I can't access that file. But I'll use
> > commun...@apache.org :o)
>
> Actually, you should be able to check out the committers repo.  See [1].
>

d'oh, of corse you're right.

B


>
> Phil
>
> http://www.apache.org/dev/new-committers-guide.html
> >
> > thanks!
> > Benedikt
> >
> >
> >>> Phil
> >>> |
>  Benedikt
> 
> 
>  -- Forwarded message --
>  From: 
>  Date: 2014-12-20 17:15 GMT+01:00
>  Subject: Returned post for committ...@apache.org
>  To: brit...@apache.org
> 
> 
>  Hi! This is the ezmlm program. I'm managing the
>  committ...@apache.org mailing list.
> 
>  I'm sorry, the list moderators for the committers list
>  have failed to act on your post. Thus, I'm returning it to you.
>  If you feel that this is in error, please repost the message
>  or contact a list moderator directly.
> 
>  --- Enclosed, please find the message you sent.
> 
> 
> 
> 
>  -- Weitergeleitete Nachricht --
>  From: Benedikt Ritter 
>  To: committ...@apache.org, Commons Developers List <
> >> dev@commons.apache.org>
>  Cc:
>  Date: Mon, 15 Dec 2014 17:05:21 +0100
>  Subject: [ANNOUNCEMENT] Apache Commons grants write access to all ASF
>  committers
>  Dear fellow committers,
> 
>  The Apache Commons Team is pleased to announce that write access to
> the
>  Apache Commons Subversion and Git repositories has been granted to all
> >> ASF
>  committers.
> 
>  Apache Commons is an Apache project focused on all aspects of reusable
> >> Java
>  components. As such, the components maintained by the Apache Commons
> >> project
>  may be of interest to a variety of other Apache projects.
> 
>  The Apache Commons community would like to invite you to share and
> >> maintain
>  useful code.
> 
>  While Apache Commons is a Commit-Then-Review community, we would
> >> consider
>  it polite and helpful for contributors to announce their intentions
> and
>  plans on the dev mailing list [1] before committing code.
> 
> 
>  Have fun,
> 
>  Benedikt Ritter,
>  on behalf of the Apache Commons Community
> 
>  [1] http://commons.apache.org/mail-lists.html
> 
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


Re: Fwd: Returned post for committ...@apache.org

2014-12-25 Thread Phil Steitz
On 12/25/14 7:00 AM, Benedikt Ritter wrote:
> 2014-12-22 16:52 GMT+01:00 Phil Steitz :
>> On 12/22/14 8:40 AM, Phil Steitz wrote:
>>> On 12/22/14 7:42 AM, Benedikt Ritter wrote:
 Well, that didn't work out they way it was supposed to be... Can anybody
 help?
>>> I think that list is "deprecated" for general announcements.  Better
>>> to send to |d...@community.apache.org.
>> or just  commun...@apache.org .  See [1]
>>
>> [1] https://svn.apache.org/repos/private/committers/docs/resources.txt
>
> I'm not a member of the ASF so I can't access that file. But I'll use
> commun...@apache.org :o)

Actually, you should be able to check out the committers repo.  See [1].

Phil

http://www.apache.org/dev/new-committers-guide.html
>
> thanks!
> Benedikt
>
>
>>> Phil
>>> |
 Benedikt


 -- Forwarded message --
 From: 
 Date: 2014-12-20 17:15 GMT+01:00
 Subject: Returned post for committ...@apache.org
 To: brit...@apache.org


 Hi! This is the ezmlm program. I'm managing the
 committ...@apache.org mailing list.

 I'm sorry, the list moderators for the committers list
 have failed to act on your post. Thus, I'm returning it to you.
 If you feel that this is in error, please repost the message
 or contact a list moderator directly.

 --- Enclosed, please find the message you sent.




 -- Weitergeleitete Nachricht --
 From: Benedikt Ritter 
 To: committ...@apache.org, Commons Developers List <
>> dev@commons.apache.org>
 Cc:
 Date: Mon, 15 Dec 2014 17:05:21 +0100
 Subject: [ANNOUNCEMENT] Apache Commons grants write access to all ASF
 committers
 Dear fellow committers,

 The Apache Commons Team is pleased to announce that write access to the
 Apache Commons Subversion and Git repositories has been granted to all
>> ASF
 committers.

 Apache Commons is an Apache project focused on all aspects of reusable
>> Java
 components. As such, the components maintained by the Apache Commons
>> project
 may be of interest to a variety of other Apache projects.

 The Apache Commons community would like to invite you to share and
>> maintain
 useful code.

 While Apache Commons is a Commit-Then-Review community, we would
>> consider
 it polite and helpful for contributors to announce their intentions and
 plans on the dev mailing list [1] before committing code.


 Have fun,

 Benedikt Ritter,
 on behalf of the Apache Commons Community

 [1] http://commons.apache.org/mail-lists.html

>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Fwd: Returned post for committ...@apache.org

2014-12-25 Thread Benedikt Ritter
2014-12-22 16:52 GMT+01:00 Phil Steitz :
>
> On 12/22/14 8:40 AM, Phil Steitz wrote:
> > On 12/22/14 7:42 AM, Benedikt Ritter wrote:
> >> Well, that didn't work out they way it was supposed to be... Can anybody
> >> help?
> > I think that list is "deprecated" for general announcements.  Better
> > to send to |d...@community.apache.org.
>
> or just  commun...@apache.org .  See [1]
>
> [1] https://svn.apache.org/repos/private/committers/docs/resources.txt


I'm not a member of the ASF so I can't access that file. But I'll use
commun...@apache.org :o)

thanks!
Benedikt


>
> >
> > Phil
> > |
> >> Benedikt
> >>
> >>
> >> -- Forwarded message --
> >> From: 
> >> Date: 2014-12-20 17:15 GMT+01:00
> >> Subject: Returned post for committ...@apache.org
> >> To: brit...@apache.org
> >>
> >>
> >> Hi! This is the ezmlm program. I'm managing the
> >> committ...@apache.org mailing list.
> >>
> >> I'm sorry, the list moderators for the committers list
> >> have failed to act on your post. Thus, I'm returning it to you.
> >> If you feel that this is in error, please repost the message
> >> or contact a list moderator directly.
> >>
> >> --- Enclosed, please find the message you sent.
> >>
> >>
> >>
> >>
> >> -- Weitergeleitete Nachricht --
> >> From: Benedikt Ritter 
> >> To: committ...@apache.org, Commons Developers List <
> dev@commons.apache.org>
> >> Cc:
> >> Date: Mon, 15 Dec 2014 17:05:21 +0100
> >> Subject: [ANNOUNCEMENT] Apache Commons grants write access to all ASF
> >> committers
> >> Dear fellow committers,
> >>
> >> The Apache Commons Team is pleased to announce that write access to the
> >> Apache Commons Subversion and Git repositories has been granted to all
> ASF
> >> committers.
> >>
> >> Apache Commons is an Apache project focused on all aspects of reusable
> Java
> >> components. As such, the components maintained by the Apache Commons
> project
> >> may be of interest to a variety of other Apache projects.
> >>
> >> The Apache Commons community would like to invite you to share and
> maintain
> >> useful code.
> >>
> >> While Apache Commons is a Commit-Then-Review community, we would
> consider
> >> it polite and helpful for contributors to announce their intentions and
> >> plans on the dev mailing list [1] before committing code.
> >>
> >>
> >> Have fun,
> >>
> >> Benedikt Ritter,
> >> on behalf of the Apache Commons Community
> >>
> >> [1] http://commons.apache.org/mail-lists.html
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter


Re: request for an article.

2014-12-25 Thread Thomas Neidhart
On 12/25/2014 01:03 AM, Devang Gaur wrote:
> Hi folks ,
> Is there any article with a chart or table  explaining the whole Apache
> Commons Collections hierarchy? If yes , link please ?.

I am not aware of an article explaining collections, but it is rather
straight-forward.

The base package org.apache.commons.collections4 contains mainly the
interfaces, e.g. Bag, OrderedMap, MultiMap, whereas the concrete
implementations reside in sub-packages, organized by collection type.

Thomas

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org