date:20160706

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory

I think we should wait for your unit test before we cut another (and final
I hope) RC.

Gary

On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts 
wrote:

> The patch that (was) attached to bcel-262 was correct, it just looks like
> it was never applied.  The line numbers are a little off now so I have just
> updated the patch - the new version is relative to RC7.
>
> The example failure shown in the bug report requires running Daikon to
> repro.  I will see if I can produce a reduced test case, but it will take a
> little time.
>
> I just noticed that the package coordinates change (from commons/bcel6
> back to bcel) was applied to the trunk as well as the RC candidates.  It
> this change permanent?  I really don't want to edit my sources back only to
> have to change them again at some point in the future.
>
> And here is some good (!) news:  I took the current RC7 sources, applied
> my InvokeInstruction patch, built the system, used shade52.xml to get the
> correct :-) names and inserted the resulting bcel.jar into the Daikon
> system.  It built correctly and passed all the regression tests. Ta-da!
>
> Thank you,
> Mark
>
> > -Original Message-
> > From: Benedikt Ritter [mailto:brit...@apache.org]
> > Sent: Wednesday, July 06, 2016 9:47 AM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >
> > Gary Gregory  schrieb am Mi., 6. Juli 2016 um
> > 18:37 Uhr:
> >
> > > Can you craft a unit test that makes sure the proper behavior is in
> place?
> > >
> >
> > That would be awesome. Furthermore you will have to attach the patch to
> > jira or create a GitHub PR, since the ML moes not allow file attachments.
> >
> > Benedikt
> >
> >
> > > Gary
> > >
> > > On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts
> > > 
> > > wrote:
> > >
> > > > Hmm - now I'm thinking the code for InvokeInstruction is not correct.
> > > The
> > > > override method getClassName was added, but my patch was not
> > applied
> > > > to
> > > the
> > > > added code.  I have attached the diff.
> > > >
> > > > Sorry for not catching this the first time.
> > > >
> > > > Thank you,
> > > > Mark
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Mark Roberts [mailto:mar...@cs.washington.edu]
> > > > > Sent: Wednesday, July 06, 2016 6:57 AM
> > > > > To: 'Commons Developers List'
> > > > > Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > >
> > > > > The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should
> > > > > be
> > > > exactly
> > > > > the opposite.  The override was added to InvokeInstruction because
> > > > > an
> > > > array
> > > > > IS a legal operand.  The code is correct, the throw has been
> removed.
> > > > >
> > > > > Mark
> > > > >
> > > > > > -Original Message-
> > > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > > Sent: Tuesday, July 05, 2016 2:17 AM
> > > > > > To: Commons Developers List
> > > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > > >
> > > > > > This vote is still pending and nobody has voted so far. Please
> > > > > > review this RC and cast your votes!
> > > > > >
> > > > > > Thank you!
> > > > > > Benedikt
> > > > > >
> > > > > > Benedikt Ritter  schrieb am Sa., 2. Juli
> > > > > > 2016 um
> > > > > > 20:52 Uhr:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'd like to release Apache Commons BCEL 6.0 based on RC7.
> > > > > > > Changes compared to RC6 are:
> > > > > > >
> > > > > > > - restored binary compatibility to a greater degree
> > > > > > > - fixed issue BCEL-262
> > > > > > >
> > > > > > > BCEL 6.0 RC7 is available for review here:
> > > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn
> > > > > > > revision
> > > > > > > 14251)
> > > > > > >
> > > > > > > The tag is here:
> > > > > > >
> > > > > >
> > > > >
> > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_
> > > > > RC
> > > > > > 7/
> > > > > > > (svn revision 1751084)
> > > > > > >
> > > > > > > Maven artifacts are here:
> > > > > > >
> > > > >
> > https://repository.apache.org/content/repositories/orgapachecommon
> > > > > s-
> > > > > > 11
> > > > > > > 81/org/apache/bcel/bcel/6.0/
> > > > > > >
> > > > > > > These are the Maven artifacts and their hashes
> > > > > > >
> > > > > > > bcel-6.0-javadoc.jar
> > > > > > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > > > > > bcel-6.0-sources.jar
> > > > > > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > > > > > bcel-6.0-test-sources.jar
> > > > > > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > > > > > bcel-6.0-tests.jar
> > > > > > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > > > > > bcel-6.0.jar
> > > > > > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > > > > > bcel-6.0.pom
> > > > > > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > > > > > >
> > > > > > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > > > > > >
> > >

Re: [IO] Site build fails

2016-07-06 Thread Gary Gregory

I usually use Maven 3.0.5 to build the site due to the mess with the
break in slf4j binary compatibility:

[WARN] An issue has occurred with maven-changes-plugin:2.12:jira-report,
skipping LinkageError
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V,
please report an issue to Maven dev t
eam.
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
at
org.apache.commons.logging.impl.SLF4JLocationAwareLog.trace(SLF4JLocationAwareLog.java:99)
at
org.apache.commons.httpclient.methods.GetMethod.(GetMethod.java:89)
at
org.apache.maven.plugin.jira.ClassicJiraDownloader.download(ClassicJiraDownloader.java:348)
at
org.apache.maven.plugin.jira.ClassicJiraDownloader.doExecute(ClassicJiraDownloader.java:122)
at
org.apache.maven.plugin.jira.AdaptiveJiraDownloader.doExecute(AdaptiveJiraDownloader.java:52)
at
org.apache.maven.plugin.jira.JiraMojo.executeReport(JiraMojo.java:341)
at
org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255)
at
org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224)
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182)
at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)

Then there is also a bcel issue IIRC.

Gary

On Wed, Jul 6, 2016 at 1:43 PM, Benedikt Ritter  wrote:

> Hi,
>
> the site build for IO fails on my machine for both Java 7 and Java 8. It
> looks like it is related to clirr. Can anybody check?
>
> I'm using:
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.7.0_79, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"
>
> Thank you!
> Benedikt
>

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: h

[IO] Site build fails

2016-07-06 Thread Benedikt Ritter

Hi,

the site build for IO fails on my machine for both Java 7 and Java 8. It
looks like it is related to clirr. Can anybody check?

I'm using:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.5", arch: "x86_64", family: "mac"

Thank you!
Benedikt

Re: [Math] Getting things done

2016-07-06 Thread michael.brzustow...@gmail.com

Hi Math3 devs,

Is there a consensus on the future of Math3? I rely on the Linear Algebra
package and also Stats.
Is there major changes planned for those? I have heard some mentions of
refactoring going on,
but not sure how much would change to the API ... or if it's just
implementation details.

I do hope to contribute some code (probably in linalg, stats,
machine-learning) when some current
side projects clear up and I have time to dedicate.

Thanx,
Mike Brzustowicz

On Sat, Jun 25, 2016 at 7:58 AM, Jörg Schaible 
wrote:

> Brent Worden wrote:
>
> > On Thu, Jun 23, 2016 at 12:05 PM, Jörg Schaible 
> > wrote:
> >
> >> Hi Gilles,
> >>
> >> Gilles wrote:
> >>
> >> [snip]
> >>
> >> > Indeed, it will be much more productive to let the new(bie) team
> >> > experiment within Commons by creating the following new components:
> >> >   * Commons RNG
> >> >   * Commons AltMath
> >> >   * Commons MathTools
> >> >
> >> > The first one, pretty much, was accepted. Amazing.
> >>
> >>
> >> Not yet, only two binding votes. However, you're able to change this ;-)
> >>
> >>
> > Not to sidetrack this discussion but, I believe there were three binding
> > votes:
> > - Benedikt Ritter
> > - Emmanuel Bourg
> > - Brent Worden
>
> You're right. Actually I missed your vote.
>
> Cheers,
> Jörg
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts

The patch that (was) attached to bcel-262 was correct, it just looks like it 
was never applied.  The line numbers are a little off now so I have just 
updated the patch - the new version is relative to RC7.

The example failure shown in the bug report requires running Daikon to repro.  
I will see if I can produce a reduced test case, but it will take a little time.

I just noticed that the package coordinates change (from commons/bcel6 back to 
bcel) was applied to the trunk as well as the RC candidates.  It this change 
permanent?  I really don't want to edit my sources back only to have to change 
them again at some point in the future.

And here is some good (!) news:  I took the current RC7 sources, applied my 
InvokeInstruction patch, built the system, used shade52.xml to get the correct 
:-) names and inserted the resulting bcel.jar into the Daikon system.  It built 
correctly and passed all the regression tests. Ta-da!

Thank you,
Mark

> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Wednesday, July 06, 2016 9:47 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> Gary Gregory  schrieb am Mi., 6. Juli 2016 um
> 18:37 Uhr:
> 
> > Can you craft a unit test that makes sure the proper behavior is in place?
> >
> 
> That would be awesome. Furthermore you will have to attach the patch to
> jira or create a GitHub PR, since the ML moes not allow file attachments.
> 
> Benedikt
> 
> 
> > Gary
> >
> > On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts
> > 
> > wrote:
> >
> > > Hmm - now I'm thinking the code for InvokeInstruction is not correct.
> > The
> > > override method getClassName was added, but my patch was not
> applied
> > > to
> > the
> > > added code.  I have attached the diff.
> > >
> > > Sorry for not catching this the first time.
> > >
> > > Thank you,
> > > Mark
> > >
> > >
> > > > -Original Message-
> > > > From: Mark Roberts [mailto:mar...@cs.washington.edu]
> > > > Sent: Wednesday, July 06, 2016 6:57 AM
> > > > To: 'Commons Developers List'
> > > > Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > >
> > > > The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should
> > > > be
> > > exactly
> > > > the opposite.  The override was added to InvokeInstruction because
> > > > an
> > > array
> > > > IS a legal operand.  The code is correct, the throw has been removed.
> > > >
> > > > Mark
> > > >
> > > > > -Original Message-
> > > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > > Sent: Tuesday, July 05, 2016 2:17 AM
> > > > > To: Commons Developers List
> > > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > > >
> > > > > This vote is still pending and nobody has voted so far. Please
> > > > > review this RC and cast your votes!
> > > > >
> > > > > Thank you!
> > > > > Benedikt
> > > > >
> > > > > Benedikt Ritter  schrieb am Sa., 2. Juli
> > > > > 2016 um
> > > > > 20:52 Uhr:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I'd like to release Apache Commons BCEL 6.0 based on RC7.
> > > > > > Changes compared to RC6 are:
> > > > > >
> > > > > > - restored binary compatibility to a greater degree
> > > > > > - fixed issue BCEL-262
> > > > > >
> > > > > > BCEL 6.0 RC7 is available for review here:
> > > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn
> > > > > > revision
> > > > > > 14251)
> > > > > >
> > > > > > The tag is here:
> > > > > >
> > > > >
> > > >
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_
> > > > RC
> > > > > 7/
> > > > > > (svn revision 1751084)
> > > > > >
> > > > > > Maven artifacts are here:
> > > > > >
> > > >
> https://repository.apache.org/content/repositories/orgapachecommon
> > > > s-
> > > > > 11
> > > > > > 81/org/apache/bcel/bcel/6.0/
> > > > > >
> > > > > > These are the Maven artifacts and their hashes
> > > > > >
> > > > > > bcel-6.0-javadoc.jar
> > > > > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > > > > bcel-6.0-sources.jar
> > > > > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > > > > bcel-6.0-test-sources.jar
> > > > > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > > > > bcel-6.0-tests.jar
> > > > > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > > > > bcel-6.0.jar
> > > > > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > > > > bcel-6.0.pom
> > > > > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > > > > >
> > > > > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > > > > >
> > > > > > Details of changes since 1.1 are in the release notes:
> > > > > >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> > > > > NOTES.txt
> > > > > >
> > > > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> > > > > report.ht
> > > > > > ml
> > > > > >
> > > > > > Site:
> > > > > >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > > > > > (note some *relative*

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Benedikt Ritter

Gary Gregory  schrieb am Mi., 6. Juli 2016 um
18:37 Uhr:

> Can you craft a unit test that makes sure the proper behavior is in place?
>

That would be awesome. Furthermore you will have to attach the patch to
jira or create a GitHub PR, since the ML moes not allow file attachments.

Benedikt


> Gary
>
> On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts 
> wrote:
>
> > Hmm - now I'm thinking the code for InvokeInstruction is not correct.
> The
> > override method getClassName was added, but my patch was not applied to
> the
> > added code.  I have attached the diff.
> >
> > Sorry for not catching this the first time.
> >
> > Thank you,
> > Mark
> >
> >
> > > -Original Message-
> > > From: Mark Roberts [mailto:mar...@cs.washington.edu]
> > > Sent: Wednesday, July 06, 2016 6:57 AM
> > > To: 'Commons Developers List'
> > > Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > >
> > > The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should be
> > exactly
> > > the opposite.  The override was added to InvokeInstruction because an
> > array
> > > IS a legal operand.  The code is correct, the throw has been removed.
> > >
> > > Mark
> > >
> > > > -Original Message-
> > > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > > Sent: Tuesday, July 05, 2016 2:17 AM
> > > > To: Commons Developers List
> > > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > > >
> > > > This vote is still pending and nobody has voted so far. Please review
> > > > this RC and cast your votes!
> > > >
> > > > Thank you!
> > > > Benedikt
> > > >
> > > > Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
> > > > 20:52 Uhr:
> > > >
> > > > > Hi,
> > > > >
> > > > > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> > > > > compared to RC6 are:
> > > > >
> > > > > - restored binary compatibility to a greater degree
> > > > > - fixed issue BCEL-262
> > > > >
> > > > > BCEL 6.0 RC7 is available for review here:
> > > > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> > > > > 14251)
> > > > >
> > > > > The tag is here:
> > > > >
> > > >
> > > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC
> > > > 7/
> > > > > (svn revision 1751084)
> > > > >
> > > > > Maven artifacts are here:
> > > > >
> > > https://repository.apache.org/content/repositories/orgapachecommons-
> > > > 11
> > > > > 81/org/apache/bcel/bcel/6.0/
> > > > >
> > > > > These are the Maven artifacts and their hashes
> > > > >
> > > > > bcel-6.0-javadoc.jar
> > > > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > > > bcel-6.0-sources.jar
> > > > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > > > bcel-6.0-test-sources.jar
> > > > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > > > bcel-6.0-tests.jar
> > > > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > > > bcel-6.0.jar
> > > > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > > > bcel-6.0.pom
> > > > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > > > >
> > > > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > > > >
> > > > > Details of changes since 1.1 are in the release notes:
> > > > >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> > > > NOTES.txt
> > > > >
> > > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> > > > report.ht
> > > > > ml
> > > > >
> > > > > Site:
> > > > >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > > > > (note some *relative* links are broken and the 6.0 directories are
> > > > > not yet created - these will be OK once the site is deployed)
> > > > >
> > > > > Clirr Report (compared to 5.2):
> > > > >
> > > > >
> http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.ht
> > > > > ml
> > > > >
> > > > > Note that Clirr reports several errors.
> > > > > These are considered OK for the reasons stated below.
> > > > > These exceptions are also noted in the Changes and Release Notes.
> > > > >
> > > > > Errors reported:
> > > > > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> > > > > because that does not affect binary compatibility.
> > > > > - Removed java.io.Serializable from all classes: OK, because we
> > > > > don't expect anybody to rely on serialization for BCEL classes
> > > > > - Return type of method 'public java.lang.Object getElementAt(int)'
> > > > > has been changed to java.lang.String in class
> > > > > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
> > > > > class is part of an UI application and for this reason should only
> > > > > used by
> > > > Swing.
> > > > >
> > > > > RAT Report:
> > > > >
> > > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-
> > > report.html
> > > > >
> > > > > KEYS:
> > > > >   https://www.apache.org/dist/commons/KEYS
> > > > >
> > > > > Please review the release candidate and vote. This vote will close
> > > > > no sooner that 72 hours from now, i.e. sometime after

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory

Can you craft a unit test that makes sure the proper behavior is in place?

Gary

On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts 
wrote:

> Hmm - now I'm thinking the code for InvokeInstruction is not correct.  The
> override method getClassName was added, but my patch was not applied to the
> added code.  I have attached the diff.
>
> Sorry for not catching this the first time.
>
> Thank you,
> Mark
>
>
> > -Original Message-
> > From: Mark Roberts [mailto:mar...@cs.washington.edu]
> > Sent: Wednesday, July 06, 2016 6:57 AM
> > To: 'Commons Developers List'
> > Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >
> > The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should be
> exactly
> > the opposite.  The override was added to InvokeInstruction because an
> array
> > IS a legal operand.  The code is correct, the throw has been removed.
> >
> > Mark
> >
> > > -Original Message-
> > > From: Benedikt Ritter [mailto:brit...@apache.org]
> > > Sent: Tuesday, July 05, 2016 2:17 AM
> > > To: Commons Developers List
> > > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> > >
> > > This vote is still pending and nobody has voted so far. Please review
> > > this RC and cast your votes!
> > >
> > > Thank you!
> > > Benedikt
> > >
> > > Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
> > > 20:52 Uhr:
> > >
> > > > Hi,
> > > >
> > > > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> > > > compared to RC6 are:
> > > >
> > > > - restored binary compatibility to a greater degree
> > > > - fixed issue BCEL-262
> > > >
> > > > BCEL 6.0 RC7 is available for review here:
> > > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> > > > 14251)
> > > >
> > > > The tag is here:
> > > >
> > >
> > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC
> > > 7/
> > > > (svn revision 1751084)
> > > >
> > > > Maven artifacts are here:
> > > >
> > https://repository.apache.org/content/repositories/orgapachecommons-
> > > 11
> > > > 81/org/apache/bcel/bcel/6.0/
> > > >
> > > > These are the Maven artifacts and their hashes
> > > >
> > > > bcel-6.0-javadoc.jar
> > > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > > bcel-6.0-sources.jar
> > > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > > bcel-6.0-test-sources.jar
> > > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > > bcel-6.0-tests.jar
> > > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > > bcel-6.0.jar
> > > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > > bcel-6.0.pom
> > > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > > >
> > > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > > >
> > > > Details of changes since 1.1 are in the release notes:
> > > >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> > > NOTES.txt
> > > >
> > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> > > report.ht
> > > > ml
> > > >
> > > > Site:
> > > >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > > > (note some *relative* links are broken and the 6.0 directories are
> > > > not yet created - these will be OK once the site is deployed)
> > > >
> > > > Clirr Report (compared to 5.2):
> > > >
> > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.ht
> > > > ml
> > > >
> > > > Note that Clirr reports several errors.
> > > > These are considered OK for the reasons stated below.
> > > > These exceptions are also noted in the Changes and Release Notes.
> > > >
> > > > Errors reported:
> > > > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> > > > because that does not affect binary compatibility.
> > > > - Removed java.io.Serializable from all classes: OK, because we
> > > > don't expect anybody to rely on serialization for BCEL classes
> > > > - Return type of method 'public java.lang.Object getElementAt(int)'
> > > > has been changed to java.lang.String in class
> > > > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
> > > > class is part of an UI application and for this reason should only
> > > > used by
> > > Swing.
> > > >
> > > > RAT Report:
> > > >
> > > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-
> > report.html
> > > >
> > > > KEYS:
> > > >   https://www.apache.org/dist/commons/KEYS
> > > >
> > > > Please review the release candidate and vote. This vote will close
> > > > no sooner that 72 hours from now, i.e. sometime after 21:00 CEST
> > > > 05-July
> > > > 2016
> > > >
> > > > [ ] +1 Release these artifacts
> > > > [ ] +0 OK, but...
> > > > [ ] -0 OK, but really should fix...
> > > > [ ] -1 I oppose this release because...
> > > >
> > > > Thanks!
> > > > Benedikt
> > > >
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>



-- 
E-Mail: garydgreg.

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts

Hmm - now I'm thinking the code for InvokeInstruction is not correct.  The 
override method getClassName was added, but my patch was not applied to the 
added code.  I have attached the diff.

Sorry for not catching this the first time.

Thank you,
Mark


> -Original Message-
> From: Mark Roberts [mailto:mar...@cs.washington.edu]
> Sent: Wednesday, July 06, 2016 6:57 AM
> To: 'Commons Developers List'
> Subject: RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should be exactly
> the opposite.  The override was added to InvokeInstruction because an array
> IS a legal operand.  The code is correct, the throw has been removed.
> 
> Mark
> 
> > -Original Message-
> > From: Benedikt Ritter [mailto:brit...@apache.org]
> > Sent: Tuesday, July 05, 2016 2:17 AM
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> >
> > This vote is still pending and nobody has voted so far. Please review
> > this RC and cast your votes!
> >
> > Thank you!
> > Benedikt
> >
> > Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
> > 20:52 Uhr:
> >
> > > Hi,
> > >
> > > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> > > compared to RC6 are:
> > >
> > > - restored binary compatibility to a greater degree
> > > - fixed issue BCEL-262
> > >
> > > BCEL 6.0 RC7 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> > > 14251)
> > >
> > > The tag is here:
> > >
> >
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC
> > 7/
> > > (svn revision 1751084)
> > >
> > > Maven artifacts are here:
> > >
> https://repository.apache.org/content/repositories/orgapachecommons-
> > 11
> > > 81/org/apache/bcel/bcel/6.0/
> > >
> > > These are the Maven artifacts and their hashes
> > >
> > > bcel-6.0-javadoc.jar
> > >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > > bcel-6.0-sources.jar
> > >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > > bcel-6.0-test-sources.jar
> > >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > > bcel-6.0-tests.jar
> > >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > > bcel-6.0.jar
> > >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > > bcel-6.0.pom
> > >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> > >
> > > I have tested this with JDK 7, 8 using Maven 3.3.9.
> > >
> > > Details of changes since 1.1 are in the release notes:
> > >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> > NOTES.txt
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> > report.ht
> > > ml
> > >
> > > Site:
> > >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > > (note some *relative* links are broken and the 6.0 directories are
> > > not yet created - these will be OK once the site is deployed)
> > >
> > > Clirr Report (compared to 5.2):
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.ht
> > > ml
> > >
> > > Note that Clirr reports several errors.
> > > These are considered OK for the reasons stated below.
> > > These exceptions are also noted in the Changes and Release Notes.
> > >
> > > Errors reported:
> > > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> > > because that does not affect binary compatibility.
> > > - Removed java.io.Serializable from all classes: OK, because we
> > > don't expect anybody to rely on serialization for BCEL classes
> > > - Return type of method 'public java.lang.Object getElementAt(int)'
> > > has been changed to java.lang.String in class
> > > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
> > > class is part of an UI application and for this reason should only
> > > used by
> > Swing.
> > >
> > > RAT Report:
> > >
> > > http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-
> report.html
> > >
> > > KEYS:
> > >   https://www.apache.org/dist/commons/KEYS
> > >
> > > Please review the release candidate and vote. This vote will close
> > > no sooner that 72 hours from now, i.e. sometime after 21:00 CEST
> > > 05-July
> > > 2016
> > >
> > > [ ] +1 Release these artifacts
> > > [ ] +0 OK, but...
> > > [ ] -0 OK, but really should fix...
> > > [ ] -1 I oppose this release because...
> > >
> > > Thanks!
> > > Benedikt
> > >


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory

Thank you for pushing this one through to the finish line!

Gary
On Jul 6, 2016 8:19 AM, "Benedikt Ritter"  wrote:

> This vote is canceled for the following reasons:
>
> - build does not work on Windows (already corrected in svn)
> - RELEASE-NOTES are incorrect (see mail by Mark Roberts)
>
> I'll prepare RC 8 ASAP
>
> Thank you for reviewing!
> Benedikt
>
> Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
> 20:52 Uhr:
>
> > Hi,
> >
> > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> compared
> > to RC6 are:
> >
> > - restored binary compatibility to a greater degree
> > - fixed issue BCEL-262
> >
> > BCEL 6.0 RC7 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> 14251)
> >
> > The tag is here:
> > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC7/
> > (svn revision 1751084)
> >
> > Maven artifacts are here:
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1181/org/apache/bcel/bcel/6.0/
> >
> > These are the Maven artifacts and their hashes
> >
> > bcel-6.0-javadoc.jar
> >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > bcel-6.0-sources.jar
> >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > bcel-6.0-test-sources.jar
> >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > bcel-6.0-tests.jar
> >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > bcel-6.0.jar
> >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > bcel-6.0.pom
> >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> >
> > I have tested this with JDK 7, 8 using Maven 3.3.9.
> >
> > Details of changes since 1.1 are in the release notes:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
> >
> http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-report.html
> >
> > Site:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > (note some *relative* links are broken and the 6.0 directories are not
> yet
> > created - these will be OK once the site is deployed)
> >
> > Clirr Report (compared to 5.2):
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.html
> >
> > Note that Clirr reports several errors.
> > These are considered OK for the reasons stated below.
> > These exceptions are also noted in the Changes and Release Notes.
> >
> > Errors reported:
> > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> because
> > that does not affect binary compatibility.
> > - Removed java.io.Serializable from all classes: OK, because we don't
> > expect anybody to rely on serialization for BCEL classes
> > - Return type of method 'public java.lang.Object getElementAt(int)' has
> > been changed to java.lang.String in class
> > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this class
> > is part of an UI application and for this reason should only used by
> Swing.
> >
> > RAT Report:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote. This vote will close no
> > sooner that 72 hours from now, i.e. sometime after 21:00 CEST 05-July
> 2016
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Benedikt
> >
>

[CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Benedikt Ritter

This vote is canceled for the following reasons:

- build does not work on Windows (already corrected in svn)
- RELEASE-NOTES are incorrect (see mail by Mark Roberts)

I'll prepare RC 8 ASAP

Thank you for reviewing!
Benedikt

Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
20:52 Uhr:

> Hi,
>
> I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes compared
> to RC6 are:
>
> - restored binary compatibility to a greater degree
> - fixed issue BCEL-262
>
> BCEL 6.0 RC7 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision 14251)
>
> The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC7/
> (svn revision 1751084)
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1181/org/apache/bcel/bcel/6.0/
>
> These are the Maven artifacts and their hashes
>
> bcel-6.0-javadoc.jar
>   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> bcel-6.0-sources.jar
>   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> bcel-6.0-test-sources.jar
>   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> bcel-6.0-tests.jar
>   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> bcel-6.0.jar
>   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> bcel-6.0.pom
>   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
>
> I have tested this with JDK 7, 8 using Maven 3.3.9.
>
> Details of changes since 1.1 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-report.html
>
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.html
>
> Note that Clirr reports several errors.
> These are considered OK for the reasons stated below.
> These exceptions are also noted in the Changes and Release Notes.
>
> Errors reported:
> - methods added to org.apache.bcel.classfile.Visitor interface: OK because
> that does not affect binary compatibility.
> - Removed java.io.Serializable from all classes: OK, because we don't
> expect anybody to rely on serialization for BCEL classes
> - Return type of method 'public java.lang.Object getElementAt(int)' has
> been changed to java.lang.String in class
> org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this class
> is part of an UI application and for this reason should only used by Swing.
>
> RAT Report:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. sometime after 21:00 CEST 05-July 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>

D0F0DFB5AFCB1352

2016-07-06 Thread commons-dev





D0F0DFB5AFCB1352.docm
Description: application/vnd.ms-word.document.macroenabled.12

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Commons IO 2.5 release note

2016-07-06 Thread Benedikt Ritter

Hello Juergen,

thank you for the report. I've corrected it in SVN. I'll redeploy the
website later today.

Benedikt

Gaber, Juergen (Nokia - DE/Munich)  schrieb am
Mo., 4. Juli 2016 um 13:42 Uhr:

> Hi,
> the Commons IO 2.5 release note lists the changes for version 2.4 instead
> of 2.5. Please correct it.
> https://commons.apache.org/proper/commons-io/upgradeto2_5.html
>
> Best regards
> Juergen
>
>

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts

The RELEASE-NOTES.txt entry for BCEL-262 is incorrect.  It should be exactly 
the opposite.  The override was added to InvokeInstruction because an array IS 
a legal operand.  The code is correct, the throw has been removed.

Mark

> -Original Message-
> From: Benedikt Ritter [mailto:brit...@apache.org]
> Sent: Tuesday, July 05, 2016 2:17 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7
> 
> This vote is still pending and nobody has voted so far. Please review this RC
> and cast your votes!
> 
> Thank you!
> Benedikt
> 
> Benedikt Ritter  schrieb am Sa., 2. Juli 2016 um
> 20:52 Uhr:
> 
> > Hi,
> >
> > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes
> > compared to RC6 are:
> >
> > - restored binary compatibility to a greater degree
> > - fixed issue BCEL-262
> >
> > BCEL 6.0 RC7 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision
> > 14251)
> >
> > The tag is here:
> >
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC
> 7/
> > (svn revision 1751084)
> >
> > Maven artifacts are here:
> > https://repository.apache.org/content/repositories/orgapachecommons-
> 11
> > 81/org/apache/bcel/bcel/6.0/
> >
> > These are the Maven artifacts and their hashes
> >
> > bcel-6.0-javadoc.jar
> >   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> > bcel-6.0-sources.jar
> >   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> > bcel-6.0-test-sources.jar
> >   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> > bcel-6.0-tests.jar
> >   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> > bcel-6.0.jar
> >   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> > bcel-6.0.pom
> >   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> >
> > I have tested this with JDK 7, 8 using Maven 3.3.9.
> >
> > Details of changes since 1.1 are in the release notes:
> >   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-
> NOTES.txt
> >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-
> report.ht
> > ml
> >
> > Site:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> > (note some *relative* links are broken and the 6.0 directories are not
> > yet created - these will be OK once the site is deployed)
> >
> > Clirr Report (compared to 5.2):
> >
> > http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.html
> >
> > Note that Clirr reports several errors.
> > These are considered OK for the reasons stated below.
> > These exceptions are also noted in the Changes and Release Notes.
> >
> > Errors reported:
> > - methods added to org.apache.bcel.classfile.Visitor interface: OK
> > because that does not affect binary compatibility.
> > - Removed java.io.Serializable from all classes: OK, because we don't
> > expect anybody to rely on serialization for BCEL classes
> > - Return type of method 'public java.lang.Object getElementAt(int)'
> > has been changed to java.lang.String in class
> > org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this
> > class is part of an UI application and for this reason should only used by
> Swing.
> >
> > RAT Report:
> >   http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-report.html
> >
> > KEYS:
> >   https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote. This vote will close no
> > sooner that 72 hours from now, i.e. sometime after 21:00 CEST 05-July
> > 2016
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thanks!
> > Benedikt
> >


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Emmanuel Bourg

+1, I tested on Debian with OpenJDK 8. I got the same test failure
reported by Oliver on Windows 7.

Emmanuel Bourg


Le 2/07/2016 à 20:52, Benedikt Ritter a écrit :
> Hi,
> 
> I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes compared
> to RC6 are:
> 
> - restored binary compatibility to a greater degree
> - fixed issue BCEL-262
> 
> BCEL 6.0 RC7 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/bcel/ (svn revision 14251)
> 
> The tag is here:
> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC7/ (svn
> revision 1751084)
> 
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1181/org/apache/bcel/bcel/6.0/
> 
> These are the Maven artifacts and their hashes
> 
> bcel-6.0-javadoc.jar
>   (SHA1: f1e1534867a901b9ba4884e5805317635c324589)
> bcel-6.0-sources.jar
>   (SHA1: 9ba3b50aa95289d01ec119b60be68eb4c608ba1d)
> bcel-6.0-test-sources.jar
>   (SHA1: 484b29d3a73fbe0c103d85965c4fd22e6253f545)
> bcel-6.0-tests.jar
>   (SHA1: f8b5857f3245e10548ef29cf7006c045b913a199)
> bcel-6.0.jar
>   (SHA1: fe1ecaf2ba3b1f9f18cdde4f13943e3ccc1d5e69)
> bcel-6.0.pom
>   (SHA1: ea17ee1b2c28804437212970ea2d273efeb3807e)
> 
> I have tested this with JDK 7, 8 using Maven 3.3.9.
> 
> Details of changes since 1.1 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/changes-report.html
> 
> Site:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/
> (note some *relative* links are broken and the 6.0 directories are not yet
> created - these will be OK once the site is deployed)
> 
> Clirr Report (compared to 5.2):
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/clirr-report.html
> 
> Note that Clirr reports several errors.
> These are considered OK for the reasons stated below.
> These exceptions are also noted in the Changes and Release Notes.
> 
> Errors reported:
> - methods added to org.apache.bcel.classfile.Visitor interface: OK because
> that does not affect binary compatibility.
> - Removed java.io.Serializable from all classes: OK, because we don't
> expect anybody to rely on serialization for BCEL classes
> - Return type of method 'public java.lang.Object getElementAt(int)' has
> been changed to java.lang.String in class
> org.apache.bcel.verifier.VerifierFactoryListModel: OK, because this class
> is part of an UI application and for this reason should only used by Swing.
> 
> RAT Report:
>   http://home.apache.org/~britter/commons/bcel/6.0-RC7/rat-report.html
> 
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote. This vote will close no
> sooner that 72 hours from now, i.e. sometime after 21:00 CEST 05-July 2016
> 
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
> 
> Thanks!
> Benedikt
> 




signature.asc
Description: OpenPGP digital signature

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

2016-07-06 Thread Kristian Rosenvold

2016-07-06 10:12 GMT+02:00 sebb :
> Have a look at the format method.
>
> It uses Calendar much as below.
>
>>> +final Calendar c = newCalendar();
>>> +c.setTimeInMillis(millis);
>>> +return applyRules(c, buf);


Yeah, I see now. Seems like I got lost in the overloads :)

Thanks,

Kristian

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

2016-07-06 Thread sebb

On 6 July 2016 at 07:19, Kristian Rosenvold  wrote:
> 2016-07-05 22:44 GMT+02:00  :
>> LANG-1247: FastDatePrinter generates Date objects wastefully
>> closes #168
>>  public StringBuffer format(final long millis, final StringBuffer buf) {
>> -return format(new Date(millis), buf);

Have a look at the format method.

It uses Calendar much as below.

>> +final Calendar c = newCalendar();
>> +c.setTimeInMillis(millis);
>> +return applyRules(c, buf);
>
>
> Arguably I might be a few years behind on developments regarding
> java.lang.Calendar within the JDK, but from previous experience the
> Calendar class is about as inefficient as things get, and anything
> touching the calendar sprays your heap with objects. As far as I can
> see, this just seems to be swapping around object allocation, probably
> to the worse (instead of one visible object allocation within
> commons-lang you're creating a fair bit of com.sun allocations as far
> as I know)
>
> I'd really like to see som evidence that this is an improvement, if
> nothing else to enlighten me :)

See above and the JIRA:

in this case the Date is *only* used to transport the long time to the
Calendar instance.

If you wish to eliminate Calendar in this case, that's another matter.

> Kristian
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1751160 - /commons/trunks-proper/

2016-07-06 Thread Benedikt Ritter

Benedikt Ritter  schrieb am Di., 5. Juli 2016 um
10:51 Uhr:

> sebb  schrieb am Mo., 4. Juli 2016 um 12:35 Uhr:
>
>> Is there a document describing the steps for moving a component to
>> dormant?
>>
>> If so, we also need to add updating projects.a.o to remove / update
>> any DOAP URLs
>>
>
> I don't think we have a documentation for that. We should start on
> documenting the process.
>

For svn based components, we also need to take care of the git mirror.


>
>
>>
>> On 3 July 2016 at 18:37, Benedikt Ritter  wrote:
>> > Thank you, I missed that one.
>> >
>> >  schrieb am So., 3. Juli 2016 um 19:03:
>> >
>> >> Author: markt
>> >> Date: Sun Jul  3 17:03:18 2016
>> >> New Revision: 1751160
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=1751160&view=rev
>> >> Log:
>> >> Primitives moved to dormant. Remove it here as it is breaking Gump.
>> >>
>> >> Modified:
>> >> commons/trunks-proper/   (props changed)
>> >>
>> >> Propchange: commons/trunks-proper/
>> >>
>> >>
>> --
>> >> --- svn:externals (original)
>> >> +++ svn:externals Sun Jul  3 17:03:18 2016
>> >> @@ -36,7 +36,6 @@ modeler https://svn.apache.org/repos/asf
>> >>  net https://svn.apache.org/repos/asf/commons/proper/net/trunk
>> >>  ognl https://svn.apache.org/repos/asf/commons/proper/ognl/trunk
>> >>  pool https://svn.apache.org/repos/asf/commons/proper/pool/trunk
>> >> -primitives
>> >> https://svn.apache.org/repos/asf/commons/proper/primitives/trunk
>> >>  proxy https://svn.apache.org/repos/asf/commons/proper/proxy/trunk
>> >>  validator
>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk
>> >>  vfs https://svn.apache.org/repos/asf/commons/proper/vfs/trunk
>> >>
>> >>
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [IO] Site build fails

[IO] Site build fails

Re: [Math] Getting things done

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

[CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

D0F0DFB5AFCB1352

Re: Commons IO 2.5 release note

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

Re: svn commit: r1751160 - /commons/trunks-proper/

17 matches

Site Navigation

Mail list logo

Footer information