Re: [VOTE][RESULT] Migrate commons-pool to git

2017-03-08 Thread Gary Gregory 
Done. It may take up to an hour for the request to be completed.

Gary

On Wed, Mar 8, 2017 at 6:06 PM, Matt Sicker  wrote:

> Looks like I need a PMC to create a repository via here:
> https://reporeq.apache.org/
>
> Then I can run svn2git locally apparently and just sync it up myself.
>
> On 8 March 2017 at 19:19, Matt Sicker  wrote:
>
> > https://issues.apache.org/jira/browse/INFRA-13630
> >
> > On 8 March 2017 at 19:13, Matt Sicker  wrote:
> >
> >> The vote passes by lazy approval with two +1 votes from Gary Gregory and
> >> myself and no -1 votes.
> >>
> >> I'll make an infra ticket to get us migrated. Please don't commit
> >> anything to commons-pool for a little while so that nothing gets out of
> >> sync during the migration.
> >>
> >> --
> >> Matt Sicker 
> >>
> >
> >
> >
> > --
> > Matt Sicker 
> >
>
>
>
> --
> Matt Sicker 
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [VOTE][RESULT] Migrate commons-pool to git

2017-03-08 Thread Matt Sicker 
Looks like I need a PMC to create a repository via here:
https://reporeq.apache.org/

Then I can run svn2git locally apparently and just sync it up myself.

On 8 March 2017 at 19:19, Matt Sicker  wrote:

> https://issues.apache.org/jira/browse/INFRA-13630
>
> On 8 March 2017 at 19:13, Matt Sicker  wrote:
>
>> The vote passes by lazy approval with two +1 votes from Gary Gregory and
>> myself and no -1 votes.
>>
>> I'll make an infra ticket to get us migrated. Please don't commit
>> anything to commons-pool for a little while so that nothing gets out of
>> sync during the migration.
>>
>> --
>> Matt Sicker 
>>
>
>
>
> --
> Matt Sicker 
>



-- 
Matt Sicker

Re: [VOTE][RESULT] Migrate commons-pool to git

2017-03-08 Thread Matt Sicker 
https://issues.apache.org/jira/browse/INFRA-13630

On 8 March 2017 at 19:13, Matt Sicker  wrote:

> The vote passes by lazy approval with two +1 votes from Gary Gregory and
> myself and no -1 votes.
>
> I'll make an infra ticket to get us migrated. Please don't commit anything
> to commons-pool for a little while so that nothing gets out of sync during
> the migration.
>
> --
> Matt Sicker 
>



-- 
Matt Sicker

[VOTE][RESULT] Migrate commons-pool to git

2017-03-08 Thread Matt Sicker 
The vote passes by lazy approval with two +1 votes from Gary Gregory and
myself and no -1 votes.

I'll make an infra ticket to get us migrated. Please don't commit anything
to commons-pool for a little while so that nothing gets out of sync during
the migration.

-- 
Matt Sicker

Re: [VOTE][LAZY] Migrate Commons Pool to Git

2017-03-08 Thread Matt Sicker 
Forgot to mention +1 from me of course.

On 5 March 2017 at 11:51, Gary Gregory  wrote:

> +1
>
> Gary
>
>
> On Mar 5, 2017 6:22 PM, "Matt Sicker"  wrote:
>
> This is a vote by lazy consensus to migrate the commons-pool subversion
> repository into git. We have been slowly migrating projects in Commons to
> git, and I'd like to migrate Pool to make it easier to perform a new
> release and in general because git's easier to use nowadays thanks to its
> widespread use.
>
> Any projects that may rely on using an svn external repo on this should be
> able to use GitHub's svn mirroring capability, though I'm not exactly sure
> if there are ASF rules against doing that in Apache projects.
>
> This vote will be open for 72 hours. If there are no objections by then, I
> will submit a request to INFRA to migrate the repo. After that, I'll update
> pom.xml with the new source repository location. It could be helpful to
> update the site as it's currently committed, though a new release would
> contain that information as well.
>
> --
> Matt Sicker 
>



-- 
Matt Sicker

Build failed in Jenkins: Commons-configuration #49

2017-03-08 Thread Apache Jenkins Server 
See 


Changes:

[oheger] Added Vincent Maurin to contributors section.

--
[...truncated 36.21 KB...]
AUsrc/main/java/org/apache/commons/configuration2/tree/TreeUtils.java
AU
src/main/java/org/apache/commons/configuration2/tree/NodeUpdateData.java
AU
src/main/java/org/apache/commons/configuration2/tree/InMemoryNodeModel.java
AUsrc/main/java/org/apache/commons/configuration2/tree/NodeAddData.java
AUsrc/main/java/org/apache/commons/configuration2/tree/TreeData.java
AUsrc/main/java/org/apache/commons/configuration2/tree/NodeMatcher.java
AU
src/main/java/org/apache/commons/configuration2/tree/DefaultExpressionEngine.java
AU
src/main/java/org/apache/commons/configuration2/tree/DefaultExpressionEngineSymbols.java
AU
src/main/java/org/apache/commons/configuration2/tree/NodeModelSupport.java
AUsrc/main/java/org/apache/commons/configuration2/tree/QueryResult.java
AU
src/main/java/org/apache/commons/configuration2/tree/ModelTransaction.java
AUsrc/main/java/org/apache/commons/configuration2/Initializable.java
AU
src/main/java/org/apache/commons/configuration2/PropertiesConfigurationLayout.java
AU
src/main/java/org/apache/commons/configuration2/PropertiesConfiguration.java
AUsrc/main/java/org/apache/commons/configuration2/package-info.java
AUsrc/main/java/org/apache/commons/configuration2/XMLConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/AbstractConfiguration.java
A src/main/java/org/apache/commons/configuration2/sync
AU
src/main/java/org/apache/commons/configuration2/sync/ReadWriteSynchronizer.java
AUsrc/main/java/org/apache/commons/configuration2/sync/package-info.java
AU
src/main/java/org/apache/commons/configuration2/sync/NoOpSynchronizer.java
AU
src/main/java/org/apache/commons/configuration2/sync/SynchronizerSupport.java
AUsrc/main/java/org/apache/commons/configuration2/sync/LockMode.java
AUsrc/main/java/org/apache/commons/configuration2/sync/Synchronizer.java
A src/main/java/org/apache/commons/configuration2/web
AU
src/main/java/org/apache/commons/configuration2/web/ServletConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/web/AppletConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/web/BaseWebConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/web/ServletContextConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/web/ServletFilterConfiguration.java
AUsrc/main/java/org/apache/commons/configuration2/web/package-info.java
AU
src/main/java/org/apache/commons/configuration2/web/ServletRequestConfiguration.java
AU
src/main/java/org/apache/commons/configuration2/ConfigurationDecoder.java
AUsrc/main/java/org/apache/commons/configuration2/XMLDocumentHelper.java
A src/main/java/org/apache/commons/configuration2/convert
AU
src/main/java/org/apache/commons/configuration2/convert/ConversionHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/package-info.java
AU
src/main/java/org/apache/commons/configuration2/convert/DefaultConversionHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/ListDelimiterHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/AbstractListDelimiterHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/PropertyConverter.java
AU
src/main/java/org/apache/commons/configuration2/convert/DefaultListDelimiterHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/LegacyListDelimiterHandler.java
AU
src/main/java/org/apache/commons/configuration2/convert/ValueTransformer.java
AU
src/main/java/org/apache/commons/configuration2/convert/DisabledListDelimiterHandler.java
A src/main/java/org/apache/commons/configuration2/event
AUsrc/main/java/org/apache/commons/configuration2/event/Event.java
AUsrc/main/java/org/apache/commons/configuration2/event/EventSource.java
AU
src/main/java/org/apache/commons/configuration2/event/ConfigurationErrorEvent.java
AU
src/main/java/org/apache/commons/configuration2/event/EventListenerList.java
AUsrc/main/java/org/apache/commons/configuration2/event/EventType.java
AU
src/main/java/org/apache/commons/configuration2/event/package-info.java
AU
src/main/java/org/apache/commons/configuration2/event/EventListener.java
AU
src/main/java/org/apache/commons/configuration2/event/ConfigurationEvent.java
AU
src/main/java/org/apache/commons/configuration2/event/EventListenerRegistrationData.java
AU

Re: [VOTE] Release Commons Text 1.0 based on RC1

2017-03-08 Thread Jörg Schaible 
+1

Builds fine with my compiler zoo incl. Java 9.

Rob Tompkins wrote:

> Hello all,
> 
> This is a [VOTE] for releasing Apache Commons Text 1.0 (from RC1).
> 
> Tag name:
>commons-text-1.0-RC1 (signature can be checked from git using 'git tag
> -v')
> 
> Tag URL:
>https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commit;h=
> e38039a3da2244741f5d33ab1b05bdee51c53c3e
> 
> Commit ID the tag points at:
>e38039a3da2244741f5d33ab1b05bdee51c53c3e
> 
> Site:
>http://home.apache.org/~chtompki/commons-text-1.0-RC1
> 
> Distribution files (committed at revision 18567):
>https://dist.apache.org/repos/dist/dev/commons/text/
> 
> Distribution files hashes (SHA1):
>commons-text-1.0-bin.tar.gz
>(SHA: a6eb41fd426d876669cc6799afd7435d97285229)
>commons-text-1.0-bin.zip
>(SHA1: 72e732a38f41aa7934a4a9834451f0a2f368dd4e)
>commons-text-1.0-src.tar.gz
>(SHA1: 83a57a925cc551bf2e6e38be12eec953820212b9)
>commons-text-1.0-src.zip
>(SHA1: d838bb107bcdbe58bba0525f8fd7341a2b40)
> 
> These are the Maven artifacts and their hashes:
>commons-text-1.0-javadoc.jar
>(SHA1: 0e904fc88c8e6cc615e53c5c8246705f8e3d8d25)
>commons-text-1.0-sources.jar
>(SHA1: 53a622edbc40f345d7015345524ace2536a8dffc)
>commons-text-1.0-test-sources.jar
>(SHA1: baabd28e90e8f7a8765b76c8882bee058a956116)
>commons-text-1.0-tests.jar
>(SHA1: adf8d0638132df9e23a4a0416741dc1c3d6be664)
>commons-text-1.0.jar
>(SHA1: 71413afd09c3ca8b3a796bc2375ef154b0afa814)
>commons-text-1.0.pom
>(SHA1: 7220d033f589194704533680c76c6a74cabe6d57)
> 
> KEYS file to check signatures:
>http://www.apache.org/dist/commons/KEYS
> 
> Maven artifacts:
>
https://repository.apache.org/content/repositories/orgapachecommons-1239
> 
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
> 
> This vote will be open at least 72 hours, i.e. until
> 2017-03-09T14:00:00Z
> (this is UTC time).
> 
> 
> Cheers,
> -Rob
> 
> [1] http://apache.org/foundation/voting.html



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL][Math] git pull requests: how?

2017-03-08 Thread Matt Sicker 
The "write to a PR branch" was something I mentioned in a different email.

If you want a single command to merge a PR into master, assuming you've
already set up "github" as your github remote:

git pull github pull/42
git push

Something like that should work. Since you're not running the git command
on git.apache.org, there's no single command do this really since you have
to pull and push regardless.

On 8 March 2017 at 05:10, Gilles  wrote:

> Hi.
>
> On Tue, 7 Mar 2017 22:06:11 -0600, Matt Sicker wrote:
>
>> Found this link while trying to remember how to do this:
>>
>> https://help.github.com/articles/checking-out-pull-requests-locally/
>>
>> Same docs as above, just from the source. It sounds like you can't write
>> to
>> a PR branch even if the author allows it, but the docs could be out of
>> date
>> (it happens!).
>>
>
> 1. I don't want to "write to a PR branch"; my question was about getting
>the PR automatically merged in a single command (as opposed to locally
>create the branch).
> 2. The result of the actions listed below was to create a local branch with
>the contents of the PR. Of course (?), I could modify that local branch.
>
> Gilles
>
>
>> On 2 March 2017 at 09:52, Gilles  wrote:
>>
>> On Thu, 2 Mar 2017 09:35:53 -0600, Matt Sicker wrote:
>>>
>>> Is the different behavior caused by svn versus git mirroring?


>>> The "Math" and "Numbers" projects both use git.
>>>
>>> Gilles
>>>
>>> That read-only branch feature is really cool.
>>>
 Some of this info might be
 useful to include in the template readme files and such for commons.


>>>
>>> On 2 March 2017 at 06:09, Gilles  wrote:

 On Thu, 2 Mar 2017 11:30:17 +, sebb wrote:

>
> This info (when validated) should be added to the Wiki:
>
>>
>> https://wiki.apache.org/commons/UsingGIT
>>
>> ...
>>
>> Oh, it already is there at the end
>>
>>
>> Indeed, there is information there.
> That works:
>   $ git fetch github pull/72/head:fix-foo-in-bar
>
> But is it simpler to
>  1. remember the syntax
>  2. go to the GitHub site (following the link "manually" posted by
> the contributor on the JIRA page)
>  3. figure out what part of the GitHub page contains the string
> for replacing "fix-foo-in-bar"
>  4. copy/paste it in a console
>  5. run the above command
>  6. merge the branch created by the above command
> than have the full command posted automatically on the JIRA page,
> so that the committer can do everything in one go?
>
> Note that the command above is not the same as the syntax provided
> in the automatic posts ("fetch" vs "pull").
>
> Question is still: Why different behaviours of the GitHub mirrors?
> Do we want this fixed?
> How?
>
>
> Thanks,
> Gilles
>
>
>
> On 2 March 2017 at 10:50, Gilles  wrote:
>
>
>> On Wed, 1 Mar 2017 22:51:54 -0600, Matt Sicker wrote:
>>
>>>
>>>
>>> Normally the GitHub email gives you the proper command to use to pull
 the
 PR into your local git which you can merge and push (which merges
 the
 PR
 once GitHub gets updated from apache.org).

 As for making sure that email gets sent, if it's not, file an INFRA
 ticket
 about it. I've never tried it, but this might work:

 git pull https://github.com/apache/commons-math/pull/55



>>> $ git pull https://github.com/apache/commons-math/pull/55
>>> remote: Not Found
>>> fatal: repository 'https://github.com/apache/commons-math/pull/55/'
>>> not
>>> found
>>>
>>> If you add .diff or .patch to the end of the URL, it gives you a diff
>>>
>>> that
 you can manually apply. The .diff URL appears to be a normal diff
 while
 the
 .patch URL is the output of "git format-patch". So, if you download
 <
 https://github.com/apache/commons-math/pull/55.patch> and run "git
 apply
 55.patch", that'll commit it properly as if you merged the PR
 itself I
 think (it'll set the commit author properly at least for proper
 historical
 attribution).



>>> Thanks, that could be a (sub-optimal) solution.
>>>
>>> Also, adding a commit message somewhere (e.g., a follow up empty
>>> commit
>>>
>>> or
 a changelog entry commit) containing the phrase "this closes #55"
 (or
 maybe
 just "closes #55"; it's pretty loose) is enough to close the PR, but
 merging it should close it automatically.



>>> Yes, I knew that, because the notification, when it gets sent,
>>>

Re: [ALL][Math] git pull requests: how?

2017-03-08 Thread Gilles 

Hi.

On Tue, 7 Mar 2017 22:06:11 -0600, Matt Sicker wrote:

Found this link while trying to remember how to do this:

https://help.github.com/articles/checking-out-pull-requests-locally/

Same docs as above, just from the source. It sounds like you can't 
write to
a PR branch even if the author allows it, but the docs could be out 
of date

(it happens!).


1. I don't want to "write to a PR branch"; my question was about 
getting
   the PR automatically merged in a single command (as opposed to 
locally

   create the branch).
2. The result of the actions listed below was to create a local branch 
with
   the contents of the PR. Of course (?), I could modify that local 
branch.


Gilles



On 2 March 2017 at 09:52, Gilles  
wrote:



On Thu, 2 Mar 2017 09:35:53 -0600, Matt Sicker wrote:


Is the different behavior caused by svn versus git mirroring?



The "Math" and "Numbers" projects both use git.

Gilles

That read-only branch feature is really cool.

Some of this info might be
useful to include in the template readme files and such for 
commons.





On 2 March 2017 at 06:09, Gilles  
wrote:


On Thu, 2 Mar 2017 11:30:17 +, sebb wrote:


This info (when validated) should be added to the Wiki:


https://wiki.apache.org/commons/UsingGIT

...

Oh, it already is there at the end



Indeed, there is information there.
That works:
  $ git fetch github pull/72/head:fix-foo-in-bar

But is it simpler to
 1. remember the syntax
 2. go to the GitHub site (following the link "manually" posted by
the contributor on the JIRA page)
 3. figure out what part of the GitHub page contains the string
for replacing "fix-foo-in-bar"
 4. copy/paste it in a console
 5. run the above command
 6. merge the branch created by the above command
than have the full command posted automatically on the JIRA page,
so that the committer can do everything in one go?

Note that the command above is not the same as the syntax provided
in the automatic posts ("fetch" vs "pull").

Question is still: Why different behaviours of the GitHub mirrors?
Do we want this fixed?
How?


Thanks,
Gilles



On 2 March 2017 at 10:50, Gilles  
wrote:




On Wed, 1 Mar 2017 22:51:54 -0600, Matt Sicker wrote:



Normally the GitHub email gives you the proper command to use 
to pull

the
PR into your local git which you can merge and push (which 
merges the

PR
once GitHub gets updated from apache.org).

As for making sure that email gets sent, if it's not, file an 
INFRA

ticket
about it. I've never tried it, but this might work:

git pull https://github.com/apache/commons-math/pull/55




$ git pull https://github.com/apache/commons-math/pull/55
remote: Not Found
fatal: repository 
'https://github.com/apache/commons-math/pull/55/'

not
found

If you add .diff or .patch to the end of the URL, it gives you a 
diff



that
you can manually apply. The .diff URL appears to be a normal 
diff

while
the
.patch URL is the output of "git format-patch". So, if you 
download <
https://github.com/apache/commons-math/pull/55.patch> and run 
"git

apply
55.patch", that'll commit it properly as if you merged the PR 
itself I

think (it'll set the commit author properly at least for proper
historical
attribution).




Thanks, that could be a (sub-optimal) solution.

Also, adding a commit message somewhere (e.g., a follow up empty 
commit



or
a changelog entry commit) containing the phrase "this closes 
#55" (or

maybe
just "closes #55"; it's pretty loose) is enough to close the 
PR, but

merging it should close it automatically.




Yes, I knew that, because the notification, when it gets sent, 
contains
all the information necessary to handle to request (and 
additionally,

the
JIRA issue will be updated automatically too).

Hence that would be the preferred solution.

I still wonder why the various Commons projects (those managed 
by git

and
having a GitHub mirror) behave differently.


Regards,
Gilles


On 1 March 2017 at 17:53, Gilles  
wrote:




Hi.



How should the project be configured such that the request
posted here:
  https://issues.apache.org/jira/browse/MATH-1405
is as easy to handle as the one posted here:
  https://issues.apache.org/jira/browse/NUMBERS-4
?

Thanks,
Gilles









-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] JUnit imports (closes #247)

2017-03-08 Thread Allon Mureinik 
thanks

On Wed, Mar 8, 2017 at 10:22 AM, Benedikt Ritter  wrote:

> Nice catch!
>
> > Am 28.02.2017 um 23:34 schrieb pascalschumac...@apache.org:
> >
> > Repository: commons-lang
> > Updated Branches:
> >  refs/heads/master 98fa164cd -> c79e6fb8f
> >
> >
> > JUnit imports (closes #247)
> >
> > The junit.framework package has been deprecated, and should no longer
> > be used.
> >
> > This patch fixes the one remaining import from it to statically import
> > org.junit.Assert.assertNull instead.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
> c79e6fb8
> > Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c79e6fb8
> > Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c79e6fb8
> >
> > Branch: refs/heads/master
> > Commit: c79e6fb8f95bb07d2394221b29b75fcc016f4900
> > Parents: 98fa164
> > Author: Allon Mureinik 
> > Authored: Tue Feb 28 23:17:51 2017 +0200
> > Committer: pascalschumacher 
> > Committed: Tue Feb 28 23:33:26 2017 +0100
> >
> > --
> > src/test/java/org/apache/commons/lang3/RandomUtilsTest.java | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > --
> >
> >
> > http://git-wip-us.apache.org/repos/asf/commons-lang/blob/
> c79e6fb8/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > --
> > diff --git a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > index ed032e7..ddbaab1 100644
> > --- a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > +++ b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> > @@ -16,10 +16,10 @@
> >  */
> > package org.apache.commons.lang3;
> >
> > -import static junit.framework.TestCase.assertNotNull;
> > import static org.junit.Assert.assertArrayEquals;
> > import static org.junit.Assert.assertEquals;
> > import static org.junit.Assert.assertFalse;
> > +import static org.junit.Assert.assertNotNull;
> > import static org.junit.Assert.assertTrue;
> >
> > import org.junit.Test;
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[CLI] Next release

2017-03-08 Thread Benedikt Ritter 
Hello,

the Maven team has asked us to provide a new release of [CLI], so I’m going to 
prepare RC1 very soonish. If you need to add something, please do it now.

Thank you!
Benedikt
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] Question with the StringEscapeUtils.(un)escapeEcmaScript

2017-03-08 Thread Benedikt Ritter 
Hello Yasser,

Sorry for the late reply! I have been on vacation and needed some time to go 
through all the mails that have piled up :-)

> Am 27.02.2017 um 15:38 schrieb Yasser Zamani :
> 
> Hi there,
> 
> I just wonder why `StringEscapeUtils.escapeEcmaScript` also includes 
> `JavaUnicodeEscaper`? is it it's business really? the problem is when we 
> use it to prevent script injection by user, it also replaces user 
> input's unicodes with "\u"s which is not deducted with 
> `escapeEcmaScript' term.

StringEscapeUtils contains general String escaping routines. It does not focus 
on business related escaping (how would you draw that line anyway?). 
escapeEcmaScript just escapes the characters in a String using EcmaScript 
String rules.
Can you please provide a failing test case showing the problem you see?

> 
> Another thing is, it replaces e.g. '<' with '' (html/xml escape) but 
> replace unicode with '\u' rather than '

Re: [lang] JUnit imports (closes #247)

2017-03-08 Thread Benedikt Ritter 
Nice catch!

> Am 28.02.2017 um 23:34 schrieb pascalschumac...@apache.org:
> 
> Repository: commons-lang
> Updated Branches:
>  refs/heads/master 98fa164cd -> c79e6fb8f
> 
> 
> JUnit imports (closes #247)
> 
> The junit.framework package has been deprecated, and should no longer
> be used.
> 
> This patch fixes the one remaining import from it to statically import
> org.junit.Assert.assertNull instead.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/c79e6fb8
> Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/c79e6fb8
> Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/c79e6fb8
> 
> Branch: refs/heads/master
> Commit: c79e6fb8f95bb07d2394221b29b75fcc016f4900
> Parents: 98fa164
> Author: Allon Mureinik 
> Authored: Tue Feb 28 23:17:51 2017 +0200
> Committer: pascalschumacher 
> Committed: Tue Feb 28 23:33:26 2017 +0100
> 
> --
> src/test/java/org/apache/commons/lang3/RandomUtilsTest.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/commons-lang/blob/c79e6fb8/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> --
> diff --git a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java 
> b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> index ed032e7..ddbaab1 100644
> --- a/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> +++ b/src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
> @@ -16,10 +16,10 @@
>  */
> package org.apache.commons.lang3;
> 
> -import static junit.framework.TestCase.assertNotNull;
> import static org.junit.Assert.assertArrayEquals;
> import static org.junit.Assert.assertEquals;
> import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> import static org.junit.Assert.assertTrue;
> 
> import org.junit.Test;
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang][crypto] LANG-1145 evaluate JVM architecture

2017-03-08 Thread Benedikt Ritter 
Hi,

> Am 07.03.2017 um 22:17 schrieb Bruno P. Kinoshita 
> :
> 
> Hi all,
> 
> We have a pull request [1][2] for adding code that detects the JVM 
> architecture. The user has a valid use case for his code, and we have similar 
> code in Apache Spark [3] and Apache Commons Crypto [4].
> 
> As this is going into [lang], another Commons component, I thought maybe 
> there could be some synergy between Crypto and Lang? I believe crypto has no 
> dependencies right now, but maybe it would be worth adding a dep + shade, so 
> that we have a single place to maintain this list of OS architectures.
> 
> Thoughts?

For a component like crypto, I’d go with sharding.

Since there are several other projects who need this code, maybe it’s worth to 
create a new component for that? Commons OS or Commons HostDetection or 
something like that?

Benedikt

> 
> Bruno
> 
> 
> [1] https://github.com/apache/commons-lang/pull/231
> [2] https://issues.apache.org/jira/browse/LANG-1145
> 
> [3] 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
> 
> [4] 
> https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/OsInfo.java
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org