GitHub Pull Requests
Hello, I have submitted a Pull Request at https://github.com/apache/commons-lang/pull/358. 10 days ago, "coveralls" commented on the request and all checks passed. Otherwise, I have heard nothing regarding the request. When do requests get reviewed and/or commented on? Thanks, Zack Macomber - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [numbers] Making fractions VALJOs
On Wed, 10 Oct 2018 16:18:50 -0700, Eric Barnhill wrote: I am interested in moving forward on making the Fraction classes VALJOs [NUMBERS-75]. Just a preliminary question for now, are we otherwise happy with the Fraction class in the context of commons-numbers? Or should I look around for any odd behaviors leftover from commons-math (Complex had a lot of those) that might also be improved? AFAIK, there was no in-depth review as was done for "Complex". So it would indeed be quite useful to check what the Javadoc states, whether it seems acceptable (wrt what other libraries do), and whether the unit tests validate everything. Side note: Unless I'm overlooking something, completing this task will result in getting rid of all the formatting and "Locale"-related classes (as for "Complex"). Best, Gilles Eric - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [numbers] Editing user guide through git mirror?
Hi Eric. On Wed, 10 Oct 2018 16:35:21 -0700, Eric Barnhill wrote: I am interested in adding some documentation to the commons Complex user guide visible at http://commons.apache.org/proper/commons-numbers/commons-numbers-complex/index.html . I was wondering if this is available to edit through the commons git mirrors somehow? Apologies if this information is presented somewhere obvious. I've added the missing file: https://git1-us-west.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-complex/src/site/xdoc/index.xml Format is "xdoc". It's a good place to explain the design and/or give some short examples of API usage. For more elaborate use-cases, we might want to create a special purpose module (like for "Commons RNG") that contain fully functional codes but not subject to the backward compatibility constraint of the official codebase. A longer-term documentation project could be to start a standalone user guide that would contain one section per module, that would be linked from the top-level web site, similar to http://commons.apache.org/proper/commons-rng/userguide/index.html There is a "skeleton" for this here: https://git1-us-west.apache.org/repos/asf?p=commons-numbers.git;a=tree;f=src/site/xdoc/userguide (not yet linked from the web site's homepage). Regards, Gilles Eric - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
