Re: [vfs] new http4 provider, not replace http?
Could someone please review my PR? - https://github.com/apache/commons-vfs/pull/38 Woonsan On Wed, Aug 15, 2018 at 9:11 AM Woonsan Ko wrote: > > Hi Bernd / Experts, > > I've submitted a PR for VFS-360. Find my summary in the comment as well. > - https://github.com/apache/commons-vfs/pull/38 > > Could you please review the changes? > > Thanks in advance, > > Woonsan > > > On Wed, Aug 8, 2018 at 6:09 PM, Woonsan Ko wrote: > > Hi Bernd, > > > > Thanks for your remarks. Please see my comments inline below. > > > > On Wed, Aug 8, 2018 at 3:34 PM, Bernd Eckenfels > > wrote: > >> Hello, > >> > >> I am for http4. In the begining it wont be maped in the StandardManager > >> but can be changed later on. > > Sounds good to me. > > > >> > >> I do wonder if we can get rid of a Special https Provider and have only > >> one (http4) which can handle both Kinds of URLs… not quite sure, what do > >> you think? > > From user's perspective, it seems better to keep 'https' separately > > from 'http'. 'http4s' and 'http4' accordingly. > > We can possibly consider nesting or adding somethings in > > configuration, for example to allow > > 'http4://www.example.com/index.html', > > 'http4:http://www.example.com/index.html' (equivalent to the first) or > > 'http4:https://www.example.com/index.html. But that doesn't seem to > > make anything more convenient than simply allowing either > > 'http4://www.example.com/index.html' or > > 'http4s://www.example.com/index.html'. > > So, I'm personally inclined to keep the existing pattern to have > > separate providers. > > > >> > >> Besides that, I wonder if we also (only?) should consider the new JDK > >> httpclient api? > > As I'm trying to scratch my own itch, I'd opt for providing a solution > > with HttpComponents HttpClient v4 first. ;-) Also, it's very matured > > and well-accepted, comparing with the new JDK HttpClient. > > I'm open to a possibility in the near future for a new separate > > provider, possibly called 'jdkhttp' with JDK HttpClient module. > > > > Kind regards, > > > > Woonsan > > > >> > >> Gruss > >> Bernd > >> > >> -- > >> http://bernd.eckenfels.net > >> > >> Von: Woonsan Ko > >> Gesendet: Mittwoch, 8. August 2018 18:35 > >> An: Commons Developers List > >> Betreff: [vfs] new http4 provider, not replace http? > >> > >> Hi, > >> > >> I'm trying to contribute for VFS-360. What a nice ticket number! > >> After a brief look, I'm considering to add a new provider in a > >> separate package, 'http4' (based on HttpComponents HttpClient), > >> keeping the old one, 'http' (based on the old Commons HttpClient), > >> as-is. The reason is that I don't want to break any public methods of > >> the http provider package in v2.x range. > >> > >> BTW, Apache Camel has a similar concept: http component with v3 and > >> http4 component with v4. [1] > >> A difference is we need one more equivalent to the old 'https', like > >> 'http4s'. It sounds a bit weird though. > >> > >> Any insights? > >> > >> Woonsan > >> > >> [1] http://camel.apache.org/components.html > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons Imaging 1.0-alpha1 based on RC2
Am 30.10.18 um 10:09 schrieb Bruno P. Kinoshita: We have fixed quite a few bugs and added some significant enhancements since Apache Sanselan Incubating 0.97-incubator was released, so I would like to release Apache Commons Imaging 1.0-alpha1. Apache Commons Imaging 1.0-alpha1 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/imaging/1.0-alpha1-RC2 (svn revision 30516) The Git tag commons-imaging-1.0-alpha1-RC2 commit for this RC is e4e1b4dd0da6d4c90205674a730738576f2bee8e which you can browse here: https://git-wip-us.apache.org/repos/asf?p=commons-imaging.git;a=tag;h=refs/tags/commons-imaging-1.0-alpha1-RC2 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1395/org/apache/commons/commons-imaging/1.0-alpha1/ These are the Maven artifacts and their hashes in Nexus: #Release SHA-256s #Tue Oct 30 21:27:02 NZDT 2018 commons-imaging-1.0-alpha1-sources-java-source=c5a359c19f7768860a520b4e37aecd0bf9e7b95665d45c3bddedac10ea83aca1 commons-imaging-1.0-alpha1-bin-zip=3eeb5894c91975524e6e858b8d9318ef69faf2b7c1c37157783897ececf9339f commons-imaging-1.0-alpha1-sources-jar.asc=0c1c298db3ead3069e221b9bbb153702819d1be0c90982bd7bc31384d4dadf7a commons-imaging-1.0-alpha1-src-zip.asc=3c2aa29c8ac1d0cc036821cf2d2c7647a3d08aadad7f156c67df92c1336ad14a commons-imaging-1.0-alpha1-pom.asc=aa33dacce18d8bcd2f90827f78907615c5f1ea0f56af9a77df9dfb29f4a10542 commons-imaging-1.0-alpha1-tests-jar.asc=4a7fe21a8c85e00b53eae6de8ccc138c7d0d7655af5d34d866196f3992a44b2f commons-imaging-1.0-alpha1-javadoc-jar.asc=ff15ecc262d47fb8551f99adcb2a7f259180c5c54763bf7b2f51c16470ff0034 commons-imaging-1.0-alpha1-tests-test-jar=520eb1223a59bcc9c14c553acc58e1e4258574f9caaf0797093698a4fa2130c0 commons-imaging-1.0-alpha1-jar.asc=28957df1acd3c3a6fb7326f03b8115a3b2d760de07d3f9b8cc6722d7af98508a commons-imaging-1.0-alpha1-bin-tar.gz.asc=415d3753f9be590f0e0be829f3499d14e2c42c2bd39deddb9a8ab538b3d2327f commons-imaging-1.0-alpha1-test-sources-jar.asc=cc085db20953597090b40084362e523cd52faa2fc535ef83b083fde08559762d commons-imaging-1.0-alpha1-src-tar.gz=486c71ef3d7ca3760dcece77c5c8979dc544270d60f21d0994725cb1aa3a04fd commons-imaging-1.0-alpha1-bin-zip.asc=ef67c0c3795ebecc6567c7e7b75cf4797f5b7d5c7387b87ac6703157c88029a9 commons-imaging-1.0-alpha1-javadoc-javadoc=37feb9395af4d17ad7407b3deb95e8c4001acb6b42d790eb20acf3ddb8b4851b commons-imaging-1.0-alpha1-src-zip=180a29bd5ff95b5c32ec62a0a0949d68ff9907e18740c793266de0bd6dc2f8b7 commons-imaging-1.0-alpha1-bin-tar.gz=73c5324e87e81f9c837c3403f133f6dc112d07f0b3ee6bbb758b3701aa8b23a4 commons-imaging-1.0-alpha1-test-sources-java-source=91d26c80147a539652cd1acb3aae2f550ee848f9f0cecf640e3916075778df2f commons-imaging-1.0-alpha1-src-tar.gz.asc=166477b4d91b51b8d5295346e697ca0f3c75b3f3f7ba06e67fea9c2d523bb061 #Release SHA-512s #Tue Oct 30 21:27:02 NZDT 2018 commons-imaging-1.0-alpha1-sources-java-source=eb0c088ec3482a60bab4a806688faa4ef955eb3099a8cbb321226ea527b9f87d176fc9f4cf4243795ec8f9b2c8ed5ab6b021b737c32fd0708e2d24a9aca6f5d0 commons-imaging-1.0-alpha1-bin-zip=8c1bf5a1d4cd1423bc1153f505493ebf8c235d2e550dc01bb77d937392e05a814b7928355a3400fe02bdfa2ae7cc9d94aec572cd35c27a47f16acd56f4c0e95b commons-imaging-1.0-alpha1-sources-jar.asc=048ef87ebc5dee2fc25353e71b79f07f5fa1b96cad65f6b6aa19e4b78d669fefe9cad36a269f6ec0ff23af0b2a591a18d2ea7769c0c3857ec3f70cc33cad2c24 commons-imaging-1.0-alpha1-src-zip.asc=584160a22dc44e2adb70c01d4cf7c8f0156bf4c27d92dea9c27a0740e406331456572ed48c4ce79ef1c4ed366097c0a4e67c5f7753f6be6bfdc34149d1bf8eeb commons-imaging-1.0-alpha1-pom.asc=648a2929ee3319bfa204c9e8e5cc55d23ad8789bd4d6d4eab8715b718d1074e89688431188017df94e27f40bf954f814a2fde6a29e13a34b6dd5eb1fd4da223d commons-imaging-1.0-alpha1-tests-jar.asc=e28ae8f2df7d178b712172170d5a791a07f8ad0f3a7820bc737365344d2e0f7ca68d976ca01ffaa00023e7ed99a029f3fb7f457a61cd16812b5d28f363ed3429 commons-imaging-1.0-alpha1-javadoc-jar.asc=62423db7b7f9715650c5324831cb049d66ee8692db8cd7654eefd110291bb52cec607cb3a1dbf5c09415f5390636f43811da4e457698befe7ff912055d4d419f commons-imaging-1.0-alpha1-tests-test-jar=375e4b6a1dd6a631d16161957d0cad6641382906f558ea54209fa8259d16395fba67eeda9115adb7b4204b5c8802309f3899adc7e456a459e25359e8abba3ca1 commons-imaging-1.0-alpha1-jar.asc=c51bbeff8de1a78a64bdedff5e4a6db44034d8fc9eec2c0e70527f090341a7789c1ab0048f790560b7086295204e885ba0e175e35b705f8eccc59d9404df323a commons-imaging-1.0-alpha1-bin-tar.gz.asc=dfc503a8b9e5672c1e444f460f02de142d12c6f321531a02ec7d1b1b67212a5014e35fe84fdc9575e8de9d5f03901916149ba7ac7ff51ae5b8fa5bff026f0c54 commons-imaging-1.0-alpha1-test-sources-jar.asc=a4b2ee4883409c498152689ec4024b627fc129d4614cfe0e1241d416cd43dfe10d365d8364260f6e14ba85e708e19b800ec88560a844499eab8f2b5d4f3fd3db commons-imaging-1.0-alpha1-src-tar.gz=32c6f6d5db016d4a96a82e0f0dd63a884b9d2a4199e30b8ab6c1d5761f72d3060c7d1d9c02d697fbba054f07023bf155b65f8b745414438884df822657212614 commons-imaging-1.0-alpha1-bin-zip.asc=c6869704d9d4b4a826663aef7667c38a580b5e7254c8ac1576018fff
Re: [beanutils] Java version
On Wed, Oct 31, 2018 at 7:35 AM Jochen Wiedmann wrote: > On Fri, Oct 12, 2018 at 11:36 PM Gary Gregory > wrote: > > > For 2.0.0, we've update [beanutils] from Java 6 to 7, but should we move > to > > Java 8 instead since anything older is deader than a doornail? > > Go on. People need to upgrade their VM anyways, > It's been over two weeks since my message, I'll update. Gary > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [jira] [Commented] (IO-588) IOUtils.writeLines() should accept an Iterable<>
On Wed, Oct 31, 2018 at 7:39 AM Jochen Wiedmann wrote: > On Fri, Oct 12, 2018 at 6:06 PM Gary Gregory (JIRA) > wrote: > > > Thank you for your patch but... -1 to this patch as it breaks binary > compatibility. > > Could you explain that, please? A Collection is, in particular, an > Iterable, thus the compiler should use the new methods, instead, as > far as I can tell. > You are talking about _source_ compatibility. Binary compatibility should allow a new jar to replace the old one, this change breaks that capability. Gary > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [jira] [Commented] (IO-588) IOUtils.writeLines() should accept an Iterable<>
On Fri, Oct 12, 2018 at 6:06 PM Gary Gregory (JIRA) wrote: > Thank you for your patch but... -1 to this patch as it breaks binary > compatibility. Could you explain that, please? A Collection is, in particular, an Iterable, thus the compiler should use the new methods, instead, as far as I can tell. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [beanutils] Java version
On Fri, Oct 12, 2018 at 11:36 PM Gary Gregory wrote: > For 2.0.0, we've update [beanutils] from Java 6 to 7, but should we move to > Java 8 instead since anything older is deader than a doornail? Go on. People need to upgrade their VM anyways, - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #91: TEXT-127 Detect when a variable is unknown in String...
Github user drajakumar commented on the issue: https://github.com/apache/commons-text/pull/91 closed the pr as @garydgregory made applied a different patch that changes the instance variable name and method name. He also provided the variable name that is not found. He added some missing Javadoc throws tags. https://github.com/apache/commons-text/commit/ed94773e2d2e4da4e993e5a50ee72624587cf76b --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #91: TEXT-127 Detect when a variable is unknown in...
Github user drajakumar closed the pull request at: https://github.com/apache/commons-text/pull/91 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
