Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-26 Thread Eitan Adler
(please make sure to CC me directly on replies)

On Sun, 26 May 2019 at 17:17, Heinrich Bohne  wrote:

> ... (I didn't subscribe to the list, which I now regret as I am editing
> the header fields of this email manually, hoping that I do it correctly and
> that the message will be attributed to the correct thread).
>

This is the first time I seeing this thread.


> Regarding the point about a potential mess of multiple JUnit versions:
> JUnit 5 seems to provide a "Vintage" test engine to support the execution
> of JUnit 3 and 4 tests alongside JUnit 5 tests.
>

It is precisely this that I am advocating against.   While JUnit 5 has a
method of running older tests, by leaving the older style tests around
we're producing confusion as to how it will get run or how to write new
tests. Using it as a migration tool is reasonable, but the commons are
small enough that wholesale migration is "easy".


>
>
-- 
Eitan Adler


Re: Proposal to introduce JUnit 5 in commons-numbers

2019-05-26 Thread Heinrich Bohne

Hello, and excuse me for the late reply, I didn't realize until now that
the online archive of the mailing list can have more than one page per
month, and since my original email didn't show up on the first page, I
was wondering whether it ever went through (I didn't subscribe to the
list, which I now regret as I am editing the header fields of this email
manually, hoping that I do it correctly and that the message will be
attributed to the correct thread).

Regarding the point about a potential mess of multiple JUnit versions:
JUnit 5 seems to provide a "Vintage" test engine to support the
execution of JUnit 3 and 4 tests alongside JUnit 5 tests. If this
Vintage test engine is added as a dependency in a Maven project in
addition to JUnit 4, then Maven will be able to run JUnit 4 tests on the
Vintage engine whilst running JUnit 5 tests on the Jupiter engine from
JUnit 5 (provided the Jupiter engine is added as a dependency). See
https://junit.org/junit5/docs/current/user-guide/#running-tests-build-maven
from the JUnit 5 user guide.

I also tried it without the Vintage engine, i.e. only JUnit 4 and the
Jupiter engine, but then, Maven would either run only the JUnit 4 tests
or only the JUnit 5 tests, or sometimes no tests at all, who knows why.
But with the Vintage engine, new tests can be written in JUnit 5 without
requiring all existing JUnit 4 tests to be migrated to JUnit 5 at once,
because, as far as I understand it, JUnit 5 tests will be run by the
Jupiter engine, JUnit 4 tests can be run by the Vintage engine until
they are migrated to JUnit 5, and the JUnit 4 dependency, it seems to
me, is only needed for compiling the JUnit 4 tests, but not for running
them.



--

From    Gilles Sadowski 
Subject    Re: Proposal to introduce JUnit 5 in commons-numbers
Date    Sat, 25 May 2019 10:11:43 GMT

Hi.

Le ven. 24 mai 2019 à 06:01, Eitan Adler  a écrit :


(please make sure to CC me on replies)

+1 on this. One thing I'd like for us to avoid a mess of different junit
versions making it difficult to know which runner will be executing the
class. It would be great if we did a complete conversion and not just
introduced new syntax.


+1


I've actually done this before on a largish Java
project from JUnit3/4 to 5. It isn't hard, just a fair amount of mechanical
code changes.


Patch/PR welcome.

Regards,
Gilles



On Wed, 22 May 2019 at 15:30, Eric Barnhill  wrote:

> +1
>
> On Wed, May 22, 2019 at 3:15 PM Gilles Sadowski 
> wrote:
>
> > Hi.
> >
> > Le mer. 22 mai 2019 à 18:43, Heinrich Bohne 

a

> > écrit :
> > >
> > > Right now, commons-numbers is using JUnit 4.12, the last stable version
> > > of JUnit 4. As far as I am aware, there is no explicit syntax in JUnit
> > > 4.12 for testing whether an exception is thrown apart from either using
> > > the deprecated class ExpectedException or adding the "expected"
> > > parameter to the Test annotation. The problem with the latter approach
> > > is that it is impossible to ascertain where exactly in the annotated
> > > method the exception is thrown – it could be thrown somewhere
> unexpected
> > > and the test will still pass. Besides, when testing the same exception
> > > trigger with multiple different inputs, it is impractical to create a
> > > separate method for each test case, which would be necessary with both
> > > aforementioned approaches.
> > >
> > > This has led to the creation of constructs where the expected exception
> > > is swallowed, which has been deemed undesirable
> > > <
> >
> 
https://issues.apache.org/jira/browse/NUMBERS-99?focusedCommentId=16843419=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16843419
> > >.
> > > Because of this, I propose to add JUnit 5 as a dependency in
> > > commons-numbers. JUnit 5 has several "assertThrows" methods that would
> > > solve the described dilemma.
> >
> > +1
> >
> > Gilles
> >




Re: [rng] Upgrade examples to Java 8

2019-05-26 Thread Gilles Sadowski
Le dim. 26 mai 2019 à 19:28, Alex Herbert  a écrit :
>
> Currently the examples projects use:
>
> Examples-jmh: JDK 1.6
> Examples-quadrature: JDK 1.7
> Examples-stress: JDK 1.8
> Examples-sampling: JDK 1.8
> Examples-jpms: JDK 1.9
>
> Having JMH at level 1.6 prevents testing against algorithms in SecureRandom 
> (newer algorithms in 1.8), ThreadLocalRandom (1.7) and SplittableRandom (1.8).
>
> It would be good to upgrade JMH to 1.8 but I don’t see a reason to not 
> upgrade all to JDK 1.8. These are not part of the RNG distribution.
>
> Alex
>

It was assumed that upgrading sub-modules of "commons-rng-examples"
was allowed if a particular example requires it.
+1 for "jmh"
+0 for "quadrature"

Gilles

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

2019-05-26 Thread Alex Herbert
Hi Gary,

+0.5

I get build failures to do with environment properties look-up because one of 
my environment properties is resolved with current known variables.

It can be reproduced using this (on a linux-type build with a bash shell):

export BAD_VAR='${USER}@${HOSTNAME}’

mvn -V clean package

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 
2017-04-03T20:39:06+01:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: “mac"

[ERROR] Failures: 
[ERROR]   TestCombinedConfigurationBuilder.testEnvironmentProperties:708 Wrong 
value for property: BAD_VAR expected:<[${USER}]@${HOSTNAME}> but 
was:<[ah403]@${HOSTNAME}>
[ERROR]   
TestCombinedConfigurationBuilderVFS>TestCombinedConfigurationBuilder.testEnvironmentProperties:708
 Wrong value for property: BAD_VAR expected:<[${USER}]@${HOSTNAME}> but 
was:<[ah403]@${HOSTNAME}>
[ERROR]   TestEnvironmentLookup.testLookup:57 Wrong value for BAD_VAR 
expected:<[ah403]@${HOSTNAME}> but was:<[${USER}]@${HOSTNAME}>


Same on JDK 11:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 
2017-04-03T20:39:06+01:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 11.0.2, vendor: AdoptOpenJDK
Java home: 
/Library/Java/JavaVirtualMachines/adoptopenjdk-11.0.2.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.5", arch: "x86_64", family: "mac"


A little dig around the code found that the ‘${USER}’ part of the environment 
variable is resolved to its current known value. In my case this is ‘ah403’. So 
the expected and actual values do not match when the environment variable is 
‘BAD_VAR’.

If I unset the offending environment variable then the code builds fine. I do 
not know how long the tests have been like this. The same thing happens when I 
checkout the code using the tag CONFIGURATION_2_4 for the previous release. For 
this reason I do not think it a blocker. It is either a ‘bug’ or a 
known/unknown ‘feature’ that has been present for a while. It should be 
investigated by a dev who knows the code and a decision made about what the 
true expected result in this case should be.


Jira report on the site has an empty column for 'Fix Version’.  I checked and 
it is because Jira entries for the version fixed when a ticket is closed is 
missing.

All other reports look good (spotbugs, checkstyle, JApiCmp, Rat, JDepend).


Note that when I tried building the site locally skipping tests (due to above 
problems) the spotbugs plugin does not have a version:

[WARNING] Report plugin com.github.spotbugs:spotbugs-maven-plugin has an empty 
version.


Alex



> On 26 May 2019, at 15:47, Gary Gregory  wrote:
> 
> Hi all, are any of you available to review this RC?
> 
> Gary
> 
> On Thu, May 23, 2019 at 9:39 PM Gary Gregory  wrote:
> 
>> To: dev@commons.apache.org
>> Subject: [VOTE] Release Apache Commons Configuration 2.5 based on RC1
>> 
>> We have fixed quite a few bugs and added some significant enhancements
>> since Apache Commons Configuration 2.4 was released, so I would like to
>> release Apache Commons Configuration 2.5.
>> 
>> Apache Commons Configuration 2.5 RC1 is available for review here:
>>https://dist.apache.org/repos/dist/dev/commons/configuration/2.5-RC1
>> (svn revision 34200)
>> 
>> The Git tag commons-configuration-2.5-RC1 commit for this RC is
>> dc00a04783ea951280ba0cd8318f53e19acb707f which you can browse here:
>> 
>> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=dc00a04783ea951280ba0cd8318f53e19acb707f
>> You may checkout this tag using:
>>git clone
>> https://gitbox.apache.org/repos/asf/commons-configuration.git --branch
>> commons-configuration-2.5-RC1 commons-configuration-2.5-RC1
>> 
>> Maven artifacts are here:
>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1439/org/apache/commons/commons-configuration2/2.5/
>> 
>> These are the artifacts and their hashes:
>> 
>> #Release SHA-512s
>> #Thu May 23 21:10:52 EDT 2019
>> 
>> commons-configuration2-2.5-bin.tar.gz=af36d6218f2b04492b1ecdb3a45c9eca0e782f38d1278076ce066b2e31c3a92fe7a10eef4639f1047bf25ae2bdc4e61e401b7713933886a221588ff276d713c1
>> 
>> commons-configuration2-2.5-bin.tar.gz.asc=5b28973721604ad88dd91918d4093876bab8d711851adcbbc641d6da555badc7cca508ec779d2ecdb846ad954063b34a04345e683652caeb4624bfc76c518d1f
>> 
>> commons-configuration2-2.5-bin.zip=1133a75ab29fa15514fd050462feb2cf6de1cd03bca0a85c109474f2671189ff05ae966a44f0ee629b91fc9c7dea15e90e4704b82f70f2e517a444c689ea34c8
>> 
>> commons-configuration2-2.5-bin.zip.asc=5bb8a2ebaaacb974c52da36626937f33aec24479590830c8ec68d148abf7163e04c9b3bbc4f54c1608679ac4ad4ce6b1c70e5ff5402c4a592d838828808d9a81
>> 
>> 

[rng] Upgrade examples to Java 8

2019-05-26 Thread Alex Herbert
Currently the examples projects use:

Examples-jmh: JDK 1.6
Examples-quadrature: JDK 1.7
Examples-stress: JDK 1.8
Examples-sampling: JDK 1.8
Examples-jpms: JDK 1.9

Having JMH at level 1.6 prevents testing against algorithms in SecureRandom 
(newer algorithms in 1.8), ThreadLocalRandom (1.7) and SplittableRandom (1.8).

It would be good to upgrade JMH to 1.8 but I don’t see a reason to not upgrade 
all to JDK 1.8. These are not part of the RNG distribution.

Alex






-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

2019-05-26 Thread Rob Tompkins



> On May 26, 2019, at 10:47 AM, Gary Gregory  wrote:
> 
> Hi all, are any of you available to review this RC?

I’ll try to get to it before the end of the day. -Rob
> 
> Gary
> 
>> On Thu, May 23, 2019 at 9:39 PM Gary Gregory  wrote:
>> 
>> To: dev@commons.apache.org
>> Subject: [VOTE] Release Apache Commons Configuration 2.5 based on RC1
>> 
>> We have fixed quite a few bugs and added some significant enhancements
>> since Apache Commons Configuration 2.4 was released, so I would like to
>> release Apache Commons Configuration 2.5.
>> 
>> Apache Commons Configuration 2.5 RC1 is available for review here:
>>https://dist.apache.org/repos/dist/dev/commons/configuration/2.5-RC1
>> (svn revision 34200)
>> 
>> The Git tag commons-configuration-2.5-RC1 commit for this RC is
>> dc00a04783ea951280ba0cd8318f53e19acb707f which you can browse here:
>> 
>> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=dc00a04783ea951280ba0cd8318f53e19acb707f
>> You may checkout this tag using:
>>git clone
>> https://gitbox.apache.org/repos/asf/commons-configuration.git --branch
>> commons-configuration-2.5-RC1 commons-configuration-2.5-RC1
>> 
>> Maven artifacts are here:
>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1439/org/apache/commons/commons-configuration2/2.5/
>> 
>> These are the artifacts and their hashes:
>> 
>> #Release SHA-512s
>> #Thu May 23 21:10:52 EDT 2019
>> 
>> commons-configuration2-2.5-bin.tar.gz=af36d6218f2b04492b1ecdb3a45c9eca0e782f38d1278076ce066b2e31c3a92fe7a10eef4639f1047bf25ae2bdc4e61e401b7713933886a221588ff276d713c1
>> 
>> commons-configuration2-2.5-bin.tar.gz.asc=5b28973721604ad88dd91918d4093876bab8d711851adcbbc641d6da555badc7cca508ec779d2ecdb846ad954063b34a04345e683652caeb4624bfc76c518d1f
>> 
>> commons-configuration2-2.5-bin.zip=1133a75ab29fa15514fd050462feb2cf6de1cd03bca0a85c109474f2671189ff05ae966a44f0ee629b91fc9c7dea15e90e4704b82f70f2e517a444c689ea34c8
>> 
>> commons-configuration2-2.5-bin.zip.asc=5bb8a2ebaaacb974c52da36626937f33aec24479590830c8ec68d148abf7163e04c9b3bbc4f54c1608679ac4ad4ce6b1c70e5ff5402c4a592d838828808d9a81
>> 
>> commons-configuration2-2.5-javadoc.jar=9f8290afe2f663ead9ddae5034c7a08f9ee792cd48821e17fced1ca287a2fb58906e782c8b3f4428ccda1089193402407002f70194d5ecba09edbebf9fab
>> 
>> commons-configuration2-2.5-javadoc.jar.asc=2b62b54400e81f1de39cfe17ed9aafa716a46b58dbf31b49270f85bbc53df09738decd7daec9fe84ef893824a63ed2d7333aa3b0d54524b879d5f17d98d3eb15
>> 
>> commons-configuration2-2.5-sources.jar=05b0675c7725a97cfc892267c44503be12f086f740f83f86b59bab902bd395c9b3f57fa37969993a1cab49a8d99266f29c984f331649d3800fe56a884a0bcc39
>> 
>> commons-configuration2-2.5-sources.jar.asc=42158d3cffd2403a6efd80b1654d252d2a164475e57c11a2a30159bd15216c87ccfdd9ce4609ceeffbd387350a93d4d2d2044af346db93f70812af80b14644d3
>> 
>> commons-configuration2-2.5-src.tar.gz=b69725d694f59678b690d50dc1f17718e7bd3deaa49a4dd30c20548b7df14494d27cec6325b6dd5a4da4adba368c26743ce80de147682cf49da1d5304f6bd9b1
>> 
>> commons-configuration2-2.5-src.tar.gz.asc=c274f8e4e1c575d3b423315019df312530910bcf465e7b109d4fcd7b6d4b671ed34f5cf7731c8fb98378940b1ae03d595e69db4cf94095ad7293a8afda8e2956
>> 
>> commons-configuration2-2.5-src.zip=57e5fa659506668a41f6fde8cc76f96152d0861d19a2f7dbd72dac56864aabf704b081fe029446de5c760ff0d1605f978d5322933c2627a0db73d9d4d1208293
>> 
>> commons-configuration2-2.5-src.zip.asc=15040a9ca0ec7a51df16ed86378656c28c345a0360dd234d118b0d00abadc0375cf031f864b92fbf3af6c0c799661e74d1d257a4b1c5dc2b53db3d8b350fcc95
>> 
>> commons-configuration2-2.5-test-sources.jar=756f6437475241b26b2ce190f8388227e058cefb862e48b98ac86b1886fa299902b77163baec789ead26f398912069b881fe1a1dfe62a1892b8245be31e13f5b
>> 
>> commons-configuration2-2.5-test-sources.jar.asc=080cc1fbc4925bdfd5679d0d2ba60c67a0f594b2b585b010f273ed7a598f817ff9224d0790d2c2981460ea8de69ba67e77c11ee17aa6965bf398b94bd92e9306
>> 
>> commons-configuration2-2.5-tests.jar=ae8a35a0f3c832f8d0869ab900ad13b33537b0112ef320ef9718ad9e707a3a18292d785b0c78f2ade81a0d8967edeb4c92ff6ea4a796a57b3d62c2c153529078
>> 
>> commons-configuration2-2.5-tests.jar.asc=2b25ba280d7c210fb2e7cdc78e971557f365eb08a6645503003833f685ca88d848afb5b56abac5d2861473f01d2d2636ae442e825506c6f059f59bef1a8ba8d6
>> 
>> commons-configuration2-2.5.jar.asc=ab783f4b2e248786a0c7c914f5e80046b045b859713e7b94c97b4f4a65001db9270650917f00ee4ab8ca6e32fe6411f9ee9e17126b86751febcbdc7b403b08c1
>> 
>> commons-configuration2-2.5.pom.asc=6836729386d91565b4e489763a0930b6cacfa697719c563210b0dd3ec9f058060d254374b6fd53ff03ecb2e78227dc4b20128b85e04bbd56d4fc1483d6140666
>> 
>> I have tested this with 'mvn clean install site -Pjacoco' using:
>> 
>> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
>> 2019-04-04T15:00:29-04:00)
>> Maven home: C:\Java\apache-maven-3.6.1\bin\..
>> Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
>> Files\Java\jdk1.8.0_212\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 

Re: svn commit: r1859859 [1/5] - in /commons/proper/jcs/trunk/commons-jcs-core/src: main/java/org/apache/commons/jcs/ main/java/org/apache/commons/jcs/access/ main/java/org/apache/commons/jcs/admin/ m

2019-05-26 Thread Thomas Vandahl
On 26.05.19 15:54, sebb wrote:
> Jan 2019
> 
> https://lists.apache.org/thread.html/053bb8f18e90800d918956f69364167b23c0cdca175568300b1108f6@%3Cdev.commons.apache.org%3E

Ok, I missed that one completely.
What do I have to do?

Bye, Thomas


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [VOTE] Release Apache Commons Configuration 2.5 based on RC1

2019-05-26 Thread Gary Gregory
Hi all, are any of you available to review this RC?

Gary

On Thu, May 23, 2019 at 9:39 PM Gary Gregory  wrote:

> To: dev@commons.apache.org
> Subject: [VOTE] Release Apache Commons Configuration 2.5 based on RC1
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Configuration 2.4 was released, so I would like to
> release Apache Commons Configuration 2.5.
>
> Apache Commons Configuration 2.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.5-RC1
> (svn revision 34200)
>
> The Git tag commons-configuration-2.5-RC1 commit for this RC is
> dc00a04783ea951280ba0cd8318f53e19acb707f which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=dc00a04783ea951280ba0cd8318f53e19acb707f
> You may checkout this tag using:
> git clone
> https://gitbox.apache.org/repos/asf/commons-configuration.git --branch
> commons-configuration-2.5-RC1 commons-configuration-2.5-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1439/org/apache/commons/commons-configuration2/2.5/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Thu May 23 21:10:52 EDT 2019
>
> commons-configuration2-2.5-bin.tar.gz=af36d6218f2b04492b1ecdb3a45c9eca0e782f38d1278076ce066b2e31c3a92fe7a10eef4639f1047bf25ae2bdc4e61e401b7713933886a221588ff276d713c1
>
> commons-configuration2-2.5-bin.tar.gz.asc=5b28973721604ad88dd91918d4093876bab8d711851adcbbc641d6da555badc7cca508ec779d2ecdb846ad954063b34a04345e683652caeb4624bfc76c518d1f
>
> commons-configuration2-2.5-bin.zip=1133a75ab29fa15514fd050462feb2cf6de1cd03bca0a85c109474f2671189ff05ae966a44f0ee629b91fc9c7dea15e90e4704b82f70f2e517a444c689ea34c8
>
> commons-configuration2-2.5-bin.zip.asc=5bb8a2ebaaacb974c52da36626937f33aec24479590830c8ec68d148abf7163e04c9b3bbc4f54c1608679ac4ad4ce6b1c70e5ff5402c4a592d838828808d9a81
>
> commons-configuration2-2.5-javadoc.jar=9f8290afe2f663ead9ddae5034c7a08f9ee792cd48821e17fced1ca287a2fb58906e782c8b3f4428ccda1089193402407002f70194d5ecba09edbebf9fab
>
> commons-configuration2-2.5-javadoc.jar.asc=2b62b54400e81f1de39cfe17ed9aafa716a46b58dbf31b49270f85bbc53df09738decd7daec9fe84ef893824a63ed2d7333aa3b0d54524b879d5f17d98d3eb15
>
> commons-configuration2-2.5-sources.jar=05b0675c7725a97cfc892267c44503be12f086f740f83f86b59bab902bd395c9b3f57fa37969993a1cab49a8d99266f29c984f331649d3800fe56a884a0bcc39
>
> commons-configuration2-2.5-sources.jar.asc=42158d3cffd2403a6efd80b1654d252d2a164475e57c11a2a30159bd15216c87ccfdd9ce4609ceeffbd387350a93d4d2d2044af346db93f70812af80b14644d3
>
> commons-configuration2-2.5-src.tar.gz=b69725d694f59678b690d50dc1f17718e7bd3deaa49a4dd30c20548b7df14494d27cec6325b6dd5a4da4adba368c26743ce80de147682cf49da1d5304f6bd9b1
>
> commons-configuration2-2.5-src.tar.gz.asc=c274f8e4e1c575d3b423315019df312530910bcf465e7b109d4fcd7b6d4b671ed34f5cf7731c8fb98378940b1ae03d595e69db4cf94095ad7293a8afda8e2956
>
> commons-configuration2-2.5-src.zip=57e5fa659506668a41f6fde8cc76f96152d0861d19a2f7dbd72dac56864aabf704b081fe029446de5c760ff0d1605f978d5322933c2627a0db73d9d4d1208293
>
> commons-configuration2-2.5-src.zip.asc=15040a9ca0ec7a51df16ed86378656c28c345a0360dd234d118b0d00abadc0375cf031f864b92fbf3af6c0c799661e74d1d257a4b1c5dc2b53db3d8b350fcc95
>
> commons-configuration2-2.5-test-sources.jar=756f6437475241b26b2ce190f8388227e058cefb862e48b98ac86b1886fa299902b77163baec789ead26f398912069b881fe1a1dfe62a1892b8245be31e13f5b
>
> commons-configuration2-2.5-test-sources.jar.asc=080cc1fbc4925bdfd5679d0d2ba60c67a0f594b2b585b010f273ed7a598f817ff9224d0790d2c2981460ea8de69ba67e77c11ee17aa6965bf398b94bd92e9306
>
> commons-configuration2-2.5-tests.jar=ae8a35a0f3c832f8d0869ab900ad13b33537b0112ef320ef9718ad9e707a3a18292d785b0c78f2ade81a0d8967edeb4c92ff6ea4a796a57b3d62c2c153529078
>
> commons-configuration2-2.5-tests.jar.asc=2b25ba280d7c210fb2e7cdc78e971557f365eb08a6645503003833f685ca88d848afb5b56abac5d2861473f01d2d2636ae442e825506c6f059f59bef1a8ba8d6
>
> commons-configuration2-2.5.jar.asc=ab783f4b2e248786a0c7c914f5e80046b045b859713e7b94c97b4f4a65001db9270650917f00ee4ab8ca6e32fe6411f9ee9e17126b86751febcbdc7b403b08c1
>
> commons-configuration2-2.5.pom.asc=6836729386d91565b4e489763a0930b6cacfa697719c563210b0dd3ec9f058060d254374b6fd53ff03ecb2e78227dc4b20128b85e04bbd56d4fc1483d6140666
>
> I have tested this with 'mvn clean install site -Pjacoco' using:
>
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: C:\Java\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_212\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 2.4 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/configuration/2.5-RC1/RELEASE-NOTES.txt
>
> 

Re: Changes to SVN proper that have occurred since move to Git

2019-05-26 Thread sebb
I think all but jcs have now been dealt with.

On Sun, 26 May 2019 at 13:28, sebb  wrote:
>
> Forgot to say that I have yet to check the commons-* trees (commons-build etc)
>
> On Sun, 26 May 2019 at 13:13, sebb  wrote:
> >
> > I've done a comparison of the latest SVN revision with the most recent
> > trunk(master) Git entry that includes a line of the following form:
> > git-svn-id: 
> > https://svn-us.apache.org/repos/asf/commons/proper/jexl/trunk@1821853
> > 13f79535-47bb-0310-9956-ffa450edef68
> >
> > AFAICT any discrepancies mean that the SVN repo has been updated since
> > the move to Git.
> >
> > I have moved all [1] the components to _moved_to_git where the latest
> > SVN revision agrees with the latest git-svn-id comment in the trunk
> > log.
> >
> > The following 4 components have had changes to SVN that don't appear
> > in the SVN-Git conversion comments. I've listed the changes following
> > the summary line.
> >
> >
> > bcel git-svn-id='1852359' SVN='1852455'
> > 
> > r1852455 | ggregory | 2019-01-29 14:10:43 + (Tue, 29 Jan 2019) | 1 line
> >
> > Use proper hashes.
> > 
> >
> >
> >
> > beanutils git-svn-id='1852248' SVN='1852822'
> > 
> > r1852822 | britter | 2019-02-03 09:57:04 + (Sun, 03 Feb 2019) | 1 line
> >
> > Drop ant build
> > 
> >
> >
> >
> > jcs git-svn-id='1852304' SVN='1859859'
> > 
> > r1858701 | tv | 2019-05-05 18:59:39 +0100 (Sun, 05 May 2019) | 1 line
> >
> > Remove most Iterators
> > 
> > r1859280 | tv | 2019-05-15 10:27:20 +0100 (Wed, 15 May 2019) | 1 line
> >
> > JCS-195 Update element attributes size on serialization
> > 
> > r1859283 | tv | 2019-05-15 10:43:32 +0100 (Wed, 15 May 2019) | 1 line
> >
> > Remove duplicate code
> > 
> > r1859284 | tv | 2019-05-15 10:44:22 +0100 (Wed, 15 May 2019) | 1 line
> >
> > JCS-195 Update element attributes size on serialization
> > 
> > r1859285 | tv | 2019-05-15 10:44:56 +0100 (Wed, 15 May 2019) | 1 line
> >
> > Make all statistic numbers long
> > 
> > r1859286 | tv | 2019-05-15 10:45:24 +0100 (Wed, 15 May 2019) | 1 line
> >
> > Remove synchronized sections
> > 
> > r1859289 | tv | 2019-05-15 13:46:21 +0100 (Wed, 15 May 2019) | 1 line
> >
> > JCS-194 NullPointerException in IndexedDiskCache.addToRecycleBin(...)
> > 
> > r1859857 | tv | 2019-05-24 10:12:04 +0100 (Fri, 24 May 2019) | 1 line
> >
> > Use lambdas for Runnables
> > 
> > r1859859 | tv | 2019-05-24 10:26:50 +0100 (Fri, 24 May 2019) | 1 line
> >
> > Use Java7 diamond operator
> > 
> >
> >
> >
> > jexl git-svn-id='1821853' SVN='1831656'
> > 
> > r1831656 | ggregory | 2018-05-15 19:57:05 +0100 (Tue, 15 May 2018) | 1 line
> >
> > Typo: 'JavaDoc' -> 'Javadoc'.
> > 
> >
> >
> > [1] I had to leave weaver for now as it is currently read-only; I will
> > fix that shortly.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1860080 - /commons/proper/jexl/trunk/README.md

2019-05-26 Thread sebb AT ASF
On Sun, 26 May 2019 at 15:22,  wrote:
>
> Author: sebb
> Date: Sun May 26 14:22:37 2019
> New Revision: 1860080
>
> URL: http://svn.apache.org/viewvc?rev=1860080=rev
> Log:
> Revert r1831656: should not have been applied to SVN copy
>
> Modified:
> commons/proper/jexl/trunk/README.md
>
> Modified: commons/proper/jexl/trunk/README.md
> URL: 
> http://svn.apache.org/viewvc/commons/proper/jexl/trunk/README.md?rev=1860080=1860079=1860080=diff
> ==
> --- commons/proper/jexl/trunk/README.md (original)
> +++ commons/proper/jexl/trunk/README.md Sun May 26 14:22:37 2019
> @@ -52,7 +52,7 @@ Documentation
>  -
>
>  More information can be found on the [Apache Commons JEXL 
> homepage](https://commons.apache.org/proper/commons-jexl).
> -The 
> [Javadoc](https://commons.apache.org/proper/commons-jexl/javadocs/api-release)
>  can be browsed.
> +The 
> [JavaDoc](https://commons.apache.org/proper/commons-jexl/javadocs/api-release)
>  can be browsed.

@gary:

I have not applied this change to Git, because I think it was wrong.
README.md is auto-generated, so changes should be applied to the
generator instead.

>  Questions related to the usage of Apache Commons JEXL should be posted to 
> the [user mailing list][ml].
>
>  Where can I get the latest release?
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1859859 [1/5] - in /commons/proper/jcs/trunk/commons-jcs-core/src: main/java/org/apache/commons/jcs/ main/java/org/apache/commons/jcs/access/ main/java/org/apache/commons/jcs/admin/ m

2019-05-26 Thread sebb
On Sun, 26 May 2019 at 12:27, Thomas Vandahl  wrote:
>
> On 24.05.19 12:33, Gary Gregory wrote:
> > -1
> >
> > We are now on gitbox https://gitbox.apache.org/repos/asf/commons-jcs.git
> >
>
> When did that happen? I don't remember an announcement or a vote.

Jan 2019

https://lists.apache.org/thread.html/053bb8f18e90800d918956f69364167b23c0cdca175568300b1108f6@%3Cdev.commons.apache.org%3E


> Bye, Thomas
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Changes to SVN proper that have occurred since move to Git

2019-05-26 Thread sebb
I've done a comparison of the latest SVN revision with the most recent
trunk(master) Git entry that includes a line of the following form:
git-svn-id: 
https://svn-us.apache.org/repos/asf/commons/proper/jexl/trunk@1821853
13f79535-47bb-0310-9956-ffa450edef68

AFAICT any discrepancies mean that the SVN repo has been updated since
the move to Git.

I have moved all [1] the components to _moved_to_git where the latest
SVN revision agrees with the latest git-svn-id comment in the trunk
log.

The following 4 components have had changes to SVN that don't appear
in the SVN-Git conversion comments. I've listed the changes following
the summary line.


bcel git-svn-id='1852359' SVN='1852455'

r1852455 | ggregory | 2019-01-29 14:10:43 + (Tue, 29 Jan 2019) | 1 line

Use proper hashes.




beanutils git-svn-id='1852248' SVN='1852822'

r1852822 | britter | 2019-02-03 09:57:04 + (Sun, 03 Feb 2019) | 1 line

Drop ant build




jcs git-svn-id='1852304' SVN='1859859'

r1858701 | tv | 2019-05-05 18:59:39 +0100 (Sun, 05 May 2019) | 1 line

Remove most Iterators

r1859280 | tv | 2019-05-15 10:27:20 +0100 (Wed, 15 May 2019) | 1 line

JCS-195 Update element attributes size on serialization

r1859283 | tv | 2019-05-15 10:43:32 +0100 (Wed, 15 May 2019) | 1 line

Remove duplicate code

r1859284 | tv | 2019-05-15 10:44:22 +0100 (Wed, 15 May 2019) | 1 line

JCS-195 Update element attributes size on serialization

r1859285 | tv | 2019-05-15 10:44:56 +0100 (Wed, 15 May 2019) | 1 line

Make all statistic numbers long

r1859286 | tv | 2019-05-15 10:45:24 +0100 (Wed, 15 May 2019) | 1 line

Remove synchronized sections

r1859289 | tv | 2019-05-15 13:46:21 +0100 (Wed, 15 May 2019) | 1 line

JCS-194 NullPointerException in IndexedDiskCache.addToRecycleBin(...)

r1859857 | tv | 2019-05-24 10:12:04 +0100 (Fri, 24 May 2019) | 1 line

Use lambdas for Runnables

r1859859 | tv | 2019-05-24 10:26:50 +0100 (Fri, 24 May 2019) | 1 line

Use Java7 diamond operator




jexl git-svn-id='1821853' SVN='1831656'

r1831656 | ggregory | 2018-05-15 19:57:05 +0100 (Tue, 15 May 2018) | 1 line

Typo: 'JavaDoc' -> 'Javadoc'.



[1] I had to leave weaver for now as it is currently read-only; I will
fix that shortly.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Changes to SVN proper that have occurred since move to Git

2019-05-26 Thread sebb
Forgot to say that I have yet to check the commons-* trees (commons-build etc)

On Sun, 26 May 2019 at 13:13, sebb  wrote:
>
> I've done a comparison of the latest SVN revision with the most recent
> trunk(master) Git entry that includes a line of the following form:
> git-svn-id: 
> https://svn-us.apache.org/repos/asf/commons/proper/jexl/trunk@1821853
> 13f79535-47bb-0310-9956-ffa450edef68
>
> AFAICT any discrepancies mean that the SVN repo has been updated since
> the move to Git.
>
> I have moved all [1] the components to _moved_to_git where the latest
> SVN revision agrees with the latest git-svn-id comment in the trunk
> log.
>
> The following 4 components have had changes to SVN that don't appear
> in the SVN-Git conversion comments. I've listed the changes following
> the summary line.
>
>
> bcel git-svn-id='1852359' SVN='1852455'
> 
> r1852455 | ggregory | 2019-01-29 14:10:43 + (Tue, 29 Jan 2019) | 1 line
>
> Use proper hashes.
> 
>
>
>
> beanutils git-svn-id='1852248' SVN='1852822'
> 
> r1852822 | britter | 2019-02-03 09:57:04 + (Sun, 03 Feb 2019) | 1 line
>
> Drop ant build
> 
>
>
>
> jcs git-svn-id='1852304' SVN='1859859'
> 
> r1858701 | tv | 2019-05-05 18:59:39 +0100 (Sun, 05 May 2019) | 1 line
>
> Remove most Iterators
> 
> r1859280 | tv | 2019-05-15 10:27:20 +0100 (Wed, 15 May 2019) | 1 line
>
> JCS-195 Update element attributes size on serialization
> 
> r1859283 | tv | 2019-05-15 10:43:32 +0100 (Wed, 15 May 2019) | 1 line
>
> Remove duplicate code
> 
> r1859284 | tv | 2019-05-15 10:44:22 +0100 (Wed, 15 May 2019) | 1 line
>
> JCS-195 Update element attributes size on serialization
> 
> r1859285 | tv | 2019-05-15 10:44:56 +0100 (Wed, 15 May 2019) | 1 line
>
> Make all statistic numbers long
> 
> r1859286 | tv | 2019-05-15 10:45:24 +0100 (Wed, 15 May 2019) | 1 line
>
> Remove synchronized sections
> 
> r1859289 | tv | 2019-05-15 13:46:21 +0100 (Wed, 15 May 2019) | 1 line
>
> JCS-194 NullPointerException in IndexedDiskCache.addToRecycleBin(...)
> 
> r1859857 | tv | 2019-05-24 10:12:04 +0100 (Fri, 24 May 2019) | 1 line
>
> Use lambdas for Runnables
> 
> r1859859 | tv | 2019-05-24 10:26:50 +0100 (Fri, 24 May 2019) | 1 line
>
> Use Java7 diamond operator
> 
>
>
>
> jexl git-svn-id='1821853' SVN='1831656'
> 
> r1831656 | ggregory | 2018-05-15 19:57:05 +0100 (Tue, 15 May 2018) | 1 line
>
> Typo: 'JavaDoc' -> 'Javadoc'.
> 
>
>
> [1] I had to leave weaver for now as it is currently read-only; I will
> fix that shortly.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1859859 [1/5] - in /commons/proper/jcs/trunk/commons-jcs-core/src: main/java/org/apache/commons/jcs/ main/java/org/apache/commons/jcs/access/ main/java/org/apache/commons/jcs/admin/ m

2019-05-26 Thread Thomas Vandahl
On 24.05.19 12:33, Gary Gregory wrote:
> -1
> 
> We are now on gitbox https://gitbox.apache.org/repos/asf/commons-jcs.git
> 

When did that happen? I don't remember an announcement or a vote.

Bye, Thomas


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org