[All][parent] RAT check

2019-08-10 Thread Gary Gregory
Hi all,

It seems to me the commons-parent should cause the RAT check to run for all
builds, say in the... validate phase?

Gary


[vfs][text][csv]

2019-08-10 Thread Gary Gregory
Hi all,

I would like to release all of the above soonish, in the order listed. Feel
free to mine Jira and GitHub for more.

Gary


Re: [IO] Improvements to CharSequenceReader

2019-08-10 Thread Rob Spoor

Hi Gary,

I just created two PRs. #90 is for the use of getChars only. #91 was 
built from that one, and adds the sub sequence support. In the latter I 
have added a test for de-serializing a CharSequenceReader that I 
serialized before adding any new code, to make sure this still works.


Rob


On 09/08/2019 23:18, Gary Gregory wrote:

Hi Rob,

Do you plan on creating a PR?

Gary

On Thu, Aug 1, 2019 at 7:00 AM Rob Spoor  wrote:


On 01/08/2019 12:31, Rob Spoor wrote:

Hi,

CharSequenceReader is great, but I think there can be two improvements:

1) read(char[], int, int) currently calls read() several times, which
delegates to charSequence.charAt. That's fine in Java 8 and before, but
in Java 9 the internal storage of String, StringBuilder and StringBuffer
is changed. It's better to use getChars. For instance, after the
length/offset check:

  if (charSequence instanceof String) {
  int count = Math.min(length, charSequence.length() - idx);
  ((String) charSequence).getChars(idx, idx + count, array,
offset);
  return count;
  }
  // similar for StringBuilder and StringBuffer
  // existing code


Small fix: before returning count, idx += count should be added.



2) It would be nice to be able to create a CharSequenceReader for only a
portion of the CharSequence. This prevents the need of having to call
subSequence, which creates a whole new String for StringBuilder and
StringBuffer.
The class would get two extra int fields, start and end:
* start is only used in close() to reset idx and mark to start instead

of 0

* end is used as upper bound instead of charSequence.length()

To prevent IndexOutOfBoundsExceptions if the CharSequence is shrunk, a
private method end() could be used, which returns Math.min(end,
charSequence.length()). The original constructor could then set start
and end to 0 and Integer.MAX_VALUE respectively. One or two constructors
would need to be added to support setting the start and end, and
possibly only the start.

One thing that may make this difficult is serialization.
CharSequenceReader implements Serializable, so it should first be
investigated if this doesn't break serialization.


Kind regards,

Rob


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



JDK 13 is now in the Release Candidate Phase

2019-08-10 Thread Rory O'Donnell

Hi Benedikt,

*JDK 13 is now in the Release Candidate Phase - if you are aware of any 
issues, please let us know.

*

Per the JDK 13 schedule [1], we are now in the Release Candidate phase.
The stabilization repository, jdk/jdk13, is open for P1 bug fixes per 
the JDK Release Process (JEP 3) [2].

All changes require approval via the Fix-Request Process [3].

For more details, see Mark Reinhold's email to jdk-dev mailing list [4]

 * Milestone Schedule:
 o Initial RC Build 33 - Aug 9, 2019
 o GAC - Aug 22, 2019
 o GAR - Sept 5, 2019
 o GA - Sept 17, 2019

*OpenJDK 13 build 33 is available at http://jdk.java.net/13/*

 * These early access, open source builds are provided under the GNU
   General Public License, version 2, with the Classpath Exception
   .
 * Schedule, status & features
 o http://openjdk.java.net/projects/jdk/13/
 * Release Notes
 o http://jdk.java.net/13/release-notes
 * Bug fixes reported by Open Source Projects  :
 o JDK-8228764 - fixed in b32 -reported by Apache Tomcat

**OpenJDK 14 *EA build 9 is now available at **http://jdk.java.net/14**
*

 * These early access, open source builds are provided under the GNU
   General Public License, version 2, with the Classpath Exception
   .
 * Release Notes
 o http://jdk.java.net/14/release-notes
 * JEPs targeted to JDK 14
 o JEP 352  - Non-Volatile Mapped
   Byte Buffers
 * Changes in this build
   

 * Bug fixes reported by Open Source Projects  :
 o JDK-8227170 - fixed in b8 -reported by Apache Ant
 o JDK-8228485 - fixed in b8 -reported by JaCoCo
 o JDK-8222791 - fixed in b7 -reported by Apache Lucene

*Project Panama Early-Access Builds*

 * Build jdk-14-panama+1-15 (2019/8/8) is available at
   http://jdk.java.net/panama/
 * These early-access, open-source builds are provided under the GNU
   General Public License, version 2, with the Classpath Exception
   .

Regards,
Rory

[1] https://openjdk.java.net/projects/jdk/13/#Schedule
[2] https://openjdk.java.net/jeps/3
[3] https://openjdk.java.net/jeps/3#Fix-Request-Process
[4] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-August/003250.html

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland