回复: [VOTE] Release Apache Commons Text 1.8 based on RC1
[x] +1 Release these artifacts Silence Tai 发件人: Gary Gregory 发送时间: 2019年8月31日 4:06 收件人: Commons Developers List 主题: [VOTE] Release Apache Commons Text 1.8 based on RC1 We have fixed quite a few bugs and added some enhancements since Apache Commons Text 1.7 was released, so I would like to release Apache Commons Text 1.8. Apache Commons Text 1.8 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1 (svn revision 35474) The Git tag commons-text-1.8-RC1 commit for this RC is b63df8d66e8306b2608c16be3661248348e78a2f which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-text.git;a=commit;h=b63df8d66e8306b2608c16be3661248348e78a2f You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-text.git --branch commons-text-1.8-RC1 commons-text-1.8-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1462/org/apache/commons/commons-text/1.8/ These are the artifacts and their hashes: #Release SHA-512s #Fri Aug 30 15:57:03 EDT 2019 commons-text-1.8-bin.tar.gz=bc40b63519308f6361d3bb206a7affd52429eb07d63d17ff4ea1f9304115b84448f69e376d93050105ab2d08b639dc5615c5c962347c17bc89abc41e1995f351 commons-text-1.8-bin.zip=0f15f8e87453b959a38be6ff439360cee7b192cf535f4a0cdec702d042af0e85cffb1257d4732bb2603f8326392e54504c050aff5319064f8a1523267dccf798 commons-text-1.8-javadoc.jar=c84918cf93104e62807c1a21e11e03139c9dab8879e505a01e66f9821b73db25de449c200e1645d5b340799beb47a051674c27448d79b3e3088f4b2d004f0e47 commons-text-1.8-sources.jar=732edde41145d05ae37c398799d9b7d337643579be52e5c8319dc05fd1a89bfd5ce492ed1de6a9e812180ebcf8a9c3c54991b01578c62af526ec2b45526662a0 commons-text-1.8-src.tar.gz=7e0bd5bf45c4cffd325f28eee0e8b1b26729c0805f7dabf4a92c82344e86aa1f3b248d78026696e5a0694155e9a0d2470768ce47a8413c23526001e914097594 commons-text-1.8-src.zip=033930730290fc355b79aba9aed83a4dae8622b0a0cb8924345f0cbf5257054d92f20340872208adfa946072d3e7fa121303af614830204b91c2f273b3d9e275 commons-text-1.8-test-sources.jar=b303063a7c9a324da09127303a28945f03c4650becf38635e8ddc6a3bfb3432652ccbc8b924fc46fbdc5ab52460ab28b0a94fc66da2864a41fb5f7c96a58eb6d commons-text-1.8-tests.jar=c1bed5f313b38df69ec3f1292cd7ab4e5ea7f7d30956c1e08990d28d64be0c7820435bdee4818672e25f7963054940b436d9d98fb99f18e6474371ceaf80 I have tested this with 'mvn -V -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Details of changes since 1.7 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/index.html (note some *relative* links are broken and the 1.8 directories are not yet created - these will be OK once the site is deployed.) CLIRR Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/clirr-report.html JApiCmp Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/japicmp.html RAT Report: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-text.git --branch commons-text-1.8-RC1 commons-text-1.8-RC1 cd commons-text-1.8-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package Y
Re: [VOTE] Release Apache Commons Text 1.8 based on RC1
[X] +1 Release these artifacts Build from tag passing on JDK 8 Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_222, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix" and JDK 11 Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 11.0.2, vendor: Oracle Corporation, runtime: /home/kinow/Development/java/jdk-11.0.2 Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-58-generic", arch: "amd64", family: "unix" Site reports look good. Checked signatures for files in the dist area, and they look OK too. Had a quick look inside the dist area files, and everything looks in order too. Thanks for RM'ing! Bruno On Saturday, 31 August 2019, 8:06:27 am NZST, Gary Gregory wrote: We have fixed quite a few bugs and added some enhancements since Apache Commons Text 1.7 was released, so I would like to release Apache Commons Text 1.8. Apache Commons Text 1.8 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1 (svn revision 35474) The Git tag commons-text-1.8-RC1 commit for this RC is b63df8d66e8306b2608c16be3661248348e78a2f which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-text.git;a=commit;h=b63df8d66e8306b2608c16be3661248348e78a2f You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-text.git --branch commons-text-1.8-RC1 commons-text-1.8-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1462/org/apache/commons/commons-text/1.8/ These are the artifacts and their hashes: #Release SHA-512s #Fri Aug 30 15:57:03 EDT 2019 commons-text-1.8-bin.tar.gz=bc40b63519308f6361d3bb206a7affd52429eb07d63d17ff4ea1f9304115b84448f69e376d93050105ab2d08b639dc5615c5c962347c17bc89abc41e1995f351 commons-text-1.8-bin.zip=0f15f8e87453b959a38be6ff439360cee7b192cf535f4a0cdec702d042af0e85cffb1257d4732bb2603f8326392e54504c050aff5319064f8a1523267dccf798 commons-text-1.8-javadoc.jar=c84918cf93104e62807c1a21e11e03139c9dab8879e505a01e66f9821b73db25de449c200e1645d5b340799beb47a051674c27448d79b3e3088f4b2d004f0e47 commons-text-1.8-sources.jar=732edde41145d05ae37c398799d9b7d337643579be52e5c8319dc05fd1a89bfd5ce492ed1de6a9e812180ebcf8a9c3c54991b01578c62af526ec2b45526662a0 commons-text-1.8-src.tar.gz=7e0bd5bf45c4cffd325f28eee0e8b1b26729c0805f7dabf4a92c82344e86aa1f3b248d78026696e5a0694155e9a0d2470768ce47a8413c23526001e914097594 commons-text-1.8-src.zip=033930730290fc355b79aba9aed83a4dae8622b0a0cb8924345f0cbf5257054d92f20340872208adfa946072d3e7fa121303af614830204b91c2f273b3d9e275 commons-text-1.8-test-sources.jar=b303063a7c9a324da09127303a28945f03c4650becf38635e8ddc6a3bfb3432652ccbc8b924fc46fbdc5ab52460ab28b0a94fc66da2864a41fb5f7c96a58eb6d commons-text-1.8-tests.jar=c1bed5f313b38df69ec3f1292cd7ab4e5ea7f7d30956c1e08990d28d64be0c7820435bdee4818672e25f7963054940b436d9d98fb99f18e6474371ceaf80 I have tested this with 'mvn -V -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Details of changes since 1.7 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/index.html (note some *relative* links are broken and the 1.8 directories are not yet created - these will be OK once the site is deployed.) CLIRR Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/clirr-report.html JApiCmp Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/japicmp.html RAT Report: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complet
[VOTE] Release Apache Commons Text 1.8 based on RC1
We have fixed quite a few bugs and added some enhancements since Apache Commons Text 1.7 was released, so I would like to release Apache Commons Text 1.8. Apache Commons Text 1.8 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1 (svn revision 35474) The Git tag commons-text-1.8-RC1 commit for this RC is b63df8d66e8306b2608c16be3661248348e78a2f which you can browse here: https://gitbox.apache.org/repos/asf?p=commons-text.git;a=commit;h=b63df8d66e8306b2608c16be3661248348e78a2f You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-text.git --branch commons-text-1.8-RC1 commons-text-1.8-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1462/org/apache/commons/commons-text/1.8/ These are the artifacts and their hashes: #Release SHA-512s #Fri Aug 30 15:57:03 EDT 2019 commons-text-1.8-bin.tar.gz=bc40b63519308f6361d3bb206a7affd52429eb07d63d17ff4ea1f9304115b84448f69e376d93050105ab2d08b639dc5615c5c962347c17bc89abc41e1995f351 commons-text-1.8-bin.zip=0f15f8e87453b959a38be6ff439360cee7b192cf535f4a0cdec702d042af0e85cffb1257d4732bb2603f8326392e54504c050aff5319064f8a1523267dccf798 commons-text-1.8-javadoc.jar=c84918cf93104e62807c1a21e11e03139c9dab8879e505a01e66f9821b73db25de449c200e1645d5b340799beb47a051674c27448d79b3e3088f4b2d004f0e47 commons-text-1.8-sources.jar=732edde41145d05ae37c398799d9b7d337643579be52e5c8319dc05fd1a89bfd5ce492ed1de6a9e812180ebcf8a9c3c54991b01578c62af526ec2b45526662a0 commons-text-1.8-src.tar.gz=7e0bd5bf45c4cffd325f28eee0e8b1b26729c0805f7dabf4a92c82344e86aa1f3b248d78026696e5a0694155e9a0d2470768ce47a8413c23526001e914097594 commons-text-1.8-src.zip=033930730290fc355b79aba9aed83a4dae8622b0a0cb8924345f0cbf5257054d92f20340872208adfa946072d3e7fa121303af614830204b91c2f273b3d9e275 commons-text-1.8-test-sources.jar=b303063a7c9a324da09127303a28945f03c4650becf38635e8ddc6a3bfb3432652ccbc8b924fc46fbdc5ab52460ab28b0a94fc66da2864a41fb5f7c96a58eb6d commons-text-1.8-tests.jar=c1bed5f313b38df69ec3f1292cd7ab4e5ea7f7d30956c1e08990d28d64be0c7820435bdee4818672e25f7963054940b436d9d98fb99f18e6474371ceaf80 I have tested this with 'mvn -V -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Details of changes since 1.7 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/index.html (note some *relative* links are broken and the 1.8 directories are not yet created - these will be OK once the site is deployed.) CLIRR Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/clirr-report.html JApiCmp Report (compared to 1.7): https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/japicmp.html RAT Report: https://dist.apache.org/repos/dist/dev/commons/text/1.8-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Gary Gregory, Release Manager (using key 86fdc7e2a11262cb) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-text.git --branch commons-text-1.8-RC1 commons-text-1.8-RC1 cd commons-text-1.8-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version produced by -V in your VOTE reply. To gather OS information from a command line: Windows: ver Linux: uname -a 5) Build the site for a single module project Note:
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
+1 >From the git tag. Apache RAT check OK. I was able to do a local deployment with Apache Commons Text as a test using: mvn -V -Duser.name=%my_apache_id% -Dcommons.release-plugin.version=%commons.release-plugin.version% -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy Using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Fri, Aug 30, 2019 at 1:08 PM Gary Gregory wrote: > Not a blocker: commons-codec 1.12 -> 1.13. > > Gary > > On Fri, Aug 30, 2019 at 10:10 AM Rob Tompkins wrote: > >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Release Plugin 1.6 was released, so I would like to >> release Apache Commons Release Plugin 1.7. >> >> Apache Commons Release Plugin 1.7 RC1 is available for review here: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 >> (svn revision 35466) >> >> The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is >> 409d9525e05863415f91590192c544c6b9f7c2e9 >> >> You may checkout this tag using: >> git clone >> https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git >> --branch commons-commons-release-plugin-1.7-RC1 >> commons-commons-release-plugin-1.7-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-release-plugin/1.7/ >> >> These are the artifacts and their hashes: >> >> #Nexus SHA-1s >> >> commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e >> >> commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c >> >> commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 >> commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb >> commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 >> >> commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 >> >> #Release SHA-512s >> #Fri Aug 30 09:58:56 EDT 2019 >> >> commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f >> >> commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 >> >> commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e >> >> commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 >> >> I have tested this with 'mvn clean install site' using: >> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> 2019-04-04T15:00:29-04:00) >> Maven home: /usr/local/Cellar/maven/3.6.1/libexec >> Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: >> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" >> >> >> Details of changes since 1.6 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html >> (note some *relative* links are broken and the 1.7 directories are >> not yet created - these will be OK once the site is deployed.) >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you, >> >> Rob Tompkins, >> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >> >> For following is intended as a helper and refresher for reviewers. >> >> Validating a release candidate >> == >> >> These guidelines are NOT complete. >> >> Requirements: Git, Java, Maven. >> >> You can validate a release from a release candidate (RC) tag as follows. >> >> 1) Clone and checkout the RC tag >> >> git clone >> https://gitbox.apache.org/repos/asf/comm
Re: [LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.11 based on RC1
+1 >From the git tag. Apache RAT check OK. I was able to do a local deployment with Apache Commons Text as a test using: mvn -V -Duser.name=%my_apache_id% -Dcommons.release-plugin.version=%commons.release-plugin.version% -Ddoclint=none -Prelease -Pjacoco -Ptest-deploy clean package site deploy Using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_221\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Fri, Aug 30, 2019 at 12:18 PM Rob Tompkins wrote: > Reasonable. I’ll sort that out when I update the site. > > -Rob > > > On Aug 30, 2019, at 12:14 PM, Gilles Sadowski > wrote: > > > > Hi. > > > > Documentation issue: see below. > > > >> Le ven. 30 août 2019 à 16:44, Rob Tompkins a > écrit : > >> > >> We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Build Plugin Maven Mojo 1.10 was released, so I would > like to release Apache Commons Build Plugin Maven Mojo 1.11. > >> > >> Apache Commons Build Plugin Maven Mojo 1.11 RC1 is available for review > here: > >> > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1 > (svn revision 35468) > >> > >> The Git tag commons-build-plugin-1.11-RC1 commit for this RC is > b67042233aef77f6f0599ef5a52982b3f0650978 > >> > >> You may checkout this tag using: > >>git clone > https://gitbox.apache.org/repos/asf/commons-build-plugin.git --branch > commons-build-plugin-1.11-RC1 commons-build-plugin-1.11-RC1 > >> > >> Maven artifacts are here: > >> > https://repository.apache.org/content/repositories/orgapachecommons-1461/org/apache/commons/commons-build-plugin/1.11/ > >> > >> These are the artifacts and their hashes: > >> > >> #Nexus SHA-1s > >> commons-build-plugin-1.11.jar=ea6c2ae38c032bdda39b2f8f760f973533be51d4 > >> commons-build-plugin-1.11.pom=fdace51c117a1136de14a7b659cf44a38740c8d5 > >> > commons-build-plugin-1.11-test-sources.jar=f5d3c86bc8af81afd471b0236a52e0282b4dde43 > >> > commons-build-plugin-1.11-javadoc.jar=fb92551a6a073dc17b0e88adb4b761c69207ec80 > >> > commons-build-plugin-1.11-sources.jar=1dd953b04d4a05ad4fc5c13fe025bbd8891f996a > >> > commons-build-plugin-1.11-tests.jar=9ba7961cf7c36e7bd4cac3ed53ff4fe15a09f133 > >> > >> > >> #Release SHA-512s > >> #Fri Aug 30 10:30:51 EDT 2019 > >> > commons-build-plugin-1.11-javadoc.jar=e749aae891d13af1c6dcea20e7386dbc6d9a7cbe56b0478c68ff210c713504ff7d144769d110a96881d695bc888d765958a17cf08d400a8988a8f4c6be9108c8 > >> > commons-build-plugin-1.11-sources.jar=1ef7d44774d5c83cdd74e3e069f738446f0e5e180d0a2ce73a5b5dbc71a5bc9f3119a44efc1e5340a5376ce0e77beeaa4e3baffac3a0dc154bc2ea57718899ed > >> > commons-build-plugin-1.11-src.tar.gz=1075448c49d5d2312d2ae9812f347600300e415f05d5b32ef2e261a7afcf10bf0733dffc8da13025e28cb58bce3cb22a98e24aeb6369cfb38f627cbf61f23c78 > >> > commons-build-plugin-1.11-src.zip=9f144ecbece6e3252bbc2d8a7a3d5c38ef02e9d2f159c77ab1e6a98d403a87f2b20fbb2b682771e6a5d863880c1f74448d205ced89080a17b37dfc7f9e5d02ed > >> > commons-build-plugin-1.11-test-sources.jar=b830741d3fbebf833b96a51c731c4c9be0f66b32c65a57ca583c6803fa7e522e6944c763bb6829d4350cc685b000655a09b6a58b6da16a65b633ddd32440b12a > >> > commons-build-plugin-1.11-tests.jar=83b368a69c0237099413931c8d38611ff20655d9db665891dd7d12c910e36223fa61d40232830ab04a2450d5950f8e70ceba7cea1a95b8adf0efcfc0b9757a3c > >> > >> > >> I have tested this with 'mvn clean install site' using: > >> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > >> Maven home: /usr/local/Cellar/maven/3.6.1/libexec > >> Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > >> Default locale: en_US, platform encoding: UTF-8 > >> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > >> > >> > >> Details of changes since 1.10 are in the release notes: > >> > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/RELEASE-NOTES.txt > >> > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/changes-report.html > >> > >> Site: > >> > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/index.html > >>(note some *relative* links are broken and the 1.11 directories are > not yet created - these will be OK once the site is deployed.) > >> > >> RAT Report: > >> > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/rat-report.html > >> > >> KEYS: > >> https://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner that 72 hours from now. > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >>
Re: [DBCP] Reduce boiler plate code using lambdas
On 8/29/19 9:47 PM, Romain Manni-Bucau wrote: Hi Think both points are valid actually. Concretely, such a change has perf impacts, indeed compared to a db init it will be very fast but compared to a driver operation it can be something. Therefore a microbench comparison does not hurt and will at least guarantee it is ok and make people calm about it. When well written lamba are just a static method call so no issue but when not it allocates way more objects and will stress the gc more which is not desired for a pool IMHO. Just my 2cts indeed What would be great is benchmarks. I respectfully disagree with the position that pool performance does not matter because other sources of latency swamp it. For heavily loaded apps, infrastructure performance matters. We spent a lot of time making DBCP 2 a high-performance pool and it would be a shame to take backward steps now. What you say above, Roman, indicates that if we do it right we can have it both ways. That will be great. We should just confirm performance characteristics. Phil Le ven. 30 août 2019 à 01:02, Gary Gregory a écrit : On Thu, Aug 29, 2019 at 6:17 PM Phil Steitz wrote: On 8/29/19 6:37 AM, Gary Gregory wrote: Hi All: In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of boilerplate code using lambdas. This also happens to fix a bunch of places where we did not call checkOpen() when we should have. Interesting. I have a couple of comments. First is a nit - it would make review much easier if you separate the formatting changes from the actual code changes in commits. Please try to do that. Second is more important. I am not a jvm expert so this may be a non-issue, but I wonder whether these changes will have performance / resource utilization impact. If someone can confirm that this all gets optimized to the same or equivalent bytecode, there is nothing to worry about. If not, I would strongly recommend running benchmarks to validate that there is no performance impact. Hi Phil, I understand your concerns but if we step back to the 10k ft level for this component, let's remember that we are managing _database_ connections here, and these database operations are typically extremely slow _compared_ to a Java application: a database app ends up suffering from dealing delays to do with network IO plus whatever the database is doing. On top of this, any DBA would not ever consider allowing an app to use 10k connections, even if the database could handle it. Maybe measurements would be different with an in-memory database like H2 or HSQLDB, but the database itself is the bottleneck no matter what, and borrow/return from DBCP is just noise in comparison IMO. My last point is that if I were to write such a component like DBCP _today_, I would absolutely do it with lambdas, otherwise the duplication would become a code smell by ignoring a language feature, released in Java 8 and which should be mature on the eve of Java 13. WRT the nit, yeah, that's unfortunate but some of the files have had _so much_ boilerplate methods edited into "one-liners" and this is going to mean a lot of changes indeed. Granted, there might be cases where I only wanted to reformat one method and mistakenly reformatted a whole file, and for that I offer my apologies. Gary Phil Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
Not a blocker: commons-codec 1.12 -> 1.13. Gary On Fri, Aug 30, 2019 at 10:10 AM Rob Tompkins wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Release Plugin 1.6 was released, so I would like to > release Apache Commons Release Plugin 1.7. > > Apache Commons Release Plugin 1.7 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 > (svn revision 35466) > > The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is > 409d9525e05863415f91590192c544c6b9f7c2e9 > > You may checkout this tag using: > git clone > https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git > --branch commons-commons-release-plugin-1.7-RC1 > commons-commons-release-plugin-1.7-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-release-plugin/1.7/ > > These are the artifacts and their hashes: > > #Nexus SHA-1s > > commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e > > commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c > > commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 > commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb > commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 > > commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 > > #Release SHA-512s > #Fri Aug 30 09:58:56 EDT 2019 > > commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f > > commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 > > commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e > > commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 > > I have tested this with 'mvn clean install site' using: > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > Maven home: /usr/local/Cellar/maven/3.6.1/libexec > Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > > Details of changes since 1.6 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html > (note some *relative* links are broken and the 1.7 directories are not > yet created - these will be OK once the site is deployed.) > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Rob Tompkins, > Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone > https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git > --branch commons-commons-release-plugin-1.7-RC1 > commons-commons-release-plugin-1.7-RC1 > cd commons-commons-release-plugin-1.7-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which > you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced
Re: [LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.11 based on RC1
Reasonable. I’ll sort that out when I update the site. -Rob > On Aug 30, 2019, at 12:14 PM, Gilles Sadowski wrote: > > Hi. > > Documentation issue: see below. > >> Le ven. 30 août 2019 à 16:44, Rob Tompkins a écrit : >> >> We have fixed quite a few bugs and added some significant enhancements since >> Apache Commons Build Plugin Maven Mojo 1.10 was released, so I would like to >> release Apache Commons Build Plugin Maven Mojo 1.11. >> >> Apache Commons Build Plugin Maven Mojo 1.11 RC1 is available for review here: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1 >> (svn revision 35468) >> >> The Git tag commons-build-plugin-1.11-RC1 commit for this RC is >> b67042233aef77f6f0599ef5a52982b3f0650978 >> >> You may checkout this tag using: >>git clone https://gitbox.apache.org/repos/asf/commons-build-plugin.git >> --branch commons-build-plugin-1.11-RC1 commons-build-plugin-1.11-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1461/org/apache/commons/commons-build-plugin/1.11/ >> >> These are the artifacts and their hashes: >> >> #Nexus SHA-1s >> commons-build-plugin-1.11.jar=ea6c2ae38c032bdda39b2f8f760f973533be51d4 >> commons-build-plugin-1.11.pom=fdace51c117a1136de14a7b659cf44a38740c8d5 >> commons-build-plugin-1.11-test-sources.jar=f5d3c86bc8af81afd471b0236a52e0282b4dde43 >> commons-build-plugin-1.11-javadoc.jar=fb92551a6a073dc17b0e88adb4b761c69207ec80 >> commons-build-plugin-1.11-sources.jar=1dd953b04d4a05ad4fc5c13fe025bbd8891f996a >> commons-build-plugin-1.11-tests.jar=9ba7961cf7c36e7bd4cac3ed53ff4fe15a09f133 >> >> >> #Release SHA-512s >> #Fri Aug 30 10:30:51 EDT 2019 >> commons-build-plugin-1.11-javadoc.jar=e749aae891d13af1c6dcea20e7386dbc6d9a7cbe56b0478c68ff210c713504ff7d144769d110a96881d695bc888d765958a17cf08d400a8988a8f4c6be9108c8 >> commons-build-plugin-1.11-sources.jar=1ef7d44774d5c83cdd74e3e069f738446f0e5e180d0a2ce73a5b5dbc71a5bc9f3119a44efc1e5340a5376ce0e77beeaa4e3baffac3a0dc154bc2ea57718899ed >> commons-build-plugin-1.11-src.tar.gz=1075448c49d5d2312d2ae9812f347600300e415f05d5b32ef2e261a7afcf10bf0733dffc8da13025e28cb58bce3cb22a98e24aeb6369cfb38f627cbf61f23c78 >> commons-build-plugin-1.11-src.zip=9f144ecbece6e3252bbc2d8a7a3d5c38ef02e9d2f159c77ab1e6a98d403a87f2b20fbb2b682771e6a5d863880c1f74448d205ced89080a17b37dfc7f9e5d02ed >> commons-build-plugin-1.11-test-sources.jar=b830741d3fbebf833b96a51c731c4c9be0f66b32c65a57ca583c6803fa7e522e6944c763bb6829d4350cc685b000655a09b6a58b6da16a65b633ddd32440b12a >> commons-build-plugin-1.11-tests.jar=83b368a69c0237099413931c8d38611ff20655d9db665891dd7d12c910e36223fa61d40232830ab04a2450d5950f8e70ceba7cea1a95b8adf0efcfc0b9757a3c >> >> >> I have tested this with 'mvn clean install site' using: >> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> 2019-04-04T15:00:29-04:00) >> Maven home: /usr/local/Cellar/maven/3.6.1/libexec >> Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: >> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" >> >> >> Details of changes since 1.10 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/changes-report.html >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/index.html >>(note some *relative* links are broken and the 1.11 directories are not >> yet created - these will be OK once the site is deployed.) >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you, >> >> Rob Tompkins, >> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >> >> For following is intended as a helper and refresher for reviewers. >> >> Validating a release candidate >> == >> >> These guidelines are NOT complete. >> >> Requirements: Git, Java, Maven. >> >> You can validate a release from a release candidate (RC) tag as follows. >> >> 1) Clone and checkout the RC tag >> >> git clone >> https://gitbox.apache.org/repos/asf/commons-commons-build-plugin.git >> --branch commons-commons-build-plugin-1.11-RC1 >> commons-commons-build-plugin-1.11-RC1 >> cd commons-commons-build-plugin-1.11-RC1 >> >> 2) Check Apache licenses >> >> This step is not required if the site includes a RAT report page which
Re: [LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.11 based on RC1
Hi. Documentation issue: see below. Le ven. 30 août 2019 à 16:44, Rob Tompkins a écrit : > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Build Plugin Maven Mojo 1.10 was released, so I would like to > release Apache Commons Build Plugin Maven Mojo 1.11. > > Apache Commons Build Plugin Maven Mojo 1.11 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1 > (svn revision 35468) > > The Git tag commons-build-plugin-1.11-RC1 commit for this RC is > b67042233aef77f6f0599ef5a52982b3f0650978 > > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-build-plugin.git > --branch commons-build-plugin-1.11-RC1 commons-build-plugin-1.11-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1461/org/apache/commons/commons-build-plugin/1.11/ > > These are the artifacts and their hashes: > > #Nexus SHA-1s > commons-build-plugin-1.11.jar=ea6c2ae38c032bdda39b2f8f760f973533be51d4 > commons-build-plugin-1.11.pom=fdace51c117a1136de14a7b659cf44a38740c8d5 > commons-build-plugin-1.11-test-sources.jar=f5d3c86bc8af81afd471b0236a52e0282b4dde43 > commons-build-plugin-1.11-javadoc.jar=fb92551a6a073dc17b0e88adb4b761c69207ec80 > commons-build-plugin-1.11-sources.jar=1dd953b04d4a05ad4fc5c13fe025bbd8891f996a > commons-build-plugin-1.11-tests.jar=9ba7961cf7c36e7bd4cac3ed53ff4fe15a09f133 > > > #Release SHA-512s > #Fri Aug 30 10:30:51 EDT 2019 > commons-build-plugin-1.11-javadoc.jar=e749aae891d13af1c6dcea20e7386dbc6d9a7cbe56b0478c68ff210c713504ff7d144769d110a96881d695bc888d765958a17cf08d400a8988a8f4c6be9108c8 > commons-build-plugin-1.11-sources.jar=1ef7d44774d5c83cdd74e3e069f738446f0e5e180d0a2ce73a5b5dbc71a5bc9f3119a44efc1e5340a5376ce0e77beeaa4e3baffac3a0dc154bc2ea57718899ed > commons-build-plugin-1.11-src.tar.gz=1075448c49d5d2312d2ae9812f347600300e415f05d5b32ef2e261a7afcf10bf0733dffc8da13025e28cb58bce3cb22a98e24aeb6369cfb38f627cbf61f23c78 > commons-build-plugin-1.11-src.zip=9f144ecbece6e3252bbc2d8a7a3d5c38ef02e9d2f159c77ab1e6a98d403a87f2b20fbb2b682771e6a5d863880c1f74448d205ced89080a17b37dfc7f9e5d02ed > commons-build-plugin-1.11-test-sources.jar=b830741d3fbebf833b96a51c731c4c9be0f66b32c65a57ca583c6803fa7e522e6944c763bb6829d4350cc685b000655a09b6a58b6da16a65b633ddd32440b12a > commons-build-plugin-1.11-tests.jar=83b368a69c0237099413931c8d38611ff20655d9db665891dd7d12c910e36223fa61d40232830ab04a2450d5950f8e70ceba7cea1a95b8adf0efcfc0b9757a3c > > > I have tested this with 'mvn clean install site' using: > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > Maven home: /usr/local/Cellar/maven/3.6.1/libexec > Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > > Details of changes since 1.10 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/index.html > (note some *relative* links are broken and the 1.11 directories are not > yet created - these will be OK once the site is deployed.) > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Rob Tompkins, > Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone > https://gitbox.apache.org/repos/asf/commons-commons-build-plugin.git --branch > commons-commons-build-plugin-1.11-RC1 commons-commons-build-plugin-1.11-RC1 > cd commons-commons-build-plugin-1.11-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which you > then must check. > > mvn clirr:check > > Newer
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
On Fri, Aug 30, 2019 at 11:59 AM Rob Tompkins wrote: > It’s only a problem on commons-release-plugin and commons-build-plugin. So > only very maybe. > OK, so let's skip it for this release. Gary > > > On Aug 30, 2019, at 11:47 AM, Gary Gregory > wrote: > > > > Does our vote template need fixing? > > > > Gary > > > >> On Fri, Aug 30, 2019 at 10:38 AM Rob Tompkins > wrote: > >> > >> Typos fixed > >> > >> -- > >> > >> > >> We have fixed quite a few bugs and added some significant enhancements > >> since Apache Commons Release Plugin 1.6 was released, so I would like to > >> release Apache Commons Release Plugin 1.7. > >> > >> Apache Commons Release Plugin 1.7 RC1 is available for review here: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 > >> (svn revision 35466) > >> > >> The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is > >> 409d9525e05863415f91590192c544c6b9f7c2e9 > >> > >> You may checkout this tag using: > >> git clone > >> https://gitbox.apache.org/repos/asf/commons-release-plugin.git --branch > >> commons-release-plugin-1.7-RC1 commons-release-plugin-1.7-RC1 > >> > >> Maven artifacts are here: > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1460/org/apache/commons/commons-release-plugin/1.7/ > >> > >> These are the artifacts and their hashes: > >> > >> #Nexus SHA-1s > >> > >> > commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e > >> > >> > commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c > >> > >> > commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 > >> commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb > >> commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 > >> > >> > commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 > >> > >> #Release SHA-512s > >> #Fri Aug 30 09:58:56 EDT 2019 > >> > >> > commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f > >> > >> > commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 > >> > >> > commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e > >> > >> > commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 > >> > >> I have tested this with 'mvn clean install site' using: > >> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > >> 2019-04-04T15:00:29-04:00) > >> Maven home: /usr/local/Cellar/maven/3.6.1/libexec > >> Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: > >> > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > >> Default locale: en_US, platform encoding: UTF-8 > >> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > >> > >> > >> Details of changes since 1.6 are in the release notes: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt > >> > >> > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html > >> > >> Site: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html > >> (note some *relative* links are broken and the 1.7 directories are not > >> yet created - these will be OK once the site is deployed.) > >> > >> RAT Report: > >> > >> > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html > >> > >> KEYS: > >> https://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner that 72 hours from now. > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> Thank you, > >> > >> Rob Tompkins, > >> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) > >> > >> For following is intended as a helper and refresher for reviewers. > >> > >> Validating a release candidate > >> == > >> > >> These guidelines are NOT complete. > >> > >> Requirements: Git, Java, Maven. > >> > >> You can validate a release from a release candidate (RC) tag as follows. > >> > >> 1) Clone and checkout the RC tag > >> > >> git clone > >> https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git > >> --branch commons-commons-release-plugin-1.7-RC1 > >> commons-commons-release-plugin-1.7-RC1 > >> cd commons-commons-release-plugin-1.7-RC1 > >> > >> 2) Check Apache licenses > >> > >> Th
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
It’s only a problem on commons-release-plugin and commons-build-plugin. So only very maybe. > On Aug 30, 2019, at 11:47 AM, Gary Gregory wrote: > > Does our vote template need fixing? > > Gary > >> On Fri, Aug 30, 2019 at 10:38 AM Rob Tompkins wrote: >> >> Typos fixed >> >> -- >> >> >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Release Plugin 1.6 was released, so I would like to >> release Apache Commons Release Plugin 1.7. >> >> Apache Commons Release Plugin 1.7 RC1 is available for review here: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 >> (svn revision 35466) >> >> The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is >> 409d9525e05863415f91590192c544c6b9f7c2e9 >> >> You may checkout this tag using: >> git clone >> https://gitbox.apache.org/repos/asf/commons-release-plugin.git --branch >> commons-release-plugin-1.7-RC1 commons-release-plugin-1.7-RC1 >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1460/org/apache/commons/commons-release-plugin/1.7/ >> >> These are the artifacts and their hashes: >> >> #Nexus SHA-1s >> >> commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e >> >> commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c >> >> commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 >> commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb >> commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 >> >> commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 >> >> #Release SHA-512s >> #Fri Aug 30 09:58:56 EDT 2019 >> >> commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f >> >> commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 >> >> commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e >> >> commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 >> >> I have tested this with 'mvn clean install site' using: >> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; >> 2019-04-04T15:00:29-04:00) >> Maven home: /usr/local/Cellar/maven/3.6.1/libexec >> Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: >> /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" >> >> >> Details of changes since 1.6 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html >> (note some *relative* links are broken and the 1.7 directories are not >> yet created - these will be OK once the site is deployed.) >> >> RAT Report: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now. >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thank you, >> >> Rob Tompkins, >> Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) >> >> For following is intended as a helper and refresher for reviewers. >> >> Validating a release candidate >> == >> >> These guidelines are NOT complete. >> >> Requirements: Git, Java, Maven. >> >> You can validate a release from a release candidate (RC) tag as follows. >> >> 1) Clone and checkout the RC tag >> >> git clone >> https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git >> --branch commons-commons-release-plugin-1.7-RC1 >> commons-commons-release-plugin-1.7-RC1 >> cd commons-commons-release-plugin-1.7-RC1 >> >> 2) Check Apache licenses >> >> This step is not required if the site includes a RAT report page which you >> then must check. >> >> mvn apache-rat:check >> >> 3) Check binary compatibility >> >> Older components still use Apache Clirr: >> >> This step is not required if the site includes a Clirr report page which >> you then must check. >> >> mvn clirr:check >> >> Ne
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
Does our vote template need fixing? Gary On Fri, Aug 30, 2019 at 10:38 AM Rob Tompkins wrote: > Typos fixed > > -- > > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Release Plugin 1.6 was released, so I would like to > release Apache Commons Release Plugin 1.7. > > Apache Commons Release Plugin 1.7 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 > (svn revision 35466) > > The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is > 409d9525e05863415f91590192c544c6b9f7c2e9 > > You may checkout this tag using: >git clone > https://gitbox.apache.org/repos/asf/commons-release-plugin.git --branch > commons-release-plugin-1.7-RC1 commons-release-plugin-1.7-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1460/org/apache/commons/commons-release-plugin/1.7/ > > These are the artifacts and their hashes: > > #Nexus SHA-1s > > commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e > > commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c > > commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 > commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb > commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 > > commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 > > #Release SHA-512s > #Fri Aug 30 09:58:56 EDT 2019 > > commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f > > commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 > > commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e > > commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 > > I have tested this with 'mvn clean install site' using: > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > Maven home: /usr/local/Cellar/maven/3.6.1/libexec > Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: > /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > > Details of changes since 1.6 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html >(note some *relative* links are broken and the 1.7 directories are not > yet created - these will be OK once the site is deployed.) > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Rob Tompkins, > Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone > https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git > --branch commons-commons-release-plugin-1.7-RC1 > commons-commons-release-plugin-1.7-RC1 > cd commons-commons-release-plugin-1.7-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which you > then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page which > you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page which > you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE
[LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.11 based on RC1
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Build Plugin Maven Mojo 1.10 was released, so I would like to release Apache Commons Build Plugin Maven Mojo 1.11. Apache Commons Build Plugin Maven Mojo 1.11 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1 (svn revision 35468) The Git tag commons-build-plugin-1.11-RC1 commit for this RC is b67042233aef77f6f0599ef5a52982b3f0650978 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-build-plugin.git --branch commons-build-plugin-1.11-RC1 commons-build-plugin-1.11-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1461/org/apache/commons/commons-build-plugin/1.11/ These are the artifacts and their hashes: #Nexus SHA-1s commons-build-plugin-1.11.jar=ea6c2ae38c032bdda39b2f8f760f973533be51d4 commons-build-plugin-1.11.pom=fdace51c117a1136de14a7b659cf44a38740c8d5 commons-build-plugin-1.11-test-sources.jar=f5d3c86bc8af81afd471b0236a52e0282b4dde43 commons-build-plugin-1.11-javadoc.jar=fb92551a6a073dc17b0e88adb4b761c69207ec80 commons-build-plugin-1.11-sources.jar=1dd953b04d4a05ad4fc5c13fe025bbd8891f996a commons-build-plugin-1.11-tests.jar=9ba7961cf7c36e7bd4cac3ed53ff4fe15a09f133 #Release SHA-512s #Fri Aug 30 10:30:51 EDT 2019 commons-build-plugin-1.11-javadoc.jar=e749aae891d13af1c6dcea20e7386dbc6d9a7cbe56b0478c68ff210c713504ff7d144769d110a96881d695bc888d765958a17cf08d400a8988a8f4c6be9108c8 commons-build-plugin-1.11-sources.jar=1ef7d44774d5c83cdd74e3e069f738446f0e5e180d0a2ce73a5b5dbc71a5bc9f3119a44efc1e5340a5376ce0e77beeaa4e3baffac3a0dc154bc2ea57718899ed commons-build-plugin-1.11-src.tar.gz=1075448c49d5d2312d2ae9812f347600300e415f05d5b32ef2e261a7afcf10bf0733dffc8da13025e28cb58bce3cb22a98e24aeb6369cfb38f627cbf61f23c78 commons-build-plugin-1.11-src.zip=9f144ecbece6e3252bbc2d8a7a3d5c38ef02e9d2f159c77ab1e6a98d403a87f2b20fbb2b682771e6a5d863880c1f74448d205ced89080a17b37dfc7f9e5d02ed commons-build-plugin-1.11-test-sources.jar=b830741d3fbebf833b96a51c731c4c9be0f66b32c65a57ca583c6803fa7e522e6944c763bb6829d4350cc685b000655a09b6a58b6da16a65b633ddd32440b12a commons-build-plugin-1.11-tests.jar=83b368a69c0237099413931c8d38611ff20655d9db665891dd7d12c910e36223fa61d40232830ab04a2450d5950f8e70ceba7cea1a95b8adf0efcfc0b9757a3c I have tested this with 'mvn clean install site' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: /usr/local/Cellar/maven/3.6.1/libexec Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" Details of changes since 1.10 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/index.html (note some *relative* links are broken and the 1.11 directories are not yet created - these will be OK once the site is deployed.) RAT Report: https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.11-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Rob Tompkins, Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-commons-build-plugin.git --branch commons-commons-build-plugin-1.11-RC1 commons-commons-build-plugin-1.11-RC1 cd commons-commons-build-plugin-1.11-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version p
Re: [rng] Releasing 1.3
Hello. Le ven. 30 août 2019 à 15:29, Alex Herbert a écrit : > > > On 30/08/2019 14:22, Gilles Sadowski wrote: > > Hi. > > > > Le ven. 30 août 2019 à 15:11, Abhishek Dhadwal a > > écrit : > >> Hello, > >> > >> What would be the deadline for the release ? > > There is no deadline, but the sooner the better. > > The many new features deserve a release. > > > >> If it’s not too early I could resolve RNG-111 > >> (https://issues.apache.org/jira/browse/RNG-111) over the next few days. I > >> couldn’t work on it before due to back to back college project evaluations > >> and my mid term examinations (which get over by tomorrow). > > Great. > > My take on this... > > There is nothing outstanding. > > It would be nice to get the JSF generator (RNG-111) put in as it is a > compliment to the SFC generator I just added (RNG-112). Let's give > Abhishek some time to finish this work. +1 > All the speed tests will need to be updated for the site. I have been > considering if we should have more 'real' benchmarks. Currently we > benchmark a single call to each method in UniformRandomProvider using > the pattern recommended by JMH. I've built these benchmarks to require > post-processing to subtract the JMH overhead. So the tables for the > user-guide can either put in the raw data or as is currently done put in > the relative scores following post-processing to subtract the JMH baseline. No strong preference. But I don't think that the userguide needs to expose details such as baseline subtraction. > > However it is unclear if the current benchmark represents real-world > observable differences. A candidate for a 'real' world test for > nextInt() is a shuffle benchmark. This can be done using an actual array > or just by generating indices to swap. How is this more real world than the above (i.e. generating *one* int)? > When using an actual array it is > more realistic but relative performance is size dependent. When the > array gets large the method is slowed by cache misses during the actual > swap of the data. So the shuffle benchmark results would have to be > report for different sizes. A perhaps better illustration would be to report the time it takes to compute pi to a certain accuracy (cf. class "ComputePi" in module "commons-rng-examples"). > The other method to target would be nextLong(). I cannot think of a real > use case for this so instead we could target nextDouble(). I tried a > benchmark using a SmallMeanPoissonSampler which calls nextDouble() n+1 > times for a mean of n. This is a good start point for an algorithm that > puts the random numbers to use. However it may be replicating what is > already listed for the comparison of the different normalised Gaussian > samplers. Currently the user guide has a table comparing the 3 different > Gaussian samplers and then another table for the Marsaglia normalised > Gaussian sampler. (Note: There is some redundancy here.) Since all the > Gaussian samplers use nextDouble()/nextLong() then the output of this > table is a rough guide to the relative speed of the RNG on 64-bit output. > > I would suggest dropping the table showing the Marsaglia normalised > Gaussian sampler (it is redundant given the comparison of different > Gaussian samplers) +1 > and adding a shuffle benchmark for different array sizes. -0 (cf. above) > > More on RNG-32 below... > > > > > Best, > > Gilles > > > >> Regards, > >> Abhishek > >> > >> Sent from Mail for Windows 10 > >> > >> From: Gilles Sadowski > >> Sent: 30 August 2019 17:22 > >> To: Commons Developers List > >> Subject: Re: [rng] Releasing 1.3 > >> > >> Hi. > >> > >> Le lun. 10 juin 2019 à 17:17, Alex Herbert a > >> écrit : > >>> > >>> On 10/06/2019 15:31, Gilles Sadowski wrote: > >> P.S. Thinking of releasing 1.3? > > Not yet. I think there are a few outstanding items [...] > >> Status? > >> > >> In particular could we resolve > >> https://issues.apache.org/jira/projects/RNG/issues/RNG-32 > >> and all its sub-tasks following the work done through GSoC? > > This could be rounded up. Each tickets need some finishing details. > > > RNG-16: We did test LCGs that outperform the 48-bit LCG of > Java.util.Random. Any 64-bit LCG which returns the upper 32-bits should > be an OK generator. The ones we tested using increments 1 (Musl) and > 1442695040888963407 (from Knuth) perform as: > > - > DieHarder > - > KnuthShiftLCG : 1, 0, 0, 0, 0 > MuslShiftLCG : 0, 0, 0, 0, 0 > --- > TestU01 > --- > MuslShiftLCG : 15, 16, 15, 14, 15 > KnuthShiftLCG : 14, 11, 16, 17, 14 > > They are bad on BigCrush but will probably be the fastest 32-bit > generators in the library if a user wants a very fast 32-bit generator > for simple random stuff (e.g. generating filenames). If doing IO afterwards, generation time will be fairly insignificant. > A single example > would at least be a reference point and a comparison for the PCG > generators that use a 64-bit LCG and then permute the output. It is > poss
Re: [LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
Typos fixed -- We have fixed quite a few bugs and added some significant enhancements since Apache Commons Release Plugin 1.6 was released, so I would like to release Apache Commons Release Plugin 1.7. Apache Commons Release Plugin 1.7 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 (svn revision 35466) The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is 409d9525e05863415f91590192c544c6b9f7c2e9 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-release-plugin.git --branch commons-release-plugin-1.7-RC1 commons-release-plugin-1.7-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1460/org/apache/commons/commons-release-plugin/1.7/ These are the artifacts and their hashes: #Nexus SHA-1s commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 #Release SHA-512s #Fri Aug 30 09:58:56 EDT 2019 commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 I have tested this with 'mvn clean install site' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: /usr/local/Cellar/maven/3.6.1/libexec Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" Details of changes since 1.6 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html (note some *relative* links are broken and the 1.7 directories are not yet created - these will be OK once the site is deployed.) RAT Report: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Rob Tompkins, Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git --branch commons-commons-release-plugin-1.7-RC1 commons-commons-release-plugin-1.7-RC1 cd commons-commons-release-plugin-1.7-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version produced by -V in your VOTE reply. To gather OS information from a command line: Windows: ver Linux: uname -a 5) Build the site for a single module project Note: Some plugins require the components to be installed instead of packaged. mvn site Check the site reports in: - Windows: target\site\index.html - Linux: target/si
[LAZY][VOTE] Release Apache Commons Release Plugin 1.7 based on RC1
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Release Plugin 1.6 was released, so I would like to release Apache Commons Release Plugin 1.7. Apache Commons Release Plugin 1.7 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1 (svn revision 35466) The Git tag commons-commons-release-plugin-1.7-RC1 commit for this RC is 409d9525e05863415f91590192c544c6b9f7c2e9 You may checkout this tag using: git clone https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git --branch commons-commons-release-plugin-1.7-RC1 commons-commons-release-plugin-1.7-RC1 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-release-plugin/1.7/ These are the artifacts and their hashes: #Nexus SHA-1s commons-release-plugin-1.7-test-sources.jar=c888982e7ac0727530115cae4c3c2808cd59ef0e commons-release-plugin-1.7-tests.jar=2fdef721d93def37cb378b6ff3fcd4cb128b451c commons-release-plugin-1.7-sources.jar=f821c5d50124bd2228ad898ec2cb92c5034992f3 commons-release-plugin-1.7.jar=6ef41fc5ecebed5d201788e4e1411f431dfd58cb commons-release-plugin-1.7.pom=57c311cd4b55d6c0f3eb3f33d02996c8ab6afaa0 commons-release-plugin-1.7-javadoc.jar=59b86042e91701129571850bf2f7092efcbd35b2 #Release SHA-512s #Fri Aug 30 09:58:56 EDT 2019 commons-release-plugin-1.7-bin.tar.gz=87517bbf53f15e5c4d0875163da6427e3ae75a53545c4c706a6b978d4644e1b13b1145d402af9d4b69a559bc0d7efb6e673142edf158f73d10de22bc5c8f commons-release-plugin-1.7-bin.zip=63f49d533ba08629d2663ae8709fadd5fa76277c0c064f20c18e43921edfd05b03db7548bc30f66ac709d50f62ff23a7a45c6eaf655a96289fa509537f56db41 commons-release-plugin-1.7-src.tar.gz=08de2f3b3b761073628bc18a1dee7b885c80d97ee53ddfd2eb1d00cf39198acad4219ae67cad88542e6ae0ebf2ebe36550c1dc0b5e1e8dca1b1031ddb918a42e commons-release-plugin-1.7-src.zip=88f5bd56dcd2b25d386f7f96b5042151374135eb39072960e6510234cd70a72230b3f39839bc971f20efa817acbfd7c64209cc246f81a0c1196660c37cfddaa3 I have tested this with 'mvn clean install site' using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: /usr/local/Cellar/maven/3.6.1/libexec Java version: 1.8.0_202, vendor: Amazon.com Inc., runtime: /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" Details of changes since 1.6 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/index.html (note some *relative* links are broken and the 1.7 directories are not yet created - these will be OK once the site is deployed.) RAT Report: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/1.7-RC1/site/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Rob Tompkins, Release Manager (using key B6E73D84EA4FCC47166087253FAAD2CD5ECBB314) For following is intended as a helper and refresher for reviewers. Validating a release candidate == These guidelines are NOT complete. Requirements: Git, Java, Maven. You can validate a release from a release candidate (RC) tag as follows. 1) Clone and checkout the RC tag git clone https://gitbox.apache.org/repos/asf/commons-commons-release-plugin.git --branch commons-commons-release-plugin-1.7-RC1 commons-commons-release-plugin-1.7-RC1 cd commons-commons-release-plugin-1.7-RC1 2) Check Apache licenses This step is not required if the site includes a RAT report page which you then must check. mvn apache-rat:check 3) Check binary compatibility Older components still use Apache Clirr: This step is not required if the site includes a Clirr report page which you then must check. mvn clirr:check Newer components use JApiCmp with the japicmp Maven Profile: This step is not required if the site includes a JApiCmp report page which you then must check. mvn install -DskipTests -P japicmp japicmp:cmp 4) Build the package mvn -V clean package You can record the Maven and Java version produced by -V in your VOTE reply. To gather OS information from a command line: Windows: ver Linux: uname -a 5) Build the site for a single module project Note: Some plugins require the components to be installed instead of packaged. mvn site Check the site reports in: - Windows: target\site\i
Re: [rng] Releasing 1.3
On 30/08/2019 14:22, Gilles Sadowski wrote: Hi. Le ven. 30 août 2019 à 15:11, Abhishek Dhadwal a écrit : Hello, What would be the deadline for the release ? There is no deadline, but the sooner the better. The many new features deserve a release. If it’s not too early I could resolve RNG-111 (https://issues.apache.org/jira/browse/RNG-111) over the next few days. I couldn’t work on it before due to back to back college project evaluations and my mid term examinations (which get over by tomorrow). Great. My take on this... There is nothing outstanding. It would be nice to get the JSF generator (RNG-111) put in as it is a compliment to the SFC generator I just added (RNG-112). Let's give Abhishek some time to finish this work. All the speed tests will need to be updated for the site. I have been considering if we should have more 'real' benchmarks. Currently we benchmark a single call to each method in UniformRandomProvider using the pattern recommended by JMH. I've built these benchmarks to require post-processing to subtract the JMH overhead. So the tables for the user-guide can either put in the raw data or as is currently done put in the relative scores following post-processing to subtract the JMH baseline. However it is unclear if the current benchmark represents real-world observable differences. A candidate for a 'real' world test for nextInt() is a shuffle benchmark. This can be done using an actual array or just by generating indices to swap. When using an actual array it is more realistic but relative performance is size dependent. When the array gets large the method is slowed by cache misses during the actual swap of the data. So the shuffle benchmark results would have to be report for different sizes. The other method to target would be nextLong(). I cannot think of a real use case for this so instead we could target nextDouble(). I tried a benchmark using a SmallMeanPoissonSampler which calls nextDouble() n+1 times for a mean of n. This is a good start point for an algorithm that puts the random numbers to use. However it may be replicating what is already listed for the comparison of the different normalised Gaussian samplers. Currently the user guide has a table comparing the 3 different Gaussian samplers and then another table for the Marsaglia normalised Gaussian sampler. (Note: There is some redundancy here.) Since all the Gaussian samplers use nextDouble()/nextLong() then the output of this table is a rough guide to the relative speed of the RNG on 64-bit output. I would suggest dropping the table showing the Marsaglia normalised Gaussian sampler (it is redundant given the comparison of different Gaussian samplers) and adding a shuffle benchmark for different array sizes. More on RNG-32 below... Best, Gilles Regards, Abhishek Sent from Mail for Windows 10 From: Gilles Sadowski Sent: 30 August 2019 17:22 To: Commons Developers List Subject: Re: [rng] Releasing 1.3 Hi. Le lun. 10 juin 2019 à 17:17, Alex Herbert a écrit : On 10/06/2019 15:31, Gilles Sadowski wrote: P.S. Thinking of releasing 1.3? Not yet. I think there are a few outstanding items [...] Status? In particular could we resolve https://issues.apache.org/jira/projects/RNG/issues/RNG-32 and all its sub-tasks following the work done through GSoC? This could be rounded up. Each tickets need some finishing details. RNG-16: We did test LCGs that outperform the 48-bit LCG of Java.util.Random. Any 64-bit LCG which returns the upper 32-bits should be an OK generator. The ones we tested using increments 1 (Musl) and 1442695040888963407 (from Knuth) perform as: - DieHarder - KnuthShiftLCG : 1, 0, 0, 0, 0 MuslShiftLCG : 0, 0, 0, 0, 0 --- TestU01 --- MuslShiftLCG : 15, 16, 15, 14, 15 KnuthShiftLCG : 14, 11, 16, 17, 14 They are bad on BigCrush but will probably be the fastest 32-bit generators in the library if a user wants a very fast 32-bit generator for simple random stuff (e.g. generating filenames). A single example would at least be a reference point and a comparison for the PCG generators that use a 64-bit LCG and then permute the output. It is possible to create one using the abstract class for the PCG generators: public class LcgShift32 extends AbstractPcg6432 { public LcgShift32(long[] seed) { super(seed); } @Override protected int transform(long x) { return (int)(x >>> 32); } } RNG-84: The PCG ticket should be resolved. I have not had time to work on the K-dimensionally distributed variants that should support the Jumpable interface. This can go on a new ticket when I get round to it. RNG-17: We never got as far as testing a Lagged Fibonacci generator. The reference example int versions only output 24-bits so were not deemed suitable. There was a reference example that used 48-bit floating point values. However to add this would not fit in the model of the source32/64 p
Re: [rng] Releasing 1.3
Hi. Le ven. 30 août 2019 à 15:11, Abhishek Dhadwal a écrit : > > Hello, > > What would be the deadline for the release ? There is no deadline, but the sooner the better. The many new features deserve a release. > If it’s not too early I could resolve RNG-111 > (https://issues.apache.org/jira/browse/RNG-111) over the next few days. I > couldn’t work on it before due to back to back college project evaluations > and my mid term examinations (which get over by tomorrow). Great. Best, Gilles > > Regards, > Abhishek > > Sent from Mail for Windows 10 > > From: Gilles Sadowski > Sent: 30 August 2019 17:22 > To: Commons Developers List > Subject: Re: [rng] Releasing 1.3 > > Hi. > > Le lun. 10 juin 2019 à 17:17, Alex Herbert a écrit > : > > > > > > On 10/06/2019 15:31, Gilles Sadowski wrote: > > >>> P.S. Thinking of releasing 1.3? > > >> Not yet. I think there are a few outstanding items [...] > > Status? > > In particular could we resolve >https://issues.apache.org/jira/projects/RNG/issues/RNG-32 > and all its sub-tasks following the work done through GSoC? > > Best, > Gilles > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
RE: [rng] Releasing 1.3
Hello, What would be the deadline for the release ? If it’s not too early I could resolve RNG-111 (https://issues.apache.org/jira/browse/RNG-111) over the next few days. I couldn’t work on it before due to back to back college project evaluations and my mid term examinations (which get over by tomorrow). Regards, Abhishek Sent from Mail for Windows 10 From: Gilles Sadowski Sent: 30 August 2019 17:22 To: Commons Developers List Subject: Re: [rng] Releasing 1.3 Hi. Le lun. 10 juin 2019 à 17:17, Alex Herbert a écrit : > > > On 10/06/2019 15:31, Gilles Sadowski wrote: > >>> P.S. Thinking of releasing 1.3? > >> Not yet. I think there are a few outstanding items [...] Status? In particular could we resolve https://issues.apache.org/jira/projects/RNG/issues/RNG-32 and all its sub-tasks following the work done through GSoC? Best, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [rng] Releasing 1.3
Hi. Le lun. 10 juin 2019 à 17:17, Alex Herbert a écrit : > > > On 10/06/2019 15:31, Gilles Sadowski wrote: > >>> P.S. Thinking of releasing 1.3? > >> Not yet. I think there are a few outstanding items [...] Status? In particular could we resolve https://issues.apache.org/jira/projects/RNG/issues/RNG-32 and all its sub-tasks following the work done through GSoC? Best, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org