Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC2

2020-01-26 Thread Carl Hall
For the 2 weeks this vote has been open, we have 1 binding and 1 non-binding 
vote so far.

May I humbly ask for a few more folks to help with this release review? Thanks 
in advance!


> On Jan 22, 2020, at 5:19 PM, William Speirs  wrote:
> 
> Sorry, meant to say: +1
> 
> On Wed, Jan 22, 2020 at 7:34 PM Carl Hall  wrote:
> 
>> Thanks, Bill. Looking for 2 more positive votes to proceed. :)  I'd like
>> to hear from Gary given his concerns on this thread.
>> 
>> 
>>> On Jan 22, 2020, at 6:00 AM, William Speirs  wrote:
>>> 
>>> Works for me... Carl, let me know how I can help.
>>> 
>>> On Wed, Jan 22, 2020 at 12:37 AM Carl Hall  wrote:
>>> 
 I’m in favor of releasing 1.8 because it’s ready and has had the most
 attention in recent months/years.
 After such, we put eyes on the 2.0 branch to ensure it is ready to be
>> the
 successive version. Once we’re happy with that, create a 1.x brach from
 master, bring 2.0 to master, and see if we can get a 2.0 release out
>> before
 2 more years.  :)
 
> On Jan 11, 2020, at 10:29 AM, William Speirs 
>> wrote:
> 
> What is there to "clean up"? Sorry, just not following exactly what you
> mean.
> 
> Thanks!
> 
> Bill-
> 
> On Fri, Jan 10, 2020 at 4:42 PM Gary Gregory 
 wrote:
> 
>> I think we should clean all of this up _now_ and then release 1.8.
>> 
>> What do others think?
>> 
>> Gary
>> 
>> On Fri, Jan 10, 2020 at 12:44 PM Carl Hall 
>> wrote:
>> 
>>> +1 to moving master to 1.8-SNAPSHOT and dealing with what's to come
 with
>>> 2.0 at some future time in a 2.0 branch.
>>> 
>>> I can change master:pom.xml to be 1.8-SNAPSHOT then when the RC is
>> out,
>>> merge release into master (1.8) and proceed to 1.9-SNAPSHOT. Advice?
>>> 
>>> 
>>> The branch name is a review miss on my part. The command to see RC2
>> is:
>>> 
>>> $ git clone https://gitbox.apache.org/repos/asf/commons-dbutils.git
>>> --branch DBUTILS_1_8_RC2 commons-dbutils-1.8-RC2
>>> 
>>> The commons plugin generates a tag that doesn't match dbutils'
>> history,
>>> but I didn't notice that until after RC1 and didn't want to change
>> tag
>>> formats mid release. I think future releases should use the tag name
>> format
>>> from the commons plugin (e.g. commons-dbutils-1.8-RC2) and abandon
>> the
>>> previous format (e.g. DBUTILS_1_8_RC2).
>>> 
>>> Thanks for the help with this RC cycle. Clearly every couple of years
 is
>>> not enough practice. :-)
>>> 
>>> 
 On Jan 10, 2020, at 7:17 AM, Bill Speirs 
>> wrote:
 
 My vote would be to make master 1.8-SNAPSHOT as I doubt 2.x will see
>> the
 light-of-day for a LONG time... it's been 3+ years already. Continue
>> with
 what Carl is trying to do, so we at least get _something_ out the
 door.
 
 Also, I _think_ I had to create 2_0 as the branch name, because svn
 (at
>>> the
 time) wouldn't let me use a dot... but I _might_ be mis-remembering.
 
 Bill-
 
 On Fri, Jan 10, 2020 at 9:28 AM Gary Gregory <
>> garydgreg...@gmail.com>
>>> wrote:
 
> On Fri, Jan 10, 2020 at 9:16 AM William Speirs >> 
>>> wrote:
> 
>> For what it's worth, I'm unable to find that branch in git:
>> 
>> $ git clone
>> https://gitbox.apache.org/repos/asf/commons-dbutils.git
>> --branch <
> https://gitbox.apache.org/repos/asf/commons-dbutils.git--branch>
>> commons-dbutils-1.8-RC2 commons-dbutils-1.8-RC2
>> Cloning into 'commons-dbutils-1.8-RC2'...
>> fatal: Remote branch commons-dbutils-1.8-RC2 not found in upstream
>>> origin
>> 
>> After cloning the repo, listing remote branches doesn't show
>> anything:
>> 
>> $ git branch -r
>> origin/2_0
>> origin/HEAD -> origin/master
>> origin/master
>> origin/release
>> 
>> Bill-
>> 
> 
> Right, I think we need to hit the pause button here and sort out
>> 1.x
>>> versus
> a desired 2.0.
> 
> Since there is a what looks like a 2.0 branch and our current
>> release
>> is
> 1.x, I would assume that this release vote is being made from the
>>> release
> branch which has been merged from master.
> 
> But that does not seem to be the case, right? Since the pom.xml in
>>> master
> is 2.0-SNAPSHOT that would seem to indicate that the release branch
>>> comes
> from elsewhere, a 1.x branch? No, we do not have one.
> 
> It feels to me like we should have one of either:
> 
> - branch master is 1.8-SNAPSHOT, merged into branch release. The
>> 2.0
>>> work
> should be in branch 2_0 (which should renamed to 

Re: [All] Sonarcloud reports zero coverage

2020-01-26 Thread Gilles Sadowski
Hello.

Le dim. 26 janv. 2020 à 18:06, Amey Jadiye  a écrit :
>
> For almost all the repo[1][2] this is suddenly dropped I can see an event
> in coverage activity written as "Quality Profile: Changes in 'Sonar way'
> (Java)".
> I see there are some changes done on profile[3] on 7th Jan, It must be that
> change broke down the coverage. ?
>
> [1]
> https://sonarcloud.io/project/activity?custom_metrics=coverage=custom=commons-numbers
> [2]
> https://sonarcloud.io/project/activity?custom_metrics=coverage=custom=commons-rng
> [3]
> https://sonarcloud.io/organizations/apache/quality_profiles/changelog?language=java=Sonar+way

Thanks for looking into it.
I too had noticed that "something" is reported as changed, but
couldn't figure out what...

Regards,
Gilles

> Regards,
> Amey
>
> On Wed, Jan 15, 2020 at 9:17 PM Gilles Sadowski 
> wrote:
>
> > Hello.
> >
> > "Sonar" reports are created for several projects, a.o.
> > https://sonarcloud.io/dashboard?id=commons-numbers
> > https://sonarcloud.io/dashboard?id=commons-geometry
> > https://sonarcloud.io/dashboard?id=commons-rng
> > https://sonarcloud.io/dashboard?id=commons-statistics
> > for which coverage is now reported as 0%, although it was reported
> > correctly earlier.
> >
> > Regards,
> > Gilles
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [All] Sonarcloud reports zero coverage

2020-01-26 Thread Gilles Sadowski
Hi.

Le dim. 26 janv. 2020 à 17:05, Matt Juntunen
 a écrit :
>
> Any word on this?

I've reported this to INFRA:
https://issues.apache.org/jira/browse/INFRA-19763

See comment there: Whoever is "admin", please follow up on their
inquiry.

Thanks,
Gilles

>
> -Matt
> 
> From: Gilles Sadowski 
> Sent: Wednesday, January 15, 2020 10:47 AM
> To: Commons Developers List 
> Subject: [All] Sonarcloud reports zero coverage
>
> Hello.
>
> "Sonar" reports are created for several projects, a.o.
> https://sonarcloud.io/dashboard?id=commons-numbers
> https://sonarcloud.io/dashboard?id=commons-geometry
> https://sonarcloud.io/dashboard?id=commons-rng
> https://sonarcloud.io/dashboard?id=commons-statistics
> for which coverage is now reported as 0%, although it was reported
> correctly earlier.
>
> Regards,
> Gilles

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Release of Commons Crypto

2020-01-26 Thread Alex Remily
I can build it on all three platforms (Win, Linux, Mac).  I don't know how
to push to Maven central, and even if I did, I don't have permissions.  I'm
happy to provide an artifact to someone who can push it to Maven.

On Sun, Jan 26, 2020 at 9:59 AM Gary Gregory  wrote:

> On Wed, Jan 22, 2020 at 7:42 PM Alex Remily  wrote:
>
> > How do we go about getting a release for Commons Crypto?
> >
>
> Someone needs to spend the time doing it... ;-) The build for this
> component is not trivial since it uses Maven to call Ant to call make,
> which fails for me. Can anyone built it?
>
> Gary
>


Re: Release of Commons Crypto

2020-01-26 Thread Gary Gregory
On Sun, Jan 26, 2020 at 9:58 AM Gary Gregory  wrote:

> On Wed, Jan 22, 2020 at 7:42 PM Alex Remily  wrote:
>
>> How do we go about getting a release for Commons Crypto?
>>
>
> Someone needs to spend the time doing it... ;-) The build for this
> component is not trivial since it uses Maven to call Ant to call make,
> which fails for me. Can anyone built it?
>

The problem for me seems to be that Ant 1.9 is not passing environment
variables down to the make file. I am using:
Linux *hidden* 4.4.0-43-Microsoft #1-Microsoft Wed Dec 31 14:42:53 PST 2014
x86_64 x86_64 x86_64 GNU/Linux


>
> Gary
>


Re: [collections] example code.

2020-01-26 Thread Gary Gregory
On Sun, Jan 26, 2020 at 4:30 PM Claude Warren  wrote:

> The doxia snippet extension allows you to reference code in the source tree
> and include it in the generated HTML files.  This means that the example
> code in the documentation/site can come directly from code that compiles
> and can be run in the examples.  Best of both worlds I think.
>

Indeed. The way we wrote
https://www.manning.com/books/java-persistence-with-hibernate-second-edition
was
using such "code slurping" through
http://4thline.org/projects/lemma/manual/lemma-manual.xhtml. The whole book
was written in XHTML in a project that contained all example sources are
real running Java code.

Gary


> Claude
>
> On Sun, Jan 26, 2020 at 8:48 PM Gary Gregory 
> wrote:
>
> > No code in the site please. It must be compiled with the build and
> > available as a plain source file for refactoring from IDEs and tools.
> >
> > Gary
> >
> > On Sun, Jan 26, 2020, 15:19 Bruno P. Kinoshita  wrote:
> >
> > >  That's exactly what we have in commons imaging. +1 to either an
> example
> > > directory in src/test and maybe a link in the website, or the code
> direct
> > > in the site.
> > > Cheers
> > > Bruno
> > >
> > > On Monday, 27 January 2020, 6:07:21 am NZDT, Gary Gregory <
> > > garydgreg...@gmail.com> wrote:
> > >
> > >  I think the simplest is to create an examples package under src/test
> > which
> > > also let you put example data under src/resources.
> > >
> > > This way, that code would get processed just like any other test code
> > > included the source xref report.
> > >
> > > Gary
> > >
> > > On Sun, Jan 26, 2020, 11:52 Claude Warren  wrote:
> > >
> > > > I see that there is no example code directory in the collections
> > project.
> > > > I was thinking of contributing an example of how to construct a Bloom
> > > > filter that operates like the Hadoop Bloom filter but this seems like
> > > > something that we may not want to include in the library.
> > > >
> > > > In the Jena project we have example code that we package for users if
> > > they
> > > > wish and we reference it in the documentation as well.
> > > >
> > > > Any thoughts on this?
> > > >
> > > > Claude
> > > >
> > > > --
> > > > I like: Like Like - The likeliest place on the web
> > > > 
> > > > LinkedIn: http://www.linkedin.com/in/claudewarren
> > > >
> > >
> >
>
>
> --
> I like: Like Like - The likeliest place on the web
> 
> LinkedIn: http://www.linkedin.com/in/claudewarren
>


Re: [collections] example code.

2020-01-26 Thread Claude Warren
The doxia snippet extension allows you to reference code in the source tree
and include it in the generated HTML files.  This means that the example
code in the documentation/site can come directly from code that compiles
and can be run in the examples.  Best of both worlds I think.

Claude

On Sun, Jan 26, 2020 at 8:48 PM Gary Gregory  wrote:

> No code in the site please. It must be compiled with the build and
> available as a plain source file for refactoring from IDEs and tools.
>
> Gary
>
> On Sun, Jan 26, 2020, 15:19 Bruno P. Kinoshita  wrote:
>
> >  That's exactly what we have in commons imaging. +1 to either an example
> > directory in src/test and maybe a link in the website, or the code direct
> > in the site.
> > Cheers
> > Bruno
> >
> > On Monday, 27 January 2020, 6:07:21 am NZDT, Gary Gregory <
> > garydgreg...@gmail.com> wrote:
> >
> >  I think the simplest is to create an examples package under src/test
> which
> > also let you put example data under src/resources.
> >
> > This way, that code would get processed just like any other test code
> > included the source xref report.
> >
> > Gary
> >
> > On Sun, Jan 26, 2020, 11:52 Claude Warren  wrote:
> >
> > > I see that there is no example code directory in the collections
> project.
> > > I was thinking of contributing an example of how to construct a Bloom
> > > filter that operates like the Hadoop Bloom filter but this seems like
> > > something that we may not want to include in the library.
> > >
> > > In the Jena project we have example code that we package for users if
> > they
> > > wish and we reference it in the documentation as well.
> > >
> > > Any thoughts on this?
> > >
> > > Claude
> > >
> > > --
> > > I like: Like Like - The likeliest place on the web
> > > 
> > > LinkedIn: http://www.linkedin.com/in/claudewarren
> > >
> >
>


-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren


Re: [collections] example code.

2020-01-26 Thread Gary Gregory
No code in the site please. It must be compiled with the build and
available as a plain source file for refactoring from IDEs and tools.

Gary

On Sun, Jan 26, 2020, 15:19 Bruno P. Kinoshita  wrote:

>  That's exactly what we have in commons imaging. +1 to either an example
> directory in src/test and maybe a link in the website, or the code direct
> in the site.
> Cheers
> Bruno
>
> On Monday, 27 January 2020, 6:07:21 am NZDT, Gary Gregory <
> garydgreg...@gmail.com> wrote:
>
>  I think the simplest is to create an examples package under src/test which
> also let you put example data under src/resources.
>
> This way, that code would get processed just like any other test code
> included the source xref report.
>
> Gary
>
> On Sun, Jan 26, 2020, 11:52 Claude Warren  wrote:
>
> > I see that there is no example code directory in the collections project.
> > I was thinking of contributing an example of how to construct a Bloom
> > filter that operates like the Hadoop Bloom filter but this seems like
> > something that we may not want to include in the library.
> >
> > In the Jena project we have example code that we package for users if
> they
> > wish and we reference it in the documentation as well.
> >
> > Any thoughts on this?
> >
> > Claude
> >
> > --
> > I like: Like Like - The likeliest place on the web
> > 
> > LinkedIn: http://www.linkedin.com/in/claudewarren
> >
>


Re: [collections] example code.

2020-01-26 Thread Bruno P. Kinoshita
 That's exactly what we have in commons imaging. +1 to either an example 
directory in src/test and maybe a link in the website, or the code direct in 
the site.
Cheers
Bruno

On Monday, 27 January 2020, 6:07:21 am NZDT, Gary Gregory 
 wrote:  
 
 I think the simplest is to create an examples package under src/test which
also let you put example data under src/resources.

This way, that code would get processed just like any other test code
included the source xref report.

Gary

On Sun, Jan 26, 2020, 11:52 Claude Warren  wrote:

> I see that there is no example code directory in the collections project.
> I was thinking of contributing an example of how to construct a Bloom
> filter that operates like the Hadoop Bloom filter but this seems like
> something that we may not want to include in the library.
>
> In the Jena project we have example code that we package for users if they
> wish and we reference it in the documentation as well.
>
> Any thoughts on this?
>
> Claude
>
> --
> I like: Like Like - The likeliest place on the web
> 
> LinkedIn: http://www.linkedin.com/in/claudewarren
>
  

Re: [commons-compress] branch master updated: one more javadoc warning

2020-01-26 Thread Gary Gregory
On Sun, Jan 26, 2020, 12:13 Stefan Bodewig  wrote:

> On 2020-01-26, Gary Gregory wrote:
>
> > On Sun, Jan 26, 2020, 07:39  wrote:
>
> >>+ * @return the parsed PAX header
>
> > Plural?
>
> Not sure. I believe it is a single PAX header block holding multiple
> header variables - while the code calls those header variable headers to
> make things more confusing.
>

Right, which is why I was hoping for a clearer Javadoc ;-) it is confusing
as is.

Gary

>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [commons-compress] branch master updated: one more javadoc warning

2020-01-26 Thread Stefan Bodewig
On 2020-01-26, Gary Gregory wrote:

> On Sun, Jan 26, 2020, 07:39  wrote:

>>+ * @return the parsed PAX header

> Plural?

Not sure. I believe it is a single PAX header block holding multiple
header variables - while the code calls those header variable headers to
make things more confusing.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collections] example code.

2020-01-26 Thread Gary Gregory
I think the simplest is to create an examples package under src/test which
also let you put example data under src/resources.

This way, that code would get processed just like any other test code
included the source xref report.

Gary

On Sun, Jan 26, 2020, 11:52 Claude Warren  wrote:

> I see that there is no example code directory in the collections project.
> I was thinking of contributing an example of how to construct a Bloom
> filter that operates like the Hadoop Bloom filter but this seems like
> something that we may not want to include in the library.
>
> In the Jena project we have example code that we package for users if they
> wish and we reference it in the documentation as well.
>
> Any thoughts on this?
>
> Claude
>
> --
> I like: Like Like - The likeliest place on the web
> 
> LinkedIn: http://www.linkedin.com/in/claudewarren
>


Re: [All] Sonarcloud reports zero coverage

2020-01-26 Thread Amey Jadiye
For almost all the repo[1][2] this is suddenly dropped I can see an event
in coverage activity written as "Quality Profile: Changes in 'Sonar way'
(Java)".
I see there are some changes done on profile[3] on 7th Jan, It must be that
change broke down the coverage. ?

[1]
https://sonarcloud.io/project/activity?custom_metrics=coverage=custom=commons-numbers
[2]
https://sonarcloud.io/project/activity?custom_metrics=coverage=custom=commons-rng
[3]
https://sonarcloud.io/organizations/apache/quality_profiles/changelog?language=java=Sonar+way


Regards,
Amey

On Wed, Jan 15, 2020 at 9:17 PM Gilles Sadowski 
wrote:

> Hello.
>
> "Sonar" reports are created for several projects, a.o.
> https://sonarcloud.io/dashboard?id=commons-numbers
> https://sonarcloud.io/dashboard?id=commons-geometry
> https://sonarcloud.io/dashboard?id=commons-rng
> https://sonarcloud.io/dashboard?id=commons-statistics
> for which coverage is now reported as 0%, although it was reported
> correctly earlier.
>
> Regards,
> Gilles
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org


FOSDEM 2020

2020-01-26 Thread Claude Warren
Is anyone on this list (besides me) planning on attending FOSDEM 2020[1]?
If so would you be interested in hosting the Apache table?  By "hosting" I
mean we stand there talk to people and promote Apache commons.

Claude

[1] https://cwiki.apache.org/confluence/display/COMDEV/FOSDEM+2020

-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren


[collections] example code.

2020-01-26 Thread Claude Warren
I see that there is no example code directory in the collections project.
I was thinking of contributing an example of how to construct a Bloom
filter that operates like the Hadoop Bloom filter but this seems like
something that we may not want to include in the library.

In the Jena project we have example code that we package for users if they
wish and we reference it in the documentation as well.

Any thoughts on this?

Claude

-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren


Re: [All] Sonarcloud reports zero coverage

2020-01-26 Thread Matt Juntunen
Any word on this?

-Matt

From: Gilles Sadowski 
Sent: Wednesday, January 15, 2020 10:47 AM
To: Commons Developers List 
Subject: [All] Sonarcloud reports zero coverage

Hello.

"Sonar" reports are created for several projects, a.o.
https://sonarcloud.io/dashboard?id=commons-numbers
https://sonarcloud.io/dashboard?id=commons-geometry
https://sonarcloud.io/dashboard?id=commons-rng
https://sonarcloud.io/dashboard?id=commons-statistics
for which coverage is now reported as 0%, although it was reported
correctly earlier.

Regards,
Gilles

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[numbers] NUMBERS-40: Exception Consistency

2020-01-26 Thread Matt Juntunen
Hello,

I'm looking into NUMBERS-40, which suggests that the exception behavior of 
commons-numbers (specifically the gamma package) needs to be made more 
consistent. Below is a summary of the public exception types explicitly thrown 
by each module.

arrays
IndexOutOfBoundsException
IllegalArgumentException

combinatorics
IllegalArgumentException
NoSuchElementException
UnsupportedOperationException

complex
NumberFormatException
IllegalArgumentException

complex-streams
IllegalArgumentException

core
ArithmeticException
IllegalArgumentException

fraction
ArithmeticException
IllegalArgumentException

gamma
IllegalArgumentException

primes
IllegalArgumentException

quaternion
NumberFormatException
IllegalArgumentException
IllegalStateException

rootfinder
IllegalArgumentException


Nothing in this list strikes me as being inconsistent. The types are all 
standard JDK exception types and seem to be used appropriately, IMO. Is there 
any work that needs to be done on this issue?

Regards,
Matt J




Re: Release of Commons Crypto

2020-01-26 Thread Gary Gregory
On Wed, Jan 22, 2020 at 7:42 PM Alex Remily  wrote:

> How do we go about getting a release for Commons Crypto?
>

Someone needs to spend the time doing it... ;-) The build for this
component is not trivial since it uses Maven to call Ant to call make,
which fails for me. Can anyone built it?

Gary


Re: [commons-compress] branch master updated: one more javadoc warning

2020-01-26 Thread Gary Gregory
On Sun, Jan 26, 2020, 07:39  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> bodewig pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-compress.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>  new 6883347  one more javadoc warning
> 6883347 is described below
>
> commit 68833474b4e77d389611832a6ae99b8da0aeee89
> Author: Stefan Bodewig 
> AuthorDate: Sun Jan 26 13:39:05 2020 +0100
>
> one more javadoc warning
> ---
>  .../apache/commons/compress/archivers/tar/TarArchiveInputStream.java|
> 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
> b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
> index 9a1ad41..e7550a5 100644
> ---
> a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
> +++
> b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStream.java
> @@ -672,7 +672,7 @@ public class TarArchiveInputStream extends
> ArchiveInputStream {
>   * @param inputstream inputstream to read keys and values
>   * @param sparseHeaders used in PAX Format 0.0  0.1, as it may
> appear multi times,
>   *  the sparse headers need to be stored in an
> array, not a map
> - * @return
> + * @return the parsed PAX header
>

Plural?

Gary

  * @throws IOException
>   */
>  Map parsePaxHeaders(final InputStream inputStream,
> List sparseHeaders)
>
>


Re: [LANG] Start contributing

2020-01-26 Thread Asanka Amarasinghe
Hi,

I started with  LANG-1499  (
https://issues.apache.org/jira/projects/LANG/issues/LANG-1499 ) . I'm
looking for a mentor to work with, get to know the rules and practices
around. Below are my findings on LANG-1499.


   - In the current implementation, if given *LHS* and *RHS* objects are
   not in the same hierarchy (Parent-Child classes) then
   *EqualsBuilder.reflectionEquals* method will always return false without
   further validations.
   - In documentation (
   
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/builder/EqualsBuilder.html)
   it says " *This method uses reflection to determine if the two Object**s
   are equal.*"  That does not describe more on how they are checked for
   equality.
   - As per the example in the LANG-1499 it implies any two Instances with
   same *fields* and having same *values for those fields* should be return
   true. ( Since at the end every Class is extends by Object class ).

Please let me know if you can mentor me this.


*Best Regards **Asanka Amarasinghe*


On Sun, Jan 26, 2020 at 2:26 PM Asanka Amarasinghe 
wrote:

> Hi Gilles,
>
> Thanks for the support. I was able to setup work space and build the
> project
>
> *Best Regards *
> *Asanka Amarasinghe*
>
>
>
>
>
> On Sat, Jan 25, 2020 at 6:21 PM Gilles Sadowski 
> wrote:
>
>> Hi.
>>
>> 2020-01-25 7:00 UTC+01:00, Asanka Amarasinghe :
>> > Hi,
>> >
>> > I'm new to open source community, and I would like to contribute to
>> > commons.lang project. I read all the materials for beginners and I
>> already
>> > joined JIRA issue tracker.
>>
>> Welcome.
>>
>> >
>> > Could someone guide me to where I can find a documentation for work
>> space
>> > setup for this project? I believe if I could go through the code then I
>> can
>> > come up with a proposal for an issue listed on the tracker.
>>
>> The command for downloading the code is provided at that page:
>> http://commons.apache.org/proper/commons-lang/scm.html
>>
>> >
>> > Pardon if this is a dummy query.
>>
>> It's not.  Don't hesitate to ask if you find that some
>> documentation for beginners is difficult to find, unclear,
>> or outdated.
>>
>> Regards,
>> Gilles
>>
>> >
>> > *Best Regards **Asanka Amarasinghe*
>> >
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>