Re: [VOTE] Release Compress 1.20 Based on RC1
+1 My review is based on the Git tag. Apache RAT check OK. Reports OK. Building OK with '*mvn -V clean install site -P jacoco -P japicmp*' on: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_241, *vendor:* Oracle Corporation*, runtime: C:\Program Files\Java\jdk1.8.0_241\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Testing OK '*mvn -V test*' with: java version "11.0.6" 2020-01-14 LTS Java(TM) SE Runtime Environment 18.9 (build 11.0.6+8-LTS) Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.6+8-LTS, mixed mode) Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *11.0.6, *vendor:* Oracle Corporation*, runtime: C:\Program Files\Java\jdk-11.0.6 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - java version "12.0.2" 2019-07-16 Java(TM) SE Runtime Environment (build 12.0.2+10) Java HotSpot(TM) 64-Bit Server VM (build 12.0.2+10, mixed mode, sharing) Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *12.0.2, *vendor:* Oracle Corporation*, runtime: C:\Program Files\Java\jdk-12.0.2 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - java version "13.0.2" 2020-01-14 Java(TM) SE Runtime Environment (build 13.0.2+8) Java HotSpot(TM) 64-Bit Server VM (build 13.0.2+8, mixed mode, sharing) C:\temp\rc\logging-log4j-scala\commons-compress>mvn -V test Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *13.0.2, *vendor:* Oracle Corporation*, runtime: C:\Program Files\Java\jdk-13.0.2 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - openjdk version "1.8.0_222" OpenJDK Runtime Environment Corretto-8.222.10.3 (build 1.8.0_222-b10) OpenJDK 64-Bit Server VM Corretto-8.222.10.3 (build 25.222-b10, mixed mode) C:\temp\rc\commons-compress>mvn -V test Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_222, *vendor:* Amazon.com Inc.*, runtime: C:\Program Files\Java\amazon-corretto\jdk1.8.0_222\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - openjdk version "1.8.0_242" OpenJDK Runtime Environment Corretto-8.242.08.1 (build 1.8.0_242-b08) OpenJDK 64-Bit Server VM Corretto-8.242.08.1 (build 25.242-b08, mixed mode) C:\temp\rc\commons-compress>mvn -V test Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *1.8.0_242, *vendor:* Amazon.com Inc.*, runtime: C:\Program Files\Java\amazon-corretto\jdk1.8.0_242\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - openjdk version "11.0.6" 2020-01-14 LTS OpenJDK Runtime Environment Corretto-11.0.6.10.1 (build 11.0.6+10-LTS) OpenJDK 64-Bit Server VM Corretto-11.0.6.10.1 (build 11.0.6+10-LTS, mixed mode) C:\temp\rc\commons-compress>mvn -V test Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: *11.0.6*, vendor: *Amazon.com Inc.*, runtime: C:\Program Files\Java\amazon-corretto\jdk11.0.6_10 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" - Not testing with Java 14-EA or Java 15-EA since pack200 has been removed which breaks the build. Gary On Sun, Feb 2, 2020 at 10:41 AM Stefan Bodewig wrote: > This time there are not so many bugs but significant improvements that > people are waiting to get their hands on. > > Compress 1.20 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/compress/ > (svn revision 37832) > > The tag is here: > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=tag;h=refs/tags/1.20-RC1 > on commit > > https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=db615d141f01d2575b0d3996030db81ed8541e72 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-/org/apache/commons/commons-compress/1.20/ > > These are the Maven artifacts and their hashes > > 7c9990e54ba0c7833054e003a386afd5205452c437501d0c49f4c26154116f44765176346229fbf131f22cb2fba43a5ea11c8c93e57af677841ba6d91e2883d0 > commons-compress-1.20.jar > 30634f984b24cfca6151541b611a8b07bcaae2536fef1453bc0a96dccc8c083c188c4d26d5feb12dc33c21cd1da6216af3fb7ab11167b1d8008c432656e1e579 > commons-compress-1.20-javadoc.jar >
Re: [VOTE] Release Compress 1.20 Based on RC1
this is what you get when you copy-paste from the release instructions :-) > This vote will close no sooner that 72 hours from now, > i.e. sometime after 04:00 UTC 31-March 2010 i.e. sometime after 16:00 UTC 05-Feb-2020 Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[VOTE] Release Compress 1.20 Based on RC1
This time there are not so many bugs but significant improvements that people are waiting to get their hands on. Compress 1.20 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 37832) The tag is here: https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=tag;h=refs/tags/1.20-RC1 on commit https://gitbox.apache.org/repos/asf?p=commons-compress.git;a=commit;h=db615d141f01d2575b0d3996030db81ed8541e72 Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-/org/apache/commons/commons-compress/1.20/ These are the Maven artifacts and their hashes 7c9990e54ba0c7833054e003a386afd5205452c437501d0c49f4c26154116f44765176346229fbf131f22cb2fba43a5ea11c8c93e57af677841ba6d91e2883d0 commons-compress-1.20.jar 30634f984b24cfca6151541b611a8b07bcaae2536fef1453bc0a96dccc8c083c188c4d26d5feb12dc33c21cd1da6216af3fb7ab11167b1d8008c432656e1e579 commons-compress-1.20-javadoc.jar 7a9881a5b705f472805471ca46982cbe71ceceff3d45923cd9db7aee239825c96daed3c52ea4b7a54bca88910ff4659b5cb140c9c411e5c1d8e60bb46dd8a333 commons-compress-1.20-sources.jar c7cbc2d7ac2f08f0c10f7b88af87f70c33db12b4d3b8124874e60ccffd5cf2735dc64bc2edf94bb806b283202bdc301dc05cb3fb694afc22f5831788abcd1a8f commons-compress-1.20-tests.jar d63e5ea6195ce5b0b7db7b5d881430dbc68f5b9f37131db1aef4d00ea37bb58793b0382e0af201ec8864b33aa9ca071ddc0abb06b788d4efea097cf970b6c88f commons-compress-1.20-test-sources.jar a7ad5f75c1509aa8d238e583a76fcf7f69fb93c40ac6cf6a3cf33dbb8c5dba98bfc0d81c88815b123d1196d958dd94a79c417e685a3440629d63b2068fe90bc3 commons-compress-1.20.pom I have tested this with JDK 8 using Maven 3.5.4 Details of changes since 1.19 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt https://stefan.samaflost.de/staging/commons-compress-1.20/changes-report.html Site: https://stefan.samaflost.de/staging/commons-compress-1.20/ (note Javadocs of 1.20 have not been created right now and this is - as usual when I cut a release - not the site I'm going to publish after the release. I'll create a new site once the release date is known). Japicmp Report (compared to 1.19): https://stefan.samaflost.de/staging/commons-compress-1.20/japicmp.html RAT Report: https://stefan.samaflost.de/staging/commons-compress-1.20/rat-report.html KEYS: https://www.apache.org/dist/commons/KEYS Please review the release candidate and vote. This vote will close no sooner that 72 hours from now, i.e. sometime after 04:00 UTC 31-March 2010 [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thanks! - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [numbers] NUMBERS-40: Exception Consistency
Hi. 2020-01-26 16:54 UTC+01:00, Matt Juntunen : > Hello, > > I'm looking into NUMBERS-40, which suggests that the exception behavior of > commons-numbers (specifically the gamma package) needs to be made more > consistent. Below is a summary of the public exception types explicitly > thrown by each module. > > arrays > IndexOutOfBoundsException > IllegalArgumentException > > combinatorics > IllegalArgumentException > NoSuchElementException > UnsupportedOperationException > > complex > NumberFormatException > IllegalArgumentException > > complex-streams > IllegalArgumentException > > core > ArithmeticException > IllegalArgumentException > > fraction > ArithmeticException > IllegalArgumentException > > gamma > IllegalArgumentException Some methods throw "ArithmeticException" while others throw "IllegalArgumentException". IIRC, my issue was whether there were cases where the behaviour is not consistent from a user POV (IOW, where the same behaviour would be expected). [Note: I did not review all the packages. But I don't recall there were this kind of issue.] Gilles > > primes > IllegalArgumentException > > quaternion > NumberFormatException > IllegalArgumentException > IllegalStateException > > rootfinder > IllegalArgumentException > > > Nothing in this list strikes me as being inconsistent. The types are all > standard JDK exception types and seem to be used appropriately, IMO. Is > there any work that needs to be done on this issue? > > Regards, > Matt J > > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
