Re: [MATH][GENETICS] Build Issue with PR #197

2021-09-25 Thread Gilles Sadowski
Hello.

Le sam. 25 sept. 2021 à 08:06, Avijit Basak  a écrit :
>
> Hi All
>
>  I have created a PR (#197) to merge my changes for Genetic 
> Algorithm. Although the build has passed locally for my components 
> (commons-math4-genetics and example-genetics) the PR build failed with unit 
> test case errors for legacy(commons-math4-legacy) modules.

Please note that maven modules should named "commons-math-Xxx";
as Alex mentioned previously, you should remove the spurious "4" in
the "genetics" module (and I'd personally favour "ga" over "genetics", as
per a previous discussion).  Thus:
   commons-math-ga
with top-level package
  org.apache.commons.math4.ga

> I have not changed anything in the legacy module. So not sure what is causing 
> those issues.

It is caused by a randomized test ("SimplexOptimizerTest", see the log[1]).

> Could anyone kindly guide me how to pass the PR build in this scenario.

You might try to resubmit the PR.
[Anyways the build will be performed after you commit the changes
indicated above.]

Best regards,
Gilles

> The local build logs are attached herewith for reference.
>
> Local build command: mvn clean verify apache-rat:check checkstyle:check 
> pmd:check spotbugs:check javadoc:javadoc
> PR Link: https://github.com/apache/commons-math/pull/197
>
> Thanks & Regards
> -- Avijit Basak
>

[1] https://app.travis-ci.com/github/apache/commons-math/builds/238471866

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[MATH][GENETICS] Build Issue with PR #197

2021-09-25 Thread Avijit Basak
Hi All

 I have created a PR (#197) to merge my changes for Genetic
Algorithm. Although the build has passed locally for my components
(commons-math4-genetics and example-genetics) the PR build failed with unit
test case errors for legacy(commons-math4-legacy) modules. I have not
changed anything in the legacy module. So not sure what is causing those
issues. Could anyone kindly guide me how to pass the PR build in this
scenario. The local build logs are attached herewith for reference.

*Local build command:* mvn clean verify apache-rat:check checkstyle:check
pmd:check spotbugs:check javadoc:javadoc
*PR Link*: https://github.com/apache/commons-math/pull/197

Thanks & Regards
-- Avijit Basak

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org