Hello.
Le lun. 27 déc. 2021 à 16:02, Avijit Basak a écrit :
>
> Hi All
>
> Please ignore my previous mail. The rebase is done successfully.
> Please let me know if there is any issue.
Here is a the list of commit messages that are should not be
present (at least not when introducing completely new code):
Merge branch 'feature/MATH-1563-ADAPTIVE' of
https://github.com/avijitbasak/commons-math.git into
feature/MATH-1563-ADAPTIVE
removed 64 by Long.SIZE
Merge branch 'master' of https://github.com/apache/commons-math.git
into feature/MATH-1563-ADAPTIVE
Minor change for UniformRandomProvider
modified as per PMD recommendations
updated for checkstyle formatting
An optimized data structure implementation for binary chromosome
minor modifications
Modifications as per review comments
Developed the new genetic algorithm module following the JIRA MATH-1563.
What I suggested is to check out a pristine copy of "master", and copy
the new files onto it, and only change whatever needs to be touched for
the new contents to be handled correctly (i.e. just the POM files I guess).
Then generate a _new_ PR (and close #199).
There should be a _single_ commit with a log message of the form:
---CUT---
MATH-1563: Introducing new implementation of GA functionality (WIP).
---CUT---
[If you don't want to give more details about all the changes, please
stick to the above sentence. Note that the convention is that the
issue identifier be followed by a colon; then, as the commit log
summary, a single sentence, ending with a period, on the first line.]
Thanks,
Gilles
>
> Thanks & Regards
> --Avijit Basak
>
> On Mon, 27 Dec 2021 at 19:21, Avijit Basak wrote:
>
> > Hi All
> >
> > I have tried to rebase. However I found too many conflicts and
> > most of them are unnecessary. So I aborted the process. Can we avoid the
> > rebase as we have very few commits after the last rebase. Please share your
> > views on this.
> >
> > Thanks & Regards
> > --Avijit Basak
> >
> > On Sat, 25 Dec 2021 at 18:45, Gilles Sadowski
> > wrote:
> >
> >> Hello.
> >>
> >> I've fetched the current contents of PR 199; locally, the build completes
> >> successfully, so the problem reported by Travis looks strange indeed.
> >> I would create a branch for further discussion on your GA design but
> >> please first create a *single* commit that contains all changes wrt to
> >> current "master" with a clear log message (first word *must* be the JIRA
> >> identifier of your proposal (perhaps a new JIRA report would be clearer?),
> >> like:
> >> ---CUT---
> >> MATH-: Refactoring of GA functionality (WIP)
> >>
> >> Summary of what has been implemented (with the corresponding JIRA
> >> reports)...
> >>
> >> (optionally) Summary what is under discussion...
> >> ---CUT---
> >>
> >> Thanks,
> >> Gilles
> >>
> >> >> [...]
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
