Re: [MATH][GA] Build Failure for PR #204

2022-02-05 Thread Avijit Basak
Hi

 Please see my comments below.

[...]

>Please note that I don't suggest that you remove the tracking of
>the optimization process (it is useful to have a trace in order to
>check that evolution proceeds as expected), instead of displaying
>a GUI, you can save snapshots (either in text form or, if the
>check is more easily done graphically, by using the "[Imaging]"
>component[3]).
-- As per the suggestion I have removed the GUI display of the convergence
process. Instead the default log based tracker has been kept for
convergence traceability.
I have created a new PR#205 after rebase and closed the old one(PR#204).

Thanks & Regards
--Avijit Basak

On Wed, 2 Feb 2022 at 19:58, Gilles Sadowski  wrote:

> Hi.
>
> Le mer. 2 févr. 2022 à 09:29, Avijit Basak  a
> écrit :
> >
> > Hi All
> >
> > Please see my comments below.
> >
> > [...]
> >
> >
> > And there was this old issue that the "" should contain
> > the name of the top-level package, i.e. "math4", not "math".
> > -- There was a review comment for PR#197 to remove 4 from artifactid.
> > "aherbert  on Sep 25, 2021
> > 
> >
> > Remove the 4 from math4. The version is specified separately from the
> > artifact ID."
>
> Indeed, it seems that there are discrepant expectations or a
> misunderstanding about how to compose the "".
> In "Commons Math", it contains "math4" as (IIUC) a unique
> identifier of the top-level package (that is updated with every
> major version).  Because of that latter convention, it is true that
> the "4" is redundant with the (major) version number.
> However, it could also be construed that the redundancy may
> be useful for stressing that artefacts with different major versions
> can be used together (without "JAR hell").
> That view of having the "packageId" as part of the artifact's name
> is used in some other components (e.g. "[Lang]"[1]) but not all
> (e.g. "[IO]"[2])...
>
> >
> > I've updated the feature branch with those changes. Please rebase.
> >
> > I've not yet looked at the code, but a question arose from looking at
> > the dependencies: What is "jfreechart" used for in the "examples"?
> > -- jfreechart is used to do a graphical plot of the optimization process.
> >
> > I've just updated the "k-means" example, removing the GUI along
> > the way.  In general, I think that the example applications should
> > follow the KISS principle (which here translates to:  Only write to the
> > console or to files).  Since we don't intend to write full-fledged
> > applications, building/testing should be as smooth as possible: GUIs
> > entail unnecessary hassle for someone working from a remote
> > (text) terminal.
> > -- I shall remove that and the corresponding part of the code.
>
> Thanks.
> Please note that I don't suggest that you remove the tracking of
> the optimization process (it is useful to have a trace in order to
> check that evolution proceeds as expected), instead of displaying
> a GUI, you can save snapshots (either in text form or, if the
> check is more easily done graphically, by using the "[Imaging]"
> component[3]).
>
> Regards,
> Gilles
>
> > [...]
> >
>
> [1]
> https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob;f=pom.xml;h=4f12fdf537fd56a69d1b94567e22de99761ec775;hb=HEAD#l28
> [2]
> https://gitbox.apache.org/repos/asf?p=commons-io.git;a=blob;f=pom.xml;h=8f61ca0177a056a80dda656dbb70a9774adac548;hb=HEAD#l26
> [3] See e.g. the "kmeans/image" module.
>
> >
> > Thanks & Regards
> > --Avijit Basak
> >
> > On Tue, 1 Feb 2022 at 05:24, Gilles Sadowski 
> wrote:
> >
> > > Hello.
> > >
> > > Le lun. 31 janv. 2022 à 06:27, Avijit Basak  a
> > > écrit :
> > > >
> > > > Hi All
> > > >
> > > > Please find my comments below.
> > > >
> > > > >There is no attachment (I think that the ML manager strips those).
> > > > >Please copy/paste the relevant part of the console log (or provide
> > > > >a link to it).
> > > > --The build was done locally with a fresh clone of the feature
> branch.
> > >
> > > Strange that the "pom.xml" in PR #204 still refers to version 1.0 of
> > > Commons Numbers, instead of version 1.1-SNAPSHOT.
> > > This creates many "NoClassDefFound" errors that were fixed with
> > > commit 7e2213f2e5a536ad49d549d21f9eed9e71db5638 in branch
> > > "feature__MATH-1563__genetic_algorithm" branch 6 days ago.
> > >
> > > Anyways, after fetching your PR and rebasing on that branch, the
> > > build is successful.
> > >
> > > Nevertheless, I had to fix/consolidate many POM files that contained
> > > a slew of duplicate declarations (the "dependency management" is
> > > done at the highest possible level, to ensure version consistency).
> > > Also, please use the same formatting rules as in existing files (in
> > > POM files, the indentation is 2 spaces).
> > >
> > > And there was this old issue that the "" should contain
> > > the name of the top-level package, i.e. "math4", not "math".

Re: please give me the contributor permission

2022-02-05 Thread Gary Gregory
Hello,

Anyone can create PRs on GitHub and create Jira tickets. You can read about
getting more involved here:
https://www.apache.org/foundation/getinvolved.html

Gary

On Sat, Feb 5, 2022, 06:08 David Huang  wrote:

> *Hi,*
>
> *I want to contribute to Apache Commons-io. Would you please give me the
> contributor permission? My JIRA USERNAME is *codeferry, EMAIL is
> huangxw...@gmail.com
>


please give me the contributor permission

2022-02-05 Thread David Huang
*Hi,*

*I want to contribute to Apache Commons-io. Would you please give me the
contributor permission? My JIRA USERNAME is *codeferry, EMAIL is
huangxw...@gmail.com