Re: [VOTE] Release Apache Commons Daemon 1.3.2 based on RC1
+1
Tested Source Zip
SHA 512 OK:
$ shasum -a 512 --check commons-daemon-1.3.2-src.zip.sha512
commons-daemon-1.3.2-src.zip: OK
ASC OK:
gpg --verify commons-daemon-1.3.2-src.zip.asc
gpg: assuming signed data in 'commons-daemon-1.3.2-src.zip'
gpg: Signature made 05-Oct-22 10:03:56 AM Eastern Daylight Time
gpg:using RSA key A9C5DF4D22E8D9875A5110C01C5A2F6059E7
gpg: Good signature from "Mark E D Thomas " [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7
Windows 10:
Build default Maven goal OK using 'mvn'
Build both native Windows apps OK using 'nmake CPU=X64'
Microsoft Windows [Version 10.0.19043.2006]
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: C:\java\apache-maven-3.8.6
Java version: 1.8.0_345, vendor: Temurin, runtime: C:\Program Files\Eclipse
Adoptium\jdk-8.0.345.1-hotspot\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
"C:\Program Files\Microsoft Visual
Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat"
Visual Studio 2022 Developer Command Prompt v17.3.5
Microsoft (R) Program Maintenance Utility Version 14.33.31630.0
Microsoft (R) C/C++ Optimizing Compiler Version 19.33.31630 for x64
Microsoft (R) Incremental Linker Version 14.33.31630.0
Linux WSL2 subsystem in Windows 10:
Linux *** 5.10.16.3-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021
x86_64 x86_64 x86_64 GNU/Linux
java -version
openjdk version "1.8.0_342"
OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~22.04-b07)
OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode)
I got a warning running 'sh support/buildconf.sh':
sh support/buildconf.sh
configure.in:44: warning: back quotes and double quotes must not be escaped in:
remove the \"$cache_file\" file and re-run configure
./support/apfunctions.m4:23: AP_CANONICAL_HOST_CHECK is expanded from...
configure.in:44: the top level
configure.in:138: warning: AC_OUTPUT should be used without arguments.
configure.in:138: You should run autoupdate.
support/buildconf.sh: configure script generated successfully
Run `./configure` OK
make ran with these warnings:
(cd native; make all)
make[1]: Entering directory
'/mnt/c/Users/ggregory/rc/commons-daemon-1.3.2-src/src/native/unix/native'
gcc -g -O2 -DOS_LINUX -DDSO_DLFCN -DCPU=\"amd64\" -Wall -Wstrict-prototypes
-I/usr/lib/jvm/java-8-openjdk-amd64//include
-I/usr/lib/jvm/java-8-openjdk-amd64//include/linux -c jsvc-unix.c -o jsvc-unix.o
jsvc-unix.c: In function ‘run_controller’:
jsvc-unix.c:1311:20: warning: assignment to ‘__sighandler_t’ {aka ‘void
(*)(int)’} from incompatible pointer type ‘void (*)(int, siginfo_t *, void *)’
[-Wincompatible-pointer-types]
1311 | act.sa_handler = controller;
|^
jsvc-unix.c: In function ‘get_pidf’:
jsvc-unix.c:666:5: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
666 | lockf(fd, F_LOCK, 0);
| ^~~~
jsvc-unix.c:668:5: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
668 | lockf(fd, F_ULOCK, 0);
| ^
jsvc-unix.c: In function ‘wait_child’:
jsvc-unix.c:762:9: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
762 | lockf(fd, F_LOCK, 0);
| ^~~~
jsvc-unix.c:764:9: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
764 | lockf(fd, F_ULOCK, 0);
| ^
jsvc-unix.c: In function ‘set_output’:
jsvc-unix.c:1064:9: warning: ignoring return value of ‘freopen’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
1064 | freopen("/dev/null", "r", stdin);
| ^~~~
jsvc-unix.c:1075:9: warning: ignoring return value of ‘freopen’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
1075 | freopen("/dev/null", "a", stdout);
| ^
jsvc-unix.c:1093:9: warning: ignoring return value of ‘freopen’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
1093 | freopen("/dev/null", "a", stderr);
| ^
jsvc-unix.c: In function ‘check_pid’:
jsvc-unix.c:592:9: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
592 | lockf(fd, F_LOCK, 0);
| ^~~~
jsvc-unix.c:599:17: warning: ignoring return value of ‘lockf’ declared with
attribute ‘warn_unused_result’ [-Wunused-result]
599 | lockf(fd, F_ULOCK, 0);
|
Re: [VOTE] Release Apache Commons Daemon 1.3.2 based on RC1
[x] +1 Release these artifacts Built from tag with mvn clean test install site on Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.4, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.15.0-48-generic", arch: "amd64", family: "unix" The link to the site in the vote email is 404 for me. But it works fine locally, and reports look good. Inspected some files from the dist area, and everything looked OK. No issues with signatures, license, notice files all good too. Thanks Mark! -Bruno On Thu, 6 Oct 2022 at 03:36, Mark Thomas wrote: > We have fixed a few bugs since Apache Commons Daemon 1.3.1 was released, > so I would like to release Apache Commons Daemon 1.3.2. > > Apache Commons Daemon 1.3.2 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/daemon/1.3.2-RC1 > (svn revision 57178) > > The Git tag commons-daemon-1.3.2-RC1 commit for this RC is > 4189f2798f20180ea9f36c00bb5a05702971ba95 which you can browse here: > > > https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=4189f2798f20180ea9f36c00bb5a05702971ba95 > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-daemon.git > --branch commons-daemon-1.3.2-RC1 commons-daemon-1.3.2-RC1 > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1598/commons-daemon/commons-daemon/1.3.2/ > > These are the artifacts and their hashes: > > commons-dameon-1.3.2-bin-windows.zip=4a4779629b76e5c7fb7885af51f0468c26ca958e6a243b60787c1576529fed48f0ec5b257ef5fcd71e48de8625d384aa27391e74e0ae4b43b0e7b3dbe8ca3d78 > > commons-daemon-1.3.2-bin.tar.gz=be2677b352cfff99ba4447468757136416a9477eadb61ec8b35e2fb72fadd40e7405f0dfc57e265957a938ff4e37f8814d731b1bf5893191f1104b0101017eb5 > > commons-daemon-1.3.2-bin.zip=130d658e09cd5a4eb82a175354ae18ad2ddd62e74fc48a661e6ce2fa08c294ae8d0cbc42ae11708284c46feae600e9c10989723035308d4dfa458bd919bfb1ec > > commons-daemon-1.3.2-cyclonedx.json=c75beb453a4930367ce29d621bcf16a7e23f8c5f19bd6ff2f6515a0d27650424e03fdd4340a50e1bb4bfd17a2e62b8005367add17a384f2c2a7d282c20695797 > > commons-daemon-1.3.2-cyclonedx.xml=d407f88a5321297712e5d35554808caba4b9818cb7d22cd5996cc984b22146df02506814d03434e8afafbdc4e4a578c7075257c39d7d97b526811454c6bf0cf7 > > commons-daemon-1.3.2-javadoc.jar=7921b2bc5bf200c25506c5f57920322c29f7a60b8568dc7ab858cb952f2a21179720a8428d4ee3a752bceb8b9ac5096c6de8953aafac9b01e7c9832e46495861 > > commons-daemon-1.3.2-native-src.tar.gz=9908858ebe7e08873a0d1a83c88f78ca6eccacab24bf5fd2980f91df128d0c3407fd68351ea0736214f6dc758f8451b0e0b1fa7ccaf593479659c7c1d3acbf95 > > commons-daemon-1.3.2-native-src.zip=264f0ae6378afb1ec78cd518dde054f26c03a10ac3330c4da8829c5774c521a4ca4b1981e068a98913c73dc8396210062985fdcc55bd8415238afb2d5ab515af > > commons-daemon-1.3.2-sources.jar=5f23cec53458818ea55572f83d93ebe1573de3371707090a5ff42e3dda60cd81387fa74d8fbc3999cab8a2394a0d1aadf5023377dffab1e5c1a9fa1b4de78b36 > > commons-daemon-1.3.2-src.tar.gz=241f3b15ef2a5e11cf802adef8c5e07d417a0c614188123db197b76154ed6ef6fc5dfaa7acff3bfac067b1b7978c3e0674bba2efc776305a2ab28a23be1c7f89 > > commons-daemon-1.3.2-src.zip=0f15f9277691cc259171ef20139fcfd8d4039da1ddc9a45aed0870d6ed6e3c78aacc10a535cc05c28ac50c9beb1b47280435b0ab339915e28f4aeda5087e5f0a > > commons-dameon-1.3.2.spdx.rdf.xml=b80766a716e02d53b1a1a674653280bb4bf516b111ab760819ed5bc240562d66161299bca2533ccfd20ab97560da8f6de55387b5ef94cac9cbf259b1765e3b90 > > > > > Details of changes since 1.3.1 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/daemon/1.3.2-RC1/RELEASE-NOTES.txt > > > https://dist.apache.org/repos/dist/dev/commons/daemon/1.3.2-RC1/site/changes-report.html > > > KEYS: >https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > >[ ] +1 Release these artifacts >[ ] +0 OK, but... >[ ] -0 OK, but really should fix... >[ ] -1 I oppose this release because... > > Thank you, > > Mark Thomas, > Release Manager (using key 10C01C5A2F6059E7) > > > > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-daemon.git > --branch commons-daemon-1.3.2-RC1 commons-daemon-1.3.2-RC1 > cd commons-daemon-1.3.2-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which > you then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not
Re: [VOTE] Release Apache Commons Daemon 1.3.2 based on RC1
On 05/10/2022 15:36, Mark Thomas wrote: Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [X] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
