date:20230131

Re: [GEOMETRY] Quickhull Implementation

2023-01-31 Thread Matt Juntunen

Hello!

Andreas, thank you for your contribution! It's good to see some work going
into commons-geometry since I've had to step away recently. Gilles is right
in that we didn't include the hull module in the 1.0 release because I felt
like it still needed work. What I'd like to do is remove that module
completely and pull the convex hull generation directly into the euclidean
module and hide the implementation algorithm details (as discussed in
GEOMETRY-144). I've replied to your comment on that Jira issue and I hope
to take a detailed look at your code over this weekend, if not before. If
you're interested in seeing the API I was aiming for when working on this,
my unfinished code is languishing on Github [1].

Regards,
Matt J

[1]
https://github.com/darkma773r/commons-geometry/blob/quickhull/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/ConvexHull3D.java




On Mon, Jan 30, 2023 at 2:38 AM Andreas Goss 
wrote:

> Thanks for the quick reply. I need to create an Jira account first for
> that. I requested an account by writing to priv...@commons.apache.org
>
> Kind Regards
> Andreas
>
> Gilles Sadowski  schrieb am Mo. 30. Jan. 2023 um
> 00:11:
>
> > Hello.
> >
> > Le dim. 29 janv. 2023 à 19:25, Andreas Goss
> >  a écrit :
> > >
> > > Hello,
> > >
> > > I want to contribute a solution for the open Jira task GEOMETRY-110 (
> > >
> >
> https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-110?filter=allopenissues
> > ).
> > > I tried my best to organize the code according to guidelines and at
> least
> > > the maven build was succesful. I created a pull-request for the github
> > > clone. If someone could give me a code review and point out areas to
> > > improve the code or errors i would be very thankful.
> >
> > Thank you for tackling this issue.
> > It was part of a broader discussion about the API around the hull
> > functionality.
> > IIRC, the "commons-geometry-hull" module was not included in the first
> > release of "Commons Geometry" because Matt Juntunen was convinced
> > that a few enhancements were necessary.  Hopefully, he'll chime in order
> to
> > make this recollection more precise.
> >
> > A general question is whether we want to expose (make "public") classes
> > that implement the algorithm(s), such as "QuickHull3D".  For example, we
> > could perhaps have (untested and required comments missing...):
> > ---CUT---
> > public interface ConvexHull3D extends ConvexHull {
> >
> > public enum Generate {
> > QUICK_HULL((c, p) -> new QuickHull3D(p).generate(c));
> >
> > private final BiFunction,
> > DoubleEquivalence, ConvexHull3D> generator;
> >
> > private HullGenerator3D(BiFunction,
> > DoubleEquivalence, ConvexHull3D> generator) {
> > this.generator = generator;
> > }
> >
> > public ConvexHull3D from(Collection points,
> > DoubleEquivalence equivalence) {
> > return generator.apply(points, equivalence));
> > }
> > }
> >
> > public Collection getFacets();
> > }
> >
> > private class QuickHull3D {
> > private final DoubleEquivalence precision;
> >
> > QuickHull3D(DoubleEquivalence precision) {
> > this.precision = precision;
> > }
> >
> > ConvexHull3D generate(Collection points) {
> > // ...
> > return new SimpleConvexHull3D(...);
> > }
> > }
> >
> > private class SimpleConvexHull3D implements ConvexHull3D {
> > private final List vertices;
> > private final ConvexVolume region;
> > private Collection facets;
> >
> > SimpleConvexHull3D(...) {
> > // ...
> > }
> >
> > // ...
> > }
> > ---CUT---
> >
> > For other concrete (basic) remarks about the code, we can certainly
> > continue the conversation in comments on the JIRA report.
> >
> > Best regards,
> > Gilles
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2

2023-01-31 Thread Bruno Kinoshita

That's odd. I ran the same command now on my checked out tag and got no
warnings, Arturo.

[INFO] --- apache-rat-plugin:0.15:check (default-cli) @ commons-csv ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from
/home/kinow/Development/java/apache/commons-csv/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 74 implicit excludes.
[INFO] 34 explicit excludes.
[INFO] 83 resources included
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0,
generated: 0, approved: 76 licenses.
[INFO]

The files you have in the warning exist.

kinow@ranma:~/Development/java/apache/commons-csv$ file
src/test/resources/org/apache/commons/csv/empty.txt
src/test/resources/org/apache/commons/csv/empty.txt: empty

Any chance you have a copy of commons-csv-rc2 inside another commons-csv
folder?

Cheers
Bruno


On Tue, 31 Jan 2023 at 21:43, Arturo Bernal 
wrote:

> Hi Gary,
>
> If you run the default maven goal (clean verify apache-rat:check
> japicmp:cmp checkstyle:check spotbugs:check pmd:check pmd:cpd-check
> javadoc:javadoc) wich contain apache-rat:check, the output will be
> something like that
>
> [WARNING] Files with unapproved licenses:
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/empty.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-259/sample.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/csv-167/sample1.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-141/csv-141.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_ignoreEmpty.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default_comment.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/bom.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246_checkWithNoComment.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180_trim.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_default.txt
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.tsv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-213/999751170.patch.csv
>
> commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-198/optd_por_public.csv
>   commons-csv-1.10.0-RC2/src/site/resources/profile.jacoco
>   commons-csv-1.10.0-RC2/src/site/resources/download_csv.cgi
> [INFO]
> 
> [INFO] BUILD FAILURE
> [INFO]
> 
> [INFO] Total time:  3.733 s
> [INFO] Finished at: 2023-01-31T21:39:45+01:00
>
>
> Arturo Bernal
> arturobern...@yahoo.com
>
>
>
> > On 28 Jan 2023, at 22:44, Gary Gregory  wrote:
> >
> > Arturo,
> >
> > Thank you for your review.
> >
> > "The only thing the rat error. Someone should  to tackle that"
> >
> > Please be specific.
> >
> > Gary
> >
> > On Sat, Jan 28, 2023, 16:02 Arturo Bernal  .invalid>
> > wrote:
> >
> >> [+1
> >>
> >>> Built from tag with `mvn clean test install site` with no issues, on
> >>
> >> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> >> Maven home: /opt/apache-maven-3.8.1
> >> Java version: 17.0.2, vendor: Oracle Corporation, runtime:
> >> /Library/Java/JavaVirtualMachines/jdk-17.0.2.jdk/Contents/Home
> >> Default locale: en_US, platform encoding: UTF-8
> >> OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac"
> >> ]
> >>
> >> The only thing the rat error. Someone should  to tackle that
> >>
> >>
> >> Arturo Bernal
> >> arturobern...@yahoo.com
> >>
> >>
> >>
> >>> On 28 Jan 2023, at 21:45, Bruno Kinoshita  wrote:
> >>>
> >>>  [x] +1 Release these artifacts
> >>>
> >>> Built from tag with `mvn clean test install site` with no issues, on
> >>>
> >>> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> >>> Maven home: /opt/apache-maven-3.8.5
> >>> Java version: 17.0.5, vendor: Private Build, runtime:
> >>> /usr/lib/jvm/java-17-openjdk-amd64
> >>> Default locale: en_US, platform encoding: UTF-8
> >>> OS name: "linux", version: "5.15.0-58-generic", arch: "amd64", family:
> >>> "unix"
> >>>
> >>>
> >>> Site reports

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2

2023-01-31 Thread Arturo Bernal

Hi Gary,

If you run the default maven goal (clean verify apache-rat:check japicmp:cmp 
checkstyle:check spotbugs:check pmd:check pmd:cpd-check javadoc:javadoc) wich 
contain apache-rat:check, the output will be something like that 

[WARNING] Files with unapproved licenses:
  commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/empty.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-259/sample.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/csv-167/sample1.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-141/csv-141.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_ignoreEmpty.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default_comment.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/bom.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV246_checkWithNoComment.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_rfc4180_trim.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/test_default.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSVFileParser/testCSV85_default.txt
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.tsv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-290/psql.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-213/999751170.patch.csv
  
commons-csv-1.10.0-RC2/src/test/resources/org/apache/commons/csv/CSV-198/optd_por_public.csv
  commons-csv-1.10.0-RC2/src/site/resources/profile.jacoco
  commons-csv-1.10.0-RC2/src/site/resources/download_csv.cgi
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  3.733 s
[INFO] Finished at: 2023-01-31T21:39:45+01:00


Arturo Bernal
arturobern...@yahoo.com



> On 28 Jan 2023, at 22:44, Gary Gregory  wrote:
> 
> Arturo,
> 
> Thank you for your review.
> 
> "The only thing the rat error. Someone should  to tackle that"
> 
> Please be specific.
> 
> Gary
> 
> On Sat, Jan 28, 2023, 16:02 Arturo Bernal 
> wrote:
> 
>> [+1
>> 
>>> Built from tag with `mvn clean test install site` with no issues, on
>> 
>> Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
>> Maven home: /opt/apache-maven-3.8.1
>> Java version: 17.0.2, vendor: Oracle Corporation, runtime:
>> /Library/Java/JavaVirtualMachines/jdk-17.0.2.jdk/Contents/Home
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "mac os x", version: "13.1", arch: "x86_64", family: "mac"
>> ]
>> 
>> The only thing the rat error. Someone should  to tackle that
>> 
>> 
>> Arturo Bernal
>> arturobern...@yahoo.com
>> 
>> 
>> 
>>> On 28 Jan 2023, at 21:45, Bruno Kinoshita  wrote:
>>> 
>>>  [x] +1 Release these artifacts
>>> 
>>> Built from tag with `mvn clean test install site` with no issues, on
>>> 
>>> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
>>> Maven home: /opt/apache-maven-3.8.5
>>> Java version: 17.0.5, vendor: Private Build, runtime:
>>> /usr/lib/jvm/java-17-openjdk-amd64
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "linux", version: "5.15.0-58-generic", arch: "amd64", family:
>>> "unix"
>>> 
>>> 
>>> Site reports look really good.
>>> 
>>> Inspected some dist files, found no issues.
>>> 
>>> Checked signatures of dist area files, found no issues.
>>> 
>>> Thanks!
>>> Bruno
>>> 
>>> On Sat, 28 Jan 2023 at 19:03, Gary Gregory 
>> wrote:
>>> 
 We have fixed quite a few bugs and added some enhancements since
 Apache Commons CSV 1.9.0 was released, so I would like to release
 Apache Commons CSV 1.10.0.
 
 Apache Commons CSV 1.10.0 RC2 is available for review here:
   https://dist.apache.org/repos/dist/dev/commons/csv/1.10.0-RC2 (svn
 revision 59641)
 
 The Git tag commons-csv-1.10.0-RC2 commit for this RC is
 5b99c860986a87f9da664bf47a3a7c0026673123 which you can browse here:
 
 
>> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=5b99c860986a87f9da664bf47a3a7c0026673123
 You may checkout this tag using:
   git clone https://gitbox.apache.org/repos/asf/commons-csv.git
 --branch 
 commons-csv-1.10.0-RC2 commons-csv-1.10.0-RC2
 
 Maven artifacts are here:

Re: [GEOMETRY] Quickhull Implementation

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC2

3 matches

Site Navigation

Mail list logo

Footer information