[cli] Repeated substring problem
The commons cli project has repeatedly used substring here. Can I simplify it
to one
Similar to the following
static String stripLeadingAndTrailingQuotes(String str) {
final int length = str.length();
String tmp;
if (length > 1 && str.startsWith("\"") && str.endsWith("\"") && (tmp =
str.substring(1, length - 1)).indexOf('"') == -1) {
return tmp;
}
return str;
}
This is from before
[cid:image001.png@01D98334.87534660]
[IMAGING] Logging vs Throwing exceptions
Hi All,
The method
org.apache.commons.imaging.icc.IccProfileParser.getICCProfileInfo(ByteSource)
looks like:
public IccProfileInfo getICCProfileInfo(final ByteSource byteSource) {
// TODO Throw instead of logging?
final IccProfileInfo result;
try (InputStream is = byteSource.getInputStream()) {
result = readICCProfileInfo(is);
} catch (final Exception e) {
LOGGER.log(Level.SEVERE, e.getMessage(), e);
return null;
}
//
try {
for (final IccTag tag : result.getTags()) {
final byte[] bytes = byteSource.getBlock(tag.offset,
tag.length);
// Debug.debug("bytes: " + bytes.length);
tag.setData(bytes);
// tag.dump("\t" + i + ": ");
}
// result.fillInTagData(byteSource);
return result;
} catch (final Exception e) {
// Debug.debug("Error: " + file.getAbsolutePath());
LOGGER.log(Level.SEVERE, e.getMessage(), e);
}
return null;
}
I find it odd and dubious that we would short-circuit the propagation of
exceptions with logging in such a low-level code. Unless someone can argue
otherwise, I would like to propagate the exceptions.
TY,
Gary
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Call for Presentations, Community Over Code 2023
(Note: You are receiving this because you are subscribed to the dev@ list for one or more Apache Software Foundation projects.) The Call for Presentations (CFP) for Community Over Code (formerly Apachecon) 2023 is open at https://communityovercode.org/call-for-presentations/, and will close Thu, 13 Jul 2023 23:59:59 GMT. The event will be held in Halifax, Canada, October 7-10, 2023. We welcome submissions on any topic related to the Apache Software Foundation, Apache projects, or the communities around those projects. We are specifically looking for presentations in the following catetegories: Fintech Search Big Data, Storage Big Data, Compute Internet of Things Groovy Incubator Community Data Engineering Performance Engineering Geospatial API/Microservices Frameworks Content Wrangling Tomcat and httpd Cloud and Runtime Streaming Sustainability - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1
On 05/05/2023 11:27, Mark Thomas wrote: Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [X] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1
Can we get more PMC reviews please? Gary On Fri, May 5, 2023, 06:27 Mark Thomas wrote: > We have fixed a few bugs since Apache Commons Daemon 1.3.3 was released, > so I would like to release Apache Commons Daemon 1.3.4. > > Apache Commons Daemon 1.3.4 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/daemon/1.3.4-RC1 > (svn revision 61662) > > The Git tag commons-daemon-1.3.4-RC1 commit for this RC is > f7c21ce501eee288c488edd416f0ddccdd365966 which you can browse here: > > > https://github.com/apache/commons-daemon/commit/f7c21ce501eee288c488edd416f0ddccdd365966 > > (gitbox browsing is currently disabled) > > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-daemon.git > --branch commons-daemon-1.3.4-RC1 commons-daemon-1.3.4-RC1 > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1634/commons-daemon/commons-daemon/1.3.4/ > > These are the artifacts and their hashes: > > > commons-daemon-1.3.4.jar=31e723efc879fb1a45001bcb1577c02defe38b0a7e02fc4efd2800f85a4dbe583eba2e67323145aa5c2c5cf9dd09c457961557898a9923e85b0375c73c639498 > > commons-daemon-1.3.4-bin.tar.gz=adc301fe9c7e50c5ed71c6775c8c41c33a369a05c30785ccb81209089603ae66563e958b466c99fc5cd27c12625bb7def68d7d91933aa8739eb645af37f3d03e > > commons-daemon-1.3.4-bin.zip=857da3217d9186b034ffecf36b8d0df84b3b4de8b06a81338df97dbabafeff9b84034d49173623f5b03786d48d85d406af8e602ea644c95552f2df68f98d5ddc > > commons-daemon-1.3.4-bin-windows.zip=57a59d402dd0a1c99ed5da062b4616d54679e4208abec8b25742f5bf3ec1ee6b5187bc830edeaa218766215371b5519ce0a7186325c929c86b567a3078aa7555 > > commons-daemon-1.3.4-native-src.tar.gz=3c10ca72fc0eb7f755c0b5452bb6d5e8b42d8f363767ffcd9a6f0883026e688ea7dff50ea05e2675a7cdf9f413cb8012ee6b79e16dfc1cd4d83bd775ea10216c > > commons-daemon-1.3.4-native-src.zip=2e2db21b142b40427c43f4802ec94fb6212d1c79cb6aa02325b71017e20384a8d6123148603eda03f309aeae5a6f88f9a014deb978af0fac2f62b576d73ae1b8 > > commons-daemon-1.3.4-src.tar.gz=bb36d88bc21a5777245012b2a73ee0e764b85715731f54cc4ff09343e95ccb18fc6c68b3ae9c680fb45a60c7ef5ed0f9e40991c2c03246dd7f8dd65031eddf24 > > commons-daemon-1.3.4-src.zip=2f77720724069655828cecb639a3c9a8411e97ed4c9923340f521cf7078ce85e5d223f20431040411a592b4d38208144ffc56da8b70091f75028a1aad9c51891 > > > KEYS: >https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > >[ ] +1 Release these artifacts >[ ] +0 OK, but... >[ ] -0 OK, but really should fix... >[ ] -1 I oppose this release because... > > Thank you, > > Mark Thomas, > Release Manager (using key 10C01C5A2F6059E7) > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
